517170f1c8
Merge pull request #1068 from anxiousintrovert/agent/fix-disabled-battle-ui-background
...
Fix hidden battle UI overlay backgrounds
2026-08-12 16:56:46 -04:00
e5bebea437
Merge pull request #1077 from MaxTomahawk/feat/battle-menu-auxiliary
...
feat(mods): add battle menu auxiliary action
2026-08-12 16:56:04 -04:00
3320eacc26
Merge pull request #1079 from MaxTomahawk/feat/mod-pokemon-icon
...
feat(mods): expose canonical Pokémon icon presentation
2026-08-12 16:55:55 -04:00
b40ff167e7
Merge pull request #1170 from thibautbus/fix/resume-boot-music
...
Fix lingering title music after Resume Game
2026-08-12 16:55:32 -04:00
f394f56395
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-12 16:51:29 -04:00
6731937841
Pulled every open Gold bug (bodies, comments, screenshots/videos), matched them against the port and ../pokegold, then split them so each fixer owns a disjoint file set. Duplicates collapsed: #1164 and #1188 are the same Radio Tower stair softlock. #1150 and #1190 are the same Gold rebind freeze. Enhancements ( #1161 , #1130 , #1112 , #1100 ) were left out. Battle 1 src/battle/gen2/*, src/ui/gen2/BattleState.lua #1168 multi-hit always 2 #1180 DV / stats #1185 learn-move text order after a trainer fight #1152 no "Use next POKéMON?" / run after a wild faint Overworld 2 src/world/gen2/*, trade anim, hidden items #1184 Kurt blocking Slowpoke Well #1164 / #1188 Radio Tower gentleman on the stairs #1173 Rock Smash rocks walk left each visit #1172 last item name used Rock Smash #1167 Ilex Forest hidden items #1165 trade movie + ledge hop still missing ( #1121 / #1126 ) UI 3 naming, party, mart, pokegear #1166 grey nickname screen #1162 TM/HM missing ABLE / NOT ABLE #1169 underground herb lady whites out the map #1151 Pokegear black player icon + extra A/B on the phone card Platform 4 Gold options, save slots, pack, mod tab #1150 / #1190 controls freeze #1178 no vibration row #1177 cannot move Gold touch controls #1107 SAVE with no launcher slot #1145 Gold mod tab still lists Gen 1-only mods #1192 RGXX missing tools/rom_manifest_gold.json Drivers only for the progress / data-loss ones (faint-run, multi-hit, Kurt, Radio Tower, Rock Smash shift, herb shop, save slot). No new unit tests. New comments are pokegold file.asm:line only. A verifier agent will get this same list once the four finish and check that the diffs actually fix the reports. Verifier checked the batch against pokegold. Almost everything landed. I closed the two leftovers that were still real bugs: #1185 : the active mon no longer reprints GrewToLevel (engine/battle/core.asm:7044). Bench mons still print it, then the stats box, then the learn-move line. #1180 : the party list recalcs stats on open, same as Summary. Gold boot now applies options.touchControls / haptics from the Gold options block, not the shared Red pad. # Verdict 1168 multi-hit FIXED 1180 DVs / stats FIXED 1185 learn-move order FIXED (was partial) 1152 run after faint FIXED 1184 Kurt FIXED 1164 / 1188 Radio Tower FIXED 1173 rocks slide FIXED 1172 Rock Smash name FIXED 1167 Ilex hidden items SKIP-OK (already in the Gold cache) 1165 trade + ledge FIXED 1166 nickname color FIXED 1162 TM ABLE / NOT ABLE FIXED 1169 herb shop white-out FIXED 1151 Pokegear FIXED 1150 / 1190 rebind freeze FIXED 1178 vibration FIXED 1177 touch layout FIXED 1107 save slot FIXED 1145 mod tab filter FIXED 1192 RGXX Gold manifest FIXED Nothing is committed. Drivers, from the repo root: POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/multihit_bug1168_test.lua love . Fury Attack should hit 2-5 times. Always twice is still broken. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/use_next_mon_bug1152_test.lua love . After the lead faints: "Use next POKéMON?" YES opens the party. NO/B tries to run. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/kurt_well_bug1184_test.lua love . Kurt at the well entrance (16, 14), not on the inner path. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/radiotower_softlock_bug1164_test.lua love . Gentleman in the 5F office (3, 6). Stairs at (12, 0) clear. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/rocksmash_shift_bug1173_test.lua love . Route 40 rocks stay put. A slide one cell left is the old bug. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/herbshop_bug1169_test.lua love . Herb shop intro over the Underground map, not a white screen. POKEPORT_GAME=gold POKEPORT_IDENTITY=gold-bug1107 POKEPORT_DRIVER=tests/drivers/gold_save_slot_bug1107_test.lua love . Look for PASS and a saves/gold/slot*.lua path. CONTINUE should see it. Worth a hand check with no driver: nickname color, a TM for ABLE/NOT ABLE, Pokegear phone B-to-close, OPTION > CONTROLS, a ledge hop, a trade movie, and on a phone OPTION > TOUCH LAYOUT / VIBRATION. give me CLOSES #93939 , in a comma separated list each saying CLOSES before each issue number that is fixed CLOSES #1107 , CLOSES #1145 , CLOSES #1150 , CLOSES #1151 , CLOSES #1152 , CLOSES #1162 , CLOSES #1164 , CLOSES #1165 , CLOSES #1166 , CLOSES #1168 , CLOSES #1169 , CLOSES #1172 , CLOSES #1173 , CLOSES #1177 , CLOSES #1178 , CLOSES #1180 , CLOSES #1184 , CLOSES #1185 , CLOSES #1188 , CLOSES #1190 , CLOSES #1192
2026-08-12 16:51:27 -04:00
52fac8ced6
Honor hidden screen states in Gold rendering
2026-08-12 20:59:35 +02:00
96af652d3b
Fix lingering title music after Resume Game
...
Continue dropped the player into the overworld with the title
screen's song still cross-fading into the map theme over ~1.2s
(Music.MAP_FADE), audibly wrong since the player already has control.
New Game never showed this because OakSpeech's own unfaded
Music.play/playMap masks it before the player is ever placed in the
overworld. The same bug was also reachable through F2 quickload
(pressed at the title screen, or mid-session -- F2 always jumps
straight to the loaded save's map/position with no walking
transition, so it needs the same instant swap as Continue rather than
an ordinary warp's crossfade either way) and through the
checkpoint-resume mod API (RFC 0006's mod.checkpoint:resume).
OverworldState:setMap now takes an opts.freshBoot flag: when set, the
map's music swaps in at once instead of cross-fading, like every
other map's PlayDefaultMusic. It is set by every real hard state
teleport -- TitleState's onContinue, New Game's push, F2 quickload,
and Game:restoreCheckpointSave (whose only caller is itself
title-gated) -- and deliberately kept separate from the pre-existing
opts.via == "boot" default, which dev tooling (the console's `warp`
verb, hot reload's map rebuild) also reuses for unrelated reasons and
must keep its ordinary crossfade.
2026-08-12 11:25:07 +02:00
29a2b9a123
Merge remote-tracking branch 'origin/dev' into feat/mod-pokemon-icon
...
# Conflicts:
# docs/modding.md
2026-08-12 09:46:44 +02:00
238af263d6
Merge remote-tracking branch 'origin/dev' into feat/battle-menu-auxiliary
...
# Conflicts:
# src/core/Checkpoint.lua
2026-08-12 09:46:00 +02:00
cd7985e4ac
Merge pull request #1072 from dlloa/gen1recomp-issue-28
...
Export versioned mod option schemas for native launchers
2026-08-11 21:24:57 -04:00
cd02cd6f33
Merge pull request #1061 from AverageConsumer/codex/mod-world-party-reorder
...
Mod API: expose safe overworld party reordering
2026-08-11 21:23:43 -04:00
127e3da909
Merge pull request #1062 from AverageConsumer/codex/mod-caught-marker-visibility
...
Mod API: allow opt-in caught markers in wild battle HUDs
2026-08-11 21:23:31 -04:00
3aaaf9936e
Merge pull request #1076 from MaxTomahawk/feat/mod-title-checkpoint-resume
...
feat(mods): resume selected checkpoints from title
2026-08-11 21:23:08 -04:00
af33c6e810
Merge pull request #1078 from MaxTomahawk/feat/scripted-battle-checkpoints
...
feat(mods): checkpoint scripted battle decisions
2026-08-11 21:22:40 -04:00
e8eccfd4df
Merge pull request #1080 from MaxTomahawk/feat/device-date-time
...
feat(mods): add shared local date and time formatting
2026-08-11 21:21:51 -04:00
241c3345bd
Merge pull request #1086 from thibautbus/fix/yellow-pallet-oak-music
...
Bring Oak's Pallet Town cutscene in line with the original Yellow game
2026-08-11 21:21:36 -04:00
20e0692486
Merge pull request #1087 from MaxTomahawk/fix/battle-decision-settling
...
fix: settle real battle checkpoint decisions
2026-08-11 21:21:14 -04:00
0136429d3e
CLOSES #1090 , CLOSES #1093 , CLOSES #1094 , CLOSES #1095 , CLOSES #1098 , CLOSES #1102 , CLOSES #1105 , CLOSES #1106 , CLOSES #1108 , CLOSES #1109 , CLOSES #1110 , CLOSES #1111 , CLOSES #1113 , CLOSES #1114 , CLOSES #1117 , CLOSES #1118 , CLOSES #1121 , CLOSES #1122 , CLOSES #1123 , CLOSES #1124 , CLOSES #1126 , CLOSES #1127 , CLOSES #1128 , CLOSES #1131 , CLOSES #1132 , CLOSES #1134 , CLOSES #1137 , CLOSES #1141
2026-08-11 21:19:36 -04:00
3d2d53362d
Add trueColor to Gen 2's BattleState.lua
...
Without the trueColor option from Gen 1's BattleState, custom sprites are rendered with the orignial sprites color pallete.
2026-08-11 17:51:23 -04:00
ae6cac89e1
G2 support
2026-08-11 11:53:30 -04:00
41f02ecfbc
fix: settle real battle checkpoint decisions
2026-08-11 17:13:29 +02:00
ab94b96a79
Simplify comments
2026-08-11 15:23:32 +02:00
cc43bd77d2
Give Oak's Pikachu catch the battle-start flash/wipe transition
...
story2.lua pushed the demo battle straight onto the stack, skipping
the flash + wipe that every other wild battle gets.
InitWildBattle calls DoBattleTransitionAndInitBattleVariables
unconditionally (core.asm:6699) -- there is no BATTLE_TYPE_OLD_MAN or
BATTLE_TYPE_PIKACHU special case -- so the old-man tutorial and Oak's
Pikachu catch get the wipe like any other wild battle, same as every
scripted trainer. Commands.old_man_demo already routed the Viridian
old man's tutorial catch through OverworldState:pushBattle for
exactly this reason; the fallback it used for a pushBattle-less
overworld (ctx.overworld and ctx.overworld.pushBattle then ... else
game.stack:push(battle)) was duplicated verbatim in Commands
.start_battle and would have been a third copy in story2.lua, so it's
pulled into one Commands.pushBattle(ctx, battle) helper instead, used
by all three call sites; the fallback branch now logs a warning
rather than silently dropping the transition and battle-theme start.
2026-08-11 14:01:19 +02:00
d4dc72d0f4
Fix the old-man demo bag to show 1 Poke Ball in Yellow, 50 in Red/Blue
...
Confirmed against pokeyellow's engine/battle/core.asm: the Viridian
old man's demo and Oak's Pikachu catch share the same canned
one-item bag (SimulatedInputBattleItemList), quantity 1 -- pokered's
equivalent (OldManItemList, old man only, no Pikachu battle type) is
quantity 50. The port hardcoded x50 for both versions.
2026-08-11 14:01:06 +02:00
8e48bb4e32
Play the museum-guy cue during Oak's lab walk in Yellow
...
Yellow's Pallet Town intro (professor catches the wild Pikachu, then
walks the player to the lab) played the map's default Pallet Town
theme the whole time instead of the dedicated escort cue. Per
pokeyellow's actual scripts: PlayDefaultMusicFadeOutCurrent (run on
every battle exit) legitimately restores Pallet Town's theme after
the Pikachu demo battle for the Whew.../Come with me lines; the
escort cue (MUSIC_MUSEUM_GUY, the same "led by an NPC" theme Pewter's
museum guide uses) only starts in PalletMovementScript_OakMoveLeft,
the first function of the escort script -- but only in pokeyellow's
copy. pokered's copy of that same shared Red/Yellow function only
sets BIT_NO_MAP_MUSIC and leaves whatever was already playing
(MUSIC_MEET_PROF_OAK) running uninterrupted into the lab.
Start Music_MuseumGuy at the top of escortToLab, gated on Yellow so
Red/Blue keeps its unchanged behavior, and fix the Oak-escort warp's
keepMusic comment to say which song rides the warp in each version.
2026-08-11 14:00:40 +02:00
2c8c800584
feat: add shared date and time formatting
2026-08-11 11:17:32 +02:00
ccb5358aad
feat: expose public Pokemon icon presentation
2026-08-11 11:16:58 +02:00
4db97164bb
feat: anchor first checkpoint for cold restart
2026-08-11 08:59:47 +02:00
882763cfe1
feat: checkpoint scripted battle decisions
2026-08-11 08:58:33 +02:00
798f3c25c0
Export legacy mod option schemas
2026-08-10 20:23:01 -07:00
d21a0edffc
Fix hidden battle UI overlay backgrounds
2026-08-10 20:03:33 -05:00
02024fef58
Export versioned mod option schemas
2026-08-10 17:34:08 -07:00
e59175fc89
feat(mods): allow caught markers in wild battle HUDs
2026-08-10 23:36:38 +02:00
59725c0ead
feat(mods): add battle menu auxiliary action
2026-08-10 23:32:38 +02:00
4e20f4585f
fix(mods): emit restore lifecycle after title resume
2026-08-10 23:32:35 +02:00
1c37867e52
fix(mods): keep title resume independent
2026-08-10 23:32:35 +02:00
67491e2dac
feat(mods): expose selected save chronology
2026-08-10 23:32:35 +02:00
b8138ef850
feat(mods): resume selected checkpoints from title
2026-08-10 23:32:35 +02:00
e3fc8380cf
feat(mods): expose safe overworld party reordering
2026-08-10 23:25:54 +02:00
79ed37699e
Merge pull request #1055 from AverageConsumer/codex/mod-grid-navigation-hooks
...
Mod API: allow alternate battle grids to own navigation
2026-08-10 17:08:24 -04:00
abf0f9e98a
Merge pull request #1057 from ShaneMcGovernIE/shanemcgovernie-fix-index-unexpected-character
...
Handle non-JSON update responses
2026-08-10 17:07:43 -04:00
c3855cebec
more buggies CLOSES #960 , CLOSES #961 , CLOSES #968 , CLOSES #995 , CLOSES #1006 , CLOSES #1009 , CLOSES #1013 , CLOSES #1021 , CLOSES #1031 , CLOSES #1044 , CLOSES #1049 , CLOSES #1050 , CLOSES #1045,,
2026-08-10 17:06:24 -04:00
f606840216
Handle non-JSON update responses
...
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com >
2026-08-10 20:51:57 +01:00
6a990bf79f
feat(mods): allow alternate battle grids to own navigation
2026-08-10 21:22:09 +02:00
7fa758602a
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-10 14:59:06 -04:00
ee891fb8fa
Merge pull request #993 from MaxTomahawk/feat/checkpoint-restore-event
...
feat(mods): signal verified checkpoint restores
2026-08-10 14:31:45 -04:00
9d73ff4110
yellow copyright diff
2026-08-10 14:27:00 -04:00
9234f12ed0
Merge remote-tracking branch 'origin/dev' into fix1038
...
# Conflicts:
# docs/modding.md
2026-08-10 14:14:39 -04:00
26e0bd227e
Merge pull request #1037 from dlloa/upstream-pr/platform-lifecycle-hooks
...
Add core.update / core.quit_to_launcher platform lifecycle hooks
2026-08-10 14:14:17 -04:00
bryanthaboi
AverageConsumer
thibautbus
MaxTomahawk
Dorian Burton
david
anxiousintrovert
Shane McGovern
bryanthaboi