pokemon/gen1recomp
1
0
Fork 0
mirror of https://github.com/bryanthaboi/gen1recomp.git synced 2026-08-12 08:21:02 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
46bd0f6709bb0aa32090b0bf5fa3de9832f02b4d
gen1recomp/tests/engine
T
History
spiritsnails 46bd0f6709 fix: battle screens keep their composition when they open a menu or prompt 
BATTLE SIZE "fixed" draws the battle as a discrete letterbox rather than
filling the window, and BATTLE BG "world" composes it over the live map.
Everything the battle then opens broke out of that composition, because
each piece of the frame's geometry was read off a fact about THIS FRAME
instead of about the battle:

* Renderer:uiScale follows the survey zoom only while a world is behind
  the UI, gated on worldActive -- this frame's world pass.  PartyMenu and
  ListMenu are opaque, so pushing one makes StateStack:visibleBase skip
  the map, no world pass runs, and the menu loses the step-down and blits
  a whole integer scale larger than the battle it just covered.  Held
  with uiWorldHold, the same whole-stack rule uiFill and the battle dim
  already use.  ("fill" hid this: it overrides the scale outright.)

* Game:draw started the frame at visibleBase, so that same opaque menu
  cut the overworld -- and the world pass with it -- out of the frame
  entirely, collapsing a "world" backdrop to endFrame's flat black clear.
  A world-bg battle now keeps the frame starting from underneath itself
  (drawBaseInStack).  Only the START of the draw moves; the clear stays
  keyed to the real visibleBase, so the menu still gets its opaque canvas
  and draws exactly as before.

* worldZones was keyed to that same clear base, so it came out nil for a
  frame whose world pass HAD run -- dropping endFrame's world blit onto
  the UI zone list instead, smearing the party menu's own HP-bar palettes
  across a world-canvas-sized image.  Keyed to whether the map drew.

* endFrame's letterbox clear read letterboxWhite off visibleBase alone,
  so an opaque menu over a BG "white" battle flipped its surround to
  black the same way.  Same whole-stack hold.

* ChoiceBox bottom-anchored unconditionally, docking it to the WINDOW
  edge.  That is only right when it rides the dialogue box beneath it,
  which is anchored there too; TextBox now passes the anchor and nothing
  else does, so the battle's switch offer and the shop/PC confirms stay
  over the screen that pushed them.

* TextBox anchors likewise: a battle is a self-contained SCREEN, not the
  window, and pokered prints its text box in the same 160x144 tilemap as
  the HUD.  The caught-mon nickname prompt was landing a whole letterbox
  below the blanked battle field it is printed on.  BattleState.holdsUI-
  Anchors holds setUIAnchor off while a battle is in the stack; the
  overworld's own dialogue box still docks to the screen edge.
2026-08-01 22:55:58 -06:00
..
advanced_palette_map.lua
Fix ADVANCED palette pack using Gen 2 per-species palettes instead of Gen 1's
2026-08-01 16:04:22 -06:00
ask_yesno_overlap.lua
fix: yes/no box popping up after the question text closes, not over it
2026-08-01 21:36:30 -06:00
battle_colors_bug484.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
battle_fit_option.lua
Port timing/parity fixes, seamless battle transitions, faithful-res lock, and zoom-aware UI anchoring
2026-08-01 15:52:34 -06:00
battle_fixed_menu_scale.lua
fix: battle screens keep their composition when they open a menu or prompt
2026-08-01 22:55:58 -06:00
discord_join_requested.lua
evee fix and some other junk
2026-07-25 15:21:49 -04:00
faithful_res.lua
Port timing/parity fixes, seamless battle transitions, faithful-res lock, and zoom-aware UI anchoring
2026-08-01 15:52:34 -06:00
fanfare_music_hold.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
formulas.lua
big ass modding update
2026-07-19 16:18:18 -04:00
gate_events.lua
big ass modding update
2026-07-19 16:18:18 -04:00
gate_fingerprint.lua
big ass modding update
2026-07-19 16:18:18 -04:00
gate_hooks.lua
big ass modding update
2026-07-19 16:18:18 -04:00
gate_meta_coverage.lua
iOS: stop fusing mods; Pokewalker moves to its own repo
2026-07-30 11:44:16 -04:00
gate_registries.lua
big ass modding update
2026-07-19 16:18:18 -04:00
gate_strings_coverage.lua
Bug squashing and translation mods (#311)
2026-07-27 13:37:05 -04:00
ghost_unveil_bug492.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
give_item_jingle.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
host_restart_android_bug575.lua
CLOSES #575, CLOSES #578, CLOSES #584, CLOSES #589
2026-08-01 12:56:13 -04:00
jessie_james_mtmoon_walk.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
jessie_james_pic.lua
merge main into dev
2026-07-30 11:35:57 -04:00
launcher_delete_confirm.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
launcher_mods_tests.lua
Scrub mod manifest strings to valid UTF-8
2026-08-01 14:22:30 -04:00
launcher_page_scroll.lua
Scroll the launcher page so the footer stops covering the panel
2026-07-29 12:53:24 -03:00
launcher_stray_mount.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
launcher_text_input_bug578.lua
CLOSES #575, CLOSES #578, CLOSES #584, CLOSES #589
2026-08-01 12:56:13 -04:00
menu_click_bug570.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
menu_row_offset_bug564.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
mod_index_tests.lua
rom finder
2026-07-31 11:58:21 -04:00
mod_update_tests.lua
mod manager now supports auto updates
2026-07-31 10:19:51 -04:00
multihit_hp_drain.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
music_volume_hook_state.lua
Fix two latent bugs surfaced by static analysis
2026-07-31 14:34:58 +00:00
oaks_lab_last_ball_bug601.lua
Fix wrong dialogue on Prof. Oak's leftover ball (#601)
2026-08-01 20:55:31 +01:00
oaks_pc_flow.lua
fix: restore PROF. OAK's PC intro, jingle timing and closing link
2026-08-01 11:01:19 -04:00
pc_menu_sides.lua
evee fix and some other junk
2026-07-25 15:21:49 -04:00
pc_release.lua
evee fix and some other junk
2026-07-25 15:21:49 -04:00
performance_tiers.lua
Add graphics performance tier for low-end devices
2026-07-31 01:44:17 +00:00
pokedex_quit_bug571.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
quit_thread_shutdown.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
rebind_capture_bug510.lua
CLOSES #575, CLOSES #578, CLOSES #584, CLOSES #589
2026-08-01 12:56:13 -04:00
rebind_swap_clear_bug589.lua
fixing failed tests/harnesses
2026-08-01 19:13:03 -06:00
render_compose_seam.lua
render: add render.compose seam + second-screen bridge
2026-08-01 09:35:24 +02:00
rom_pick_error_bug442.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
save_convert_extra_flags.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
save_file_io_tests.lua
keep imported save cache on export
2026-07-29 14:01:19 -04:00
save_import_retry_bug420.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
save_slots.lua
Nameable save slots in the launcher (#205)
2026-07-28 09:25:55 -04:00
soft_reset_bug563.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
teleport_ends_turn.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
teleport_escape_ends_turn.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
timing_parity.lua
Port timing/parity fixes, seamless battle transitions, faithful-res lock, and zoom-aware UI anchoring
2026-08-01 15:52:34 -06:00
title_fill_scale.lua
Port timing/parity fixes, seamless battle transitions, faithful-res lock, and zoom-aware UI anchoring
2026-08-01 15:52:34 -06:00
title_zone_seams.lua
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
tool_mod_hooks.lua
Update tool_mod_hooks.lua
2026-07-31 10:45:12 -04:00
tool_save_safety.lua
Add lifecycle hooks for tool mods
2026-07-28 13:33:53 -07:00
trade_anim_tests.lua
evee fix and some other junk
2026-07-25 15:21:49 -04:00
trainer_loss_line_bug566.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
trainer_shift_prompt_bug565.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
turn_in_place_bug415.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
update_check_tests.lua
CLOSES #303, CLOSES #307, CLOSES #314, CLOSES #318
2026-07-28 06:16:21 -04:00
update_tests.lua
CLOSES #303, CLOSES #307, CLOSES #314, CLOSES #318
2026-07-28 06:16:21 -04:00
wave_channel_mix_bug429.lua
CLOSES #339, CLOSES #354, CLOSES #360, CLOSES #372, CLOSES #373, CLOSES #374, CLOSES #375, CLOSES #378, CLOSES #379, CLOSES #383, CLOSES #384, CLOSES #385, CLOSES #391, CLOSES #392, CLOSES #393, CLOSES #394, CLOSES #395, CLOSES #396, CLOSES #397, CLOSES #398, CLOSES #413, CLOSES #420, CLOSES #423, CLOSES #424, CLOSES #425, CLOSES #426, CLOSES #427, CLOSES #429, CLOSES #430, CLOSES #431, CLOSES #433, CLOSES #435, CLOSES #436, CLOSES #438, CLOSES #439, CLOSES #441, CLOSES #442, CLOSES #444
2026-07-30 11:14:51 -04:00
wide_battle_layout.lua
Keep wide layout through battle menus
2026-07-29 13:14:56 -04:00
wide_battle_shake_bug562.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00
yellow_oak_back_pikapic.lua
CLOSES #415, CLOSES #484, CLOSES #488, CLOSES #492, CLOSES #497, CLOSES #541, CLOSES #559, CLOSES #562, CLOSES #563, CLOSES #564, CLOSES #565, CLOSES #566, CLOSES #567, CLOSES #568, CLOSES #569, CLOSES #570, CLOSES #571, CLOSES #572
2026-08-01 08:10:20 -04:00