Merge origin/main into squadhing-som-bug

Keep elevator seed-exit helpers and blocking play_once across the squashy squash merge.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -18,19 +18,6 @@ body:
     validations:
       required: true
 
-  - type: dropdown
-    id: game
-    attributes:
-      label: Which game were you playing
-      description: Pick every version you saw the bug in.
-      multiple: true
-      options:
-        - Red
-        - Blue
-        - Yellow
-    validations:
-      required: true
-
   - type: dropdown
     id: os
     attributes:
@@ -38,33 +25,10 @@ body:
       options:
         - macOS
         - Windows
-        - Linux
-        - Android
-        - iOS
-        - Multiple platforms
+        - Both
     validations:
       required: true
 
-  - type: dropdown
-    id: mods_enabled
-    attributes:
-      label: Were any mods on
-      description: Check the MODS tab in the launcher if you're not sure.
-      options:
-        - "No"
-        - "Yes"
-    validations:
-      required: true
-
-  - type: input
-    id: mods_which
-    attributes:
-      label: Which mods (if any were on)
-      description: List the enabled mods. Leave blank if none were on.
-      placeholder: nuzlocke 1.0.0, running-shoes 0.3
-    validations:
-      required: false
-
   - type: input
     id: version
     attributes:
@@ -74,17 +38,6 @@ body:
     validations:
       required: true
 
-  - type: input
-    id: discord
-    attributes:
-      label: Discord username (optional)
-      description: >
-        So maintainers can ping you on Discord if they need a quick follow-up.
-        Leave blank if you'd rather keep everything on GitHub.
-      placeholder: yourname
-    validations:
-      required: false
-
   - type: input
     id: location
     attributes:

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,67 +1,35 @@
 name: Feature request
-description: Ask for something new in the engine, launcher, or platform — not a content/gameplay mod.
+description: Ask for something new, or a change to how something already works.
 labels: ["enhancement"]
 body:
   - type: markdown
     attributes:
       value: |
-        Use this for **engine / launcher / platform** work (ports, video options, save
-        tooling, networking, mod API seams, docs).
-
-        If what you want is a gameplay, cosmetic, audio, or QoL change that a Lua mod
-        could ship — running shoes, alternate sprites, day/night, shiny indicators,
-        Gen 2-like battle toggles, soundtrack packs — open a
-        **[Mod request](https://github.com/bryanthaboi/gen1recomp/issues/new?template=mod_request.yml)**
-        instead.
-
         "Can we add X" on its own is hard to act on. Say what you want, why you want it,
-        and how you picture it working.
+        and how you picture it working. A request with real detail is one someone can
+        actually build without guessing at what you meant.
 
   - type: input
     id: summary
     attributes:
       label: One line summary
       description: What you want, in a sentence.
-      placeholder: Add Linux AppImage releases next to the macOS and Windows builds
+      placeholder: Add a run toggle so you can move at bike speed without the bike
     validations:
       required: true
 
-  - type: dropdown
-    id: game
-    attributes:
-      label: Which game is this about
-      description: Pick every version it applies to.
-      multiple: true
-      options:
-        - Red
-        - Blue
-        - Yellow
-        - Not version-specific
-    validations:
-      required: true
-
-  - type: input
-    id: discord
-    attributes:
-      label: Discord username (optional)
-      description: >
-        So maintainers can ping you on Discord if they need a quick follow-up.
-        Leave blank if you'd rather keep everything on GitHub.
-      placeholder: yourname
-    validations:
-      required: false
-
   - type: textarea
     id: what
     attributes:
       label: What do you want
       description: >
-        Describe it properly. What is it, where does it live (launcher, options,
-        engine), what does the player see or do. If it changes something that already
-        exists, say what it does today and what it should do instead.
+        Describe it properly. What is it, where does it live in the game, what does the
+        player see or do. If it changes something that already exists, say what it does today
+        and what it should do instead.
       placeholder: |
-        Ship a Linux AppImage on each release, same version as the macOS/Windows builds,
-        with the same save folder layout and mod discovery path.
+        A hold-to-run button, the way later Pokemon games do it. Hold B while moving on
+        foot and the player moves at bike speed. Release and you go back to walking.
+        Doesn't work indoors where the bike doesn't work, doesn't work in battles or menus.
     validations:
       required: true
 
@@ -73,8 +41,9 @@ body:
         What's annoying or missing right now. What does this fix. If it's just because you
         think it would be fun, say that, it's a real answer.
       placeholder: |
-        LÖVE already runs on Linux; without a packaged build, players have to assemble
-        it themselves and miss release notes / update checks.
+        Backtracking across routes you've already cleared is slow, and the bike is a menu
+        dive away and doesn't work in a lot of places. Running would cut a lot of dead time
+        without making the game easier.
     validations:
       required: true
 
@@ -83,12 +52,14 @@ body:
     attributes:
       label: How should it work
       description: >
-        The specifics. Which menu, what happens in the edge cases. If you don't
+        The specifics. Which button, which menu, what happens in the edge cases. If you don't
         know, say what you'd expect as a player and leave the rest open.
       placeholder: |
-        - GitHub Releases asset next to the .dmg / .exe
-        - Same options.lua / mods/ layout as desktop
-        - Documented in the README install section
+        - Hold B on the overworld to run
+        - Same speed as the bike
+        - Disabled anywhere the bike is disabled
+        - Sprite should probably need a running animation, not sure what that takes
+        - No effect on encounter rates
     validations:
       required: true
 

.github/ISSUE_TEMPLATE/mod_request.yml

@@ -1,129 +0,0 @@
-name: Mod request
-description: Ask for a gameplay, cosmetic, audio, or QoL change that belongs as a Lua mod.
-labels: ["mod request"]
-body:
-  - type: markdown
-    attributes:
-      value: |
-        This tracker is for ideas that should ship as **mods**, not as core engine
-        features — alternate sprites, running shoes, day/night, shiny indicators,
-        soundtrack packs, Gen 2-like battle toggles, map cosmetics, bag QoL, etc.
-
-        The engine already exposes a lot of this through registries and hooks
-        ([modding wiki](https://github.com/bryanthaboi/gen1recomp/wiki)).
-        Use a **Feature request** instead for launcher / ports / video options /
-        networking / save tooling / new API seams.
-
-  - type: input
-    id: summary
-    attributes:
-      label: One line summary
-      description: What the mod should do, in a sentence.
-      placeholder: Hold B to run at bike speed on the overworld
-    validations:
-      required: true
-
-  - type: dropdown
-    id: game
-    attributes:
-      label: Which game is this for
-      description: Pick every version the mod should cover.
-      multiple: true
-      options:
-        - Red
-        - Blue
-        - Yellow
-        - Not version-specific
-    validations:
-      required: true
-
-  - type: input
-    id: discord
-    attributes:
-      label: Discord username (optional)
-      description: >
-        So maintainers or mod authors can ping you on Discord if they pick this up.
-        Leave blank if you'd rather keep everything on GitHub.
-      placeholder: yourname
-    validations:
-      required: false
-
-  - type: textarea
-    id: what
-    attributes:
-      label: What should the mod do
-      description: >
-        Describe the player-facing behavior. What changes, where, what does the
-        player see or press. If it toggles from Options or a START-menu entry, say so.
-      placeholder: |
-        Hold B while walking outdoors to move at bike speed. Release to walk again.
-        Same places the bike is allowed; no effect in battles or menus.
-    validations:
-      required: true
-
-  - type: textarea
-    id: why
-    attributes:
-      label: Why is this worth doing as a mod
-      description: >
-        Why optional/modded rather than a core option. Who wants it on, who wants
-        vanilla left alone.
-      placeholder: |
-        Great for replaying and backtracking, but some people want a strict Gen 1
-        pace. A mod (or an opt-in mod option) keeps both camps happy.
-    validations:
-      required: true
-
-  - type: textarea
-    id: how
-    attributes:
-      label: How should it work
-      description: >
-        Buttons, menus, edge cases, whether it needs new art/audio. If you know a
-        hook or registry that fits (movement.speed, pokemon.sprite, rulesets, …),
-        mention it — otherwise leave it open.
-      placeholder: |
-        - Hold B on the overworld
-        - Same step timing as the bike
-        - Disabled where the bike is disabled
-        - Prefer hooks:wrap("movement.speed") if that still fits
-    validations:
-      required: true
-
-  - type: dropdown
-    id: vanilla
-    attributes:
-      label: With the mod off, is vanilla unchanged
-      options:
-        - Yes — parity when disabled
-        - No — it would replace something always-on
-        - Not sure
-    validations:
-      required: true
-
-  - type: dropdown
-    id: category
-    attributes:
-      label: Best-fit mod category
-      description: Same taxonomy as example mods (BALANCE, GRAPHICS, AUDIO, …).
-      options:
-        - GAMEPLAY / QoL
-        - GRAPHICS
-        - AUDIO
-        - BALANCE / ruleset
-        - CONTENT (maps, encounters, trainers)
-        - UI / TOOL
-        - TOTAL_CONVERSION-ish
-        - Not sure
-    validations:
-      required: true
-
-  - type: textarea
-    id: extra
-    attributes:
-      label: Anything else
-      description: >
-        Reference screenshots, other games/hacks that do it, related issues, or
-        "I'd like to try writing this myself." Leave blank if nothing comes to mind.
-    validations:
-      required: false

.github/dependabot.yml

@@ -1,6 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: github-actions
-    directory: /
-    schedule:
-      interval: weekly

.github/workflows/ci.yml

@@ -10,11 +10,11 @@ name: ci
 # The T3 content tier asserts Pokemon Red facts; scripts/test.sh detects
 # data/generated/ is absent and skips it rather than failing.
 #
+# Runs alongside release.yml, which is untouched by this file.
+
 on:
   push:
-    # Integration branch + release branch. PRs already run via pull_request
-    # (any base); this list is only for post-merge push runs.
-    branches: [dev, main]
+    branches: [main]
   pull_request:
 
 # a force-push while CI is mid-run should cancel the stale run, not queue
@@ -22,91 +22,12 @@ concurrency:
   group: ci-${{ github.ref }}
   cancel-in-progress: true
 
-permissions:
-  contents: read
-
 jobs:
-  ios-changes:
-    name: detect iOS changes
-    runs-on: ubuntu-latest
-    outputs:
-      changed: ${{ steps.paths.outputs.changed }}
-    steps:
-      - uses: actions/checkout@v7
-        with:
-          fetch-depth: 0
-      - id: paths
-        env:
-          BASE_SHA: ${{ github.event.pull_request.base.sha || github.event.before }}
-          HEAD_SHA: ${{ github.sha }}
-        run: |
-          if [ -z "$BASE_SHA" ] || [ "$BASE_SHA" = "0000000000000000000000000000000000000000" ]; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-            exit 0
-          fi
-          if git diff --name-only "$BASE_SHA" "$HEAD_SHA" | grep -Eq '^(mobile/ios/|scripts/build_ios\.sh$)'; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          else
-            echo "changed=false" >> "$GITHUB_OUTPUT"
-          fi
-
-  ios-build:
-    name: iOS build
-    needs: ios-changes
-    if: needs.ios-changes.outputs.changed == 'true'
-    runs-on: ${{ fromJSON(github.repository == 'bryanthaboi/gen1recomp' && '["self-hosted", "macOS"]' || '"macos-latest"') }}
-    outputs:
-      ipa_url: ${{ steps.upload-ipa.outputs.artifact-url }}
-    steps:
-      - uses: actions/checkout@v7
-      - name: import signing certificate
-        if: github.repository == 'bryanthaboi/gen1recomp'
-        run: |
-          keychain_path="$RUNNER_TEMP/gen1recomp-ci-signing.keychain-db"
-          ci_dir="${POKEMON_CI_DIR:-$HOME/.config/pokemon-ci}"
-          p12="$ci_dir/signing.p12"
-          passfile="$ci_dir/signing.pass"
-          [ -f "$p12" ] && [ -f "$passfile" ] || exit 1
-          p12pw="$(cat "$passfile")"
-          kcpw="$(openssl rand -base64 24)"
-          echo "::add-mask::$kcpw"
-          security delete-keychain "$keychain_path" 2>/dev/null || true
-          security create-keychain -p "$kcpw" "$keychain_path"
-          security set-keychain-settings "$keychain_path"
-          security unlock-keychain -p "$kcpw" "$keychain_path"
-          security import "$p12" -P "$p12pw" -k "$keychain_path" -T /usr/bin/codesign -T /usr/bin/security
-          security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$kcpw" "$keychain_path" >/dev/null
-          existing="$(security list-keychains -d user | sed -e 's/^[[:space:]]*//' -e 's/"//g')"
-          security list-keychains -d user -s "$keychain_path" $existing
-      - name: install xcbeautify
-        run: brew list xcbeautify >/dev/null 2>&1 || brew install xcbeautify
-      - name: build iOS release
-        env:
-          CANONICAL_REPOSITORY: ${{ github.repository == 'bryanthaboi/gen1recomp' }}
-        run: |
-          if [ "$CANONICAL_REPOSITORY" = true ]; then
-            scripts/build_ios.sh --fetch --device --release
-          else
-            scripts/build_ios.sh --fetch --release
-          fi
-      - name: upload iOS release artifact
-        id: upload-ipa
-        if: github.repository == 'bryanthaboi/gen1recomp'
-        uses: actions/upload-artifact@v7
-        with:
-          name: gen1recomp-ios-ipa
-          path: dist/ios/gen1recomp.ipa
-          if-no-files-found: error
-          retention-days: 7
-      - name: clean up signing keychain
-        if: ${{ always() && github.repository == 'bryanthaboi/gen1recomp' }}
-        run: security delete-keychain "$RUNNER_TEMP/gen1recomp-ci-signing.keychain-db" 2>/dev/null || true
-
   headless:
     name: headless suites (no ROM)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v7
+      - uses: actions/checkout@v4
 
       # LuaJIT, not lua5.4: LOVE 11.x embeds LuaJIT 2.1 and the engine is
       # written to Lua 5.1 semantics, so CI must run the interpreter the
@@ -124,7 +45,7 @@ jobs:
     name: fixture dataset integrity
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v7
+      - uses: actions/checkout@v4
       - run: sudo apt-get update && sudo apt-get install -y luajit
       - run: python3 -m pip install --upgrade pillow
 
@@ -166,7 +87,7 @@ jobs:
     name: screenshot differ (capture not yet wired)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v7
+      - uses: actions/checkout@v4
       - run: python3 -m pip install --upgrade pillow
 
       # 21-testing-and-ci §"Testing & acceptance criteria": compare_shots
@@ -214,7 +135,7 @@ jobs:
     name: mod lint (no ROM-derived content)
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v7
+      - uses: actions/checkout@v4
 
       # the MK305 dump check key-diffs shipped tables through luajit, and
       # modkit treats a missing interpreter as a fatal MK100 -- without

.github/workflows/ios-artifact-comment.yml

@@ -1,61 +0,0 @@
-name: iOS artifact comment
-
-on:
-  workflow_run:
-    workflows: [ci]
-    types: [completed]
-
-permissions:
-  contents: read
-  issues: write
-  pull-requests: write
-
-jobs:
-  comment:
-    if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
-    runs-on: ubuntu-latest
-    steps:
-      - id: artifact
-        env:
-          GH_TOKEN: ${{ github.token }}
-          RUN_ID: ${{ github.event.workflow_run.id }}
-          HEAD_BRANCH: ${{ github.event.workflow_run.head_branch }}
-          HEAD_REPOSITORY: ${{ github.event.workflow_run.head_repository.full_name }}
-        run: |
-          artifact_id="$(gh api "repos/$GITHUB_REPOSITORY/actions/runs/$RUN_ID/artifacts" --jq '.artifacts[] | select(.name == "gen1recomp-ios-ipa") | .id')"
-          [ -n "$artifact_id" ] || exit 0
-          head_owner="${HEAD_REPOSITORY%%/*}"
-          pr_number="$(gh api "repos/$GITHUB_REPOSITORY/pulls?state=open&head=$head_owner:$HEAD_BRANCH" --jq '.[0].number // empty')"
-          [ -n "$pr_number" ] || exit 0
-          echo "artifact_url=https://github.com/$GITHUB_REPOSITORY/actions/runs/$RUN_ID/artifacts/$artifact_id" >> "$GITHUB_OUTPUT"
-          echo "pr_number=$pr_number" >> "$GITHUB_OUTPUT"
-      - name: Delete existing comment
-        if: steps.artifact.outputs.pr_number != ''
-        uses: izhangzhihao/delete-comment@master
-        with:
-          github_token: ${{ github.token }}
-          delete_user_name: github-actions[bot]
-          issue_number: ${{ steps.artifact.outputs.pr_number }}
-      - name: Get build info
-        id: build-info
-        env:
-          HEAD_SHA: ${{ github.event.workflow_run.head_sha }}
-        run: |
-          commit_hash="$(printf '%s' "$HEAD_SHA" | cut -c1-7)"
-          build_time="$(date "+%Y-%m-%d %H:%M:%S")"
-          echo "hash=$commit_hash" >> "$GITHUB_OUTPUT"
-          echo "time=$build_time" >> "$GITHUB_OUTPUT"
-      - name: comment iOS artifact
-        if: steps.artifact.outputs.pr_number != ''
-        uses: thollander/actions-comment-pull-request@v3
-        with:
-          message: |
-            [gen1recomp.ipa](${{ steps.artifact.outputs.artifact_url }})
-
-            **Commit**: [#${{ steps.build-info.outputs.hash }}](https://github.com/${{ github.event.workflow_run.head_repository.full_name }}/commit/${{ github.event.workflow_run.head_sha }})
-            **Build Time**: `${{ steps.build-info.outputs.time }}`
-
-            <sub>This comment was automatically generated. [View workflow run](https://github.com/${{ github.repository }}/actions/runs/${{ github.event.workflow_run.id }})</sub>
-          pr-number: ${{ steps.artifact.outputs.pr_number }}
-          comment-tag: ios-build-result
-          github-token: ${{ github.token }}

.github/workflows/release.yml

@@ -1,8 +1,7 @@
 name: Release
 
-# Builds the macOS, Windows, and Linux desktop apps, an Android APK, an iOS
-# IPA, and the Anbernic RG34XXSP (Stock OS 64-bit MOD / PortMaster) port on
-# the self-hosted Mac runner, and publishes them as a GitHub Release.
+# Builds the macOS, Windows, and Linux desktop apps plus an Android APK
+# on the self-hosted Mac runner, and publishes them as a GitHub Release.
 #
 # Versioning:
 #   - First ever release is 0.1.0.
@@ -11,9 +10,6 @@ name: Release
 #   - To force a specific version, either:
 #       * run this workflow manually (Actions tab) and type it into "version", or
 #       * put "[release X.Y.Z]" anywhere in the commit message.
-#
-# Branch model: day-to-day work merges to `dev`. Releases stay on `main` only
-# so promoting `dev` -> `main` is the ship gate that cuts a build.
 
 on:
   push:
@@ -24,7 +20,6 @@ on:
     paths-ignore:
       - '.github/**'
       - '**.md'
-      - 'mobile/ios/app-repo.json'
   workflow_dispatch:
     inputs:
       version:
@@ -43,17 +38,11 @@ concurrency:
 
 jobs:
   release:
-    runs-on: ${{ fromJSON(github.repository == 'bryanthaboi/gen1recomp' && '["self-hosted", "macOS"]' || '"macos-latest"') }}
+    runs-on: [self-hosted, macOS]
 
     steps:
-      # The self-hosted runner lives under the machine owner's home
-      # directory; mask it first so absolute paths in every later step's
-      # output show up as *** in the public workflow logs.
-      - name: Mask runner paths
-        run: echo "::add-mask::$HOME"
-
       - name: Checkout
-        uses: actions/checkout@v7
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           fetch-tags: true
@@ -128,7 +117,6 @@ jobs:
           echo "tag=$tag" >> "$GITHUB_OUTPUT"
 
       - name: Import signing certificate into a temporary keychain
-        if: github.repository == 'bryanthaboi/gen1recomp'
         run: |
           set -euo pipefail
           KEYCHAIN_PATH="$RUNNER_TEMP/pokemon-signing.keychain-db"
@@ -178,33 +166,7 @@ jobs:
           set -euo pipefail
           scripts/build_android.sh --version "${{ steps.ver.outputs.version }}"
 
-      - name: Install xcbeautify
-        run: |
-          set -euo pipefail
-          brew list xcbeautify >/dev/null 2>&1 || brew install xcbeautify
-
-      - name: Build iOS
-        env:
-          CANONICAL_REPOSITORY: ${{ github.repository == 'bryanthaboi/gen1recomp' }}
-        run: |
-          set -euo pipefail
-          if [ "$CANONICAL_REPOSITORY" = true ]; then
-            scripts/build_ios.sh --fetch --device --release \
-              --version "${{ steps.ver.outputs.version }}"
-          else
-            scripts/build_ios.sh --fetch --release \
-              --version "${{ steps.ver.outputs.version }}"
-          fi
-
-      - name: Build Anbernic RG34XXSP port
-        run: |
-          set -euo pipefail
-          # Self-contained aarch64 PortMaster-style pack; pulls the LÖVE 11.5
-          # runtime from PortMaster-GUI, so it needs no signing/notarization.
-          ./build-rg34xxsp.sh --version "${{ steps.ver.outputs.version }}"
-
       - name: Notarize & staple macOS app
-        if: github.repository == 'bryanthaboi/gen1recomp'
         run: |
           set -euo pipefail
           ci_dir="${POKEMON_CI_DIR:-$HOME/.config/pokemon-ci}"
@@ -239,7 +201,6 @@ jobs:
           echo "Notarized + stapled ✓"
 
       - name: Stage release assets
-        if: github.repository == 'bryanthaboi/gen1recomp'
         id: assets
         run: |
           set -euo pipefail
@@ -253,33 +214,9 @@ jobs:
           apk="$(find dist/android/debug -name '*.apk' | head -1)"
           [ -n "$apk" ] || { echo "::error::no Android APK found under dist/android/debug"; exit 1; }
           cp "$apk" "$outdir/gen1recomp-${v}-android.apk"
-
-          ipa="dist/ios/gen1recomp.ipa"
-          [ -f "$ipa" ] || { echo "::error::$ipa not found (expected from scripts/build_ios.sh --device)"; exit 1; }
-          cp "$ipa" "$outdir/gen1recomp-${v}-ios.ipa"
-
-          # Anbernic handheld port (suffix names the CFW it targets, so a
-          # future RG35XX/other-CFW pack can ship alongside it).
-          rg34="dist/rg34xxsp/gen1recomp-rg34xxsp-stockos64-mod.zip"
-          [ -f "$rg34" ] || { echo "::error::$rg34 not found (expected from ./build-rg34xxsp.sh)"; exit 1; }
-          cp "$rg34" "$outdir/gen1recomp-${v}-rg34xxsp-stockos64-mod.zip"
-
-          # Platform-independent update payload, built alongside the desktop
-          # apps above (same game.love that gets fused into each of them).
-          love_file=".bazinga/work/game.love"
-          [ -f "$love_file" ] || { echo "::error::$love_file not found (expected from scripts/build.sh)"; exit 1; }
-          cp "$love_file" "$outdir/gen1recomp-${v}.love"
-
           ls -lh "$outdir"
 
-          # Checksums for every staged release asset (sums file itself is
-          # written after this and named outside the gen1recomp-* glob, so it
-          # never lists itself).
-          (cd "$outdir" && shasum -a 256 gen1recomp-* > sha256sums.txt)
-          cat "$outdir/sha256sums.txt"
-
       - name: Publish GitHub Release
-        if: github.repository == 'bryanthaboi/gen1recomp'
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
@@ -287,37 +224,19 @@ jobs:
           v="${{ steps.ver.outputs.version }}"
           tag="${{ steps.ver.outputs.tag }}"
 
-          # Issues this release closes. Three sources, deduped by number:
-          #   1. GitHub's own "closing issues" links on every PR whose
-          #      commits are in the range (works for squash, rebase, and
-          #      merge commits alike) -- including PRs that were merged
-          #      into a branch this release PR is itself merging in.
-          #   2. CLOSES/fixes/resolves text in those PRs' titles + bodies
-          #      that GitHub didn't turn into a closing link (a PR into a
-          #      non-default branch never gets one).
-          #   3. The same text in raw commit messages, so a direct push
-          #      with "CLOSES #N #M" still lands in the notes.
-          # Scans every commit since the previous tag so a skipped release
-          # run doesn't drop issues on the floor.
+          # Issues this release closes, per GitHub's own "closing issues" links
+          # (works for squash, rebase, and merge commits alike). Scans every
+          # commit since the previous tag so a skipped release run doesn't drop
+          # issues on the floor.
           prev_tag="$(git tag -l 'v*' --sort=-v:refname | grep -v "^${tag}$" | head -1 || true)"
           range="${prev_tag:+${prev_tag}..}$GITHUB_SHA"
 
-          # every #N on a line that carries a closing keyword (handles the
-          # multi-issue "CLOSES #1 #2 #3" form the tracker uses)
-          scan_closes() {
-            grep -iE '\b(close[sd]?|fix(es|ed)?|resolve[sd]?)\b' \
-              | grep -oE '#[0-9]+' | tr -d '#' || true
-          }
-
-          nums=""
-          nums+=" $(git log --pretty=%B "$range" | scan_closes | tr '\n' ' ')"
-
-          prs="$(git log --pretty=%H "$range" \
-                   | xargs -I{} gh api "repos/$GITHUB_REPOSITORY/commits/{}/pulls" \
-                         --jq '.[].number' 2>/dev/null \
-                   | sort -un || true)"
-          for pr in $prs; do
-            nums+=" $(gh api graphql \
+          closed=""
+          for pr in $(git log --pretty=%H "$range" \
+                        | xargs -I{} gh api "repos/$GITHUB_REPOSITORY/commits/{}/pulls" \
+                              --jq '.[].number' 2>/dev/null \
+                        | sort -un || true); do
+            closed+="$(gh api graphql \
               -f owner="${GITHUB_REPOSITORY%/*}" \
               -f name="${GITHUB_REPOSITORY#*/}" \
               -F pr="$pr" \
@@ -325,48 +244,19 @@ jobs:
                 query($owner:String!, $name:String!, $pr:Int!) {
                   repository(owner:$owner, name:$name) {
                     pullRequest(number:$pr) {
-                      closingIssuesReferences(first:50) { nodes { number } }
+                      closingIssuesReferences(first:50) { nodes { number title } }
                     }
                   }
                 }' \
-              --jq '.data.repository.pullRequest.closingIssuesReferences.nodes[].number' \
-              2>/dev/null | grep -E '^[0-9]+$' | tr '\n' ' ' || true)"
-            nums+=" $(gh api "repos/$GITHUB_REPOSITORY/pulls/$pr" \
-              --jq '.title + " " + (.body // "")' 2>/dev/null \
-              | scan_closes | tr '\n' ' ' || true)"
-          done
-
-          # dedupe, drop anything that is a PR or does not exist, keep
-          # titles (gh api prints the response body to stdout on an HTTP
-          # error, so only a zero exit counts)
-          closed=""
-          for n in $(printf '%s' "$nums" | tr ' ' '\n' | grep -E '^[0-9]+$' | sort -un); do
-            if title="$(gh api "repos/$GITHUB_REPOSITORY/issues/$n" \
-                --jq 'if .pull_request then empty else .title end' \
-                2>/dev/null)"; then
-              [ -n "$title" ] && closed+="- #$n $title"$'\n'
-            fi
+              --jq '.data.repository.pullRequest.closingIssuesReferences.nodes[]
+                    | "- #\(.number) \(.title)"' 2>/dev/null || true)"$'\n'
           done
           closed="$(printf '%s' "$closed" | grep . | sort -t'#' -k2 -n || true)"
 
-          # Everyone whose commits are in the range: GitHub login when the
-          # commit is linked to an account, the raw git author name when not;
-          # CI bots filtered out.
-          base="${prev_tag:-$(git rev-list --max-parents=0 "$GITHUB_SHA" | tail -1)}"
-          contributors="$(gh api --paginate \
-            "repos/$GITHUB_REPOSITORY/compare/${base}...${GITHUB_SHA}" \
-            --jq '.commits[] | if .author and .author.login
-                              then "@" + .author.login
-                              else .commit.author.name end' 2>/dev/null \
-            | grep -viE '\[bot\]$' | sort -uf | sed 's/^/- /' || true)"
-
           notes="Download the correct version for your computer below."
           if [ -n "$closed" ]; then
             notes+=$'\n\n## Issues closed\n\n'"$closed"
           fi
-          if [ -n "$contributors" ]; then
-            notes+=$'\n\n## Contributors\n\n'"$contributors"
-          fi
           printf 'Release notes:\n%s\n' "$notes"
 
           gh release create "$tag" \
@@ -376,80 +266,11 @@ jobs:
             "dist/release/gen1recomp-${v}-macos.zip" \
             "dist/release/gen1recomp-${v}-windows.zip" \
             "dist/release/gen1recomp-${v}-linux.zip" \
-            "dist/release/gen1recomp-${v}-android.apk" \
-            "dist/release/gen1recomp-${v}-ios.ipa" \
-            "dist/release/gen1recomp-${v}-rg34xxsp-stockos64-mod.zip" \
-            "dist/release/gen1recomp-${v}.love" \
-            "dist/release/sha256sums.txt"
+            "dist/release/gen1recomp-${v}-android.apk"
 
           echo "Published release $tag"
 
-      - name: Update iOS app repository
-        if: github.repository == 'bryanthaboi/gen1recomp'
-        run: |
-          set -euo pipefail
-          v="${{ steps.ver.outputs.version }}"
-          ipa="dist/release/gen1recomp-${v}-ios.ipa"
-          app_repo="mobile/ios/app-repo.json"
-          [ -f "$ipa" ] || { echo "::error::$ipa not found"; exit 1; }
-          [ -f "$app_repo" ] || { echo "::error::$app_repo not found"; exit 1; }
-
-          date="$(date -u +"%Y-%m-%d")"
-          size="$(wc -c < "$ipa" | tr -d '[:space:]')"
-          download_url="https://github.com/${GITHUB_REPOSITORY}/releases/download/v${v}/gen1recomp-${v}-ios.ipa"
-          localized_description="Gen1Recomp - A native Lua / LÖVE2D recreation of Gen 1 Poke"
-          release_notes="$(GH_TOKEN="${{ github.token }}" gh release view "v${v}" --json body --jq '.body // ""' 2>/dev/null || true)"
-          if [ -n "$release_notes" ]; then
-            localized_description="$release_notes"
-          fi
-          entry="$(jq -n \
-            --arg version "$v" \
-            --arg date "$date" \
-            --arg download_url "$download_url" \
-            --arg localized_description "$localized_description" \
-            --argjson size "$size" \
-            '{version: $version, date: $date, size: $size, downloadURL: $download_url, localizedDescription: $localized_description}')"
-
-          if jq -e --arg version "$v" \
-            'any(.apps[] | select(.bundleIdentifier == "com.theboisclub.gen1recomp").versions[]?; .version == $version)' \
-            "$app_repo" >/dev/null; then
-            jq --arg version "$v" --argjson entry "$entry" \
-              '(.apps[] | select(.bundleIdentifier == "com.theboisclub.gen1recomp").versions) |= map(if .version == $version then $entry else . end)' \
-              "$app_repo" > "$app_repo.tmp"
-          else
-            jq --argjson entry "$entry" \
-              '(.apps[] | select(.bundleIdentifier == "com.theboisclub.gen1recomp").versions) |= [$entry] + .' \
-              "$app_repo" > "$app_repo.tmp"
-          fi
-          mv "$app_repo.tmp" "$app_repo"
-
-      # main is PR-only for everyone except deploy keys (the "main protection"
-      # ruleset's bypass actor), so this push must authenticate with the
-      # RELEASE_DEPLOY_KEY deploy key over SSH; the workflow's GITHUB_TOKEN
-      # would be rejected by the branch protection.
-      - name: Commit iOS app repository
-        if: github.repository == 'bryanthaboi/gen1recomp'
-        env:
-          DEPLOY_KEY: ${{ secrets.RELEASE_DEPLOY_KEY }}
-        run: |
-          set -euo pipefail
-          git add mobile/ios/app-repo.json
-          if git diff --cached --quiet; then
-            echo "app-repo.json unchanged; nothing to push"
-            exit 0
-          fi
-          key="$RUNNER_TEMP/release-deploy-key"
-          printf '%s\n' "$DEPLOY_KEY" > "$key"
-          chmod 600 "$key"
-          git config user.name "github-actions[bot]"
-          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
-          git commit -m "chore(ios): update app-repo.json [skip ci]"
-          git -c core.sshCommand="ssh -i $key -o IdentitiesOnly=yes -o StrictHostKeyChecking=accept-new" \
-            push "git@github.com:${GITHUB_REPOSITORY}.git" "HEAD:${GITHUB_REF_NAME}"
-          rm -f "$key"
-
       - name: Clean up signing keychain
-        if: ${{ always() && github.repository == 'bryanthaboi/gen1recomp' }}
+        if: always()
         run: |
           security delete-keychain "$RUNNER_TEMP/pokemon-signing.keychain-db" 2>/dev/null || true
-          rm -f "$RUNNER_TEMP/release-deploy-key"

.gitignore

@@ -16,7 +16,6 @@ __pycache__/
 .*
 !.github/
 !.gitignore
-!.luacheckrc
 
 # Android build outputs / local SDK path / packaged payload (keep love-android sources)
 mobile/android/app/build/
@@ -36,10 +35,3 @@ mobile/ios/build/
 
 # Legacy manual convenience-copy location (superseded by /dist/android/)
 mobile/dist/
-
-# Tiled map-editing workspace (tools/tiled_export.py). Derived from the imported
-# ROM cache exactly like data/generated/, so it is never committable.
-/build/tiled/
-
-# per-machine iOS bundle-id pin (see scripts/build_ios.sh)
-mobile/ios/bundle_id.local

.luacheckrc

@@ -1,43 +0,0 @@
--- Static-analysis config for `luacheck` (https://luacheck.readthedocs.io).
---
--- Run it over the engine with:  luacheck src   (or scripts/lint.sh)
---
--- The point is a high-signal baseline: the categories left on are the ones
--- that catch real defects -- undefined globals/locals (the class that hid a
--- `music.volume` crash: applyVolume read a `state` that was still the nil
--- global), unused values, unreachable code, redefinitions. The cosmetic
--- categories the codebase deliberately lives with (a `self`/`dt` an
--- interface requires but a given method ignores, documented empty
--- fall-through branches, the odd long line) are muted so they don't drown
--- the signal.
-
-std = "luajit"
-
--- LÖVE exposes `love` as a mutable table: games assign their callbacks onto
--- it (love.wheelmoved, love.run, ...), so it is a regular global, not
--- read-only -- otherwise every callback registration reads as a violation.
-globals = { "love" }
-
-read_globals = {
-  "jit",
-  -- LuaJIT 2.1 ships table.unpack even though the bare 5.1 `table` std lacks
-  -- it; without this, every `table.unpack` reads as an undefined field.
-  table = { fields = { "unpack" } },
-}
-
--- Vendored/native trees and the test suites have their own conventions.
-exclude_files = {
-  "mobile/",
-  "tests/",
-  "tools/save-editor/",
-}
-
-ignore = {
-  "212",  -- unused argument -- self/dt kept for a shared method signature
-  "213",  -- unused loop variable -- `for _, v in` where only v is wanted
-  "421",  -- shadowing a local -- deliberate re-use in a few tight scopes
-  "431",  -- shadowing an upvalue
-  "432",  -- shadowing an argument
-  "542",  -- empty if branch -- documented fall-throughs, not gaps
-  "631",  -- line is too long
-}

CONTRIBUTING-mods.md

@@ -118,7 +118,6 @@ not a hard error, so the list can grow without breaking old mods.
 | `QUEST` | New story, NPCs, dialogue, cutscenes | content |
 | `MECHANIC` | New or changed battle/field mechanics via hooks/effects | overhaul |
 | `GRAPHICS` | Sprite / tileset / palette / font changes | content |
-| `LANGUAGE` | A translation: `text`, `strings` and the glyphs it needs | content |
 | `AUDIO` | Music, sfx, cries | content |
 | `UI` | New or modified screens, menus, overlays | content / overhaul |
 | `TOOL` | Dev/QoL utilities, overlays, inter-mod libraries | content |
@@ -129,15 +128,6 @@ not a hard error, so the list can grow without breaking old mods.
 keeps validating with the value it has shipped since before the taxonomy
 existed.
 
-A translation may also set `"language": true` in the manifest. That is the
-one claim online play acts on: an install running nothing but verified
-translations may take an ONLINE MATCH or a TOURNAMENT instead of being
-asked to restart vanilla. The claim is checked, not taken -- the mod
-qualifies only if every record it writes lands in `text`, `strings` or
-`font`, it wraps no hook, subscribes to no event and requests no
-permission. Anything else and it is an ordinary content mod that happens to
-ship text.
-
 ### 4. `mod.card`
 
 The manifest is the *engine's* contract: identity, load order, dependencies,

LICENSE.MD

@@ -1,7 +0,0 @@
-Copyright 2026 BOIS CLUB GAMES, LLC
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

README.md

@@ -1,186 +1,49 @@
-# Gen1Recomp
+# Pokemon Gen 1 Recompilation Project
 
-A native LÖVE2D recreation of Poke Red, Blue and Yellow. The engine and map
-behavior are hand-written Lua; game data and graphics are decoded from a ROM
-supplied by the player.
-
-> [!CAUTION]
-> **We are NOT affiliated with the website `gen1recomp[.]com`** That website is not run by this project, was not authorized by us, and we have no idea who operates it. It is impersonating this project; do not download anything from it, and treat anything it hosts or claims as untrustworthy. Even if the site currently links back to this repository, the people behind it can change its content at any time, so nothing on it should ever be trusted. This GitHub repository and the Discord linked below are the only official sources for this project.
-
-<p align="center"><img src="https://raw.githubusercontent.com/bryanthaboi/gen1recomp/refs/heads/dev/assets/logo/logo.png"></p>
-
-**SUPPORT / ANNOUNCEMENTS / MODS:** [Discord](https://bois.icu)
-
-<p align="center">
-
-<a href="https://www.youtube.com/@bryanthaboi">
-  <img src="https://img.shields.io/badge/YouTube-FF0000?style=for-the-badge&logo=youtube&logoColor=white" alt="YouTube">
-</a>
-<a href="https://www.tiktok.com/@bryanthaboi">
-  <img src="https://img.shields.io/badge/TikTok-000000?style=for-the-badge&logo=tiktok&logoColor=white" alt="TikTok">
-</a>
-<a href="https://x.com/bryanthaboi">
-  <img src="https://img.shields.io/badge/X-000000?style=for-the-badge&logo=x&logoColor=white" alt="X">
-</a>
-<a href="https://bsky.app/profile/bryanthaboi.live">
-  <img src="https://img.shields.io/badge/Bluesky-0285FF?style=for-the-badge&logo=bluesky&logoColor=white" alt="Bluesky">
-</a>
-<a href="https://www.instagram.com/bryanthaboi">
-  <img src="https://img.shields.io/badge/Instagram-E4405F?style=for-the-badge&logo=instagram&logoColor=white" alt="Instagram">
-</a>
-
-</p>
-
-
-<p align="center"> <a href="https://www.polygon.com/pokemon-red-blue-3d-voxel-mod-battle-pixels-gameplay-footage-remake/"> <img src="https://img.shields.io/badge/AS%20SEEN%20ON-POLYGON-ea2e49?style=for-the-badge" alt="As seen on Polygon"> </a> 
-<a href="https://kotaku.com/pokemon-red-blue-recompilation-project-voxel-3d-mod-2000720281"> <img src="https://img.shields.io/badge/AS%20SEEN%20ON-KOTAKU-ea2e49?style=for-the-badge" alt="As seen on KOTAKU"> </a> 
-
-  <a href="https://www.digitalfoundry.net/news/2026/07/pokemon-yellow-voxel-mod-turns-the-original-gameboy-code-into-a-stunning-world">
-    <img src="https://img.shields.io/badge/AS%20SEEN%20ON-DIGITAL%20FOUNDRY-ea2e49?style=for-the-badge" alt="As seen on Digital Foundry">
-  </a>
-  <a href="https://www.androidauthority.com/unofficial-android-port-pokemon-red-blue-yellow-3692724/">
-  <img src="https://img.shields.io/badge/AS%20SEEN%20ON-ANDROID%20AUTHORITY-ea2e49?style=for-the-badge" alt="As seen on Android Authority">
-</a>
-
-<a href="https://www.xda-developers.com/this-amazing-pokemon-red-and-blue-voxel-mod-adds-a-3d-perspective-without-an-emulator/">
-  <img src="https://img.shields.io/badge/AS%20SEEN%20ON-XDA%20DEVELOPERS-ea2e49?style=for-the-badge" alt="As seen on XDA Developers">
-</a>
-</p>
-
-### Watch the latest update video
-
-[![Watch the latest update video](https://img.youtube.com/vi/8IOgqbe4YvA/maxresdefault.jpg)](https://www.youtube.com/watch?v=8IOgqbe4YvA)
+A native LÖVE2D recreation of Pokemon Red. The engine and map behavior are
+hand-written Lua; game data and graphics are decoded from a ROM supplied by
+the player.
 
+SUPPORT AND ANNOUNCEMENTS: [Discord](https://bois.icu)
 
 This project does not include a ROM, emulate the Game Boy, transpile assembly,
-or download a disassembly. A canonical US Poke Red, Blue, or Yellow ROM is the
-only game content input.
+or download a disassembly. A canonical US Pokemon Red ROM is the only game
+content input.
 
 The ROM is verified, used during import, and then released from memory. It is
 not copied into the cache. Later launches load the private generated cache and
-do not ask for the ROM again. Red, Blue, and Yellow can all be imported and
-played side by side.
+do not ask for the ROM again.
 
 ## Quick Start
 
-Open the desktop app. On first boot, choose your legally obtained `.gb` /
-`.gbc` file or drop it onto the window. Import takes a few seconds and the
-game starts automatically.
-
-Only the canonical 1 MiB US Red, Blue, and Yellow ROMs are accepted. The
-importer verifies SHA-1 before creating any game data:
-
-- Red: `ea9bcae617fdf159b045185467ae58b2e4a48b9a`
-- Blue: `d7037c83e1ae5b39bde3c30787637ba1d4c48ce2`
-- Yellow: `cc7d03262ebfaf2f06772c1a480c7d9d5f4a38e1`
+Open the desktop app. On first boot, choose your legally obtained `.gb` file
+or drop it onto the window. Import takes a few seconds and the game starts
+automatically.
 
+Only the canonical 1 MiB US Red ROM is accepted. The importer verifies SHA-1
+`ea9bcae617fdf159b045185467ae58b2e4a48b9a` before creating any game data.
 The packaged app contains neither a ROM nor pre-extracted game data. Music,
 sound effects, and cries are synthesized while the game runs from compact
 audio channel programs copied out of the verified ROM.
 
-### A note on Windows Defender warnings
-
-Windows Defender sometimes flags the Windows build with a generic
-machine-learning detection such as `Trojan:Win32/Wacatac!ml` (#621). This is
-a known false positive: the exe is the official LÖVE runtime with the game
-archive appended (the standard way LÖVE games ship), and Defender's
-heuristics distrust unsigned executables with appended data. Every release
-publishes SHA-256 checksums (`sha256sums.txt`) so you can verify your
-download, and you can confirm a flagged file yourself on
-[VirusTotal](https://www.virustotal.com), where these builds come back clean
-on every engine except Defender's heuristic. False positives are reported to
-Microsoft as they come up.
-
 ## Controls
 
-
-| Action | Keyboard          | Controller         |
-| ------ | ----------------- | ------------------ |
-| Move   | Arrow keys / WASD | D-pad / left stick |
-| A      | Z / Enter / Space | A                  |
-| B      | X / Backspace     | B                  |
-| Start  | Escape            | Start              |
-| Select | Tab / Shift       | Back / Select      |
-
-
-Rebind any of these in-game under **OPTIONS → CONTROLS**. Controllers are
-supported out of the box.
-
-### Hotkeys
-
-
-| Key       | What it does                                         |
-| --------- | ---------------------------------------------------- |
-| `-` / `=` | Zoom out / in (overworld; also mouse wheel)          |
-| `1`       | Cycle GAME SPEED up (controller: R2 faster, L2 slower) |
-| `2`       | Cycle COLORS                                         |
-| `3`       | Cycle TILT (free-roam overworld)                     |
-| `4`       | Cycle ZOOM through every level (free-roam overworld) |
-| `5`       | Cycle GBC FX                                         |
-| `F1`      | Save                                                 |
-| `F2`      | Load                                                 |
-| `F10`     | Open / close the mod manager                         |
-
-
-COLORS, TILT, ZOOM, GBC FX, GAME SPEED, and VOID FILL are also in the
-Options menu and persist in `options.lua`.
-
-### Low-end devices
-
-**OPTIONS → PERFORMANCE** scales the port's optional extras for weaker
-hardware: **HIGH** (everything on), **BALANCED** (no 3D tilt or GBC FX),
-**LOW** (also no survey zoom, FPS capped), or **AUTO** — the default, which
-picks a tier from your device (ARM handhelds → LOW, phones → BALANCED,
-normal desktops → HIGH, unchanged). It only scales presentation; the
-fixed-step game logic is identical on every tier, and a lower tier hides
-your tilt/zoom/GBC-FX preferences without forgetting them. Details in
-[docs/new-features.md](docs/new-features.md#performance-tier-low-end-devices).
-
-### Rulesets
-
-**OPTIONS → RULESET** picks which set of Gen 1 battle behaviors to run.
-Both rulesets share the same damage formulas; they differ only in whether
-the original's quirks are kept. The setting persists in `options.lua`, and
-mods can register their own.
-
-`gen1_faithful` is the default and reproduces the original cartridge,
-famous bugs included:
-
-| Rule                        | Behavior                                              |
-| --------------------------- | ----------------------------------------------------- |
-| `oneIn256Miss`              | A 100%-accurate move still misses on a roll of 255     |
-| `critUsesBaseSpeed`         | Crit rate reads base speed, not the current stat       |
-| `critIgnoresStages`         | Crit rate ignores stat stages                          |
-| `focusEnergyBug`            | FOCUS ENERGY quarters the crit rate instead of x4      |
-| `enemyUnlimitedPP`          | Enemies never spend PP, so they never Struggle         |
-| `hyperBeamSkipRechargeOnKO` | HYPER BEAM skips its recharge when the target faints   |
-| `randMin` / `randMax`       | Damage random factor 217-255                           |
-
-`modern_clean` keeps the formulas but removes the notorious quirks:
-
-| Rule                        | Behavior                                              |
-| --------------------------- | ----------------------------------------------------- |
-| `oneIn256Miss`              | Off: a 100%-accurate move always hits                  |
-| `critUsesBaseSpeed`         | Unchanged: crit rate still reads base speed            |
-| `critIgnoresStages`         | Off: stat stages count toward the crit rate            |
-| `focusEnergyBug`            | Off: FOCUS ENERGY raises the crit rate as intended     |
-| `enemyUnlimitedPP`          | Off: enemies deplete PP and Struggle when empty        |
-| `hyperBeamSkipRechargeOnKO` | Off: HYPER BEAM always recharges, like Gen 2+          |
-| `randMin` / `randMax`       | Damage random factor 217-255, same as faithful         |
+arrow keys or WASD move; Z, Enter, or Space is A; X or Backspace is
+B; Escape opens START. F1 saves and F2 loads. Controllers are supported.
 
 ## Running From Source
 
-Requires LÖVE 11.x. Place a Red, Blue, or Yellow ROM in the project folder and
-double-click `Play-Mac.command` or `Play-Windows.bat`, or run:
+Requires LÖVE 11.x. Place the ROM in the project folder and double-click
+`Play-Mac.command` or `Play-Windows.bat`, or run:
 
 ```sh
-scripts/setup.sh --rom "/path/to/Poke Red.gb"   # or Blue.gb / Yellow.gbc
+scripts/setup.sh --rom "/path/to/Pokemon Red.gb"
 scripts/run.sh
 ```
 
 then `love .` for later launches. Windows PowerShell scripts, the optional
 developer data build, test suites, and cache management are covered in
-[Developer Setup](https://github.com/bryanthaboi/gen1recomp/wiki/Guide-Developer-Setup).
+[Developer Setup](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Guide-Developer-Setup).
 
 ## Portable Mode
 
@@ -188,7 +51,7 @@ By default the game keeps your save, options, and the private ROM-derived
 data cache in your OS's normal per-user app data folder. To keep everything
 next to the game instead (handy for a USB stick or portable drive you carry
 between computers), drop an empty file named `portable.txt` next to the app
-(next to `gen1recomp.app`/`.exe`, or next to `main.lua`/`conf.lua` when
+(next to `PokemonRed.app`/`.exe`, or next to `main.lua`/`conf.lua` when
 running from source), then launch the game. Portable mode is desktop-only
 (Windows, Linux, macOS); it has no effect on Android or iOS, where the app
 runs from a read-only package.
@@ -196,38 +59,14 @@ runs from a read-only package.
 With `portable.txt` present:
 
 - `save.lua`, `save.lua.bak`, and `options.lua` are read from and written to
-that same folder instead of the OS save directory.
+  that same folder instead of the OS save directory.
 - A ROM import writes the generated `data/generated` and `assets/generated`
-cache straight into that folder too (nothing is left in the OS save
-directory), so a later launch reuses it without asking for the ROM again
-even on a different computer, as long as the same folder comes along.
+  cache straight into that folder too (nothing is left in the OS save
+  directory), so a later launch reuses it without asking for the ROM again
+  even on a different computer, as long as the same folder comes along.
 - Deleting `portable.txt` switches back to the normal OS save directory; nothing
-already written to either location is touched automatically, so copy files
-over yourself if you want to carry existing progress across the switch.
-
-## iOS
-
-Every release ships `gen1recomp-*-ios.ipa`. Sideload it with AltStore
-(Windows or Mac) — see [docs/ios-sideload.md](docs/ios-sideload.md). To
-build and install from source on a Mac instead, see
-[docs/ios-install.md](docs/ios-install.md).
-
-<div>
-    <a href="https://intradeus.github.io/http-protocol-redirector?r=sidestore://source?url=https://github.com/bryanthaboi/gen1recomp/raw/refs/heads/main/mobile/ios/app-repo.json"><img src="./.github/resources/sidestore-badge.png" alt="Add to SideStore" height="60"></a>
-    &nbsp;
-    <a href="https://intradeus.github.io/http-protocol-redirector?r=feather://source/https://github.com/bryanthaboi/gen1recomp/raw/refs/heads/main/mobile/ios/app-repo.json"><img src="./.github/resources/feather-badge.png" alt="Add to Feather" height="60"></a>
-    &nbsp;
-    <a href="https://intradeus.github.io/http-protocol-redirector?r=altstore://source?url=https://github.com/bryanthaboi/gen1recomp/raw/refs/heads/main/mobile/ios/app-repo.json"><img src="./.github/resources/altstore-badge.png" alt="Add to AltStore" height="60"></a>
-    &nbsp;
-    <a href="https://github.com/bryanthaboi/gen1recomp/releases/latest"><img src="./.github/resources/github-badge.png" alt="Download from GitHub" height="60"></a>
-</div>
-
-## Handhelds
-
-A PortMaster-style port for the **Anbernic RG34XXSP** on Stock OS 64-bit MOD
-ships with every release as `gen1recomp-*-rg34xxsp-stockos64-mod.zip`.
-Install steps, controls, and troubleshooting live in
-[docs/anbernic-rg34xxsp.md](docs/anbernic-rg34xxsp.md).
+  already written to either location is touched automatically, so copy files
+  over yourself if you want to carry existing progress across the switch.
 
 ## Modding
 
@@ -235,40 +74,33 @@ The game ships a native mod platform: content registries, events and hooks,
 per-mod saves and options, and an in-game manager. The full modding book —
 getting started, a twelve-rung tutorial ladder, a cookbook, and the generated
 reference — lives on the
-[project wiki](https://github.com/bryanthaboi/gen1recomp/wiki).
+[project wiki](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki).
 
-Shipped example mods, one per kind of author, live in `[mods/](mods/)`.
-
-Maps can be edited in our own build of [Tiled](https://www.mapeditor.org),
-[bryanthaboi/tiled_gen1recomp](https://github.com/bryanthaboi/tiled_gen1recomp/releases),
-and exported back out as a mod; see
-[docs/tiled-map-editing.md](docs/tiled-map-editing.md).
+Shipped example mods, one per kind of author, live in [`mods/`](mods/).
 
 ## Bugs and Ideas
 
 Found a bug? A warp dropping you somewhere it shouldn't, a battle doing math
 that looks wrong, text in the wrong box, anything that does not match the
 original game.
-[Open a bug report](https://github.com/bryanthaboi/gen1recomp/issues/new?template=bug_report.yml).
+[Open a bug report](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/issues/new?template=bug_report.yml).
 Attach a screenshot if you can. It saves a lot of back and forth, and if you
 can't get one, the form asks you to describe what you saw instead.
 
 Thought of a feature that could be good, or a way to improve one that already
 exists?
-[Open a feature request](https://github.com/bryanthaboi/gen1recomp/issues/new?template=feature_request.yml).
+[Open a feature request](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/issues/new?template=feature_request.yml).
 Say what you want, why it is worth doing, and how you picture it working. A
 request with real detail is one that can actually get built.
 
 ## More
 
-- [Link play](https://github.com/bryanthaboi/gen1recomp/wiki/Guide-Link-Play)
-— START > LINK connects two copies directly over UDP.
-- [Save editor](https://github.com/bryanthaboi/gen1recomp/wiki/Guide-Save-Editor)
-— edit party, boxes, items, events, and Pokédex flags outside the game.
+- [Link play](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Guide-Link-Play)
+  — START > LINK connects two copies directly over UDP.
+- [Save editor](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Guide-Save-Editor)
+  — edit party, boxes, items, events, and Pokédex flags outside the game.
 - `docs/architecture.md` — runtime details;
-`docs/behavior-porting-notes.md` — formula provenance.
-
-
+  `docs/behavior-porting-notes.md` — formula provenance.
 
 ## Special Thanks
 
@@ -276,4 +108,6 @@ This project would not be possible without [pret](https://github.com/pret) >
 the pret band of decompiling maniacs > and their
 [pokered](https://github.com/pret/pokered) disassembly.
 
-<p align="center"><a href="https://boisclub.games"><img src="https://raw.githubusercontent.com/bryanthaboi/gen1recomp/refs/heads/dev/assets/logo/bcg.png"></a></p>
+## Wanna Support My Work?
+[![Buy Me a Coffee](https://img.shields.io/badge/Buy_Me_a_Coffee-FFDD00?style=for-the-badge&logo=buy-me-a-coffee&logoColor=black)](https://buymeacoffee.com/bryanthaboi)
+

assets/touch/README.md

@@ -1,9 +0,0 @@
-# On-screen touch control art
-
-From Xelu's "Free Controller & Keyboard Prompts" pack (Nicolae Berbece /
-Those Awesome Guys), public domain under CC0:
-https://thoseawesomeguys.com/prompts/
-
-256px Nintendo Switch set, renamed for src/core/TouchControls.lua:
-d-pad (neutral + per-direction highlight), A, B, plus (START) and
-minus (SELECT).

build-rg34xxsp.sh

@@ -1,333 +0,0 @@
-#!/usr/bin/env bash
-# Build a PortMaster-style aarch64 port of gen1recomp for Anbernic RG34XXSP
-# on Stock OS 64-bit MOD (H700; cbepx-me StockOS MOD / official V1.0.6 base
-# + PortMaster).
-#
-# The stock Anbernic firmware resolves ports relative to the launch script
-# (roms/PORTS/...), not PortMaster's /$directory/ports/... path. This pack
-# uses SHDIR-relative paths and bundles the LÖVE 11.5 aarch64 runtime so the
-# device does not need a separate love_11.5 runtime download on first launch.
-#
-# Usage:
-#   ./build-rg34xxsp.sh [--version X.Y.Z]
-#
-# Output:
-#   dist/rg34xxsp/gen1recomp-rg34xxsp-stockos64-mod.zip
-#
-# Install on device:
-#   1. Flash / run Stock OS 64-bit MOD with PortMaster installed.
-#   2. Unzip into the SD card's roms/PORTS/ folder so you have:
-#        roms/PORTS/Gen1recomp.sh
-#        roms/PORTS/gen1recomp/...
-#   3. Copy a legal US Red or Blue .gb into roms/PORTS/gen1recomp/lovegame/
-#   4. Launch "Gen1recomp" from the Ports list; press Choose ROM (scans that
-#      folder when zenity is missing).
-
-set -euo pipefail
-
-ROOT="$(cd "$(dirname "$0")" && pwd)"
-HERE="$ROOT/.bazinga"
-CACHE="$HERE/cache/rg34xxsp"
-WORK="$HERE/work/rg34xxsp"
-DIST="$ROOT/dist/rg34xxsp"
-
-APP_NAME="gen1recomp"
-# Artifact suffix matches the CFW this port targets (Anbernic H700 Stock OS
-# 64-bit MOD for RG34XXSP). Release uploads stage it as
-# gen1recomp-<ver>-rg34xxsp-stockos64-mod.zip.
-ARTIFACT_SUFFIX="rg34xxsp-stockos64-mod"
-PORT_DIR_NAME="gen1recomp"
-LAUNCHER_NAME="Gen1recomp.sh"
-LOVE_VERSION="11.5"
-VERSION="$(git -C "$ROOT" rev-parse --short HEAD 2>/dev/null || echo dev)"
-
-# Official PortMaster LÖVE 11.5 aarch64 runtime (small love stub + liblove).
-PM_RUNTIME_BASE="https://raw.githubusercontent.com/PortsMaster/PortMaster-GUI/main/PortMaster/runtimes/love_${LOVE_VERSION}"
-
-say()  { printf '\033[1;32m==>\033[0m %s\n' "$*"; }
-warn() { printf '\033[1;33mwarn:\033[0m %s\n' "$*" >&2; }
-fail() { printf '\033[1;31merror:\033[0m %s\n' "$*" >&2; exit 1; }
-
-while [ $# -gt 0 ]; do
-  case "$1" in
-    --version) VERSION="$2"; shift ;;
-    -h|--help)
-      sed -n '2,24p' "$0"
-      exit 0
-      ;;
-    *) fail "unknown argument: $1" ;;
-  esac
-  shift
-done
-
-command -v curl >/dev/null || fail "curl is required"
-command -v zip  >/dev/null || fail "zip is required"
-command -v unzip >/dev/null || fail "unzip is required"
-
-mkdir -p "$CACHE" "$WORK" "$DIST"
-
-download() {
-  local url="$1" dest="$2"
-  if [ -f "$dest" ] && [ -s "$dest" ]; then
-    return 0
-  fi
-  say "downloading $(basename "$dest")"
-  curl -fL --progress-bar "$url" -o "$dest.tmp" \
-    || fail "download failed: $url"
-  mv "$dest.tmp" "$dest"
-}
-
-# --------------------------------------------------------------- game tree
-# Unpacked directory (not a .love zip) so the player can drop a .gb next to
-# main.lua and RomImporter can scan it without zenity/kdialog.
-say "staging lovegame/"
-GAME_SRC="$WORK/lovegame"
-rm -rf "$GAME_SRC"
-mkdir -p "$GAME_SRC"
-
-# Same payload as scripts/build.sh's game.love — never ship ROM-derived cache.
-# tools/save-editor is part of that payload: the launcher's Edit button on a
-# save row opens it in-process (main.lua).
-(cd "$ROOT" && zip -q -9 -r "$WORK/game-payload.zip" \
-  main.lua conf.lua src libs data assets tools/save-editor \
-  tools/rom_manifest.json tools/rom_manifest_blue.json \
-  -x '*.DS_Store' 'data/generated/*' 'assets/generated/*')
-if unzip -Z1 "$WORK/game-payload.zip" \
-    | grep -Eq '^(data|assets)/generated/[^/]+|^(data|assets)/generated/.+/'; then
-  fail "payload unexpectedly contains generated ROM data"
-fi
-unzip -q "$WORK/game-payload.zip" -d "$GAME_SRC"
-rm -f "$WORK/game-payload.zip"
-
-# Stamp release version into the staged tree only (never the working tree).
-if printf '%s' "$VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$'; then
-  say "stamping engine version $VERSION"
-  sed -E "s/(engine[[:space:]]*=[[:space:]]*\")[^\"]*(\")/\1$VERSION\2/" \
-    "$ROOT/src/core/Version.lua" > "$GAME_SRC/src/core/Version.lua"
-  version_re="$(printf '%s' "$VERSION" | sed 's/\./\\./g')"
-  grep -Eq "engine[[:space:]]*=[[:space:]]*\"$version_re\"" \
-    "$GAME_SRC/src/core/Version.lua" \
-    || fail "version stamp failed"
-else
-  say "version '$VERSION' is not X.Y.Z — shipping default engine (no stamp)"
-fi
-
-# Portable marker: saves + ROM cache live next to the game on the SD card.
-: > "$GAME_SRC/portable.txt"
-
-# --------------------------------------------------------------- love runtime
-say "fetching LÖVE $LOVE_VERSION aarch64 runtime"
-LOVE_BIN="$CACHE/love.aarch64"
-LOVE_LIB="$CACHE/liblove-11.5.so"
-LUAJIT_LIB="$CACHE/libluajit-5.1.so.2"
-MODPLUG_LIB="$CACHE/libmodplug.so.1"
-OGG_LIB="$CACHE/libogg.so.0"
-
-download "$PM_RUNTIME_BASE/love.aarch64" "$LOVE_BIN"
-download "$PM_RUNTIME_BASE/libs.aarch64/liblove-11.5.so" "$LOVE_LIB"
-download "$PM_RUNTIME_BASE/libs.aarch64/libluajit-5.1.so.2" "$LUAJIT_LIB"
-download "$PM_RUNTIME_BASE/libs.aarch64/libmodplug.so.1" "$MODPLUG_LIB"
-download "$PM_RUNTIME_BASE/libs.aarch64/libogg.so.0" "$OGG_LIB"
-
-# Sanity: love stub must be an aarch64 ELF.
-file "$LOVE_BIN" | grep -qi 'aarch64\|ARM aarch64' \
-  || fail "love.aarch64 does not look like an aarch64 ELF (got: $(file "$LOVE_BIN"))"
-
-# --------------------------------------------------------------- port tree
-say "assembling port package"
-PORT_ROOT="$WORK/port"
-rm -rf "$PORT_ROOT"
-mkdir -p "$PORT_ROOT/$PORT_DIR_NAME/bin" \
-         "$PORT_ROOT/$PORT_DIR_NAME/libs.aarch64" \
-         "$PORT_ROOT/$PORT_DIR_NAME/licenses" \
-         "$PORT_ROOT/$PORT_DIR_NAME/conf"
-
-cp -R "$GAME_SRC" "$PORT_ROOT/$PORT_DIR_NAME/lovegame"
-cp "$LOVE_BIN" "$PORT_ROOT/$PORT_DIR_NAME/bin/love.aarch64"
-chmod +x "$PORT_ROOT/$PORT_DIR_NAME/bin/love.aarch64"
-cp "$LOVE_LIB" "$LUAJIT_LIB" "$MODPLUG_LIB" "$OGG_LIB" \
-  "$PORT_ROOT/$PORT_DIR_NAME/libs.aarch64/"
-
-# Drop a short license pointer for the bundled LÖVE bits.
-cat > "$PORT_ROOT/$PORT_DIR_NAME/licenses/LICENSE.love2d.txt" <<'EOF'
-This port bundles the LÖVE 11.5 aarch64 runtime from PortMaster
-(https://github.com/PortsMaster/PortMaster-GUI). LÖVE is zlib-licensed;
-see https://love2d.org/ for full terms.
-EOF
-
-# --------------------------------------------------------------- launcher
-# Stock OS fix: resolve GAMEDIR from this script's directory (SHDIR), not
-# PortMaster's $directory variable — Anbernic uses roms/PORTS with different
-# casing and mount points (mmc / sdcard / TF1 / TF2).
-cat > "$PORT_ROOT/$LAUNCHER_NAME" <<'EOF'
-#!/bin/bash
-# gen1recomp — Anbernic RG34XXSP stock OS / PortMaster launcher
-# Uses SHDIR-relative paths so stock firmware finds the game folder.
-
-export HOME="${HOME:-/root}"
-XDG_DATA_HOME="${XDG_DATA_HOME:-$HOME/.local/share}"
-
-if [ -d "/opt/system/Tools/PortMaster/" ]; then
-  controlfolder="/opt/system/Tools/PortMaster"
-elif [ -d "/opt/tools/PortMaster/" ]; then
-  controlfolder="/opt/tools/PortMaster"
-elif [ -d "$XDG_DATA_HOME/PortMaster/" ]; then
-  controlfolder="$XDG_DATA_HOME/PortMaster"
-elif [ -d "/mnt/mmc/Roms/PORTS/PortMaster" ]; then
-  controlfolder="/mnt/mmc/Roms/PORTS/PortMaster"
-elif [ -d "/mnt/sdcard/Roms/PORTS/PortMaster" ]; then
-  controlfolder="/mnt/sdcard/Roms/PORTS/PortMaster"
-elif [ -d "/roms/ports/PortMaster" ]; then
-  controlfolder="/roms/ports/PortMaster"
-else
-  controlfolder="/roms/PORTS/PortMaster"
-fi
-
-SHDIR="$(cd "$(dirname "$0")" && pwd)"
-# shellcheck disable=SC1090
-source "$controlfolder/control.txt"
-get_controls
-[ -f "${controlfolder}/mod_${CFW_NAME}.txt" ] && source "${controlfolder}/mod_${CFW_NAME}.txt"
-
-GAMEDIR="$SHDIR/gen1recomp"
-CONFDIR="$GAMEDIR/conf"
-mkdir -p "$CONFDIR"
-
-cd "$GAMEDIR" || exit 1
-> "$GAMEDIR/log.txt" && exec > >(tee "$GAMEDIR/log.txt") 2>&1
-
-export XDG_DATA_HOME="$CONFDIR"
-export XDG_CONFIG_HOME="$CONFDIR"
-export LD_LIBRARY_PATH="$GAMEDIR/libs.aarch64:${LD_LIBRARY_PATH:-}"
-export SDL_GAMECONTROLLERCONFIG="${sdl_controllerconfig:-}"
-# Mali / H700: prefer GLES where available
-export LOVE_GRAPHICS_USE_OPENGLES="${LOVE_GRAPHICS_USE_OPENGLES:-1}"
-# Same GPU class as a phone, but getOS() here says "Linux", so the Android
-# gate (issue #136) would not fire on its own: refuse GBC FX explicitly.
-# Hides the OPTIONS row, pins the level to OFF, and heals a level already
-# persisted in options.lua.
-export POKEPORT_GBCFX="${POKEPORT_GBCFX:-0}"
-
-$ESUDO chmod a+x ./bin/love.aarch64 2>/dev/null || chmod a+x ./bin/love.aarch64
-$ESUDO chmod 666 /dev/uinput 2>/dev/null || true
-
-if [ -n "${GPTOKEYB:-}" ]; then
-  $GPTOKEYB "love.aarch64" &
-fi
-if type pm_platform_helper >/dev/null 2>&1; then
-  pm_platform_helper "$GAMEDIR/bin/love.aarch64"
-fi
-
-./bin/love.aarch64 "$GAMEDIR/lovegame"
-
-if type pm_finish >/dev/null 2>&1; then
-  pm_finish
-else
-  if [ -n "${ESUDO:-}" ]; then
-    $ESUDO kill -9 $(pidof gptokeyb) 2>/dev/null || true
-  else
-    kill -9 $(pidof gptokeyb) 2>/dev/null || true
-  fi
-fi
-EOF
-chmod +x "$PORT_ROOT/$LAUNCHER_NAME"
-
-# --------------------------------------------------------------- metadata
-cat > "$PORT_ROOT/port.json" <<EOF
-{
-  "version": 2,
-  "name": "gen1recomp.zip",
-  "items": [
-    "$LAUNCHER_NAME",
-    "$PORT_DIR_NAME"
-  ],
-  "items_opt": null,
-  "attr": {
-    "title": "gen1recomp",
-    "desc": "Native LÖVE2D recreation of Pokemon Red and Blue. Supply your own legal US Red or Blue ROM.",
-    "inst": "Requires Anbernic RG34XXSP Stock OS 64-bit MOD with PortMaster. Copy a canonical US Red or Blue .gb into gen1recomp/lovegame/, then launch and press Choose ROM.",
-    "genres": ["adventure", "rpg"],
-    "porter": ["gen1recomp"],
-    "image": {},
-    "rtr": true,
-    "runtime": null,
-    "reqs": [],
-    "arch": ["aarch64"]
-  }
-}
-EOF
-
-cat > "$PORT_ROOT/gameinfo.xml" <<EOF
-<?xml version="1.0" encoding="utf-8"?>
-<gameList>
-  <game>
-    <path>./$LAUNCHER_NAME</path>
-    <name>gen1recomp</name>
-    <desc>Native LÖVE2D recreation of Pokemon Red and Blue. Requires your own legal US Red or Blue ROM.</desc>
-    <releasedate>20250101T000000</releasedate>
-    <developer>the bois club</developer>
-    <publisher>the bois club</publisher>
-    <genre>RPG</genre>
-  </game>
-</gameList>
-EOF
-
-cat > "$PORT_ROOT/README.md" <<'EOF'
-## gen1recomp (RG34XXSP / Stock OS 64-bit MOD)
-
-Native LÖVE 11.5 port of gen1recomp for Anbernic RG34XXSP on
-**Stock OS 64-bit MOD** (H700, PortMaster).
-
-### Install
-
-1. Use **Stock OS 64-bit MOD** with PortMaster installed (TF1).
-2. Unzip so `Gen1recomp.sh` and the `gen1recomp/` folder sit in `roms/PORTS/`.
-3. Copy a legal US Pokemon Red or Blue `.gb` into `gen1recomp/lovegame/`.
-4. Refresh Ports / restart EmulationStation and launch **Gen1recomp**.
-
-### Controls (launcher)
-
-| Input | Action |
-|--|--|
-| D-pad / left stick | Move cursor |
-| A | Click |
-| L1 / R1 | Switch tabs |
-| Right stick | Scroll lists |
-| Start / Select | Play or Choose ROM |
-
-In-game controls use the normal PortMaster / SDL pad map (rebind under OPTIONS → CONTROLS).
-
-### Display options
-
-GBC FX is disabled on this device (the H700's Mali GPU compiles that present
-pass and then shows a black frame), so the OPTIONS row is hidden. COLORS,
-TILT, ZOOM, VOID FILL and MAX FPS all work. To try it anyway, launch with
-`POKEPORT_GBCFX=1`.
-
-### First run
-
-Stock OS has no zenity file picker. Put the `.gb` in `lovegame/`, then press
-**Choose ROM** — the game scans that folder. After import, the ROM-derived
-cache and saves stay beside the game (`portable.txt`).
-
-Canonical SHA-1 (1 MiB US carts only):
-
-- Red: `ea9bcae617fdf159b045185467ae58b2e4a48b9a`
-- Blue: `d7037c83e1ae5b39bde3c30787637ba1d4c48ce2`
-
-### Thanks
-
-LÖVE runtime binaries from [PortMaster](https://portmaster.games/).
-Stock OS 64-bit MOD: [cbepx-me](https://github.com/cbepx-me/Anbernic-H700-RG-xx-StockOS-Modification).
-EOF
-
-# --------------------------------------------------------------- zip
-ZIP_OUT="$DIST/$APP_NAME-$ARTIFACT_SUFFIX.zip"
-rm -f "$ZIP_OUT" "$DIST/$APP_NAME-rg34xxsp.zip"
-say "packing $ZIP_OUT"
-(cd "$PORT_ROOT" && zip -q -9 -r "$ZIP_OUT" \
-  "$LAUNCHER_NAME" "$PORT_DIR_NAME" port.json gameinfo.xml README.md)
-
-say "done."
-say "artifact: $ZIP_OUT ($(du -h "$ZIP_OUT" | cut -f1))"
-say "copy onto the RG34XXSP SD card under roms/PORTS/ (Stock OS 64-bit MOD), then drop your .gb into gen1recomp/lovegame/"

conf.lua

@@ -1,9 +1,4 @@
 function love.conf(t)
-  -- PhysFS ignores symlinks unless told otherwise, so a mod dev-linked into
-  -- mods/ (ln -s, matching the mklink /J workflow on Windows) is invisible
-  -- to love.filesystem.getDirectoryItems without this.
-  love.filesystem.setSymlinksEnabled(true)
-
   local editor = os.getenv("POKEPORT_EDITOR") == "1"
   local developer = os.getenv("POKEPORT_DEV") == "1"
   if arg then
@@ -18,12 +13,7 @@ function love.conf(t)
   _G.POKEPORT_DEV_MODE = developer
 
   if editor then
-    -- Same identity as the game, deliberately: the editor edits the game's
-    -- saves and reads the game's ROM cache, both of which live under this
-    -- folder.  A private editor identity would point love.filesystem at an
-    -- empty directory in a packaged build, so `--editor` could not find
-    -- data/generated at all (SaveIO.defaultPath already assumed this name).
-    t.identity = os.getenv("POKEPORT_IDENTITY") or "pokemon-love2d"
+    t.identity = os.getenv("POKEPORT_IDENTITY") or "pokemon-love2d-editor"
     t.window.title = "Pokemon Save Editor"
     t.window.width = 1280
     t.window.height = 800
@@ -40,16 +30,8 @@ function love.conf(t)
     -- starting size, not the game's resolution.
     t.window.width = 1024
     t.window.height = 768
-    -- Floor for the resizable desktop window.  The launcher's single-column
-    -- layout is laid out against ~420 logical px of content, and the game
-    -- canvas letterboxes fine below that, so this only stops a drag that would
-    -- squeeze the cards past the point where their buttons still read.  Kept
-    -- well under the smallest supported desktop display; mobile ignores it
-    -- (fullscreen), so the handheld ports are unaffected.
-    t.window.minwidth = 480
-    t.window.minheight = 360
   end
-  t.version = love._os == "iOS" and "12.0" or "11.5"
+  t.version = "11.5"
   t.window.vsync = 1
   t.modules.joystick = true
   t.modules.physics = false
@@ -65,12 +47,8 @@ function love.conf(t)
     -- freely to portrait or landscape), otherwise locked to the window's w/h
     -- aspect.  So a non-resizable tall window forced portrait; resizable lets
     -- the game follow the device.  The renderer letterboxes the 160x144
-    -- viewport into whatever size results, and the on-screen touch controls
-    -- re-lay themselves out from the new window size, so both orientations
-    -- just work.  FULL_SENSOR ignores the device's rotation lock, so
-    -- GameActivity.setOrientationBis remaps it to FULL_USER after SDL has
-    -- run: same orientations allowed, but auto-rotate being off now wins.
-    -- iOS follows the Info.plist orientations
+    -- viewport into whatever size results, and touch input is gesture-based,
+    -- so both orientations just work.  iOS follows the Info.plist orientations
     -- (see mobile/ios/overlays/love-ios.plist, now portrait + landscape).
     t.window.resizable = true
     -- Starting size is a tall portrait hint; the OS resizes to the real
@@ -86,14 +64,6 @@ function love.conf(t)
     -- player to copy their ROM there instead of needing a native file
     -- picker (LOVE 11.5 on Android has none -- see src/import/RomImporter.lua).
     t.externalstorage = osName == "Android"
-    -- LOVE 11.x exposes the phone's accelerometer as a 3-axis joystick by
-    -- default.  Gravity keeps one axis pinned near +/-1.0 whenever the phone
-    -- is held upright, so it streams past-deadzone joystickaxis events that
-    -- both hid the touch overlay every instant (it reads as "a controller is
-    -- in use") and, via the generic-joystick axis mapping (#459), walked the
-    -- player around by tilt.  Nothing in the game reads the accelerometer,
-    -- so drop the device entirely (#468).
-    t.accelerometerjoystick = false
   else
     t.window.resizable = true
   end

data/palettes_gbc.lua

@@ -1683,172 +1683,158 @@ return {
       { 0, 0, 0 },
     },
   },
-  -- Species -> palette NAME, taken from pokered-gbc data/pokemon/palettes.asm
-  -- ELSE branch -- the one that is NOT gated on GEN_2_GRAPHICS.
-  --
-  -- That file has two tables.  The IF GEN_2_GRAPHICS branch assigns a
-  -- PER-SPECIES palette (PAL_BULBASAUR, PAL_SQUIRTLE, ...) authored for Gen 2
-  -- sprite art; the ELSE branch keeps Gen 1's own assignments (GREENMON,
-  -- CYANMON, ...).  This port extracts Gen 1 pics from the ROM, so the Gen 1
-  -- branch is the matching one.  The per-species table was imported here by
-  -- mistake, which pointed every mon at colours shaded for different art:
-  -- Bulbasaur wore PAL_BULBASAUR's red-orange over a sprite that has no red
-  -- on it, and Squirtle wore PAL_SQUIRTLE's shell brown on his head.
-  --
-  -- The palette VALUES below are still pokered-gbc's, so ADVANCED keeps its
-  -- richer colours -- only which palette each species points at changed.
   pokemon = {
-    ABRA = "YELLOWMON",
-    AERODACTYL = "GRAYMON",
-    ALAKAZAM = "YELLOWMON",
-    ARBOK = "PURPLEMON",
-    ARCANINE = "REDMON",
-    ARTICUNO = "BLUEMON",
-    BEEDRILL = "YELLOWMON",
-    BELLSPROUT = "GREENMON",
-    BLASTOISE = "CYANMON",
-    BULBASAUR = "GREENMON",
-    BUTTERFREE = "CYANMON",
-    CATERPIE = "GREENMON",
-    CHANSEY = "PINKMON",
-    CHARIZARD = "REDMON",
-    CHARMANDER = "REDMON",
-    CHARMELEON = "REDMON",
-    CLEFABLE = "PINKMON",
-    CLEFAIRY = "PINKMON",
-    CLOYSTER = "GRAYMON",
-    CUBONE = "GRAYMON",
-    DEWGONG = "BLUEMON",
-    DIGLETT = "BROWNMON",
-    DITTO = "GRAYMON",
-    DODRIO = "BROWNMON",
-    DODUO = "BROWNMON",
-    DRAGONAIR = "BLUEMON",
-    DRAGONITE = "BROWNMON",
-    DRATINI = "GRAYMON",
-    DROWZEE = "YELLOWMON",
-    DUGTRIO = "BROWNMON",
-    EEVEE = "GRAYMON",
-    EKANS = "PURPLEMON",
-    ELECTABUZZ = "YELLOWMON",
-    ELECTRODE = "YELLOWMON",
-    EXEGGCUTE = "PINKMON",
-    EXEGGUTOR = "GREENMON",
-    FARFETCHD = "BROWNMON",
-    FEAROW = "BROWNMON",
-    FLAREON = "REDMON",
-    GASTLY = "PURPLEMON",
-    GENGAR = "PURPLEMON",
-    GEODUDE = "GRAYMON",
-    GLOOM = "REDMON",
-    GOLBAT = "BLUEMON",
-    GOLDEEN = "REDMON",
-    GOLDUCK = "CYANMON",
-    GOLEM = "GRAYMON",
-    GRAVELER = "GRAYMON",
-    GRIMER = "PURPLEMON",
-    GROWLITHE = "BROWNMON",
-    GYARADOS = "BLUEMON",
-    HAUNTER = "PURPLEMON",
-    HITMONCHAN = "BROWNMON",
-    HITMONLEE = "BROWNMON",
-    HORSEA = "CYANMON",
-    HYPNO = "YELLOWMON",
-    IVYSAUR = "GREENMON",
-    JIGGLYPUFF = "PINKMON",
-    JOLTEON = "YELLOWMON",
-    JYNX = "MEWMON",
-    KABUTO = "BROWNMON",
-    KABUTOPS = "BROWNMON",
-    KADABRA = "YELLOWMON",
-    KAKUNA = "YELLOWMON",
-    KANGASKHAN = "BROWNMON",
-    KINGLER = "REDMON",
-    KOFFING = "PURPLEMON",
-    KRABBY = "REDMON",
-    LAPRAS = "CYANMON",
-    LICKITUNG = "PINKMON",
-    MACHAMP = "GRAYMON",
-    MACHOKE = "GRAYMON",
-    MACHOP = "GRAYMON",
-    MAGIKARP = "REDMON",
-    MAGMAR = "REDMON",
-    MAGNEMITE = "GRAYMON",
-    MAGNETON = "GRAYMON",
-    MANKEY = "BROWNMON",
-    MAROWAK = "GRAYMON",
-    MEOWTH = "YELLOWMON",
-    METAPOD = "GREENMON",
-    MEW = "MEWMON",
-    MEWTWO = "MEWMON",
-    MOLTRES = "REDMON",
-    MR_MIME = "PINKMON",
-    MUK = "PURPLEMON",
-    NIDOKING = "PURPLEMON",
-    NIDOQUEEN = "BLUEMON",
-    NIDORAN_F = "BLUEMON",
-    NIDORAN_M = "PURPLEMON",
-    NIDORINA = "BLUEMON",
-    NIDORINO = "PURPLEMON",
-    NINETALES = "YELLOWMON",
-    ODDISH = "GREENMON",
-    OMANYTE = "BLUEMON",
-    OMASTAR = "BLUEMON",
-    ONIX = "GRAYMON",
-    PARAS = "REDMON",
-    PARASECT = "REDMON",
-    PERSIAN = "YELLOWMON",
-    PIDGEOT = "BROWNMON",
-    PIDGEOTTO = "BROWNMON",
-    PIDGEY = "BROWNMON",
-    PIKACHU = "YELLOWMON",
-    PINSIR = "BROWNMON",
-    POLIWAG = "BLUEMON",
-    POLIWHIRL = "BLUEMON",
-    POLIWRATH = "BLUEMON",
-    PONYTA = "REDMON",
-    PORYGON = "GRAYMON",
-    PRIMEAPE = "BROWNMON",
-    PSYDUCK = "YELLOWMON",
-    RAICHU = "YELLOWMON",
-    RAPIDASH = "REDMON",
-    RATICATE = "GRAYMON",
-    RATTATA = "GRAYMON",
-    RHYDON = "GRAYMON",
-    RHYHORN = "GRAYMON",
-    SANDSHREW = "BROWNMON",
-    SANDSLASH = "BROWNMON",
-    SCYTHER = "GREENMON",
-    SEADRA = "CYANMON",
-    SEAKING = "REDMON",
-    SEEL = "BLUEMON",
-    SHELLDER = "GRAYMON",
-    SLOWBRO = "PINKMON",
-    SLOWPOKE = "PINKMON",
-    SNORLAX = "PINKMON",
-    SPEAROW = "BROWNMON",
-    SQUIRTLE = "CYANMON",
-    STARMIE = "GRAYMON",
-    STARYU = "REDMON",
-    TANGELA = "BLUEMON",
-    TAUROS = "GRAYMON",
-    TENTACOOL = "CYANMON",
-    TENTACRUEL = "CYANMON",
-    VAPOREON = "CYANMON",
-    VENOMOTH = "PURPLEMON",
-    VENONAT = "PURPLEMON",
-    VENUSAUR = "GREENMON",
-    VICTREEBEL = "GREENMON",
-    VILEPLUME = "REDMON",
-    VOLTORB = "YELLOWMON",
-    VULPIX = "REDMON",
-    WARTORTLE = "CYANMON",
-    WEEDLE = "YELLOWMON",
-    WEEPINBELL = "GREENMON",
-    WEEZING = "PURPLEMON",
-    WIGGLYTUFF = "PINKMON",
-    ZAPDOS = "YELLOWMON",
-    ZUBAT = "BLUEMON",
+    ABRA = "ABRA",
+    AERODACTYL = "AERODACTYL",
+    ALAKAZAM = "ALAKAZAM",
+    ARBOK = "ARBOK",
+    ARCANINE = "ARCANINE",
+    ARTICUNO = "ARTICUNO",
+    BEEDRILL = "BEEDRILL",
+    BELLSPROUT = "BELLSPROUT",
+    BLASTOISE = "BLASTOISE",
+    BULBASAUR = "BULBASAUR",
+    BUTTERFREE = "BUTTERFREE",
+    CATERPIE = "CATERPIE",
+    CHANSEY = "CHANSEY",
+    CHARIZARD = "CHARIZARD",
+    CHARMANDER = "CHARMANDER",
+    CHARMELEON = "CHARMELEON",
+    CLEFABLE = "CLEFABLE",
+    CLEFAIRY = "CLEFAIRY",
+    CLOYSTER = "CLOYSTER",
+    CUBONE = "CUBONE",
+    DEWGONG = "DEWGONG",
+    DIGLETT = "DIGLETT",
+    DITTO = "DITTO",
+    DODRIO = "DODRIO",
+    DODUO = "DODUO",
+    DRAGONAIR = "DRAGONAIR",
+    DRAGONITE = "DRAGONITE",
+    DRATINI = "DRATINI",
+    DROWZEE = "DROWZEE",
+    DUGTRIO = "DUGTRIO",
+    EEVEE = "EEVEE",
+    EKANS = "EKANS",
+    ELECTABUZZ = "ELECTABUZZ",
+    ELECTRODE = "ELECTRODE",
+    EXEGGCUTE = "EXEGGCUTE",
+    EXEGGUTOR = "EXEGGUTOR",
+    FARFETCHD = "FARFETCH_D",
+    FEAROW = "FEAROW",
+    FLAREON = "FLAREON",
+    GASTLY = "GASTLY",
+    GENGAR = "GENGAR",
+    GEODUDE = "GEODUDE",
+    GLOOM = "GLOOM",
+    GOLBAT = "GOLBAT",
+    GOLDEEN = "GOLDEEN",
+    GOLDUCK = "GOLDUCK",
+    GOLEM = "GOLEM",
+    GRAVELER = "GRAVELER",
+    GRIMER = "GRIMER",
+    GROWLITHE = "GROWLITHE",
+    GYARADOS = "GYARADOS",
+    HAUNTER = "HAUNTER",
+    HITMONCHAN = "HITMONCHAN",
+    HITMONLEE = "HITMONLEE",
+    HORSEA = "HORSEA",
+    HYPNO = "HYPNO",
+    IVYSAUR = "IVYSAUR",
+    JIGGLYPUFF = "JIGGLYPUFF",
+    JOLTEON = "JOLTEON",
+    JYNX = "JYNX",
+    KABUTO = "KABUTO",
+    KABUTOPS = "KABUTOPS",
+    KADABRA = "KADABRA",
+    KAKUNA = "KAKUNA",
+    KANGASKHAN = "KANGASKHAN",
+    KINGLER = "KINGLER",
+    KOFFING = "KOFFING",
+    KRABBY = "KRABBY",
+    LAPRAS = "LAPRAS",
+    LICKITUNG = "LICKITUNG",
+    MACHAMP = "MACHAMP",
+    MACHOKE = "MACHOKE",
+    MACHOP = "MACHOP",
+    MAGIKARP = "MAGIKARP",
+    MAGMAR = "MAGMAR",
+    MAGNEMITE = "MAGNEMITE",
+    MAGNETON = "MAGNETON",
+    MANKEY = "MANKEY",
+    MAROWAK = "MAROWAK",
+    MEOWTH = "MEOWTH",
+    METAPOD = "METAPOD",
+    MEW = "MEW",
+    MEWTWO = "MEWTWO",
+    MOLTRES = "MOLTRES",
+    MR_MIME = "MR_MIME",
+    MUK = "MUK",
+    NIDOKING = "NIDOKING",
+    NIDOQUEEN = "NIDOQUEEN",
+    NIDORAN_F = "NIDORAN_F",
+    NIDORAN_M = "NIDORAN_M",
+    NIDORINA = "NIDORINA",
+    NIDORINO = "NIDORINO",
+    NINETALES = "NINETALES",
+    ODDISH = "ODDISH",
+    OMANYTE = "OMANYTE",
+    OMASTAR = "OMASTAR",
+    ONIX = "ONIX",
+    PARAS = "PARAS",
+    PARASECT = "PARASECT",
+    PERSIAN = "PERSIAN",
+    PIDGEOT = "PIDGEOT",
+    PIDGEOTTO = "PIDGEOTTO",
+    PIDGEY = "PIDGEY",
+    PIKACHU = "PIKACHU",
+    PINSIR = "PINSIR",
+    POLIWAG = "POLIWAG",
+    POLIWHIRL = "POLIWHIRL",
+    POLIWRATH = "POLIWRATH",
+    PONYTA = "PONYTA",
+    PORYGON = "PORYGON",
+    PRIMEAPE = "PRIMEAPE",
+    PSYDUCK = "PSYDUCK",
+    RAICHU = "RAICHU",
+    RAPIDASH = "RAPIDASH",
+    RATICATE = "RATICATE",
+    RATTATA = "RATTATA",
+    RHYDON = "RHYDON",
+    RHYHORN = "RHYHORN",
+    SANDSHREW = "SANDSHREW",
+    SANDSLASH = "SANDSLASH",
+    SCYTHER = "SCYTHER",
+    SEADRA = "SEADRA",
+    SEAKING = "SEAKING",
+    SEEL = "SEEL",
+    SHELLDER = "SHELLDER",
+    SLOWBRO = "SLOWBRO",
+    SLOWPOKE = "SLOWPOKE",
+    SNORLAX = "SNORLAX",
+    SPEAROW = "SPEAROW",
+    SQUIRTLE = "SQUIRTLE",
+    STARMIE = "STARMIE",
+    STARYU = "STARYU",
+    TANGELA = "TANGELA",
+    TAUROS = "TAUROS",
+    TENTACOOL = "TENTACOOL",
+    TENTACRUEL = "TENTACRUEL",
+    VAPOREON = "VAPOREON",
+    VENOMOTH = "VENOMOTH",
+    VENONAT = "VENONAT",
+    VENUSAUR = "VENUSAUR",
+    VICTREEBEL = "VICTREEBEL",
+    VILEPLUME = "VILEPLUME",
+    VOLTORB = "VOLTORB",
+    VULPIX = "VULPIX",
+    WARTORTLE = "WARTORTLE",
+    WEEDLE = "WEEDLE",
+    WEEPINBELL = "WEEPINBELL",
+    WEEZING = "WEEZING",
+    WIGGLYTUFF = "WIGGLYTUFF",
+    ZAPDOS = "ZAPDOS",
+    ZUBAT = "ZUBAT",
   },
   source = "pokered-gbc data/super_palettes.asm + data/mon_palettes.asm + color/**",
   world = {

data/palettes_yellow.lua

@@ -1,686 +0,0 @@
--- Generated by tools/build_data.py. DO NOT EDIT.
--- Pokemon Yellow palettes (COLORS=OG YELLOW): SuperPalettes +
--- CGBBasePalettes (authentic GBC look) as 4 8-bit RGB colors
--- per palette (color 0 first), plus MonsterPalettes.
-return {
-  cgbBase = {
-    ["0F"] = {
-      { 255, 255, 255 },
-      { 107, 8, 255 },
-      { 0, 74, 255 },
-      { 8, 8, 8 },
-    },
-    BADGE = {
-      { 255, 255, 255 },
-      { 189, 66, 0 },
-      { 140, 115, 90 },
-      { 25, 25, 25 },
-    },
-    BLACK = {
-      { 255, 255, 255 },
-      { 25, 25, 25 },
-      { 25, 25, 25 },
-      { 25, 25, 25 },
-    },
-    BLUEMON = {
-      { 255, 255, 255 },
-      { 132, 148, 255 },
-      { 0, 8, 206 },
-      { 25, 25, 25 },
-    },
-    BROWNMON = {
-      { 255, 255, 255 },
-      { 239, 148, 82 },
-      { 140, 74, 41 },
-      { 25, 25, 25 },
-    },
-    CAVE = {
-      { 255, 255, 255 },
-      { 189, 66, 0 },
-      { 140, 115, 90 },
-      { 25, 25, 25 },
-    },
-    CELADON = {
-      { 255, 255, 255 },
-      { 41, 255, 41 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    CERULEAN = {
-      { 255, 255, 255 },
-      { 41, 66, 255 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    CINNABAR = {
-      { 255, 255, 255 },
-      { 255, 66, 66 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    CYANMON = {
-      { 255, 255, 255 },
-      { 132, 214, 255 },
-      { 0, 140, 255 },
-      { 25, 25, 25 },
-    },
-    FUCHSIA = {
-      { 255, 255, 255 },
-      { 255, 123, 123 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    GAMEFREAK = {
-      { 255, 255, 255 },
-      { 255, 156, 0 },
-      { 156, 156, 0 },
-      { 25, 25, 25 },
-    },
-    GRAYMON = {
-      { 255, 255, 255 },
-      { 165, 189, 82 },
-      { 90, 90, 41 },
-      { 25, 25, 25 },
-    },
-    GREENBAR = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 0, 255, 0 },
-      { 25, 25, 25 },
-    },
-    GREENMON = {
-      { 255, 255, 255 },
-      { 140, 255, 90 },
-      { 8, 181, 49 },
-      { 25, 25, 25 },
-    },
-    INDIGO = {
-      { 255, 255, 255 },
-      { 90, 66, 255 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    LAVENDER = {
-      { 255, 255, 255 },
-      { 206, 33, 255 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    LOGO1 = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 255, 0, 0 },
-      { 255, 0, 0 },
-    },
-    LOGO2 = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 58, 58, 206 },
-      { 0, 0, 140 },
-    },
-    MEWMON = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 255, 8, 8 },
-      { 25, 25, 25 },
-    },
-    PALLET = {
-      { 255, 255, 255 },
-      { 189, 140, 255 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    PEWTER = {
-      { 255, 255, 255 },
-      { 148, 148, 123 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    PIKACHUS_BEACH = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    PIKACHUS_BEACH_TITLE = {
-      { 255, 255, 255 },
-      { 74, 74, 74 },
-      { 255, 173, 0 },
-      { 25, 25, 25 },
-    },
-    PIKACHU_PORTRAIT = {
-      { 255, 255, 255 },
-      { 255, 148, 0 },
-      { 156, 58, 8 },
-      { 25, 25, 25 },
-    },
-    PINKMON = {
-      { 255, 255, 255 },
-      { 255, 123, 148 },
-      { 255, 0, 49 },
-      { 25, 25, 25 },
-    },
-    PURPLEMON = {
-      { 255, 255, 255 },
-      { 206, 123, 255 },
-      { 156, 0, 181 },
-      { 25, 25, 25 },
-    },
-    REDBAR = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 255, 0, 0 },
-      { 25, 25, 25 },
-    },
-    REDMON = {
-      { 255, 255, 255 },
-      { 255, 140, 0 },
-      { 255, 0, 0 },
-      { 25, 25, 25 },
-    },
-    ROUTE = {
-      { 255, 255, 255 },
-      { 132, 255, 33 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    SAFFRON = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    SLOTS1 = {
-      { 255, 255, 255 },
-      { 206, 8, 255 },
-      { 255, 0, 0 },
-      { 25, 25, 25 },
-    },
-    SLOTS2 = {
-      { 255, 255, 255 },
-      { 255, 33, 156 },
-      { 255, 255, 0 },
-      { 25, 25, 25 },
-    },
-    SLOTS3 = {
-      { 255, 255, 255 },
-      { 66, 255, 0 },
-      { 255, 255, 0 },
-      { 25, 25, 25 },
-    },
-    SLOTS4 = {
-      { 255, 255, 255 },
-      { 0, 255, 255 },
-      { 255, 255, 0 },
-      { 25, 25, 25 },
-    },
-    TOWNMAP = {
-      { 255, 255, 255 },
-      { 0, 173, 255 },
-      { 82, 230, 0 },
-      { 8, 8, 8 },
-    },
-    VERMILION = {
-      { 255, 255, 255 },
-      { 255, 156, 0 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    VIRIDIAN = {
-      { 255, 255, 255 },
-      { 156, 255, 0 },
-      { 90, 189, 255 },
-      { 25, 25, 25 },
-    },
-    YELLOWBAR = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 255, 148, 0 },
-      { 25, 25, 25 },
-    },
-    YELLOWMON = {
-      { 255, 255, 255 },
-      { 255, 255, 0 },
-      { 230, 115, 0 },
-      { 25, 25, 25 },
-    },
-  },
-  order = {
-    "ROUTE",
-    "PALLET",
-    "VIRIDIAN",
-    "PEWTER",
-    "CERULEAN",
-    "LAVENDER",
-    "VERMILION",
-    "CELADON",
-    "FUCHSIA",
-    "CINNABAR",
-    "INDIGO",
-    "SAFFRON",
-    "TOWNMAP",
-    "LOGO1",
-    "LOGO2",
-    "0F",
-    "MEWMON",
-    "BLUEMON",
-    "REDMON",
-    "CYANMON",
-    "PURPLEMON",
-    "BROWNMON",
-    "GREENMON",
-    "PINKMON",
-    "YELLOWMON",
-    "GRAYMON",
-    "SLOTS1",
-    "SLOTS2",
-    "SLOTS3",
-    "SLOTS4",
-    "BLACK",
-    "GREENBAR",
-    "YELLOWBAR",
-    "REDBAR",
-    "BADGE",
-    "CAVE",
-    "GAMEFREAK",
-    "PIKACHUS_BEACH",
-    "PIKACHU_PORTRAIT",
-    "PIKACHUS_BEACH_TITLE",
-  },
-  palettes = {
-    ["0F"] = {
-      { 255, 255, 247 },
-      { 197, 165, 247 },
-      { 90, 165, 247 },
-      { 25, 16, 16 },
-    },
-    BADGE = {
-      { 255, 255, 247 },
-      { 165, 123, 90 },
-      { 181, 173, 165 },
-      { 49, 49, 49 },
-    },
-    BLACK = {
-      { 255, 255, 247 },
-      { 49, 49, 49 },
-      { 49, 49, 49 },
-      { 49, 49, 49 },
-    },
-    BLUEMON = {
-      { 255, 255, 247 },
-      { 173, 181, 255 },
-      { 74, 82, 165 },
-      { 49, 49, 49 },
-    },
-    BROWNMON = {
-      { 255, 255, 247 },
-      { 214, 189, 148 },
-      { 148, 115, 82 },
-      { 49, 49, 49 },
-    },
-    CAVE = {
-      { 255, 255, 247 },
-      { 165, 123, 90 },
-      { 181, 173, 165 },
-      { 49, 49, 49 },
-    },
-    CELADON = {
-      { 255, 255, 247 },
-      { 181, 255, 181 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    CERULEAN = {
-      { 255, 255, 247 },
-      { 181, 189, 255 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    CINNABAR = {
-      { 255, 255, 247 },
-      { 255, 123, 115 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    CYANMON = {
-      { 255, 255, 247 },
-      { 214, 230, 255 },
-      { 58, 197, 230 },
-      { 49, 49, 49 },
-    },
-    FUCHSIA = {
-      { 255, 255, 247 },
-      { 255, 214, 214 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    GAMEFREAK = {
-      { 255, 255, 247 },
-      { 230, 197, 115 },
-      { 165, 165, 90 },
-      { 49, 49, 49 },
-    },
-    GRAYMON = {
-      { 255, 255, 247 },
-      { 206, 206, 148 },
-      { 132, 132, 115 },
-      { 49, 49, 49 },
-    },
-    GREENBAR = {
-      { 255, 255, 247 },
-      { 255, 255, 156 },
-      { 0, 173, 0 },
-      { 49, 49, 49 },
-    },
-    GREENMON = {
-      { 255, 255, 247 },
-      { 197, 230, 148 },
-      { 107, 173, 123 },
-      { 49, 49, 49 },
-    },
-    INDIGO = {
-      { 255, 255, 247 },
-      { 140, 140, 206 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    LAVENDER = {
-      { 255, 255, 247 },
-      { 222, 189, 239 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    LOGO1 = {
-      { 255, 255, 247 },
-      { 247, 247, 140 },
-      { 173, 0, 33 },
-      { 173, 0, 33 },
-    },
-    LOGO2 = {
-      { 255, 255, 247 },
-      { 247, 247, 140 },
-      { 148, 148, 197 },
-      { 58, 58, 132 },
-    },
-    MEWMON = {
-      { 255, 255, 247 },
-      { 255, 247, 181 },
-      { 222, 132, 132 },
-      { 49, 49, 49 },
-    },
-    PALLET = {
-      { 255, 255, 247 },
-      { 230, 222, 255 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    PEWTER = {
-      { 255, 255, 247 },
-      { 189, 189, 181 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    PIKACHUS_BEACH = {
-      { 255, 255, 247 },
-      { 255, 247, 181 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    PIKACHUS_BEACH_TITLE = {
-      { 255, 255, 247 },
-      { 132, 132, 132 },
-      { 255, 206, 74 },
-      { 49, 49, 49 },
-    },
-    PIKACHU_PORTRAIT = {
-      { 255, 255, 247 },
-      { 230, 189, 74 },
-      { 148, 115, 82 },
-      { 49, 49, 49 },
-    },
-    PINKMON = {
-      { 255, 255, 247 },
-      { 255, 197, 214 },
-      { 255, 148, 173 },
-      { 49, 49, 49 },
-    },
-    PURPLEMON = {
-      { 255, 255, 247 },
-      { 222, 181, 247 },
-      { 181, 123, 189 },
-      { 49, 49, 49 },
-    },
-    REDBAR = {
-      { 255, 255, 247 },
-      { 255, 255, 156 },
-      { 214, 74, 49 },
-      { 49, 49, 49 },
-    },
-    REDMON = {
-      { 255, 255, 247 },
-      { 255, 197, 90 },
-      { 214, 74, 49 },
-      { 49, 49, 49 },
-    },
-    ROUTE = {
-      { 255, 255, 247 },
-      { 189, 214, 156 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    SAFFRON = {
-      { 255, 255, 247 },
-      { 255, 255, 156 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    SLOTS1 = {
-      { 255, 255, 247 },
-      { 222, 181, 247 },
-      { 214, 74, 49 },
-      { 49, 49, 49 },
-    },
-    SLOTS2 = {
-      { 255, 255, 247 },
-      { 255, 189, 214 },
-      { 239, 239, 66 },
-      { 49, 49, 49 },
-    },
-    SLOTS3 = {
-      { 255, 255, 247 },
-      { 189, 255, 165 },
-      { 239, 239, 66 },
-      { 49, 49, 49 },
-    },
-    SLOTS4 = {
-      { 255, 255, 247 },
-      { 189, 239, 255 },
-      { 239, 239, 66 },
-      { 49, 49, 49 },
-    },
-    TOWNMAP = {
-      { 255, 255, 247 },
-      { 165, 214, 255 },
-      { 140, 189, 82 },
-      { 25, 16, 16 },
-    },
-    VERMILION = {
-      { 255, 255, 247 },
-      { 255, 206, 132 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    VIRIDIAN = {
-      { 255, 255, 247 },
-      { 214, 255, 173 },
-      { 189, 222, 255 },
-      { 49, 49, 49 },
-    },
-    YELLOWBAR = {
-      { 255, 255, 247 },
-      { 255, 255, 156 },
-      { 230, 189, 74 },
-      { 49, 49, 49 },
-    },
-    YELLOWMON = {
-      { 255, 255, 247 },
-      { 255, 255, 156 },
-      { 230, 189, 74 },
-      { 49, 49, 49 },
-    },
-  },
-  pokemon = {
-    ABRA = "YELLOWMON",
-    AERODACTYL = "GRAYMON",
-    ALAKAZAM = "YELLOWMON",
-    ARBOK = "PURPLEMON",
-    ARCANINE = "REDMON",
-    ARTICUNO = "BLUEMON",
-    BEEDRILL = "YELLOWMON",
-    BELLSPROUT = "GREENMON",
-    BLASTOISE = "CYANMON",
-    BULBASAUR = "GREENMON",
-    BUTTERFREE = "CYANMON",
-    CATERPIE = "GREENMON",
-    CHANSEY = "PINKMON",
-    CHARIZARD = "REDMON",
-    CHARMANDER = "REDMON",
-    CHARMELEON = "REDMON",
-    CLEFABLE = "PINKMON",
-    CLEFAIRY = "PINKMON",
-    CLOYSTER = "GRAYMON",
-    CUBONE = "GRAYMON",
-    DEWGONG = "BLUEMON",
-    DIGLETT = "BROWNMON",
-    DITTO = "GRAYMON",
-    DODRIO = "BROWNMON",
-    DODUO = "BROWNMON",
-    DRAGONAIR = "BLUEMON",
-    DRAGONITE = "BROWNMON",
-    DRATINI = "GRAYMON",
-    DROWZEE = "YELLOWMON",
-    DUGTRIO = "BROWNMON",
-    EEVEE = "GRAYMON",
-    EKANS = "PURPLEMON",
-    ELECTABUZZ = "YELLOWMON",
-    ELECTRODE = "YELLOWMON",
-    EXEGGCUTE = "PINKMON",
-    EXEGGUTOR = "GREENMON",
-    FARFETCHD = "BROWNMON",
-    FEAROW = "BROWNMON",
-    FLAREON = "REDMON",
-    GASTLY = "PURPLEMON",
-    GENGAR = "PURPLEMON",
-    GEODUDE = "GRAYMON",
-    GLOOM = "REDMON",
-    GOLBAT = "BLUEMON",
-    GOLDEEN = "REDMON",
-    GOLDUCK = "CYANMON",
-    GOLEM = "GRAYMON",
-    GRAVELER = "GRAYMON",
-    GRIMER = "PURPLEMON",
-    GROWLITHE = "BROWNMON",
-    GYARADOS = "BLUEMON",
-    HAUNTER = "PURPLEMON",
-    HITMONCHAN = "BROWNMON",
-    HITMONLEE = "BROWNMON",
-    HORSEA = "CYANMON",
-    HYPNO = "YELLOWMON",
-    IVYSAUR = "GREENMON",
-    JIGGLYPUFF = "PINKMON",
-    JOLTEON = "YELLOWMON",
-    JYNX = "MEWMON",
-    KABUTO = "BROWNMON",
-    KABUTOPS = "BROWNMON",
-    KADABRA = "YELLOWMON",
-    KAKUNA = "YELLOWMON",
-    KANGASKHAN = "BROWNMON",
-    KINGLER = "REDMON",
-    KOFFING = "PURPLEMON",
-    KRABBY = "REDMON",
-    LAPRAS = "CYANMON",
-    LICKITUNG = "PINKMON",
-    MACHAMP = "GRAYMON",
-    MACHOKE = "GRAYMON",
-    MACHOP = "GRAYMON",
-    MAGIKARP = "REDMON",
-    MAGMAR = "REDMON",
-    MAGNEMITE = "GRAYMON",
-    MAGNETON = "GRAYMON",
-    MANKEY = "BROWNMON",
-    MAROWAK = "GRAYMON",
-    MEOWTH = "YELLOWMON",
-    METAPOD = "GREENMON",
-    MEW = "MEWMON",
-    MEWTWO = "MEWMON",
-    MOLTRES = "REDMON",
-    MR_MIME = "PINKMON",
-    MUK = "PURPLEMON",
-    NIDOKING = "PURPLEMON",
-    NIDOQUEEN = "BLUEMON",
-    NIDORAN_F = "BLUEMON",
-    NIDORAN_M = "PURPLEMON",
-    NIDORINA = "BLUEMON",
-    NIDORINO = "PURPLEMON",
-    NINETALES = "YELLOWMON",
-    ODDISH = "GREENMON",
-    OMANYTE = "BLUEMON",
-    OMASTAR = "BLUEMON",
-    ONIX = "GRAYMON",
-    PARAS = "REDMON",
-    PARASECT = "REDMON",
-    PERSIAN = "YELLOWMON",
-    PIDGEOT = "BROWNMON",
-    PIDGEOTTO = "BROWNMON",
-    PIDGEY = "BROWNMON",
-    PIKACHU = "YELLOWMON",
-    PINSIR = "BROWNMON",
-    POLIWAG = "BLUEMON",
-    POLIWHIRL = "BLUEMON",
-    POLIWRATH = "BLUEMON",
-    PONYTA = "REDMON",
-    PORYGON = "GRAYMON",
-    PRIMEAPE = "BROWNMON",
-    PSYDUCK = "YELLOWMON",
-    RAICHU = "YELLOWMON",
-    RAPIDASH = "REDMON",
-    RATICATE = "GRAYMON",
-    RATTATA = "GRAYMON",
-    RHYDON = "GRAYMON",
-    RHYHORN = "GRAYMON",
-    SANDSHREW = "BROWNMON",
-    SANDSLASH = "BROWNMON",
-    SCYTHER = "GREENMON",
-    SEADRA = "CYANMON",
-    SEAKING = "REDMON",
-    SEEL = "BLUEMON",
-    SHELLDER = "GRAYMON",
-    SLOWBRO = "PINKMON",
-    SLOWPOKE = "PINKMON",
-    SNORLAX = "PINKMON",
-    SPEAROW = "BROWNMON",
-    SQUIRTLE = "CYANMON",
-    STARMIE = "GRAYMON",
-    STARYU = "REDMON",
-    TANGELA = "BLUEMON",
-    TAUROS = "GRAYMON",
-    TENTACOOL = "CYANMON",
-    TENTACRUEL = "CYANMON",
-    VAPOREON = "CYANMON",
-    VENOMOTH = "PURPLEMON",
-    VENONAT = "PURPLEMON",
-    VENUSAUR = "GREENMON",
-    VICTREEBEL = "GREENMON",
-    VILEPLUME = "REDMON",
-    VOLTORB = "YELLOWMON",
-    VULPIX = "REDMON",
-    WARTORTLE = "CYANMON",
-    WEEDLE = "YELLOWMON",
-    WEEPINBELL = "GREENMON",
-    WEEZING = "PURPLEMON",
-    WIGGLYTUFF = "PINKMON",
-    ZAPDOS = "YELLOWMON",
-    ZUBAT = "BLUEMON",
-  },
-  source = "pokeyellow data/sgb/sgb_palettes.asm + data/pokemon/palettes.asm",
-}

data/scripts/celadon_eevee.lua

@@ -11,70 +11,8 @@
 -- equivalent, kept for save compatibility: rows 1-4 also self-heal
 -- older saves (flag set before the port hid the ball) by hiding the
 -- leftover ball on the next interaction.
---
--- The room's two readables (data/events/hidden_events.asm,
--- hidden_events_for CELADON_MANSION_ROOF_HOUSE):
---   hidden_text_predef 3, 0 / 4, 0  PrintBlackboardLinkCableText, LinkCableHelp
---   hidden_text_predef 3, 4         PrintNotebookText, TMNotebook
--- tools/extract/field.py only parses `hidden_event` rows, so no
--- hidden_text_predef row reaches data/generated/field.lua and both tiles
--- were dead A presses (#391).  Same hook shape as the bedroom SNES in
--- data/scripts/flavor/reds_house_2f.lua (#135).  hidden_text_predef puts
--- the predef id in the facing byte, so neither tile gates on facing.
-
-local Menu = require("src.ui.Menu")
-local TextBox = require("src.render.TextBox")
-
--- TMNotebookText (data/text/text_2.asm) has no leading underscore, so the
--- extractor never collects it and the pamphlet's text is inlined.
-local TM_NOTEBOOK_TEXT = "It's a pamphlet\non TMs.\f...\f"
-  .. "There are 50 TMs\nin all.\f"
-  .. "There are also 5\nHMs that can be\vused repeatedly.\f"
-  .. "SILPH CO."
-
--- LinkCableHelp (engine/events/hidden_events/school_blackboard.asm):
--- HowToLinkText's four headings in the 15x10 box at the top left; picking
--- a heading prints its LinkCableInfoText and returns to the menu, B or
--- STOP READING closes.
-local LINK_HEADINGS = { "HOW TO LINK", "COLOSSEUM", "TRADE CENTER" }
-
-local function linkCableHelp(game)
-  local text = game.data.text or {}
-  local items, showMenu, askHeading
-  function showMenu()
-    game.stack:push(Menu.new(game, items,
-      { tx = 0, ty = 0, tw = 15, th = 10, rowStep = 1 }))
-  end
-  function askHeading()
-    game.stack:push(TextBox.new(game,
-      text._LinkCableHelpText2 or "Which heading do\nyou want to read?",
-      showMenu))
-  end
-  items = {}
-  for i, label in ipairs(LINK_HEADINGS) do
-    items[i] = { label = label, onSelect = function()
-      game.stack:push(TextBox.new(game,
-        text["_LinkCableInfoText" .. i] or label, askHeading))
-    end }
-  end
-  items[#items + 1] = { label = "STOP READING" }
-  game.stack:push(TextBox.new(game,
-    text._LinkCableHelpText1 or "TRAINER TIPS\fUsing a Game Link\nCable",
-    askHeading))
-end
 
 return {
-  onInteract = function(game, ow, fx, fy)
-    if fy == 0 and (fx == 3 or fx == 4) then
-      linkCableHelp(game)
-      return true
-    end
-    if fx == 3 and fy == 4 then
-      game.stack:push(TextBox.new(game, TM_NOTEBOOK_TEXT))
-      return true
-    end
-    return false
-  end,
   talk = {
     TEXT_CELADONMANSION_ROOF_HOUSE_EEVEE_POKEBALL = {
       { "check_flag", "EVENT_GOT_EEVEE" },                     -- 1
@@ -84,16 +22,11 @@ return {
       { "jump", 13 },                                          -- 4
       { "give_pokemon", "EEVEE", 25 },                         -- 5
       { "jump_if_false", 12 },                                 -- 6 (party+box full)
-      -- flag + HideObject before the jingle and GotMonText: the nickname
-      -- prompt inside give_pokemon and the text row both yield, and a
-      -- script that dies there would leave the EEVEE taken with the ball
-      -- still on the table and the gift claimable again (#426).  The row
-      -- count is unchanged, so the numeric jump targets still hold.
-      { "set_flag", "EVENT_GOT_EEVEE" },                       -- 7
+      { "play_sound", "Get_Item1" },                           -- 7 (GotMonText jingle)
+      { "show_text", "_GotMonText", { RAM = "EEVEE" } },       -- 8
+      { "set_flag", "EVENT_GOT_EEVEE" },                       -- 9
       { "hide_object", "CELADON_MANSION_ROOF_HOUSE",
-        "CELADONMANSION_ROOF_HOUSE_EEVEE_POKEBALL" },          -- 8
-      { "play_sound", "Get_Item1" },                           -- 9 (GotMonText jingle)
-      { "show_text", "_GotMonText", { RAM = "EEVEE" } },       -- 10
+        "CELADONMANSION_ROOF_HOUSE_EEVEE_POKEBALL" },          -- 10
       { "jump", 13 },                                          -- 11
       { "show_text", "_BoxIsFullText" },                       -- 12
     },

data/scripts/flavor/bike_shop.lua

@@ -1,9 +1,10 @@
 -- BikeShop (BIKE_SHOP) flavor dialogue
 -- Source: pokered/scripts/BikeShop.asm, pokered/text/BikeShop.asm
 --
--- TEXT_BIKESHOP_CLERK lives in data/scripts/story2.lua (M.BIKE_SHOP): the
--- voucher exchange and the BICYCLE/CANCEL price window need more than
--- command rows (#568).
+-- TEXT_BIKESHOP_CLERK is skipped: it drives the actual voucher-for-bicycle
+-- exchange (YesNoChoice purchase menu, GiveItem, RemoveItemByID, SetEvent
+-- EVENT_GOT_BICYCLE). That is a significant standalone feature outside the
+-- scope of these two flavor NPCs and is left unported here.
 
 return {
   BIKE_SHOP = {
@@ -19,15 +20,12 @@ return {
       -- CheckEvent EVENT_GOT_BICYCLE ; jr nz, .gotBike
       -- before the player owns a bike -> TheseBikesAreExpensiveText
       -- after the player owns a bike  -> CoolBikeText
-      -- The check reads the bag, not the event: the port hands out the
-      -- BICYCLE itself (a key item, so it cannot be tossed), and that also
-      -- reads right on saves written before the clerk set the event (#567).
       TEXT_BIKESHOP_YOUNGSTER = {
         { "face_player" },                                            -- 1
-        { "check_item", "BICYCLE" },                                  -- 2
-        { "jump_if_true", 6 },                                        -- 3
+        { "check_flag", "EVENT_GOT_BICYCLE" },                        -- 2
+        { "jump_if_true", 5 },                                        -- 3
         { "show_text", "_BikeShopYoungsterTheseBikesAreExpensiveText" }, -- 4
-        { "jump", "end" },                                            -- 5
+        { "jump", 6 },                                                -- 5
         { "show_text", "_BikeShopYoungsterCoolBikeText" },            -- 6
       },
     },

data/scripts/flavor/celadon_mansion_3f.lua

@@ -1,88 +1,33 @@
--- Celadon Mansion 3F, the GAME FREAK dev floor
--- (pokered+pokeyellow/scripts/CeladonMansion3F.asm).  Every dev's
--- text_asm counts set bits in wPokedexOwned against NUM_POKEMON - 1
--- (150, discounting Mew).  The game designer shows the diploma
--- (DisplayDiploma -> src/ui/Diploma.lua) on a completed dex; Yellow's
--- graphic artist then offers the printed copy (PrintDiploma, stood in
--- by src/core/Printer.lua's PNG export like the Pokédex PRNT item).
-
-local function ownedCount(game)
-  local dex = game.save.pokedex
-  local owned = 0
-  if dex and dex.owned then
-    for _ in pairs(dex.owned) do owned = owned + 1 end
-  end
-  return owned
-end
-
+-- Celadon Mansion 3F Game Designer (pokered/scripts/CeladonMansion3F.asm
+-- CeladonMansion3FGameDesignerText): text_asm counts set bits in
+-- wPokedexOwned and compares against NUM_POKEMON - 1 (discounts Mew).
+-- If the player owns >= 150 species, shows the "completed" text
+-- (originally followed by DisplayDiploma, which has no equivalent UI
+-- in this port, so we just show the congratulatory text); otherwise
+-- shows the normal encouragement text.
 return {
   CELADON_MANSION_3F = {
     talk = {
       TEXT_CELADONMANSION3F_GAME_DESIGNER = function(game, ow, npc, done)
         local t = game.data.text
-        local TextBox = require("src.render.TextBox")
-        if ownedCount(game) < 150 then
-          game.stack:push(TextBox.new(game,
-            t._CeladonMansion3FGameDesignerText
-            or "Is that right?\nI'm the game\ndesigner!\fFilling up your\nPOKéDEX is tough,\nbut don't quit!",
-            done))
-          return
+        local dex = game.save.pokedex
+        local owned = 0
+        if dex and dex.owned then
+          for _ in pairs(dex.owned) do
+            owned = owned + 1
+          end
         end
-        game.stack:push(TextBox.new(game,
-          t._CeladonMansion3FGameDesignerCompletedDexText
-          or "Wow! Excellent!\nYou completed\nyour POKéDEX!\nCongratulations!",
-          function()
-            local Diploma = require("src.ui.Diploma")
-            game.stack:push(Diploma.new(game, function()
-              -- Yellow tags on the unlocked-printing line (CompletedDexText2)
-              local after = require("src.core.GameVersion").isYellow()
-                and (t._CeladonMansion3FGameDesignerCompletedDexText2
-                     or "You can print out\nyour diploma with\nthe GAME BOY\nPrinter!")
-                or nil
-              if after then
-                game.stack:push(TextBox.new(game, after, done))
-              else
-                done()
-              end
-            end))
-          end))
-      end,
-
-      TEXT_CELADONMANSION3F_GRAPHIC_ARTIST = function(game, ow, npc, done)
-        local t = game.data.text
-        local TextBox = require("src.render.TextBox")
-        local yellow = require("src.core.GameVersion").isYellow()
-        if not (yellow and ownedCount(game) >= 150) then
-          game.stack:push(TextBox.new(game,
-            t._CeladonMansion3FGraphicArtistText
-            or "I'm the graphic\nartist!\nI drew you!", done))
-          return
+        -- NUM_POKEMON - 1 = 150 (discounts Mew, per pokered)
+        local label, fallback
+        if owned >= 150 then
+          label, fallback = "_CeladonMansion3FGameDesignerCompletedDexText",
+            "Wow! Excellent!\nYou completed\nyour POKeDEX!\nCongratulations!"
+        else
+          label, fallback = "_CeladonMansion3FGameDesignerText",
+            "Is that right?\nI'm the game\ndesigner!\nFilling up your\nPOKeDEX is tough,\nbut don't quit!\nWhen you finish,\ncome tell me!"
         end
-        -- _CeladonMansion3FGraphicArtistText2: offer to print the diploma
-        game.stack:push(TextBox.new(game,
-          t._CeladonMansion3FGraphicArtistText2
-          or "I'm the graphic\nartist!\fShould I print\nyour diploma?",
-          function()
-            local ChoiceBox = require("src.ui.ChoiceBox")
-            game.stack:push(ChoiceBox.new(game, function(yes)
-              if not yes then
-                game.stack:push(TextBox.new(game,
-                  t._CeladonMansion3FGraphicArtistText3
-                  or "Oh. But it's a\nspecial diploma!", done))
-                return
-              end
-              local Printer = require("src.core.Printer")
-              local Diploma = require("src.ui.Diploma")
-              local Strings = require("src.core.Strings")
-              local saved, err = Printer.save("diploma", 160, 144, function()
-                Diploma.render(game)
-              end)
-              -- the PRNT stand-in always reports where the PNG landed
-              game.stack:push(TextBox.new(game, saved
-                and Strings("There you go!\fSaved as\n%s\vin the save\nfolder.", saved)
-                or Strings("Printer error!\n%s", tostring(err)), done))
-            end))
-          end))
+        local TextBox = require("src.render.TextBox")
+        game.stack:push(TextBox.new(game, t[label] or fallback, done))
       end,
     },
   },

data/scripts/flavor/cerulean_badge_house.lua

@@ -35,25 +35,13 @@ local function middleAgedMan(game, ow, npc, done)
     -- .loop: print WhichBadgeText, then show the badge list menu again
     push(game, t._CeruleanBadgeHouseMiddleAgedManWhichBadgeText, function()
       local ListMenu = require("src.ui.ListMenu")
-      local Strings = require("src.core.Strings")
       local items = {}
       for _, id in ipairs(BADGE_ORDER) do
         local idef = game.data.items[id]
         items[#items + 1] = { label = idef and idef.name or id, value = id }
       end
-      -- PrintListMenuEntries prints ListMenuCancelText once it hits the
-      -- list's $FF terminator (home/list_menu.asm), so every
-      -- DisplayListMenuID list ends in an on-screen CANCEL row; picking it
-      -- takes DisplayListMenuIDLoop's ExitListMenu path, the same .done
-      -- exit as B (#569)
-      items[#items + 1] = { label = Strings("CANCEL") }
       local menu = ListMenu.new(game, "", items, {
         onChoose = function(item)
-          game.stack:pop()
-          if not item.value then
-            push(game, t._CeruleanBadgeHouseMiddleAgedManVisitAnyTimeText, done)
-            return
-          end
           push(game, t[BADGE_TEXT[item.value]], loop)
         end,
         onCancel = function()

data/scripts/flavor/cerulean_city.lua

@@ -3,10 +3,6 @@
 -- Both NPCs use text_asm with an hRandomAdd roll to pick one of several
 -- flavor lines (no flags, no branching outcome) -- ported as a weighted
 -- math.random pick each time the NPC is talked to.
---
--- Yellow renames Slowbro -> Electrode in the text labels (see
--- tools/yellow_symbol_aliases.py); look up both so Red/Blue and Yellow
--- share this script.
 
 local M = {}
 
@@ -16,29 +12,6 @@ local function push(game, ow, npc, done, text)
   game.stack:push(TextBox.new(game, text, done))
 end
 
--- CeruleanCitySlowbroText / CeruleanCityElectrodeText
--- cp 180 -> 76/256 chance of 1st; cp 120 -> 60/256 chance of 2nd;
--- cp 60 -> 60/256 chance of 3rd; else 60/256 chance of 4th.
-local function talkMon(game, ow, npc, done)
-  local t = game.data.text
-  local roll = math.random(0, 255)
-  local text
-  if roll >= 180 then
-    text = t._CeruleanCitySlowbroTookASnoozeText
-        or t._CeruleanCityElectrodeTookASnoozeText
-  elseif roll >= 120 then
-    text = t._CeruleanCitySlowbroIsLoafingAroundText
-        or t._CeruleanCityElectrodeIsLoafingAroundText
-  elseif roll >= 60 then
-    text = t._CeruleanCitySlowbroTurnedAwayText
-        or t._CeruleanCityElectrodeTurnedAwayText
-  else
-    text = t._CeruleanCitySlowbroIgnoredOrdersText
-        or t._CeruleanCityElectrodeIgnoredOrdersText
-  end
-  push(game, ow, npc, done, text)
-end
-
 M.CERULEAN_CITY = {
   talk = {
     -- CeruleanCityCooltrainerF1Text (scripts/CeruleanCity.asm:362-393)
@@ -50,20 +23,32 @@ M.CERULEAN_CITY = {
       local text
       if roll >= 180 then
         text = t._CeruleanCityCooltrainerF1SlowbroUseSonicboomText
-            or t._CeruleanCityCooltrainerF1ElectrodeUseSonicboomText
       elseif roll >= 100 then
         text = t._CeruleanCityCooltrainerF1SlowbroPunchText
-            or t._CeruleanCityCooltrainerF1ElectrodePunchText
       else
         text = t._CeruleanCityCooltrainerF1SlowbroWithdrawText
-            or t._CeruleanCityCooltrainerF1ElectrodeWithdrawText
       end
       push(game, ow, npc, done, text)
     end,
 
-    TEXT_CERULEANCITY_SLOWBRO = talkMon,
-    -- Yellow map object uses TEXT_CERULEANCITY_ELECTRODE
-    TEXT_CERULEANCITY_ELECTRODE = talkMon,
+    -- CeruleanCitySlowbroText (scripts/CeruleanCity.asm:395-436)
+    -- cp 180 -> 76/256 chance of 1st; cp 120 -> 60/256 chance of 2nd;
+    -- cp 60 -> 60/256 chance of 3rd; else 60/256 chance of 4th.
+    TEXT_CERULEANCITY_SLOWBRO = function(game, ow, npc, done)
+      local t = game.data.text
+      local roll = math.random(0, 255)
+      local text
+      if roll >= 180 then
+        text = t._CeruleanCitySlowbroTookASnoozeText
+      elseif roll >= 120 then
+        text = t._CeruleanCitySlowbroIsLoafingAroundText
+      elseif roll >= 60 then
+        text = t._CeruleanCitySlowbroTurnedAwayText
+      else
+        text = t._CeruleanCitySlowbroIgnoredOrdersText
+      end
+      push(game, ow, npc, done, text)
+    end,
   },
 }
 

data/scripts/flavor/cerulean_trashed_house.lua

@@ -14,9 +14,9 @@ return {
       --   else               -> .WhatsLostIsLostText (player has TM_DIG)
       TEXT_CERULEANTRASHEDHOUSE_FISHING_GURU = {
         { "check_item", "TM_DIG" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_CeruleanTrashedHouseFishingGuruTheyStoleATMText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_CeruleanTrashedHouseFishingGuruWhatsLostIsLostText" },
       },
     },

data/scripts/flavor/copycats_house_2f.lua

@@ -1,8 +1,9 @@
 -- Flavor talk scripts for CopycatsHouse2F (registry id COPYCATS_HOUSE_2F).
 -- Source: pokered/scripts/CopycatsHouse2F.asm, pokered/text/CopycatsHouse2F.asm
 --
--- TEXT_COPYCATSHOUSE2F_COPYCAT (POKE DOLL -> TM31 MIMIC) lives in
--- data/scripts/story4.lua.
+-- TEXT_COPYCATSHOUSE2F_COPYCAT is already ported (with the POKE DOLL /
+-- TM31 MIMIC trade) in data/scripts/story4.lua, so it is intentionally
+-- omitted here.
 
 return {
   COPYCATS_HOUSE_2F = {

data/scripts/flavor/fuchsia_city.lua

@@ -1,80 +0,0 @@
--- Fuchsia City (pokered/scripts/FuchsiaCity.asm)
---
--- The exhibit signs are text_asm bodies: PrintText of a single text_far,
--- then DisplayPokedex for the exhibited species.  The preview marks the
--- species seen but not owned, same as the S.S. Anne passenger's Snorlax.
---
--- The fossil sign branches on the Mt. Moon fossil events.  The exhibit
--- holds the fossil the player did NOT take: taking the Dome Fossil puts
--- Omanyte on display, taking the Helix Fossil puts Kabuto.  With neither
--- event set the sign only prints its undetermined line and no dex entry
--- opens.
---
--- The other text pointers (city sign, Safari Game signs, mart/center/gym
--- and warden signs, the four NPCs, the exhibited-mon FuchsiaCityPokemonText
--- rows) are plain text_far wrappers that resolve through Data:resolveText,
--- so they are not ported here.
-return {
-  FUCHSIA_CITY = {
-    talk = {
-      -- FuchsiaCityChanseySignText: PrintText(_FuchsiaCityChanseySignText),
-      -- then DisplayPokedex CHANSEY.
-      TEXT_FUCHSIACITY_CHANSEY_SIGN = {
-        { "show_text", "_FuchsiaCityChanseySignText" },
-        { "mark_seen", "CHANSEY" },
-        { "push_screen", "DexEntryMenu", "CHANSEY" },
-      },
-
-      -- FuchsiaCityVoltorbSignText: PrintText(_FuchsiaCityVoltorbSignText),
-      -- then DisplayPokedex VOLTORB.
-      TEXT_FUCHSIACITY_VOLTORB_SIGN = {
-        { "show_text", "_FuchsiaCityVoltorbSignText" },
-        { "mark_seen", "VOLTORB" },
-        { "push_screen", "DexEntryMenu", "VOLTORB" },
-      },
-
-      -- FuchsiaCityKangaskhanSignText: PrintText(_FuchsiaCityKangaskhanSignText),
-      -- then DisplayPokedex KANGASKHAN.
-      TEXT_FUCHSIACITY_KANGASKHAN_SIGN = {
-        { "show_text", "_FuchsiaCityKangaskhanSignText" },
-        { "mark_seen", "KANGASKHAN" },
-        { "push_screen", "DexEntryMenu", "KANGASKHAN" },
-      },
-
-      -- FuchsiaCitySlowpokeSignText: PrintText(_FuchsiaCitySlowpokeSignText),
-      -- then DisplayPokedex SLOWPOKE.
-      TEXT_FUCHSIACITY_SLOWPOKE_SIGN = {
-        { "show_text", "_FuchsiaCitySlowpokeSignText" },
-        { "mark_seen", "SLOWPOKE" },
-        { "push_screen", "DexEntryMenu", "SLOWPOKE" },
-      },
-
-      -- FuchsiaCityLaprasSignText: PrintText(_FuchsiaCityLaprasSignText),
-      -- then DisplayPokedex LAPRAS.
-      TEXT_FUCHSIACITY_LAPRAS_SIGN = {
-        { "show_text", "_FuchsiaCityLaprasSignText" },
-        { "mark_seen", "LAPRAS" },
-        { "push_screen", "DexEntryMenu", "LAPRAS" },
-      },
-
-      -- FuchsiaCityFossilSignText: CheckEvent EVENT_GOT_DOME_FOSSIL /
-      -- CheckEventReuseA EVENT_GOT_HELIX_FOSSIL pick the text and the
-      -- displayed entry; with neither set only the undetermined line prints.
-      TEXT_FUCHSIACITY_FOSSIL_SIGN = {
-        { "check_flag", "EVENT_GOT_DOME_FOSSIL" },                 -- 1
-        { "jump_if_true", 7 },                                     -- 2
-        { "check_flag", "EVENT_GOT_HELIX_FOSSIL" },                -- 3
-        { "jump_if_true", 11 },                                    -- 4
-        { "show_text", "_FuchsiaCityFossilSignUndeterminedText" }, -- 5
-        { "jump", "end" },                                         -- 6
-        { "show_text", "_FuchsiaCityFossilSignOmanyteText" },      -- 7
-        { "mark_seen", "OMANYTE" },                                -- 8
-        { "push_screen", "DexEntryMenu", "OMANYTE" },              -- 9
-        { "jump", "end" },                                         -- 10
-        { "show_text", "_FuchsiaCityFossilSignKabutoText" },       -- 11
-        { "mark_seen", "KABUTO" },                                 -- 12
-        { "push_screen", "DexEntryMenu", "KABUTO" },               -- 13
-      },
-    },
-  },
-}

data/scripts/flavor/game_corner.lua

@@ -85,47 +85,6 @@ return {
         alreadyGotLabel = "_GameCornerGentlemanCloselyWatchTheReelsText",
         alreadyGotFallback = "The trick is to\nwatch the reels\vclosely!",
       }),
-
-      -- Yellow keeps all three giveaways with the same events and amounts
-      -- but renames the objects and their text labels: FISHING_GURU ->
-      -- FISHING_GURU1, CLERK2 -> MIDDLE_AGED_MAN2, GENTLEMAN ->
-      -- FISHING_GURU2 (pokeyellow/scripts/GameCorner.asm).  The Red/Blue
-      -- keys above never match there, so Yellow needs its own three (#552).
-      TEXT_GAMECORNER_FISHING_GURU1 = coinGiver({
-        event = "EVENT_GOT_10_COINS",
-        amount = 10,
-        askLabel = "_GameCornerFishingGuru1WantToPlayText",
-        askFallback = "Kid, do you want\nto play?",
-        receivedLabel = "_GameCornerFishingGuru1Received10CoinsText",
-        coinCaseFullLabel = "_GameCornerFishingGuru1DontNeedMyCoinsText",
-        coinCaseFullFallback = "You don't need my\ncoins!",
-        alreadyGotLabel = "_GameCornerFishingGuru1WinsComeAndGoText",
-        alreadyGotFallback = "Wins seem to come\nand go.",
-      }),
-
-      TEXT_GAMECORNER_MIDDLE_AGED_MAN2 = coinGiver({
-        event = "EVENT_GOT_20_COINS_2",
-        amount = 20,
-        askLabel = "_GameCornerMiddleAgedMan2WantSomeCoinsText",
-        askFallback = "What's up? Want\nsome coins?",
-        receivedLabel = "_GameCornerMiddleAgedMan2Received20CoinsText",
-        coinCaseFullLabel = "_GameCornerMiddleAgedMan2YouHaveLotsOfCoinsText",
-        coinCaseFullFallback = "You have lots of\ncoins!",
-        alreadyGotLabel = "_GameCornerMiddleAgedMan2INeedMoreCoinsText",
-        alreadyGotFallback = "Darn! I need more\ncoins for the\vPOKéMON I want!",
-      }),
-
-      TEXT_GAMECORNER_FISHING_GURU2 = coinGiver({
-        event = "EVENT_GOT_20_COINS",
-        amount = 20,
-        askLabel = "_GameCornerFishingGuru2ThrowingMeOffText",
-        askFallback = "Hey, what? You're\nthrowing me off!\vHere are some\vcoins, shoo!",
-        receivedLabel = "_GameCornerFishingGuru2Received20CoinsText",
-        coinCaseFullLabel = "_GameCornerFishingGuru2YouGotYourOwnCoinsText",
-        coinCaseFullFallback = "You've got your\nown coins!",
-        alreadyGotLabel = "_GameCornerFishingGuru2CloselyWatchTheReelsText",
-        alreadyGotFallback = "The trick is to\nwatch the reels\vclosely!",
-      }),
     },
   },
 }

data/scripts/flavor/lavender_mart.lua

@@ -8,9 +8,9 @@ return {
       TEXT_LAVENDERMART_COOLTRAINER_M = {
         { "face_player" },
         { "check_flag", "EVENT_RESCUED_MR_FUJI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_LavenderMartCooltrainerMReviveText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_LavenderMartCooltrainerMNuggetText" },
       },
     },

data/scripts/flavor/mr_fujis_house.lua

@@ -13,9 +13,9 @@ M.MR_FUJIS_HOUSE = {
     TEXT_MRFUJISHOUSE_SUPER_NERD = {
       { "face_player" },                                                    -- 1
       { "check_flag", "EVENT_RESCUED_MR_FUJI" },                            -- 2
-      { "jump_if_true", 6 },                                                -- 3
+      { "jump_if_true", 5 },                                                -- 3
       { "show_text", "_MrFujisHouseSuperNerdMrFujiIsntHereText" },          -- 4
-      { "jump", "end" },                                                    -- 5
+      { "jump", 6 },                                                        -- 5
       { "show_text", "_MrFujisHouseSuperNerdMrFujiHadBeenPrayingText" },    -- 6
     },
 
@@ -25,9 +25,9 @@ M.MR_FUJIS_HOUSE = {
     TEXT_MRFUJISHOUSE_LITTLE_GIRL = {
       { "face_player" },                                                    -- 1
       { "check_flag", "EVENT_RESCUED_MR_FUJI" },                            -- 2
-      { "jump_if_true", 6 },                                                -- 3
+      { "jump_if_true", 5 },                                                -- 3
       { "show_text", "_MrFujisHouseLittleGirlThisIsMrFujisHouseText" },     -- 4
-      { "jump", "end" },                                                    -- 5
+      { "jump", 6 },                                                        -- 5
       { "show_text", "_MrFujisHouseLittleGirlPokemonAreNiceToHugText" },    -- 6
     },
 

data/scripts/flavor/pewter_nidoran_house.lua

@@ -1,21 +1,13 @@
 -- pokered/scripts/PewterNidoranHouse.asm
 -- PewterNidoranHouseNidoranText: text_far _PewterNidoranHouseNidoranText, then
 -- text_asm plays the NIDORAN_M cry (PlayCry/WaitForSoundToFinish) before ending.
--- play_cry only stashes ctx.pendingCry for the very next show_text row, so it
--- has to sit immediately before that row (src/script/Commands.lua); the cry
--- then sounds once the box has typed out, matching the asm's print-then-cry
--- order.  Its waitForButton form keeps DisplayTextID's trailing
--- WaitForTextScrollButtonPress -- PewterNidoranHouse_Script is
--- `jp EnableAutoTextBoxDrawing`, which zeroes
--- wDoNotWaitForButtonPressAfterDisplayingText -- so the box still holds until
--- A/B.  The cry row was missing, leaving the NIDORAN silent (#247).
+-- No sound-effect command exists in Commands.lua, so we port the dialogue line
+-- only; the cry SFX is cosmetic and has no gameplay effect.
 return {
   PEWTER_NIDORAN_HOUSE = {
     talk = {
       TEXT_PEWTERNIDORANHOUSE_NIDORAN = {
         { "face_player" },
-        -- text_asm: ld a, NIDORAN_M / call PlayCry
-        { "play_cry", "NIDORAN_M", true },
         { "show_text", "_PewterNidoranHouseNidoranText" },
       },
     },

data/scripts/flavor/reds_house_2f.lua

@@ -1,22 +0,0 @@
--- Red's House 2F (pokered data/events/hidden_events.asm +
--- engine/events/hidden_objects PrintRedSNESText).
---
--- The bedroom SNES is a hidden_event at (3, 5) with ANY_FACING that
--- prints _RedBedroomSNESText.  field.py extracts OpenRedsPC on this map
--- but skips PrintRedSNESText, so interaction was a no-op (#135).
-
-local TextBox = require("src.render.TextBox")
-
-return {
-  REDS_HOUSE_2F = {
-    -- hidden_events.asm:
-    --   hidden_event 3, 5, PrintRedSNESText, ANY_FACING
-    onInteract = function(game, ow, fx, fy)
-      if fx ~= 3 or fy ~= 5 then return false end
-      local text = game.data.text._RedBedroomSNESText
-        or "{PLAYER} is\nplaying the SNES!"
-      game.stack:push(TextBox.new(game, text))
-      return true
-    end,
-  },
-}

data/scripts/flavor/route_16_gate_1f.lua

@@ -12,9 +12,9 @@ return {
       TEXT_ROUTE16GATE1F_GUARD = {
         { "face_player" },
         { "check_item", "BICYCLE" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_Route16Gate1FGuardNoPedestriansAllowedText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_Route16Gate1FGuardCyclingRoadExplanationText" },
       },
     },

data/scripts/flavor/route_18_gate_1f.lua

@@ -14,9 +14,9 @@ return {
       TEXT_ROUTE18GATE1F_GUARD = {
         { "face_player" },
         { "check_item", "BICYCLE" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_Route18Gate1FGuardYouNeedABicycleText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_Route18Gate1FGuardCyclingRoadUphillText" },
       },
     },

data/scripts/flavor/route_23.lua

@@ -28,29 +28,7 @@ local function badgeGuard(badge, passFlag)
   }
 end
 
--- Route23SetVictoryRoadBoulders (pokered scripts/Route23.asm:8): every entry
--- to Route 23 resets the Victory Road boulder puzzle behind you.  The 2F/3F
--- switch events clear (so those barriers are closed again on the next floor
--- load) and the boulder that fell through 3F's hole goes back upstairs:
--- ShowObject TOGGLE_VICTORY_ROAD_3F_BOULDER / HideObject
--- TOGGLE_VICTORY_ROAD_2F_BOULDER, which are VICTORYROAD3F_BOULDER4 and
--- VICTORYROAD2F_BOULDER3 (data/maps/toggleable_objects.asm).  1F's event is
--- reset by the Indigo Plateau lobby and by Victory Road 2F, not here.  This
--- is what makes the puzzle "completely reset" on a return trip (#258).
--- onEnter is the port's BIT_CUR_MAP_LOADED_2 equivalent: setMap runs it on
--- every map entry, connection crossings included, like EnterMap.
 M.ROUTE_23 = {
-  onEnter = function(game, ow)
-    local f = game.save.flags
-    f.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH1 = nil
-    f.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2 = nil
-    f.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1 = nil
-    f.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH2 = nil
-    local Commands = require("src.script.Commands")
-    local ctx = { save = game.save, overworld = ow, game = game }
-    Commands.show_object(ctx, "VICTORY_ROAD_3F", "VICTORYROAD3F_BOULDER4")
-    Commands.hide_object(ctx, "VICTORY_ROAD_2F", "VICTORYROAD2F_BOULDER3")
-  end,
   talk = {
     -- Route23Guard1Text: EventFlagBit ..., EVENT_PASSED_EARTHBADGE_CHECK
     -- -> wWhichBadge = EARTHBADGE

data/scripts/flavor/silph_co_10f.lua

@@ -12,9 +12,9 @@ return {
       TEXT_SILPHCO10F_SILPH_WORKER_F = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo10FSilphWorkerFImScaredText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo10FSilphWorkerFQuietAboutMyCryingText" },
       },
     },

data/scripts/flavor/silph_co_3f.lua

@@ -10,9 +10,9 @@ return {
       --   not set: _SilphCo3FSilphWorkerMWhatShouldIDoText
       TEXT_SILPHCO3F_SILPH_WORKER_M = {
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_SilphCo3FSilphWorkerMWhatShouldIDoText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_SilphCo3FSilphWorkerMYouSavedUsText" },
       },
     },

data/scripts/flavor/silph_co_4f.lua

@@ -7,9 +7,9 @@ return {
       TEXT_SILPHCO4F_SILPH_WORKER_M = {
         {"face_player"},
         {"check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI"},
-        {"jump_if_true", 6},
+        {"jump_if_true", 5},
         {"show_text", "_SilphCo4FSilphWorkerMImHidingText"},
-        {"jump", "end"},
+        {"jump", 6},
         {"show_text", "_SilphCo4FSilphWorkerMTeamRocketIsGoneText"},
       },
     },

data/scripts/flavor/silph_co_5f.lua

@@ -7,9 +7,9 @@ return {
       TEXT_SILPHCO5F_SILPH_WORKER_M = {
         {"face_player"},
         {"check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI"},
-        {"jump_if_true", 6},
+        {"jump_if_true", 5},
         {"show_text", "_SilphCo5FSilphWorkerMThatsYouRightText"},
-        {"jump", "end"},
+        {"jump", 6},
         {"show_text", "_SilphCo5FSilphWorkerMYoureOurHeroText"},
       },
     },

data/scripts/flavor/silph_co_6f.lua

@@ -11,9 +11,9 @@ return {
       TEXT_SILPHCO6F_SILPH_WORKER_M1 = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo6FSilphWorkerM1TookOverTheBuildingText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo6FSilphWorkerM1BackToWorkText" },
       },
 
@@ -21,9 +21,9 @@ return {
       TEXT_SILPHCO6F_SILPH_WORKER_M2 = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo6FSilphWorkerMHelpMePleaseText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo6FSilphWorkerMWeGotEngagedText" },
       },
 
@@ -31,9 +31,9 @@ return {
       TEXT_SILPHCO6F_SILPH_WORKER_F1 = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo6FSilphWorkerF1SuchACowardText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo6FSilphWorkerF1HaveToMarryHimText" },
       },
 
@@ -41,9 +41,9 @@ return {
       TEXT_SILPHCO6F_SILPH_WORKER_F2 = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo6FSilphWorkerF2TeamRocketConquerWorldText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo6FSilphWorkerF2TeamRocketRanText" },
       },
 
@@ -51,9 +51,9 @@ return {
       TEXT_SILPHCO6F_SILPH_WORKER_M3 = {
         { "face_player" },
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 6 },
+        { "jump_if_true", 5 },
         { "show_text", "_SilphCo6FSilphWorkerM3TargetedSilphText" },
-        { "jump", "end" },
+        { "jump", 6 },
         { "show_text", "_SilphCo6FSilphWorkerM3WorkForSilphText" },
       },
     },

data/scripts/flavor/silph_co_7f.lua

@@ -10,9 +10,9 @@ return {
       --   set: _SilphCo7FSilphWorkerM2CancelledMasterBallText
       TEXT_SILPHCO7F_SILPH_WORKER_M2 = {
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_SilphCo7FSilphWorkerM2AfterTheMasterBallText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_SilphCo7FSilphWorkerM2CancelledMasterBallText" },
       },
 
@@ -22,9 +22,9 @@ return {
       --   set: _SilphCo7FSilphWorkerM3YouChasedOffTeamRocketText
       TEXT_SILPHCO7F_SILPH_WORKER_M3 = {
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_SilphCo7FSilphWorkerM3ItWouldBeBadText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_SilphCo7FSilphWorkerM3YouChasedOffTeamRocketText" },
       },
 
@@ -34,9 +34,9 @@ return {
       --   set: _SilphCo7FSilphWorkerM4SafeAtLastText
       TEXT_SILPHCO7F_SILPH_WORKER_M4 = {
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_SilphCo7FSilphWorkerM4ItsReallyDangerousHereText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_SilphCo7FSilphWorkerM4SafeAtLastText" },
       },
     },

data/scripts/flavor/silph_co_8f.lua

@@ -10,9 +10,9 @@ return {
       --   set: _SilphCo8FSilphWorkerMThanksForSavingUsText
       TEXT_SILPHCO8F_SILPH_WORKER_M = {
         { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },
-        { "jump_if_true", 5 },
+        { "jump_if_true", 4 },
         { "show_text", "_SilphCo8FSilphWorkerMSilphIsFinishedText" },
-        { "jump", "end" },
+        { "jump", 5 },
         { "show_text", "_SilphCo8FSilphWorkerMThanksForSavingUsText" },
       },
     },

data/scripts/flavor/ss_anne_2f_rooms.lua

@@ -7,19 +7,19 @@
 -- CheckFightingMapTrainers/TalkToTrainer via the existing trainer
 -- system, and the item pickups carry no talk text of their own here.
 --
--- TEXT_SSANNE2FROOMS_GENTLEMAN3 opens SNORLAX's POKéDEX entry after its
--- text box, like DisplayPokedex in the original. The preview marks it seen
--- but does not mark it owned.
+-- TEXT_SSANNE2FROOMS_GENTLEMAN3 also opens the POKéDEX entry for
+-- SNORLAX after the text box (DisplayPokedex in the original), which
+-- has no equivalent talk-script hook in this port (DexEntryMenu has
+-- no done-callback the way other pushed UI states do) -- only the
+-- flavor line is ported here.
 return {
   SS_ANNE_2F_ROOMS = {
     talk = {
-      -- SSAnne2FRoomsGentleman3Text: PrintText(_SSAnne2FRoomsGentleman3Text),
-      -- then DisplayPokedex SNORLAX.
+      -- SSAnne2FRoomsGentleman3Text: PrintText(_SSAnne2FRoomsGentleman3Text)
+      -- (then DisplayPokedex SNORLAX -- not ported, see note above)
       TEXT_SSANNE2FROOMS_GENTLEMAN3 = {
         { "face_player" },
         { "show_text", "_SSAnne2FRoomsGentleman3Text" },
-        { "mark_seen", "SNORLAX" },
-        { "push_screen", "DexEntryMenu", "SNORLAX" },
       },
 
       -- SSAnne2FRoomsGentleman4Text: PrintText(_SSAnne2FRoomsGentleman4Text)

data/scripts/flavor/viridian_city.lua

@@ -59,17 +59,13 @@ M.VIRIDIAN_CITY = {
     -- ViridianCityYoungster2CaterpieAndWeedleDescriptionText are
     -- defined without a leading underscore in pokered/text/ViridianCity.asm
     -- and aren't present in data/generated/text.lua, so we fall back to
-    -- the literal strings from pokered.  Those fallbacks have to carry the
-    -- extractor's markers, not plain newlines: line -> \n, cont -> \v,
-    -- para -> \f.  Spelling cont/para as \n and \n\n put all six lines on
-    -- one page with nothing to wait on, so the whole speech scrolled past
-    -- without a button press (#250).
+    -- the literal strings from pokered.
     TEXT_VIRIDIANCITY_YOUNGSTER2 = function(game, ow, npc, done)
       local t = text(game)
       ask(game, t._ViridianCityYoungster2YouWantToKnowAboutText
-        or "You want to know\nabout the 2 kinds\vof caterpillar\vPOKéMON?", function(yes)
+        or "You want to know\nabout the 2 kinds\nof caterpillar\nPOKéMON?", function(yes)
         if yes then
-          push(game, "CATERPIE has no\npoison, but\vWEEDLE does.\fWatch out for its\nPOISON STING!", done)
+          push(game, "CATERPIE has no\npoison, but\nWEEDLE does.\n\nWatch out for its\nPOISON STING!", done)
         else
           push(game, "Oh, OK then!", done)
         end

data/scripts/flavor/viridian_nickname_house.lua

@@ -3,16 +3,12 @@
 return {
   VIRIDIAN_NICKNAME_HOUSE = {
     talk = {
-      -- ViridianNicknameHouseSpearowText: text_asm that PrintTexts the
-      -- line, then plays the SPEAROW cry (PlayCry/WaitForSoundToFinish)
-      -- before TextScriptEnd.  play_cry only arms the show_text row that
-      -- follows it, so the cry sounds once the box has typed out; its
-      -- waitForButton form keeps DisplayTextID's trailing
-      -- WaitForTextScrollButtonPress, so the box then holds until A/B like
-      -- any other NPC line rather than popping itself (#251).
+      -- ViridianNicknameHouseSpearowText: text_asm that shows the text
+      -- then plays a SPEAROW cry (PlayCry/WaitForSoundToFinish). The
+      -- cry playback isn't in the talk-script command vocabulary, so
+      -- only the flavor line is ported here.
       TEXT_VIRIDIANNICKNAMEHOUSE_SPEAROW = {
-        { "play_cry", "SPEAROW", true },                      -- 1 PlayCry
-        { "show_text", "_ViridianNicknameHouseSpearowText" }, -- 2 PrintText
+        { "show_text", "_ViridianNicknameHouseSpearowText" },
       },
     },
   },

data/scripts/flavor/viridian_school_house.lua

@@ -1,175 +0,0 @@
--- Viridian School House's two readables (data/events/hidden_events.asm,
--- hidden_events_for VIRIDIAN_SCHOOL_HOUSE):
---   hidden_text_predef 3, 0  PrintBlackboardLinkCableText, ViridianSchoolBlackboard
---   hidden_text_predef 3, 4  PrintNotebookText, ViridianSchoolNotebook
--- tools/extract/field.py only parses `hidden_event` rows, so neither
--- hidden_text_predef row reaches data/generated/field.lua and both tiles
--- were dead A presses (#503).  Same hook shape, and the same sibling asm
--- file, as the Celadon roof house in data/scripts/celadon_eevee.lua (#391);
--- hidden_text_predef spends the facing byte on the tx_pre id, so neither
--- tile gates on facing.
-
-local Font = require("src.render.Font")
-local Theme = require("src.ui.Theme")
-local TextBox = require("src.render.TextBox")
-
--- ViridianSchoolBlackboard (engine/events/hidden_events/school_blackboard.asm):
--- StatusAilmentText1/2 are the two columns of the 12x8 box at the top left
--- (hlcoord 0, 0 + `lb bc, 6, 10`); picking a status prints its
--- ViridianBlackboardStatusPointers entry and jumps back to .blackboardLoop,
--- QUIT or B falls through to .exitBlackboard.
-local STATUS_LABELS = {
-  { " SLP", "_ViridianBlackboardSleepText" },
-  { " PSN", "_ViridianBlackboardPoisonText" },
-  { " PAR", "_ViridianBlackboardPrlzText" },
-  { " BRN", "_ViridianBlackboardBurnText" },
-  { " FRZ", "_ViridianBlackboardFrozenText" },
-}
-
--- The headings list is a two-column menu, which src/ui/Menu.lua does not do
--- (it stacks one column), so the layout lives here (#591).  .blackboardLoop:
--- TextBoxBorder at hlcoord 0, 0 with `lb bc, 6, 10` is the 12x8 box,
--- StatusAilmentText1 (" SLP"/" PSN"/" PAR") is placed at hlcoord 1, 2 and
--- StatusAilmentText2 (" BRN"/" FRZ"/" QUIT") at hlcoord 6, 2.  LEFT/RIGHT
--- move wTopMenuItemX between those two columns and swap wMenuItemOffset
--- between 0 and 3 while leaving wCurrentMenuItem (the row) alone; UP/DOWN
--- are not in wMenuWatchedKeys, so they only slide the cursor and loop.
-local BOARD_LABELS = {}
-for i, row in ipairs(STATUS_LABELS) do BOARD_LABELS[i] = row[1] end
-BOARD_LABELS[#BOARD_LABELS + 1] = " QUIT"
-local BOARD_COL_X = { 1, 6 }
-local BOARD_ROW_Y = 2
-local BOARD_ROWS = 3
-
-local StatusBoard = {}
-StatusBoard.__index = StatusBoard
-
-function StatusBoard.new(game, onPick, onQuit)
-  return setmetatable({ game = game, col = 1, row = 1, labels = BOARD_LABELS,
-                        onPick = onPick, onQuit = onQuit }, StatusBoard)
-end
-
--- flat index = pokered's wMenuItemOffset (0 or 3) + wCurrentMenuItem (0..2),
--- so 1..5 are the statuses in ViridianBlackboardStatusPointers order and 6
--- is QUIT
-function StatusBoard:selection()
-  return (self.col - 1) * BOARD_ROWS + self.row
-end
-
-function StatusBoard:update()
-  local input = self.game.input
-  if input:wasPressed("up") then
-    -- wMenuWrappingEnabled is never set here, so both ends are hard stops
-    if self.row > 1 then self.row = self.row - 1 end
-  elseif input:wasPressed("down") then
-    if self.row < BOARD_ROWS then self.row = self.row + 1 end
-  elseif input:wasPressed("left") then
-    self.col = 1
-  elseif input:wasPressed("right") then
-    self.col = 2
-  elseif input:wasPressed("a") or input:wasPressed("b") then
-    -- HandleMenuInput_ (home/window.asm) beeps for the PAD_A | PAD_B branch,
-    -- and B and QUIT share .exitBlackboard
-    require("src.core.Sound").play(self.game.data, "Press_AB")
-    local sel = self:selection()
-    if input:wasPressed("b") or sel > #STATUS_LABELS then
-      self.onQuit()
-    else
-      self.onPick(sel)
-    end
-  end
-end
-
-function StatusBoard:draw()
-  Font.drawBox(0, 0, 12, 8)
-  love.graphics.setColor(0, 0, 0, 1)
-  for i, label in ipairs(BOARD_LABELS) do
-    local col = i <= BOARD_ROWS and 1 or 2
-    local row = i - (col - 1) * BOARD_ROWS
-    Font.draw(label, BOARD_COL_X[col] * 8, (BOARD_ROW_Y + row - 1) * 8)
-  end
-  -- wTopMenuItemX equals the column PlaceString started at, so the cursor
-  -- covers the blank each label leads with
-  Font.drawCode(Theme.cursor, BOARD_COL_X[self.col] * 8,
-                (BOARD_ROW_Y + self.row - 1) * 8)
-  love.graphics.setColor(1, 1, 1, 1)
-end
-
-local function blackboard(game)
-  local text = game.data.text or {}
-  local openBoard
-  -- wCurrentMenuItem / wMenuItemOffset are zeroed once, above .blackboardLoop,
-  -- and nothing inside the loop clears them again: after a status blurb
-  -- `jp .blackboardLoop` comes back with the cursor still on the row and
-  -- column the player just picked.  One StatusBoard lives for the whole
-  -- reading and is re-pushed each pass, so only entering the blackboard
-  -- resets to the left column / top row (#591).
-  local board
-  -- .blackboardLoop reprints ViridianSchoolBlackboardText2 and only then
-  -- calls HandleMenuInput, so the prompt is on screen for exactly as long as
-  -- the headings list is.  That text ends in `done`, not `prompt`
-  -- (data/text/text_2.asm:646), so PrintText returns with the box still up
-  -- and never waits for a button: TextBox opts.stay holds it open under the
-  -- list and these callbacks pop the pair together (#591).
-  local function closeBoard()
-    game.stack:pop() -- the headings list
-    game.stack:pop() -- the held "Which heading" box under it
-  end
-  local function pick(i)
-    closeBoard()
-    game.stack:push(TextBox.new(game,
-      text[STATUS_LABELS[i][2]] or STATUS_LABELS[i][1], openBoard))
-  end
-  function openBoard()
-    game.stack:push(TextBox.new(game,
-      text._ViridianSchoolBlackboardText2 or "Which heading do\nyou want to read?",
-      nil, { stay = { onShown = function()
-        board = board or StatusBoard.new(game, pick, closeBoard)
-        game.stack:push(board)
-      end } }))
-  end
-  game.stack:push(TextBox.new(game,
-    text._ViridianSchoolBlackboardText1
-      or "The blackboard\ndescribes POKéMON\vSTATUS changes\vduring battles.",
-    openBoard))
-end
-
--- ViridianSchoolNotebook (engine/events/hidden_events/school_notebooks.asm):
--- pages 1-3 each end in TurnPageSchoolNotebook (TurnPageText + YesNoChoice)
--- and NO stops the read; page 4 turns without asking and runs straight into
--- page 5, the girl catching you at it.
-local function notebook(game)
-  local text = game.data.text or {}
-  local function page(n, after)
-    return TextBox.new(game, text["_ViridianSchoolNotebookText" .. n] or "", after)
-  end
-  local function turnPage(nextPage)
-    return function()
-      game.stack:push(TextBox.new(game, text._TurnPageText or "Turn the page?",
-        nil, { choice = function(yes)
-          if yes then game.stack:push(nextPage()) end
-        end }))
-    end
-  end
-  local function page5() return page(5) end
-  local function page4() return page(4, function() game.stack:push(page5()) end) end
-  local function page3() return page(3, turnPage(page4)) end
-  local function page2() return page(2, turnPage(page3)) end
-  game.stack:push(page(1, turnPage(page2)))
-end
-
-return {
-  VIRIDIAN_SCHOOL_HOUSE = {
-    onInteract = function(game, ow, fx, fy)
-      if fx == 3 and fy == 0 then
-        blackboard(game)
-        return true
-      end
-      if fx == 3 and fy == 4 then
-        notebook(game)
-        return true
-      end
-      return false
-    end,
-  },
-}

data/scripts/flavor_all.lua

@@ -15,7 +15,6 @@ local files = {
   "data.scripts.flavor.cerulean_trashed_house",
   "data.scripts.flavor.copycats_house_1f",
   "data.scripts.flavor.copycats_house_2f",
-  "data.scripts.flavor.fuchsia_city",
   "data.scripts.flavor.game_corner",
   "data.scripts.flavor.lavender_cubone_house",
   "data.scripts.flavor.lavender_mart",
@@ -29,7 +28,6 @@ local files = {
   "data.scripts.flavor.pokemon_fan_club",
   "data.scripts.flavor.power_plant",
   "data.scripts.flavor.reds_house_1f",
-  "data.scripts.flavor.reds_house_2f",
   "data.scripts.flavor.route11_gate_2f",
   "data.scripts.flavor.route18_gate_2f",
   "data.scripts.flavor.route_12_gate_2f",
@@ -61,7 +59,6 @@ local files = {
   "data.scripts.flavor.victory_road_2f",
   "data.scripts.flavor.viridian_city",
   "data.scripts.flavor.viridian_nickname_house",
-  "data.scripts.flavor.viridian_school_house", -- #503
   "data.scripts.flavor.wardens_house",
 }
 

data/scripts/init.lua

@@ -12,18 +12,11 @@
 -- different files can each add NPCs to the same map), and mod
 -- contributions from the map_scripts registry compose on top of it.
 
-local GameVersion = require("src.core.GameVersion")
 local MapScripts = require("src.script.MapScripts")
 
--- OaksLab is a full Yellow rewrite (one Eevee ball + forced Pikachu);
--- Red/Blue keep the three-starter choose flow.
-local oaksLab = GameVersion.isYellow()
-  and "data.scripts.oaks_lab_yellow"
-  or "data.scripts.oaks_lab"
-
 for _, mapEntry in ipairs({
   { "PALLET_TOWN", "data.scripts.pallet_town" },
-  { "OAKS_LAB", oaksLab },
+  { "OAKS_LAB", "data.scripts.oaks_lab" },
   { "REDS_HOUSE_1F", "data.scripts.reds_house" },
   { "CELADON_MANSION_ROOF_HOUSE", "data.scripts.celadon_eevee" },
 }) do
@@ -43,19 +36,6 @@ for _, file in ipairs({ "data.scripts.story", "data.scripts.story2",
   end
 end
 
--- Yellow-only content on top of the shared tables (talk keys merge per
--- TEXT constant): the Kanto-starter gift quests and Jessie & James.
-if GameVersion.isYellow() then
-  for _, file in ipairs({ "data.scripts.yellow_gifts",
-                          "data.scripts.yellow_jessie_james",
-                          "data.scripts.yellow_beach_house",
-                          "data.scripts.yellow_viridian_old_man" }) do
-    for mapId, mod in pairs(require(file)) do
-      MapScripts.attachBase(mapId, mod)
-    end
-  end
-end
-
 local M = {}
 
 function M.get(mapId)

data/scripts/oaks_lab.lua

@@ -6,10 +6,7 @@
 --   takes it ("I'll take this one, then!") and both balls disappear.
 --   Source: scripts/OaksLab.asm OaksLabCharmanderPokeBallText /
 --   OaksLabRivalTakePokeBallScript.
--- * Leftover ball (after the pick): Oak turns and reads the last-mon
---   line instead of re-offering the starter (OaksLabLastMonScript, #601).
--- * Rival (object 1): before starter -> "go ahead and choose" once Oak
---   has walked you in, else "gramps isn't around" (#218); with
+-- * Rival (object 1): before starter -> "gramps isn't around"; with
 --   starter -> taunt + battle OPP_RIVAL1 with the counter-pick party
 --   (player Bulbasaur -> rival Charmander etc., parties 1/2/3 =
 --   Squirtle/Bulbasaur/Charmander in data/trainers/parties.asm);
@@ -22,10 +19,10 @@ local function starterBall(askText, species, choseFlag, ownBall,
                            rivalBallX, rivalBall)
   return {
     { "check_flag", "EVENT_GOT_STARTER" },        -- 1
-    { "jump_if_true", 22 },                       -- 2
+    { "jump_if_true", 20 },                       -- 2
     -- no picking until Oak has walked you in (OaksLabScript gating)
     { "check_flag", "EVENT_FOLLOWED_OAK_INTO_LAB" }, -- 3
-    { "jump_if_false", 25 },                      -- 4
+    { "jump_if_false", 20 },                      -- 4
     -- the Pokédex "new species" entry shows before the ask (predef
     -- StarterDex ahead of OaksLabYouWant...Text).  StarterDex temporarily
     -- sets the owned bits so ShowPokedexData prints height/weight/text;
@@ -33,161 +30,78 @@ local function starterBall(askText, species, choseFlag, ownBall,
     { "push_screen", "DexEntryMenu",
       { species = species, forceOwned = true } }, -- 5
     { "ask", askText },                           -- 6
-    { "jump_if_false", "end" },                   -- 7
-    -- OaksLab.asm prints ReceivedMon then AddPartyMon (AskName lives
-    -- inside give_pokemon).  Show the received text first so the
-    -- nickname prompt follows "you got X", matching Gen1.
-    -- The received text carries sound_get_key_item (OaksLab.asm
-    -- OaksLabReceivedMonText); the jingle plays as the box opens
-    -- (same beat as the Yellow port's starter, #668).
-    { "play_sound", "Get_Key_Item" },                              -- 8
-    { "show_text", "_OaksLabReceivedMonText", { RAM = species } }, -- 9
-    { "give_pokemon", species, 5 },               -- 10
-    { "set_flag", "EVENT_GOT_STARTER" },          -- 11
-    { "set_flag", choseFlag },                    -- 12
+    { "jump_if_false", 21 },                      -- 7
+    { "give_pokemon", species, 5 },               -- 8
+    { "set_flag", "EVENT_GOT_STARTER" },          -- 9
+    { "set_flag", choseFlag },                    -- 10
     -- POKé BALLs are not handed out here in the original -- Oak gives
     -- them later, at OaksLabOak1Text's .give_poke_balls beat once the
     -- player has beaten the Route 22 rival (see TEXT_OAKSLAB_OAK1 below)
-    { "hide_object", "OAKS_LAB", ownBall },       -- 13
+    { "show_text", "_OaksLabReceivedMonText", { RAM = species } }, -- 11
+    { "hide_object", "OAKS_LAB", ownBall },       -- 12
     -- the rival walks to the countering ball (around the furniture)
-    { "move_npc_to", 1, rivalBallX, 4 },          -- 14
-    { "face_object", 1, "up" },                   -- 15
-    { "show_text", "_OaksLabRivalIllTakeThisOneText" },            -- 16
-    { "hide_object", "OAKS_LAB", rivalBall },     -- 17
-    { "play_sound", "Get_Key_Item" },             -- 18 (sound_get_key_item)
+    { "move_npc_to", 1, rivalBallX, 4 },          -- 13
+    { "face_object", 1, "up" },                   -- 14
+    { "show_text", "_OaksLabRivalIllTakeThisOneText" },            -- 15
+    { "hide_object", "OAKS_LAB", rivalBall },     -- 16
     { "show_text", "_OaksLabRivalReceivedMonText",
       { RAM = rivalBall == "OAKSLAB_CHARMANDER_POKE_BALL" and "CHARMANDER"
               or rivalBall == "OAKSLAB_SQUIRTLE_POKE_BALL" and "SQUIRTLE"
-              or "BULBASAUR" } },                 -- 19
-    { "jump", "end" },                            -- 20
-    { "jump", "end" },                            -- 21 (spacer)
-    -- a leftover ball after the player's pick: Oak turns to face the
-    -- player and reads the last-mon line instead of re-offering the
-    -- starter (scripts/OaksLab.asm OaksLabSelectedPokeBallScript ->
-    -- OaksLabLastMonScript; #601).  The ROM's "#MON" ligature is spelled
-    -- out as Pokémon here.
-    { "face_object", 5, "down" },                 -- 22
-    { "show_text", "That's PROF.OAK's\nlast Pokémon!" }, -- 23
-    -- OaksLabLastMonScript ends at TextScriptEnd; the port used to fall
-    -- through into the pre-pick line below (#601 remnant, reported on #600)
-    { "jump", "end" },                            -- 24
-    { "show_text", "_OaksLabThoseArePokeBallsText" }, -- 25
+              or "BULBASAUR" } },                 -- 17
+    { "jump", 21 },                               -- 18
+    { "jump", 21 },                               -- 19 (spacer)
+    { "show_text", "_OaksLabThoseArePokeBallsText" }, -- 20
   }
 end
 
 return {
   talk = {
-    -- Oak: OaksLabOak1Text.  Parcel delivery kicks SCRIPT_OAKSLAB_RIVAL_
-    -- ARRIVES_AT_OAKS_REQUEST + OaksLabOakGivesPokedexScript (rival walk-
-    -- in, full Pokédex speech, rival exit, Route 22 arm).
+    -- Oak: accepts the parcel and hands over the Pokédex, then (once the
+    -- player has beaten the Route 22 rival) hands over the real POKé
+    -- BALLs (scripts/OaksLab.asm OaksLabOak1Text, simplified: no rival
+    -- recall / dex-rating / "pokemon can fight" / "around the world"
+    -- branches -- see docs/known-differences.md)
     TEXT_OAKSLAB_OAK1 = {
-      { "face_player" },
-      -- OaksLabOak1Text leads with the dex-rating branch (#600): with
-      -- EVENT_PALLET_AFTER_GETTING_POKEBALLS set (converted saves), or
-      -- 2+ species owned once the Pokédex is in hand, Oak asks how it is
-      -- coming and rates it (predef DisplayDexRating).  Red keeps the
-      -- GOT_POKEDEX gate that Yellow's copy of this text drops
-      -- (data/scripts/oaks_lab_yellow.lua).
-      { "check_flag", "EVENT_PALLET_AFTER_GETTING_POKEBALLS" },
-      { "jump_if_true", "dex_rating" },
-      { "check_dex_owned", 2 },
-      { "jump_if_false", "no_rating" },
-      { "check_flag", "EVENT_GOT_POKEDEX" },
-      { "jump_if_true", "dex_rating" },
-      { "label", "no_rating" },
-      { "check_item", "POKE_BALL" },
-      { "jump_if_true", "come_see" },
-      { "check_flag", "EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE" },
-      { "jump_if_true", "give_balls" },
-      { "check_flag", "EVENT_GOT_POKEDEX" },
-      { "jump_if_true", "around_world" },
-      { "check_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" },
-      { "jump_if_false", "pre_lab_battle" },
-      { "check_item", "OAKS_PARCEL" },
-      { "jump_if_false", "raise_young" },
-      -- OaksLabOak1Text.got_parcel → RivalArrives + OakGivesPokedex
-      { "show_text", "_OaksLabOak1DeliverParcelText" },
-      { "play_sound", "Get_Key_Item" },
-      { "show_text", "_OaksLabOak1ParcelThanksText" },
-      { "take_item", "OAKS_PARCEL", 1 },
-      { "stop_music" },
-      { "play_music", "Music_MeetRival" },
-      { "show_text", "_OaksLabRivalGrampsText" },
-      { "show_object", "OAKS_LAB", "OAKSLAB_RIVAL" },
-      -- OaksLabCalcRivalMovementScript: sprite map (8,11) → cell (4,7)
-      -- when the player stands below Oak (the usual desk talk).
-      { "place_npc", 1, 4, 7, "up" },
-      { "move_npc_to", 1, 4, 3 },
-      { "play_music", "Music_OaksLab" },
-      { "face_object", 1, "up" },
-      { "face_object", 5, "down" },
-      { "show_text", "_OaksLabRivalWhatDidYouCallMeForText" },
-      { "face_object", 1, "up" },
-      { "face_object", 5, "down" },
-      { "show_text", "_OaksLabOakIHaveARequestText" },
-      { "face_object", 1, "up" },
-      { "face_object", 5, "down" },
-      { "show_text", "_OaksLabOakMyInventionPokedexText" },
-      { "show_text", "_OaksLabOakGotPokedexText" },
-      { "play_sound", "Get_Key_Item" },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX1" },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX2" },
-      { "face_object", 1, "up" },
-      { "face_object", 5, "down" },
-      { "show_text", "_OaksLabOakThatWasMyDreamText" },
-      { "face_object", 1, "right" },
-      { "show_text", "_OaksLabRivalLeaveItAllToMeText" },
-      { "set_flag", "EVENT_GOT_POKEDEX" },
-      { "set_flag", "EVENT_OAK_GOT_PARCEL" },
-      { "hide_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN_SLEEPY" },
-      { "show_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN" },
-      { "stop_music" },
-      { "play_music", "Music_MeetRival" },
-      { "move_npc_to", 1, 4, 7 },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_RIVAL" },
-      { "play_music", "Music_OaksLab" },
-      { "set_flag", "EVENT_1ST_ROUTE22_RIVAL_BATTLE" },
-      { "clear_flag", "EVENT_2ND_ROUTE22_RIVAL_BATTLE" },
-      { "set_flag", "EVENT_ROUTE22_RIVAL_WANTS_BATTLE" },
-      { "show_object", "ROUTE_22", "ROUTE22_RIVAL1" },
-      { "jump", "end" },
-
-      { "label", "raise_young" },
-      { "show_text", "_OaksLabOak1RaiseYourYoungPokemonText" },
-      { "jump", "end" },
-
-      { "label", "pre_lab_battle" },
-      { "check_flag", "EVENT_GOT_STARTER" },
-      { "jump_if_true", "can_fight" },
-      { "show_text", "_OaksLabOak1WhichPokemonDoYouWantText" },
-      { "jump", "end" },
-      { "label", "can_fight" },
-      { "show_text", "_OaksLabOak1YourPokemonCanFightText" },
-      { "jump", "end" },
-
-      { "label", "around_world" },
-      { "show_text", "_OaksLabOak1PokemonAroundTheWorldText" },
-      { "jump", "end" },
-
-      { "label", "give_balls" },
-      { "check_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },
-      { "jump_if_true", "come_see" },
-      { "set_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },
-      { "give_item", "POKE_BALL", 5, false },
-      { "show_text", "_OaksLabOak1ReceivedPokeballsText" },
-      { "show_text", "_OaksLabGivePokeballsExplanationText" },
-      { "jump", "end" },
-
-      { "label", "come_see" },
-      { "show_text", "_OaksLabOak1ComeSeeMeSometimesText" },
-      { "jump", "end" },
-
-      -- .HowIsYourPokedexComingText ends on `prompt` and OaksLabOak1Text
-      -- sets wDoNotWaitForButtonPressAfterDisplayingText, so the seen/owned
-      -- tally follows with no button wait (engine/events/pokedex_rating.asm)
-      { "label", "dex_rating" },
-      { "show_text", "_OaksLabOak1HowIsYourPokedexComingText" },
-      { "dex_rating" },
+      { "face_player" },                                          -- 1
+      { "check_flag", "EVENT_GOT_OAKS_PARCEL" },                  -- 2
+      { "jump_if_false", 16 },                                    -- 3
+      { "check_flag", "EVENT_OAK_GOT_PARCEL" },                   -- 4
+      { "jump_if_true", 16 },                                     -- 5
+      { "show_text", "_OaksLabOak1DeliverParcelText" },           -- 6
+      { "take_item", "OAKS_PARCEL", 1 },                          -- 7
+      { "set_flag", "EVENT_OAK_GOT_PARCEL" },                     -- 8
+      { "show_text", "_OaksLabOak1PokemonAroundTheWorldText" },   -- 9
+      { "set_flag", "EVENT_GOT_POKEDEX" },                        -- 10
+      -- OaksLab.asm OakGivesPokedex: HideObject TOGGLE_POKEDEX_1/2
+      -- so the table sprites leave with the gift (#106).
+      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX1" },          -- 11
+      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX2" },          -- 12
+      -- the Pokédex swaps Viridian's two old men (OaksLab.asm:602-606:
+      -- HideObject TOGGLE_LYING_OLD_MAN / ShowObject TOGGLE_OLD_MAN).
+      -- Until this ran, the walking man at (17,5) -- who owns the coffee
+      -- ask and the catch tutorial -- stayed OFF for the whole game
+      -- (toggleable_objects.asm seeds him OFF, the sleeper ON).
+      { "hide_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN_SLEEPY" }, -- 13
+      { "show_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN" },  -- 14
+      { "jump", "end" },                                          -- 15
+      { "check_flag", "EVENT_GOT_STARTER" },                      -- 16
+      { "jump_if_false", 31 },                                    -- 17
+      { "check_item", "POKE_BALL" },                              -- 18
+      { "jump_if_true", 29 },                                     -- 19
+      { "check_flag", "EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE" },    -- 20
+      { "jump_if_false", 33 },                                    -- 21
+      { "check_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },           -- 22
+      { "jump_if_true", 29 },                                     -- 23
+      { "set_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },             -- 24
+      { "give_item", "POKE_BALL", 5, false },                     -- 25
+      { "show_text", "_OaksLabOak1ReceivedPokeballsText" },       -- 26
+      { "show_text", "_OaksLabGivePokeballsExplanationText" },    -- 27
+      { "jump", "end" },                                          -- 28
+      { "show_text", "_OaksLabOak1ComeSeeMeSometimesText" },      -- 29
+      { "jump", "end" },                                          -- 30
+      { "show_text", "_OaksLabOak1WhichPokemonDoYouWantText" },   -- 31
+      { "jump", "end" },                                          -- 32
+      { "show_text", "_OaksLabOak1RaiseYourYoungPokemonText" },   -- 33
     },
 
     TEXT_OAKSLAB_CHARMANDER_POKE_BALL =
@@ -200,45 +114,36 @@ return {
       starterBall("_OaksLabYouWantBulbasaurText", "BULBASAUR", "EVENT_CHOSE_BULBASAUR",
                   "OAKSLAB_BULBASAUR_POKE_BALL", 6, "OAKSLAB_CHARMANDER_POKE_BALL"),
 
-    -- Talking to the rival only ever prints a line: the lab battle is a
-    -- coordinate trigger (OaksLabRivalChallengesPlayerScript, wYCoord == 6;
-    -- see onStep below), never a talk action.  The handler used to fall
-    -- through from the "looks stronger" taunt straight into start_battle,
-    -- so talking to Blue at the table launched the rival fight before the
-    -- player ever stepped onto the trigger (#219).  scripts/OaksLab.asm
-    -- OaksLabText8 branches text only:
-    --   * got starter, not yet battled -> _OaksLabRivalMyPokemonLooksStronger
-    --   * already battled -> _OaksLabRivalFedUpWithWaitingText (a Route 22
-    --     line; normally unreachable since the rival is hidden after the
-    --     lab battle in OaksLabRivalEndBattleScript)
-    --   * no starter yet -> the FOLLOWED_OAK pre-starter fork (#218)
     TEXT_OAKSLAB_RIVAL = {
-      { "face_player" },
-      { "check_flag", "EVENT_GOT_STARTER" },
-      { "jump_if_false", "pre_starter" },
-      { "check_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" },
-      { "jump_if_true", "after_battle" },
-      -- has a starter, has not fought yet: just the taunt.  The battle is
-      -- the coordinate trigger in onStep, not this talk (#219)
-      { "show_text", "_OaksLabRivalMyPokemonLooksStrongerText" },
-      { "jump", "end" },
-
-      { "label", "after_battle" },
-      { "show_text", "_OaksLabRivalFedUpWithWaitingText" },
-      { "jump", "end" },
-
-      -- pre-starter fork (scripts/OaksLab.asm OaksLabText8 rival handler):
-      -- Oak has already escorted you in (three balls on the table) -> he
-      -- waves you on to choose; not yet escorted (very early game) -> the
-      -- "Gramps isn't around" line.  #218
-      { "label", "pre_starter" },
-      { "check_flag", "EVENT_FOLLOWED_OAK_INTO_LAB" },
-      { "jump_if_false", "gramps_gone" },
-      { "show_text", "_OaksLabRivalGoAheadAndChooseText" },
-      { "jump", "end" },
-
-      { "label", "gramps_gone" },
-      { "show_text", "_OaksLabRivalGrampsIsntAroundText" },
+      { "face_player" },                                          -- 1
+      { "check_flag", "EVENT_GOT_STARTER" },                      -- 2
+      { "jump_if_false", 21 },                                    -- 3
+      { "check_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" },        -- 4
+      { "jump_if_true", 19 },                                     -- 5
+      { "show_text", "_OaksLabRivalMyPokemonLooksStrongerText" }, -- 6
+      { "check_flag", "EVENT_CHOSE_BULBASAUR" },                  -- 7
+      { "jump_if_false", 11 },                                    -- 8
+      { "start_battle", "trainer", "OPP_RIVAL1", 3 },             -- 9  Charmander
+      { "jump", 16 },                                             -- 10
+      { "check_flag", "EVENT_CHOSE_SQUIRTLE" },                   -- 11
+      { "jump_if_false", 15 },                                    -- 12
+      { "start_battle", "trainer", "OPP_RIVAL1", 2 },             -- 13 Bulbasaur
+      { "jump", 16 },                                             -- 14
+      { "start_battle", "trainer", "OPP_RIVAL1", 1 },             -- 15 Squirtle
+      -- OaksLabRivalEndBattleScript: HealParty + flag, then exit either way
+      { "heal_party" },                                           -- 16
+      { "set_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" },          -- 17
+      { "jump", 23 },                                             -- 18
+      { "show_text", "_OaksLabRivalFedUpWithWaitingText" },       -- 19
+      { "jump", "end" },                                          -- 20
+      { "show_text", "_OaksLabRivalGrampsIsntAroundText" },       -- 21
+      { "jump", "end" },                                          -- 22
+      -- win: sulk text then exit; loss: Rival1WinText already played in
+      -- battle (HandlePlayerBlackOut), so skip straight to the walk-out
+      { "jump_if_false", 25 },                                    -- 23
+      { "show_text", "_OaksLabRivalIPickedTheWrongPokemonText" }, -- 24
+      { "move_npc_to", 1, 4, 11 },                                -- 25
+      { "hide_object", "OAKS_LAB", "OAKSLAB_RIVAL" },             -- 26
     },
   },
 
@@ -260,16 +165,9 @@ return {
   -- OaksLabScript8 / OaksLabRivalChallenge)
   onStep = function(game, ow, x, y)
     local flags = game.save.flags
-    -- Oak stops you leaving without a starter at the bookshelf row (cell
-    -- y == 6): this is the same wYCoord == 6 coordinate script the rival
-    -- challenge just below uses (scripts/OaksLab.asm, both gated on
-    -- EVENT_GOT_STARTER), so Oak halts you level with the shelves, not one
-    -- corridor length later on the exit mat.  At y>=6 only the x=4,5
-    -- corridor is walkable and the up-push keeps the player above y=7, so
-    -- this only ever fires at y=6 in the corridor -- matching the rival
-    -- trigger's shape. (#232)
+    -- Oak blocks the exit mats (4,11)/(5,11) until you take a starter
     if flags.EVENT_FOLLOWED_OAK_INTO_LAB and not flags.EVENT_GOT_STARTER
-       and y >= 6 then
+       and y == 11 and (x == 4 or x == 5) then
       ow.runner:run({
         { "show_text", "_OaksLabOakDontGoAwayYetText" },
         { "move_player", "up", 1 },
@@ -282,12 +180,7 @@ return {
        and y >= 6 then
       local rival = ow:npcByIndex(1)
       if not rival then return false end
-      -- OaksLabRivalChallengesPlayerScript swaps in the rival encounter
-      -- fanfare for the taunt/challenge exchange, same as the Yellow port
-      -- (oaks_lab_yellow.lua); it was silently dropped here (#596).
       local rows = {
-        { "stop_music" },
-        { "play_music", "Music_MeetRival" },
         { "show_text", "_OaksLabRivalIllTakeYouOnText" },         -- 1
       }
       -- the rival routes to a free cell beside the player
@@ -313,27 +206,12 @@ return {
       -- OaksLabRivalEndBattleScript: heal + flag on win or loss; no blackout
       table.insert(rows, { "heal_party" })
       table.insert(rows, { "set_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" })
-      -- OaksLabRivalEndBattleScript: on WIN, print the "picked the wrong
-      -- POKéMON!" gloat, then BOTH win and loss print the shared exit line
-      -- _OaksLabRivalSmellYouLaterText ("OK! I'll make my POKéMON fight to
-      -- toughen it up!\012<PLAYER>! Gramps! Smell you later!") before Blue
-      -- marches out.  A loss skips only the gloat (that taunt was already
-      -- shown in-battle via Rival1WinText), never the exit line (#231).  The
-      -- jump_if_false convergence point is the exit line: base+6 indexes the
-      -- SmellYouLater row below, so WIN falls IPicked -> SmellYouLater and
-      -- LOSS jumps straight to SmellYouLater (both then walk-out + hide).
+      -- win: sulk text then exit; loss jumps to the walk-out (taunt was
+      -- already shown in-battle via Rival1WinText)
       table.insert(rows, { "jump_if_false", base + 6 })
       table.insert(rows, { "show_text", "_OaksLabRivalIPickedTheWrongPokemonText" })
-      table.insert(rows, { "show_text", "_OaksLabRivalSmellYouLaterText" })
-      -- OaksLabRivalStartsExitScript: parting shot, rival exit fanfare, then
-      -- walk out past the player.  The fanfare was dropped here (#683) -- the
-      -- parcel scene above already plays Music_MeetRival on both arrival and
-      -- departure (lines 144-146), and this exit should match (#596).
-      table.insert(rows, { "stop_music" })
-      table.insert(rows, { "play_music", "Music_MeetRival" })
       table.insert(rows, { "move_npc_to", 1, 4, 11 })
       table.insert(rows, { "hide_object", "OAKS_LAB", "OAKSLAB_RIVAL" })
-      table.insert(rows, { "play_music", "Music_OaksLab" })
       ow.runner:run(rows, { npc = rival })
       return true
     end

data/scripts/oaks_lab_yellow.lua

@@ -1,310 +0,0 @@
--- Hand-ported from pret/pokeyellow scripts/OaksLab.asm.
--- Yellow: one Eevee ball on the table.  Rival snatches it; Oak then
--- gives the player the wild Pikachu he caught earlier (STARTER_PIKACHU).
--- Object indices differ from Red (no Charmander/Squirtle/Bulbasaur balls):
---   1 RIVAL (4,3), 2 EEVEE_POKE_BALL (7,3), 3 OAK1 (5,2),
---   4-5 POKEDEX (2,1)/(3,1), 6 OAK2 (door), 7 GIRL, 8-9 SCIENTIST.
---
--- wRivalStarter rides in save.rivalStarter (RIVAL_STARTER_* 1 JOLTEON /
--- 2 FLAREON / 3 VAPOREON): JOLTEON baseline at the snatch
--- (OaksLabRivalTakesPokeballScript), FLAREON on a lab win / VAPOREON on
--- a lab loss (OaksLabRivalEndBattleScript), and Route 22's first battle
--- upgrades FLAREON back to JOLTEON (Route22Rival1AfterBattleScript).
-
-local OAK1 = 3
-local RIVAL = 1
-
-return {
-  talk = {
-    TEXT_OAKSLAB_OAK1 = {
-      { "face_player" },
-      -- Yellow's OaksLabOak1Text leads with the dex-rating branch: once
-      -- EVENT_PALLET_AFTER_GETTING_POKEBALLS is set (converted saves) or
-      -- 2+ species are owned, Oak asks how the Pokédex is coming and
-      -- rates it (predef DisplayDexRating)
-      { "check_flag", "EVENT_PALLET_AFTER_GETTING_POKEBALLS" },
-      { "jump_if_true", "dex_rating" },
-      { "check_dex_owned", 2 },
-      { "jump_if_true", "dex_rating" },
-      { "check_item", "POKE_BALL" },
-      { "jump_if_true", "come_see" },
-      { "check_flag", "EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE" },
-      { "jump_if_true", "give_balls" },
-      { "check_flag", "EVENT_GOT_POKEDEX" },
-      { "jump_if_true", "around_world" },
-      { "check_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" },
-      { "jump_if_false", "pre_lab_battle" },
-      { "check_item", "OAKS_PARCEL" },
-      { "jump_if_false", "raise_young" },
-      -- .DeliverParcelText: parcel handover, then the Pokédex scene
-      -- (OaksLabRivalArrivesAtOaksRequestScript -> OakGivesPokedexScript)
-      { "show_text", "_OaksLabOak1DeliverParcelText" },
-      { "play_sound", "Get_Key_Item" },
-      { "show_text", "_OaksLabOak1ParcelThanksText" },
-      { "take_item", "OAKS_PARCEL", 1 },
-      { "stop_music" },
-      { "play_music", "Music_MeetRival" },
-      { "show_text", "_OaksLabRivalGrampsText" },
-      { "show_object", "OAKS_LAB", "OAKSLAB_RIVAL" },
-      { "place_npc", RIVAL, 4, 7, "up" },
-      { "move_npc_to", RIVAL, 4, 3 },
-      { "play_music", "Music_OaksLab" },
-      { "face_object", RIVAL, "up" },
-      { "face_object", OAK1, "down" },
-      -- Yellow opens with the rival bragging, not Red's "what did you
-      -- call me for" (OaksLabOakGivesPokedexScript text order)
-      { "show_text", "_OaksLabRivalMyPokemonHasGrownStrongerText" },
-      { "face_object", RIVAL, "up" },
-      { "face_object", OAK1, "down" },
-      { "show_text", "_OaksLabOakIHaveARequestText" },
-      { "face_object", RIVAL, "up" },
-      { "face_object", OAK1, "down" },
-      { "show_text", "_OaksLabOakMyInventionPokedexText" },
-      { "show_text", "_OaksLabOakGotPokedexText" },
-      { "play_sound", "Get_Key_Item" },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX1" },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_POKEDEX2" },
-      { "face_object", RIVAL, "up" },
-      { "face_object", OAK1, "down" },
-      { "show_text", "_OaksLabOakThatWasMyDreamText" },
-      { "face_object", RIVAL, "right" },
-      { "show_text", "_OaksLabRivalLeaveItAllToMeText" },
-      { "set_flag", "EVENT_GOT_POKEDEX" },
-      { "set_flag", "EVENT_OAK_GOT_PARCEL" },
-      -- OaksLabOakGivesPokedexScript: HideObject TOGGLE_LYING_OLD_MAN /
-      -- ShowObject TOGGLE_OLD_MAN_2 -- Yellow's tutorial old man stands
-      -- on the sleeper's cell (18,9); the Red/Blue walker OLD_MAN at
-      -- (17,5) never appears in Yellow (#617)
-      { "hide_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN_SLEEPY" },
-      { "show_object", "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN2" },
-      { "stop_music" },
-      { "play_music", "Music_MeetRival" },
-      { "move_npc_to", RIVAL, 4, 7 },
-      { "hide_object", "OAKS_LAB", "OAKSLAB_RIVAL" },
-      { "play_music", "Music_OaksLab" },
-      { "set_flag", "EVENT_1ST_ROUTE22_RIVAL_BATTLE" },
-      { "clear_flag", "EVENT_2ND_ROUTE22_RIVAL_BATTLE" },
-      { "set_flag", "EVENT_ROUTE22_RIVAL_WANTS_BATTLE" },
-      { "show_object", "ROUTE_22", "ROUTE22_RIVAL1" },
-      { "jump", "end" },
-
-      { "label", "raise_young" },
-      -- Yellow: talk-to-it (starter Pikachu) instead of Red raise-young line.
-      { "show_text", "_OaksLabOak1YouShouldTalkToIt" },
-      { "jump", "end" },
-
-      { "label", "pre_lab_battle" },
-      { "check_flag", "EVENT_GOT_STARTER" },
-      { "jump_if_true", "can_fight" },
-      { "show_text", "_OaksLabOak1GoAheadItsYours" },
-      { "jump", "end" },
-      { "label", "can_fight" },
-      { "show_text", "_OaksLabOak1YourPokemonCanFightText" },
-      { "jump", "end" },
-
-      { "label", "around_world" },
-      { "show_text", "_OaksLabOak1PokemonAroundTheWorldText" },
-      { "jump", "end" },
-
-      { "label", "give_balls" },
-      { "check_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },
-      { "jump_if_true", "come_see" },
-      { "set_flag", "EVENT_GOT_POKEBALLS_FROM_OAK" },
-      { "give_item", "POKE_BALL", 5, false },
-      { "show_text", "_OaksLabOak1ReceivedPokeballsText" },
-      { "play_sound", "Get_Key_Item" },
-      { "show_text", "_OaksLabGivePokeballsExplanationText" },
-      { "jump", "end" },
-
-      { "label", "come_see" },
-      { "show_text", "_OaksLabOak1ComeSeeMeSometimesText" },
-      { "jump", "end" },
-
-      { "label", "dex_rating" },
-      { "show_text", "_OaksLabOak1HowIsYourPokedexComingText" },
-      { "dex_rating" },
-    },
-
-    -- OaksLabEeveePokeBallText / OaksLabRivalExclamationScript ->
-    -- OaksLabChoseStarterScript..OaksLabPlayerReceivesPikachuScript:
-    -- before Oak's choose speech the ball is just flavor; after it, the
-    -- rival "!"s, shoves the player off the table, snatches the ball,
-    -- then the player is walked over to Oak and handed Pikachu.
-    TEXT_OAKSLAB_EEVEE_POKE_BALL = function(game, ow, npc, done)
-      local flags = game.save.flags
-      if flags.EVENT_GOT_STARTER then
-        done()
-        return
-      end
-      if not flags.EVENT_OAK_ASKED_TO_CHOOSE_MON then
-        ow.runner:run({
-          { "show_text", "_OaksLabThatsAPokeball" },
-        }, { onDone = done })
-        return
-      end
-      local px, py = ow.player.cellX, ow.player.cellY
-      local rows = {
-        -- OaksLabRivalExclamationScript: "!" over the rival
-        { "emote", RIVAL, "shock" },
-      }
-      -- .RivalPushesPlayerAwayFromEeveeBall is DOWN then RIGHT x3 (the $07
-      -- bytes are Yellow's own step-right encoding, decoded by
-      -- engine/overworld/movement.asm Func_5288 -> Func_532b), and the
-      -- PAD_RIGHT x2 shove is NOT queued alongside it:
-      -- OaksLabRivalTakesPokeballScript .asm_1c564 polls every frame and
-      -- only simulates the pair once wNPCNumScriptedSteps reads 1 -- i.e.
-      -- as the rival begins the LAST byte, the step onto the tile the
-      -- player is standing on.  Starting both on one row had Red stroll
-      -- off the Eevee while the rival was still at the top of the table
-      -- (#559).
-      if py == 4 then
-        rows[#rows + 1] = { "walk_npc", RIVAL, { "down", "right", "right" } }
-        -- this one runs concurrently with the shove below
-        rows[#rows + 1] = { "walk_npc", RIVAL, { "right" }, { wait = false } }
-        rows[#rows + 1] = { "face_player_dir", "left" }
-        rows[#rows + 1] = { "move_player", "right", 2 }
-        -- move_player blocks for both tiles, so the rival has already
-        -- landed on (7,4); this is just the beat before he turns up
-        rows[#rows + 1] = { "wait", 20 }
-      else
-        rows[#rows + 1] = { "move_npc_to", RIVAL, 7, 4 }
-      end
-      rows[#rows + 1] = { "face_object", RIVAL, "up" }
-      rows[#rows + 1] = { "hide_object", "OAKS_LAB", "OAKSLAB_EEVEE_POKE_BALL" }
-      -- rival starter baseline (RIVAL_STARTER_JOLTEON) at snatch time
-      rows[#rows + 1] = { "set_field", "rivalStarter", 1 }
-      rows[#rows + 1] = { "show_text", "_OaksLabRivalTakesText1" }
-      rows[#rows + 1] = { "play_sound", "Get_Key_Item" }
-      rows[#rows + 1] = { "show_text", "_OaksLabRivalTakesText2" }
-      rows[#rows + 1] = { "show_text", "_OaksLabRivalTakesText3" }
-      rows[#rows + 1] = { "show_text", "_OaksLabRivalTakesText4" }
-      rows[#rows + 1] = { "show_text", "_OaksLabRivalTakesText5" }
-      -- OaksLabRLE_PlayerWalksToOak: the simulated-joypad buffer plays
-      -- its RLE list BACKWARDS (StartSimulatingJoypadStates consumes
-      -- from wSimulatedJoypadStatesEnd), so the real order is LEFT 1,
-      -- DOWN 1, LEFT 3, UP 2 -- from the shove spot (9,4) the player
-      -- rounds the BOTTOM of the table to (5,3), directly below Oak
-      if py == 4 then
-        rows[#rows + 1] = { "walk_npc", "player",
-          { "left", "down", "left", "left", "left", "up", "up" } }
-      else
-        rows[#rows + 1] = { "walk_npc", "player", { "left" } }
-      end
-      rows[#rows + 1] = { "face_player_dir", "up" }
-      rows[#rows + 1] = { "face_object", OAK1, "down" }
-      -- OaksLabPlayerReceivedMonText: no nickname prompt -- the starter
-      -- Pikachu keeps its species name
-      rows[#rows + 1] = { "show_text", "_OaksLabOakGivesText" }
-      rows[#rows + 1] = { "play_sound", "Get_Key_Item" }
-      rows[#rows + 1] = { "show_text", "_OaksLabReceivedText", { RAM = "PIKACHU" } }
-      rows[#rows + 1] = { "give_pokemon", "PIKACHU", 5, true }
-      rows[#rows + 1] = { "set_flag", "EVENT_GOT_STARTER" }
-      rows[#rows + 1] = { "set_flag", "EVENT_CHOSE_PIKACHU" }
-      ow.runner:run(rows, { npc = npc, onDone = done })
-    end,
-
-    TEXT_OAKSLAB_RIVAL = {
-      { "face_player" },
-      { "check_flag", "EVENT_GOT_STARTER" },
-      { "jump_if_false", "pre_starter" },
-      { "show_text", "_OaksLabRivalMyPokemonLooksStrongerText" },
-      { "jump", "end" },
-
-      { "label", "pre_starter" },
-      { "check_flag", "EVENT_FOLLOWED_OAK_INTO_LAB_2" },
-      { "jump_if_false", "gramps_gone" },
-      { "show_text", "_OaksLabRivalIllGetABetterPokemonThanYou" },
-      { "jump", "end" },
-
-      { "label", "gramps_gone" },
-      { "show_text", "_OaksLabRivalGrampsIsntAroundText" },
-    },
-  },
-
-  onEnter = function(game, ow)
-    if not (game.save.flags and game.save.flags.EVENT_GOT_POKEDEX) then
-      return
-    end
-    local Commands = require("src.script.Commands")
-    local ctx = { save = game.save, game = game, overworld = ow }
-    Commands.hide_object(ctx, "OAKS_LAB", "OAKSLAB_POKEDEX1")
-    Commands.hide_object(ctx, "OAKS_LAB", "OAKSLAB_POKEDEX2")
-  end,
-
-  onStep = function(game, ow, x, y)
-    local flags = game.save.flags
-    -- OaksLabPlayerDontGoAwayScript: y==6 without the starter walks the
-    -- player back up a tile
-    if flags.EVENT_FOLLOWED_OAK_INTO_LAB and not flags.EVENT_GOT_STARTER
-       and y >= 6 then
-      ow.runner:run({
-        { "face_object", OAK1, "down" },
-        { "face_object", RIVAL, "down" },
-        { "show_text", "_OaksLabOakDontGoAwayYetText" },
-        { "move_player", "up", 1 },
-      }, {})
-      return true
-    end
-    -- OaksLabRivalChallengesPlayerScript..OaksLabPikachuDislikesPokeballsScript:
-    -- heading for the door with Pikachu starts the rival battle, his
-    -- exit walk, then Pikachu pops out of its ball.
-    if flags.EVENT_GOT_STARTER and not flags.EVENT_BATTLED_RIVAL_IN_OAKS_LAB
-       and y >= 6 then
-      local rival = ow:npcByIndex(RIVAL)
-      if not rival then return false end
-      local rows = {
-        { "face_player_dir", "up" },
-        { "stop_music" },
-        { "play_music", "Music_MeetRival" },
-        { "show_text", "_OaksLabRivalIllTakeYouOnText" },
-      }
-      -- FindPathToPlayer with the Y distance decremented: the rival
-      -- stops one tile above the player
-      local target
-      for _, c in ipairs({ { x, y - 1 }, { x - 1, y }, { x + 1, y },
-                           { x, y + 1 } }) do
-        if ow.map:inBounds(c[1], c[2]) and ow.map:isWalkableCell(c[1], c[2]) then
-          target = c
-          break
-        end
-      end
-      if target then
-        table.insert(rows, { "move_npc_to", RIVAL, target[1], target[2] })
-      end
-      table.insert(rows, { "face_object", RIVAL,
-                           target and target[2] < y and "down"
-                           or target and target[2] > y and "up"
-                           or target and target[1] < x and "right" or "left" })
-      table.insert(rows, { "start_battle", "trainer", "OPP_RIVAL1", 1 })
-      table.insert(rows, { "heal_party" })
-      table.insert(rows, { "set_flag", "EVENT_BATTLED_RIVAL_IN_OAKS_LAB" })
-      -- OaksLabRivalEndBattleScript: his Eevee's future evolution is
-      -- decided here -- FLAREON if the player won, VAPOREON otherwise
-      table.insert(rows, { "check_battle_result", "win" })
-      table.insert(rows, { "jump_if_false", "lost_lab" })
-      table.insert(rows, { "set_field", "rivalStarter", 2 })
-      table.insert(rows, { "jump", "exit" })
-      table.insert(rows, { "label", "lost_lab" })
-      table.insert(rows, { "set_field", "rivalStarter", 3 })
-      table.insert(rows, { "label", "exit" })
-      -- OaksLabRivalStartsExitScript: parting shot, rival exit fanfare, then
-      -- walk out past the player (#683).
-      table.insert(rows, { "wait", 20 })
-      table.insert(rows, { "show_text", "_OaksLabRivalSmellYouLaterText" })
-      table.insert(rows, { "stop_music" })
-      table.insert(rows, { "play_music", "Music_MeetRival" })
-      table.insert(rows, { "move_npc_to", RIVAL, 4, 11 })
-      table.insert(rows, { "hide_object", "OAKS_LAB", "OAKSLAB_RIVAL" })
-      table.insert(rows, { "play_music", "Music_OaksLab" })
-      -- OaksLabPikachuEscapesPokeballScript: Pikachu hates its ball.
-      -- The overworld follower itself is still an open port
-      -- (docs/yellow-version.md runtime backlog); the story beat plays.
-      table.insert(rows, { "play_cry", "PIKACHU" })
-      table.insert(rows, { "show_text", "_OaksLabPikachuDislikesPokeballsText1" })
-      table.insert(rows, { "show_text", "_OaksLabPikachuDislikesPokeballsText2" })
-      ow.runner:run(rows, { npc = rival })
-      return true
-    end
-    return false
-  end,
-}

data/scripts/safari.lua

@@ -4,11 +4,9 @@
 -- (.PlayerNextToSafariZoneWorker1CoordsArray).  Paying ¥500 hands over
 -- 30 SAFARI BALLs and starts the 502-step game
 -- (SafariZoneGateWouldYouLikeToJoinScript: wSafariSteps = 502,
--- wNumSafariBalls = SAFARI_BALLS_RECEIVED), then auto-walks the player
--- up through the north warp into the zone.  Declining walks you back
--- so you can't slip past.  Returning to the gate ends the game, the
--- worker takes the leftover balls back and the auto-walk drops you 3
--- cells below the warp you came in by (#540).
+-- wNumSafariBalls = SAFARI_BALLS_RECEIVED).  Declining walks you back
+-- so you can't slip past.  Returning to the gate ends the game and the
+-- worker takes the leftover balls back.
 --
 -- Step/ball bookkeeping lives in src/world/OverworldController.lua
 -- (safariStep/safariGameOver, from
@@ -21,87 +19,17 @@ local FEE = 500
 local BALLS = 30
 local STEPS = 502
 
--- SafariZoneGateSafariZoneWorker1WouldYouLikeToJoinText .success closes with
--- `ld a, PAD_UP / ld c, 3 / SafariZoneEntranceAutoWalk`: paying walks the
--- player up out of the gate and through the north warp, it is never left to
--- the player.  EVENT_IN_SAFARI_ZONE is already set when that walk runs, so
--- the two gate steps taken before the warp fires are charged against
--- wSafariSteps (home/overworld.asm:307-310) -- which is why the counter
--- reads 500/500 on arrival even though the script wrote 502 (#540).  The
--- port's counter only runs on the nine interior maps (FieldDefaults
--- safari.stepMaps, OverworldState:inSafariStepZone), so charge those two
--- steps here instead.
-local function walkIntoZone(game, ow)
-  local p = ow.player
-  -- only from the two trigger cells in front of the worker, which are the
-  -- columns the north warps sit on; a player who paid after TALKING to him
-  -- from somewhere else walks in on their own, as they do today
-  local w = p.cellY == 2 and ow.map:warpAtCell(p.cellX, 0) or nil
-  if not w then return end
-  ow:scriptMove(p, "up", 2, function()
-    local st = game.save.safari
-    if st then st.steps = st.steps - 2 end
-    -- scripted steps skip onStepComplete (and with it CheckWarpsNoCollision),
-    -- so take that warp explicitly once the walk lands on it
-    ow:takeWarp(w.def)
-  end)
-end
-
-local function startGame(game, ow, t, done, balls, introText)
-  game.save.safari = { balls = balls or BALLS, steps = STEPS }
-  game.save.safariNags = nil
+local function startGame(game, t, done)
+  game.save.money = game.save.money - FEE
+  game.save.safari = { balls = BALLS, steps = STEPS }
   local TextBox = require("src.render.TextBox")
-  local paid = introText
-    or (t._SafariZoneGateSafariZoneWorker1ThatllBe500PleaseText
-        or "That'll be ¥500\nplease!\f{PLAYER} received\n30 SAFARI BALLs!")
-       :gsub("{NUM:[^}]*}", "500")
-  paid = paid:gsub("{PLAYER}", game.save.player.name)
+  local paid = (t._SafariZoneGateSafariZoneWorker1ThatllBe500PleaseText
+                or "That'll be ¥500\nplease!\f{PLAYER} received\n30 SAFARI BALLs!")
+               :gsub("{PLAYER}", game.save.player.name)
   local pa = t._SafariZoneGateSafariZoneWorker1CallYouOnThePAText
              or "\fWe'll call you on\nthe PA when you\nrun out of time\nor SAFARI BALLs!"
   local luck = t._SafariZoneGateSafariZoneWorker1GoodLuckText or "Good Luck!"
-  game.stack:push(TextBox.new(game, paid .. pa .. "\f" .. luck, function()
-    if done then done() end
-    walkIntoZone(game, ow)
-  end))
-end
-
--- Yellow's soft-lock fix (scripts/SafariZoneGate_2.asm): a player short of
--- the full fee still gets in.
---   0 < money < 500: SafariZoneEntranceCalculateLowCostAdmission takes
---   everything and hands over min(money/23 + 1, 29) balls.
---   money == 0: SafariZoneEntranceGetLowCostAdmissionText nags four times
---   (LowCostText5/6/7/8), then relents -- free entry, one ball.
-local function yellowLowCost(game, ow, t, done, back)
-  local TextBox = require("src.render.TextBox")
-  if game.save.money > 0 then
-    local balls = math.min(math.floor(game.save.money / 23) + 1, 29)
-    game.save.money = 0
-    local intro =
-      (t._SafariZoneGateSafariZoneWorker1NotEnoughMoneyText
-       or "Oops! Not enough\nmoney!")
-      .. (t._SafariZoneLowCostText1
-          or "\fOh, all right, pay\nme what you have.")
-      .. "\f" .. (t._SafariZoneLowCostText2
-                  or "But, I can't give\nyou all 30 BALLs.")
-    startGame(game, ow, t, done, balls, intro)
-    return
-  end
-  local nag = game.save.safariNags or 0
-  game.save.safariNags = nag + 1
-  if nag >= 3 then
-    local intro =
-      (t._SafariZoneLowCostText8 or "Read my lips, NO!\nGet it?")
-      .. (t._SafariZoneLowCostText3
-          or "\fYou're persistent,\naren't you?\fOK, you can go in\nfor free, but\njust this once!")
-    startGame(game, ow, t, done, 1, intro)
-    return
-  end
-  local nags = {
-    t._SafariZoneLowCostText5 or "I'm sorry, but you\nhave to pay to\nenter.",
-    t._SafariZoneLowCostText6 or "You can't enter\nwithout paying!",
-    t._SafariZoneLowCostText7 or "I said, no money,\nno entry!",
-  }
-  back(nags[nag + 1])
+  game.stack:push(TextBox.new(game, paid .. pa .. "\f" .. luck, done))
 end
 
 local function joinPrompt(game, ow, done)
@@ -123,15 +51,10 @@ local function joinPrompt(game, ow, done)
           back(t._SafariZoneGateSafariZoneWorker1PleaseComeAgainText
                or "OK! Please come\nagain!")
         elseif game.save.money < FEE then
-          if require("src.core.GameVersion").isYellow() then
-            yellowLowCost(game, ow, t, done, back)
-          else
-            back(t._SafariZoneGateSafariZoneWorker1NotEnoughMoneyText
-                 or "Oops! Not enough\nmoney!")
-          end
+          back(t._SafariZoneGateSafariZoneWorker1NotEnoughMoneyText
+               or "Oops! Not enough\nmoney!")
         else
-          game.save.money = game.save.money - FEE
-          startGame(game, ow, t, done)
+          startGame(game, t, done)
         end
       end))
     end))
@@ -166,38 +89,27 @@ M.SAFARI_ZONE_GATE = {
   -- no walks you back into the zone
   onEnter = function(game, ow)
     if not game.save.safari or ow.player.cellY > 1 then return end
-    -- QUEUED, never pushed: onEnter runs inside the arriving warp's
-    -- Transition midpoint, and Transition:finish pops whatever is on top
-    -- the same frame (Timing.WARP_FADE_IN is 0) -- so a box pushed here is
-    -- swallowed, and on a build where it survived it drew over a screen
-    -- still faded to black (#540).  Same contract as M.HALL_OF_FAME in
-    -- data/scripts/story.lua.
-    --
-    -- SafariZoneGateLeavingSafariScript .leaving_early: YES prints the
-    -- return-balls text, faces the player down and runs
-    -- SafariZoneEntranceAutoWalk with `PAD_DOWN, c = 3`, landing on the
-    -- counter row 3 cells below the warp you came in by; NO prints
-    -- "Good Luck!" and walks one step back up through that same warp.
-    local rightSide = ow.player.cellX ~= 3
-    local dest = game.data.maps.SAFARI_ZONE_CENTER.warps[rightSide and 2 or 1]
-    ow:queueScript({
-      { "ask", "_SafariZoneGateSafariZoneWorker1LeavingEarlyText" },
-      { "jump_if_false", "stay" },
-      -- the port never reaches SafariZoneGateLeavingSafariScript's own
-      -- GOOD_HAUL_COME_AGAIN branch (safariGameOver warps straight to the
-      -- counter), so the sign-off rides on this path
-      { "show_text", "_SafariZoneGateSafariZoneWorker1ReturnSafariBallsText" },
-      { "show_text", "_SafariZoneGateSafariZoneWorker1GoodHaulComeAgainText" },
-      -- no value: set_field assigns nil, which is how save.safari is cleared
-      { "set_field", "safari" },
-      -- move_player runs through scriptMove, which skips onStepComplete, so
-      -- walking back down past (x,2) cannot re-fire the join trigger
-      { "move_player", "down", 3 },
-      { "jump", "end" },
-      { "label", "stay" },
-      { "show_text", "_SafariZoneGateSafariZoneWorker1GoodLuckText" },
-      { "warp", "SAFARI_ZONE_CENTER", dest.x, dest.y, "up" },
-    })
+    local TextBox = require("src.render.TextBox")
+    local ChoiceBox = require("src.ui.ChoiceBox")
+    local t = game.data.text
+    game.stack:push(TextBox.new(game,
+      t._SafariZoneGateSafariZoneWorker1LeavingEarlyText or "Leaving early?",
+      function()
+        game.stack:push(ChoiceBox.new(game, function(yes)
+          if not yes then
+            -- back into the zone through the entrance warp
+            local w = game.data.maps.SAFARI_ZONE_CENTER.warps[1]
+            ow:startWarpTo("SAFARI_ZONE_CENTER", w.x, w.y, "up")
+            return
+          end
+          game.save.safari = nil
+          game.stack:push(TextBox.new(game,
+            (t._SafariZoneGateSafariZoneWorker1ReturnSafariBallsText
+             or "Please return any\nSAFARI BALLs you\nhave left.")
+            .. "\f" .. (t._SafariZoneGateSafariZoneWorker1GoodHaulComeAgainText
+                        or "Did you get a\ngood haul?\fCome again!")))
+        end))
+      end))
   end,
 }
 

data/scripts/seafoam.lua

@@ -11,7 +11,7 @@
 -- field.seafoam (SEAFOAM_ISLANDS_1F/B1F/B3F holes+holeDestination and
 -- B3F's pluggedByHolesOn) plus the generic
 -- OverworldState:boulderIntoHole in src/world/OverworldController.lua;
--- no per-map onEnter hook is needed for the boulders.
+-- no per-map onEnter hook is needed here.
 
 local M = {}
 
@@ -23,46 +23,4 @@ M.VERMILION_GYM = {
   end,
 }
 
--- The PLAYER falling down those same holes (#599).  field.seafoam's holes
--- carry only the BOULDER's object cell on the floor below (landsAt), not
--- the player's landing, so the player's landing is spelled out here: it
--- comes from data/maps/special_warps.asm DungeonWarpList/DungeonWarpData,
--- which the importer does not extract.  Same shape as MANSION_HOLES in
--- data/scripts/story6.lua and VICTORY_ROAD_3F.onStep in
--- data/scripts/story.lua; CAVERN $22 is a walkable tile, so the fall has
--- to be an onStep, not a collision block.
---
--- Sources: scripts/SeafoamIslands1F.asm Seafoam1HolesCoords (17,6)/(24,6),
--- B1F.asm Seafoam2HolesCoords (18,6)/(23,6), B2F.asm Seafoam3HolesCoords
--- (19,6)/(22,6), B3F.asm Seafoam4HolesCoords (3,16)/(6,16).  Each floor
--- sets wDungeonWarpDestinationMap and calls IsPlayerOnDungeonWarp, and
--- wCoordIndex picks that floor's DungeonWarpData row.  Unconditional in
--- the original: a plugged hole still drops the player.  The B3F and B4F
--- landings are water; setMap's CheckForceBikeOrSurf pass
--- (OverworldState:checkForcedMovement) mounts SURF on arrival.
-local HOLE_FALLS = {
-  SEAFOAM_ISLANDS_1F  = { { 17, 6, "SEAFOAM_ISLANDS_B1F", 18, 7 },
-                          { 24, 6, "SEAFOAM_ISLANDS_B1F", 23, 7 } },
-  SEAFOAM_ISLANDS_B1F = { { 18, 6, "SEAFOAM_ISLANDS_B2F", 19, 7 },
-                          { 23, 6, "SEAFOAM_ISLANDS_B2F", 22, 7 } },
-  SEAFOAM_ISLANDS_B2F = { { 19, 6, "SEAFOAM_ISLANDS_B3F", 18, 7 },
-                          { 22, 6, "SEAFOAM_ISLANDS_B3F", 19, 7 } },
-  SEAFOAM_ISLANDS_B3F = { {  3, 16, "SEAFOAM_ISLANDS_B4F", 4, 14 },
-                          {  6, 16, "SEAFOAM_ISLANDS_B4F", 5, 14 } },
-}
-
-for mapId, holes in pairs(HOLE_FALLS) do
-  M[mapId] = M[mapId] or {}
-  M[mapId].onStep = function(game, ow, x, y)
-    for _, h in ipairs(holes) do
-      if x == h[1] and y == h[2] then
-        require("src.core.Sound").play(game.data, "Faint_Fall")
-        ow:startWarpTo(h[3], h[4], h[5], ow.player.facing)
-        return true
-      end
-    end
-    return false
-  end
-end
-
 return M

data/scripts/story.lua

@@ -16,14 +16,6 @@ M.VIRIDIAN_MART = {
   -- StartSimulatingJoypadStates walks the player to the counter
   -- (.PlayerMovement: PAD_LEFT 1, PAD_UP 2, door (3,7) -> counter (2,5))
   -- and ViridianMartOaksParcelScript hands the parcel over.  The player
-  -- never presses A.
-  --
-  -- The RLE list is consumed back to front: DecodeRLEList fills forward
-  -- from wSimulatedJoypadStatesEnd, the script seeds wSimulatedJoypadStates-
-  -- Index with the count, and home/overworld.asm decrements that index
-  -- before each read.  So PAD_LEFT 1, PAD_UP 2 actually plays up, up, left,
-  -- and the walk ends facing the clerk.  Replaying the list front to back
-  -- put the player at the counter facing up instead (#235).  The player
   -- never presses A.  This matters beyond convenience: the parcel gates
   -- Oak's Pokedex and the old man clearing Route 2, so vanilla guarantees
   -- it on entry rather than letting you walk out without it.
@@ -36,8 +28,8 @@ M.VIRIDIAN_MART = {
     if not f.EVENT_GOT_STARTER then return end
     ow:queueScript({
       { "show_text", "_ViridianMartClerkYouCameFromPalletTownText" },
-      { "move_player", "up", 2 },
       { "move_player", "left", 1 },
+      { "move_player", "up", 2 },
       -- the quest text's last page is "{PLAYER} got\nOAK's PARCEL!"
       { "give_item", "OAKS_PARCEL", 1, "_ViridianMartClerkParcelQuestText" },
       { "set_flag", "EVENT_GOT_OAKS_PARCEL" },
@@ -94,27 +86,6 @@ M.VIRIDIAN_CITY = {
       { "show_text", "_ViridianCityOldManTimeIsMoneyText" },             -- 8 (9 = end)
     },
   },
-  -- Re-apply the Pokedex old-man swap for a save that already holds the flag
-  -- but was never standing here when it fired: a vanilla .sav imported
-  -- through src/save_convert, whose codec does not model pokered's
-  -- wToggleableObjectFlags array, so save.objectToggles arrives empty and
-  -- both objects fall back to their compiled-in defaults -- the sleeper ON
-  -- (data/maps/toggleable_objects.asm toggleable_objects_for VIRIDIAN_CITY),
-  -- still lying across the north path (#234).
-  -- OaksLabOakGivesPokedexScript (scripts/OaksLab.asm) sets EVENT_GOT_POKEDEX
-  -- and, with no branch in between, runs HideObject TOGGLE_LYING_OLD_MAN /
-  -- ShowObject TOGGLE_OLD_MAN, so that one flag settles both toggles exactly.
-  -- Same shape as M.OAKS_LAB.onEnter in data/scripts/oaks_lab.lua, which
-  -- re-applies the same script's other two HideObjects on entry (#106).
-  onEnter = function(game, ow)
-    if not (game.save.flags and game.save.flags.EVENT_GOT_POKEDEX) then
-      return
-    end
-    local Commands = require("src.script.Commands")
-    local ctx = { save = game.save, game = game, overworld = ow }
-    Commands.hide_object(ctx, "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN_SLEEPY")
-    Commands.show_object(ctx, "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN")
-  end,
   -- ViridianCityCheckGotPokedexScript: the north corridor is gated on
   -- EVENT_GOT_POKEDEX, NOT on the sleeper being hidden, and it triggers
   -- on exactly one cell -- (19,9), the gap east of the sleeper (18,9)
@@ -183,17 +154,11 @@ M.BILLS_HOUSE = {
                                    overworld = ow },
                                  "BILLS_HOUSE", "BILLSHOUSE_BILL_POKEMON")
             game.save.flags.EVENT_BILL_SAID_USE_CELL_SEPARATOR = true
-            require("src.world.PikachuFollower").onBillEnteredMachine(game, ow)
             done()
           end
           if ow.player.facing == "down" then
             -- the player is standing on his straight path: walk around
-            -- (.PokemonWalkAroundPlayerMovement).  BillsHouseScript2 runs
-            -- BillsHousePikachuWatchPlayer first on this branch, so a
-            -- Pikachu that is still following steps clear of Bill's detour
-            -- and turns to watch the player (#455).
-            require("src.world.PikachuFollower")
-              .onBillWalksAroundPlayer(game, ow)
+            -- (.PokemonWalkAroundPlayerMovement)
             ow:scriptMove(npc, "right", 1, function()
               ow:scriptMove(npc, "up", 2, function()
                 ow:scriptMove(npc, "left", 1, function()
@@ -279,9 +244,6 @@ M.BILLS_HOUSE = {
       Commands.hide_object(ctx, "BILLS_HOUSE", "BILLSHOUSE_BILL1")
       Commands.show_object(ctx, "BILLS_HOUSE", "BILLSHOUSE_BILL2")
     end
-    if not flags.EVENT_MET_BILL_2 then
-      require("src.world.PikachuFollower").onBillsHouseEnter(game, ow)
-    end
   end,
 }
 
@@ -433,93 +395,7 @@ M.SS_ANNE_CAPTAINS_ROOM = {
 -- MrFujisHouse.asm; the teleport back to his house is a warp)
 -- -------------------------------------------------------------------
 
--- scripts/PokemonTower7F.asm: after each Rocket loses,
--- PokemonTower7FEndBattleScript shows its EndBattle text (EndTrainerBattle),
--- prints its AfterBattle text (DisplayTextID), then
--- PokemonTower7FRocketLeaveMovementScript walks the grunt off toward the
--- (9,16) stairs (MoveSprite) and PokemonTower7FHideNPCScript despawns it
--- (HideObject).  Without this the beaten grunts stood in the corridor
--- forever (#200).
-local POKEMON_TOWER_7F_ROCKETS = {
-  { index = 1, name = "POKEMONTOWER7F_ROCKET1",
-    beat = "EVENT_BEAT_POKEMONTOWER_7_TRAINER_0",
-    after = "_PokemonTower7FRocket1AfterBattleText" },
-  { index = 2, name = "POKEMONTOWER7F_ROCKET2",
-    beat = "EVENT_BEAT_POKEMONTOWER_7_TRAINER_1",
-    after = "_PokemonTower7FRocket2AfterBattleText" },
-  { index = 3, name = "POKEMONTOWER7F_ROCKET3",
-    beat = "EVENT_BEAT_POKEMONTOWER_7_TRAINER_2",
-    after = "_PokemonTower7FRocket3AfterBattleText" },
-}
-
--- PokemonTower7FNPCCoordMovementTable, keyed by the PLAYER's tile ("x,y")
--- at the engagement (both the talk and the sight walk-up leave the player on
--- the tile the vanilla table indexes).  Each list is that entry's
--- NPC_MOVEMENT_* exit, applied from the grunt's current tile.  The exact
--- tables are one per grunt (dbmapcoord bytes decoded back to x,y).
-local POKEMON_TOWER_7F_EXITS = {
-  [1] = { -- ROCKET1 @ (9,11), faces RIGHT
-    ["9,12"]  = { "right", "down", "down", "down", "down", "down", "left" },
-    ["10,11"] = { "down", "right", "down", "down", "down", "down" },
-    ["11,11"] = { "down", "down", "down", "down", "down" },
-    ["12,11"] = { "down", "down", "down", "down", "down" },
-  },
-  [2] = { -- ROCKET2 @ (12,9), faces LEFT
-    ["12,10"] = { "left", "down", "down", "down", "down", "down", "down" },
-    ["11,9"]  = { "down", "down", "down", "left", "down", "down" },
-    ["10,9"]  = { "down", "down", "down", "down", "down" },
-    ["9,9"]   = { "down", "down", "down", "down", "down" },
-  },
-  [3] = { -- ROCKET3 @ (9,7), faces RIGHT
-    ["9,8"]  = { "right", "down", "down", "down", "down", "down", "down" },
-    ["10,7"] = { "down", "down", "down", "down", "down" },
-    ["11,7"] = { "down", "down", "down", "down", "down" },
-    ["12,7"] = { "down", "down", "down", "down", "down" },
-  },
-}
--- The vanilla table only lists the sight/talk tiles the map geometry allows;
--- a plain down-walk keeps any other engagement tile (e.g. talking from the
--- side) safe -- it still clears the corridor and despawns the grunt.
-local POKEMON_TOWER_7F_EXIT_FALLBACK =
-  { "down", "down", "down", "down", "down" }
-
 M.POKEMON_TOWER_7F = {
-  -- Repair saves that beat a grunt before the exit walk was ported: in
-  -- vanilla HideObject persists (wMissableObjectFlags), so a beaten grunt is
-  -- still gone on re-entry.  hide_object below writes objectToggles for new
-  -- wins; this hides any grunt whose BEAT flag is already set.
-  onEnter = function(game, ow)
-    local Commands = require("src.script.Commands")
-    local ctx = { game = game, save = game.save, overworld = ow }
-    for _, r in ipairs(POKEMON_TOWER_7F_ROCKETS) do
-      if game.save.flags[r.beat] then
-        Commands.hide_object(ctx, "POKEMON_TOWER_7F", r.name)
-      end
-    end
-  end,
-  -- runVictoryHook fires after every trainer win on the map (both the sight
-  -- and talk paths route through engageTrainer -> checkVictoryRewards), so
-  -- this walks off whichever grunt was just beaten but is still standing.
-  -- The AfterBattle text + walk queue UNDER the EndBattle box engageTrainer
-  -- pushes right after, giving the vanilla order: EndBattle, AfterBattle,
-  -- walk, despawn.
-  onVictory = function(game, ow)
-    if ow.runner:isRunning() then return end
-    for _, r in ipairs(POKEMON_TOWER_7F_ROCKETS) do
-      local npc = ow:npcByIndex(r.index)
-      if npc and game.save.flags[r.beat] then
-        local key = ow.player.cellX .. "," .. ow.player.cellY
-        local dirs = (POKEMON_TOWER_7F_EXITS[r.index] or {})[key]
-                     or POKEMON_TOWER_7F_EXIT_FALLBACK
-        ow.runner:run({
-          { "show_text", r.after },                       -- DisplayTextID
-          { "walk_npc", r.index, dirs },                  -- MoveSprite
-          { "hide_object", "POKEMON_TOWER_7F", r.name },  -- HideObject
-        }, { npc = npc })
-        return
-      end
-    end
-  end,
   talk = {
     TEXT_POKEMONTOWER7F_MR_FUJI = {
       { "face_player" },                                  -- 1
@@ -605,34 +481,12 @@ local function snorlaxWake(mapId, objName, beatFlag, wokeUpText, calmedText)
   }
 end
 
--- A beaten Snorlax is gone for good: Route12/Route16DefaultScript run
--- HideObject in the same breath as the battle that sets
--- EVENT_BEAT_ROUTEnn_SNORLAX, so "event set, object still on the map" is a
--- state the asm cannot produce.  Here it can (a mod's world:toggleObject, a
--- save edited or migrated from a build older than the flag), and it is a
--- dead end: ItemEffects' adjacentSleepingSnorlax refuses to wake a Snorlax
--- whose beat flag is set (ItemUsePokeFlute's CheckEvent, engine/items/
--- item_effects.asm), so the sleeper sits in the road forever and Cycling
--- Road is unreachable (#585).  Reconcile the toggle from the flag on every
--- entry -- the mirror of SaveData.lua's toggle -> flag backfill, and the
--- same repair shape the Silph Co. floors use below.
-local function hideBeatenSnorlax(mapId, objName, beatFlag)
-  return function(game, ow)
-    if not game.save.flags[beatFlag] then return end
-    local Commands = require("src.script.Commands")
-    Commands.hide_object({ game = game, save = game.save, overworld = ow },
-                         mapId, objName)
-  end
-end
-
 -- snorlaxWake is looked up by ItemEffects.lua/BagMenu.lua (via
 -- data/scripts/init.lua's M.get) and run when the flute wakes Snorlax;
 -- objName/beatFlag let ItemEffects find the NPC and check whether it's
 -- already been beaten before allowing the wake.
 M.ROUTE_12 = {
   talk = { TEXT_ROUTE12_SNORLAX = { { "show_text", "_Route12SnorlaxText" } } },
-  onEnter = hideBeatenSnorlax("ROUTE_12", "ROUTE12_SNORLAX",
-                              "EVENT_BEAT_ROUTE12_SNORLAX"),
   snorlaxWake = {
     objName = "ROUTE12_SNORLAX", beatFlag = "EVENT_BEAT_ROUTE12_SNORLAX",
     script = snorlaxWake("ROUTE_12", "ROUTE12_SNORLAX", "EVENT_BEAT_ROUTE12_SNORLAX",
@@ -641,8 +495,6 @@ M.ROUTE_12 = {
 }
 M.ROUTE_16 = {
   talk = { TEXT_ROUTE16_SNORLAX = { { "show_text", "_Route16Text7" } } },
-  onEnter = hideBeatenSnorlax("ROUTE_16", "ROUTE16_SNORLAX",
-                              "EVENT_BEAT_ROUTE16_SNORLAX"),
   snorlaxWake = {
     objName = "ROUTE16_SNORLAX", beatFlag = "EVENT_BEAT_ROUTE16_SNORLAX",
     script = snorlaxWake("ROUTE_16", "ROUTE16_SNORLAX", "EVENT_BEAT_ROUTE16_SNORLAX",
@@ -674,18 +526,11 @@ M.SAFARI_ZONE_SECRET_HOUSE = {
 M.WARDENS_HOUSE = {
   talk = {
     TEXT_WARDENSHOUSE_WARDEN = {
-      -- Labelled rather than hand-numbered: the branches here have been
-      -- re-pointed twice now (#535, #645), and every insert used to mean
-      -- renumbering three jumps that had no way of announcing they were stale.
       { "face_player" },                                             -- 1
       { "check_flag", "EVENT_GOT_HM04" },                            -- 2
-      -- #535: previously jumped to the same silent-end target as the
-      -- give-then-thank fallthrough, so the warden said nothing on every
-      -- visit after the trade. pokered's .got_item branch
-      -- (scripts/WardensHouse.asm) instead prints HM04ExplanationText.
-      { "jump_if_true", "got_hm04" },                                -- 3
+      { "jump_if_true", 13 },                                        -- 3
       { "check_item", "GOLD_TEETH" },                                -- 4
-      { "jump_if_false", "no_teeth" },                               -- 5
+      { "jump_if_false", 15 },                                       -- 5
       { "show_text", "_WardensHouseWardenGaveTheGoldTeethText" },    -- 6
       { "take_item", "GOLD_TEETH", 1 },                              -- 7
       { "set_flag", "EVENT_GAVE_GOLD_TEETH" },                       -- 8
@@ -694,27 +539,9 @@ M.WARDENS_HOUSE = {
       { "give_item", "HM_STRENGTH", 1, false },                      -- 10
       { "show_text", "_WardensHouseWardenReceivedHM04Text" },        -- 11
       { "set_flag", "EVENT_GOT_HM04" },                              -- 12
-      { "jump", "end" },                                             -- 13 (jp .done)
-
-      -- #645: WardensHouseWardenText prints Gibberish1, then YesNoChoice,
-      -- and the warden answers the same gibberish either way -- Gibberish2
-      -- on yes, Gibberish3 on no (scripts/WardensHouse.asm).  The port
-      -- printed the question and walked off before the answer.
-      { "label", "no_teeth" },                                       -- 14
-      { "ask", "_WardensHouseWardenGibberish1Text" },                -- 15
-      { "jump_if_true", "gibberish_yes" },                           -- 16
-      { "show_text", "_WardensHouseWardenGibberish3Text" },          -- 17
-      { "jump", "end" },                                             -- 18
-      { "label", "gibberish_yes" },                                  -- 19
-      { "show_text", "_WardensHouseWardenGibberish2Text" },          -- 20
-      { "jump", "end" },                                             -- 21
-
-      -- #535: pokered .got_item branch (scripts/WardensHouse.asm) --
-      -- printed on every subsequent talk once EVENT_GOT_HM04 is set.
-      -- Text is _WardensHouseWardenHM04ExplanationText (text/WardensHouse.asm):
-      -- HM04 teaches Strength, and hints at the Safari Zone secret house.
-      { "label", "got_hm04" },                                       -- 22
-      { "show_text", "_WardensHouseWardenHM04ExplanationText" },     -- 23
+      { "jump", 16 },                                                -- 13 (already got it)
+      { "jump", 16 },                                                -- 14 (unused)
+      { "show_text", "_WardensHouseWardenGibberish1Text" },          -- 15
     },
   },
 }
@@ -724,48 +551,6 @@ M.WARDENS_HOUSE = {
 -- generic OPP_GIOVANNI#2 battle)
 -- -------------------------------------------------------------------
 
--- SilphCo11FTeamRocketLeavesScript (scripts/SilphCo11F.asm) hides every
--- ROCKET and rocket-aligned SCIENTIST toggle on 2F-11F the moment Giovanni
--- falls; the item balls, the 2F/10F rescued workers and the 7F rival keep
--- theirs.  Names and order are data/maps/toggleable_objects.asm's
--- TOGGLE_SILPH_CO_<floor>_n entries.  Saffron City's half of the same
--- script lives in M.SAFFRON_CITY (story4.lua) (#392).
-local SILPH_ROCKET_OBJECTS = {
-  { "SILPH_CO_2F",  { "SILPHCO2F_SCIENTIST1", "SILPHCO2F_SCIENTIST2",
-                      "SILPHCO2F_ROCKET1", "SILPHCO2F_ROCKET2" } },
-  { "SILPH_CO_3F",  { "SILPHCO3F_ROCKET", "SILPHCO3F_SCIENTIST" } },
-  { "SILPH_CO_4F",  { "SILPHCO4F_ROCKET1", "SILPHCO4F_SCIENTIST",
-                      "SILPHCO4F_ROCKET2" } },
-  { "SILPH_CO_5F",  { "SILPHCO5F_ROCKET1", "SILPHCO5F_SCIENTIST",
-                      "SILPHCO5F_ROCKER", "SILPHCO5F_ROCKET2" } },
-  { "SILPH_CO_6F",  { "SILPHCO6F_ROCKET1", "SILPHCO6F_SCIENTIST",
-                      "SILPHCO6F_ROCKET2" } },
-  { "SILPH_CO_7F",  { "SILPHCO7F_ROCKET1", "SILPHCO7F_SCIENTIST",
-                      "SILPHCO7F_ROCKET2", "SILPHCO7F_ROCKET3" } },
-  { "SILPH_CO_8F",  { "SILPHCO8F_ROCKET1", "SILPHCO8F_SCIENTIST",
-                      "SILPHCO8F_ROCKET2" } },
-  { "SILPH_CO_9F",  { "SILPHCO9F_ROCKET1", "SILPHCO9F_SCIENTIST",
-                      "SILPHCO9F_ROCKET2" } },
-  { "SILPH_CO_10F", { "SILPHCO10F_ROCKET", "SILPHCO10F_SCIENTIST" } },
-  { "SILPH_CO_11F", { "SILPHCO11F_GIOVANNI", "SILPHCO11F_ROCKET1",
-                      "SILPHCO11F_ROCKET2" } },
-}
-
--- hide_object writes save.objectToggles, so the single pass at the win
--- covers floors the player is not standing on; onlyMap is the per-floor
--- repair path below.
-local function silphRocketsLeave(game, ow, onlyMap)
-  local Commands = require("src.script.Commands")
-  local ctx = { game = game, save = game.save, overworld = ow }
-  for _, floor in ipairs(SILPH_ROCKET_OBJECTS) do
-    if not onlyMap or onlyMap == floor[1] then
-      for _, name in ipairs(floor[2]) do
-        Commands.hide_object(ctx, floor[1], name)
-      end
-    end
-  end
-end
-
 M.SILPH_CO_11F = {
   -- Giovanni's battle is a COORDINATE TRIGGER, not a talk.
   -- SilphCo11FDefaultScript (scripts/SilphCo11F.asm) checks
@@ -792,11 +577,13 @@ M.SILPH_CO_11F = {
     ow:scriptMove(gio, "down", 3, function()
       gio:facePlayer(ow.player)
       ow:engageTrainer(gio, function()
-        -- SilphCo11FTeamRocketLeavesScript: every Silph rocket leaves
+        -- SilphCo11FTeamRocketLeavesScript: Giovanni leaves the floor
         -- after the loss (the street rockets are handled by
         -- M.SAFFRON_CITY.onEnter in story4.lua).
         if game.save.flags.EVENT_BEAT_SILPH_CO_GIOVANNI then
-          silphRocketsLeave(game, ow)
+          local Commands = require("src.script.Commands")
+          local ctx = { game = game, save = game.save, overworld = ow }
+          Commands.hide_object(ctx, "SILPH_CO_11F", "SILPHCO11F_GIOVANNI")
         end
       end)
     end)
@@ -804,51 +591,32 @@ M.SILPH_CO_11F = {
   end,
   onEnter = function(game, ow)
     if game.save.flags.EVENT_BEAT_SILPH_CO_GIOVANNI then
-      silphRocketsLeave(game, ow)
+      local Commands = require("src.script.Commands")
+      local ctx = { game = game, save = game.save, overworld = ow }
+      Commands.hide_object(ctx, "SILPH_CO_11F", "SILPHCO11F_GIOVANNI")
     end
   end,
   talk = {
-    -- SilphCo11FSilphPresidentText branches on EVENT_GOT_MASTER_BALL only:
-    -- the teleport pads reach him without passing Giovanni's trigger, and
-    -- afterwards he describes the ball forever.  The old rows fell off the
-    -- end of the script on both branches, so a second talk was silence
-    -- (#392).
     TEXT_SILPHCO11F_SILPH_PRESIDENT = {
       { "face_player" },                                                     -- 1
-      { "check_flag", "EVENT_GOT_MASTER_BALL" },                             -- 2
-      { "jump_if_true", 9 },                                                 -- 3
-      { "show_text", "_SilphCo11FSilphPresidentText" },                      -- 4
+      { "check_flag", "EVENT_BEAT_SILPH_CO_GIOVANNI" },                      -- 2
+      { "jump_if_false", 10 },                                               -- 3
+      { "check_flag", "EVENT_GOT_MASTER_BALL" },                             -- 4
+      { "jump_if_true", 10 },                                                -- 5
+      { "show_text", "_SilphCo11FSilphPresidentText" },                      -- 6
       -- give-then-print like scripts/SilphCo11F.asm
-      { "give_item", "MASTER_BALL", 1, false },                              -- 5
-      { "show_text", "_SilphCo11FSilphPresidentReceivedMasterBallText" },    -- 6
-      { "set_flag", "EVENT_GOT_MASTER_BALL" },                               -- 7
-      { "jump", "end" },                                                     -- 8
-      { "show_text",
-        "_SilphCo11FSilphPresidentMasterBallDescriptionText" },              -- 9
+      { "give_item", "MASTER_BALL", 1, false },                              -- 7
+      { "show_text", "_SilphCo11FSilphPresidentReceivedMasterBallText" },    -- 8
+      { "set_flag", "EVENT_GOT_MASTER_BALL" },                               -- 9
+      { "jump", 11 },                                                        -- 10
     },
   },
 }
 
--- Floors 2F-10F carry no other onEnter, so this repairs saves that beat
--- Giovanni before the hide list existed (same shape as
--- M.POKEMON_TOWER_7F.onEnter); 11F hides its own inside the table above.
-for _, floor in ipairs(SILPH_ROCKET_OBJECTS) do
-  local mapId = floor[1]
-  if mapId ~= "SILPH_CO_11F" then
-    M[mapId] = M[mapId] or {}
-    M[mapId].onEnter = function(game, ow)
-      if game.save.flags.EVENT_BEAT_SILPH_CO_GIOVANNI then
-        silphRocketsLeave(game, ow, mapId)
-      end
-    end
-  end
-end
-
 -- -------------------------------------------------------------------
 -- Victory Road boulder switches (scripts/VictoryRoad1F/2F/3F.asm):
 -- a boulder resting on a switch removes a barrier block; the 3F hole
--- drops a boulder down to the 2F switch, and also dungeon-warps the
--- player (IsPlayerOnDungeonWarp + DungeonWarpList/Data -> 2F at 22,16).
+-- drops a boulder down to the 2F switch.
 -- -------------------------------------------------------------------
 
 local function boulderAt(ow, x, y)
@@ -856,20 +624,11 @@ local function boulderAt(ow, x, y)
   return npc and npc.def.sprite == "SPRITE_BOULDER" and npc or nil
 end
 
--- Each barrier is stamped BOTH ways on entry.  pokered only ever stamps the
--- OPEN block (ReplaceTileBlock edits the loaded block map, which the next map
--- load throws away, so a fresh entry always shows the .blk's closed barrier),
--- but OverworldState:replaceBlock writes through Map:setBlock into the SHARED
--- map record in Game.data, so the port has to put the closed block back
--- itself or a solved barrier stays open for the rest of the session (#258).
--- The closed ids are the shipped .blk bytes: VictoryRoad1F.blk (4,6) = $25,
--- VictoryRoad2F.blk (3,4) = $37 and (11,7) = $25, VictoryRoad3F.blk
--- (3,5) = $25.  Same both-ways pattern as the card-key doors in
--- OverworldState:setMap.
 M.VICTORY_ROAD_1F = {
   onEnter = function(game, ow)
-    ow:replaceBlock(4, 6,
-      game.save.flags.EVENT_VICTORY_ROAD_1_BOULDER_ON_SWITCH and 0x1D or 0x25)
+    if game.save.flags.EVENT_VICTORY_ROAD_1_BOULDER_ON_SWITCH then
+      ow:replaceBlock(4, 6, 0x1D)
+    end
   end,
   onBoulderMoved = function(game, ow, npc)
     if npc.cellX == 17 and npc.cellY == 13
@@ -882,14 +641,12 @@ M.VICTORY_ROAD_1F = {
 
 M.VICTORY_ROAD_2F = {
   onEnter = function(game, ow)
-    -- VictoryRoad2FResetBoulderEventScript (scripts/VictoryRoad2F.asm:19):
-    -- entering 2F clears the 1F switch event, so 1F's barrier is closed
-    -- again the next time you climb down (#258)
-    game.save.flags.EVENT_VICTORY_ROAD_1_BOULDER_ON_SWITCH = nil
-    ow:replaceBlock(3, 4,
-      game.save.flags.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH1 and 0x15 or 0x37)
-    ow:replaceBlock(11, 7,
-      game.save.flags.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2 and 0x1D or 0x25)
+    if game.save.flags.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH1 then
+      ow:replaceBlock(3, 4, 0x15)
+    end
+    if game.save.flags.EVENT_VICTORY_ROAD_2_BOULDER_ON_SWITCH2 then
+      ow:replaceBlock(11, 7, 0x1D)
+    end
   end,
   onBoulderMoved = function(game, ow, npc)
     if npc.cellX == 1 and npc.cellY == 16
@@ -907,8 +664,9 @@ M.VICTORY_ROAD_2F = {
 
 M.VICTORY_ROAD_3F = {
   onEnter = function(game, ow)
-    ow:replaceBlock(3, 5,
-      game.save.flags.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1 and 0x1D or 0x25)
+    if game.save.flags.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1 then
+      ow:replaceBlock(3, 5, 0x1D)
+    end
   end,
   onBoulderMoved = function(game, ow, npc)
     if npc.cellX == 3 and npc.cellY == 5
@@ -916,38 +674,14 @@ M.VICTORY_ROAD_3F = {
       game.save.flags.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH1 = true
       ow:replaceBlock(3, 5, 0x1D)
     end
-    -- the hole at (23,15): the boulder drops to 2F next to switch 2.
-    -- VictoryRoad3FDefaultScript .handle_hole gates the swap on
-    -- CheckAndSetEvent EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH2, then
-    -- HideObject TOGGLE_VICTORY_ROAD_3F_BOULDER / ShowObject
-    -- TOGGLE_VICTORY_ROAD_2F_BOULDER.  Those two toggles are
-    -- VICTORYROAD3F_BOULDER4 and VICTORYROAD2F_BOULDER3
-    -- (data/maps/toggleable_objects.asm); the old "VICTORYROAD2F_BOULDER"
-    -- matched no object_event name, so the toggle landed under a key
-    -- objectVisible never reads: harmless only while nothing hid that
-    -- boulder, and fatal once Route 23's reset does (#258).
-    if npc.cellX == 23 and npc.cellY == 15
-       and not game.save.flags.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH2 then
-      game.save.flags.EVENT_VICTORY_ROAD_3_BOULDER_ON_SWITCH2 = true
+    -- the hole at (23,15): the boulder drops to 2F next to switch 2
+    if npc.cellX == 23 and npc.cellY == 15 then
       local Commands = require("src.script.Commands")
       local ctx = { save = game.save, overworld = ow, game = game }
       Commands.hide_object(ctx, "VICTORY_ROAD_3F", npc.def.name)
-      Commands.show_object(ctx, "VICTORY_ROAD_2F", "VICTORYROAD2F_BOULDER3")
+      Commands.show_object(ctx, "VICTORY_ROAD_2F", "VICTORYROAD2F_BOULDER")
     end
   end,
-  -- scripts/VictoryRoad3F.asm VictoryRoad3FDefaultScript: the same hole
-  -- is a dungeon warp for the player (wDungeonWarpDestinationMap =
-  -- VICTORY_ROAD_2F, wWhichDungeonWarp = 2 -> DungeonWarpData 22,16).
-  -- Mirrors POKEMON_MANSION_3F.onStep; CAVERN $22 is walkable so the
-  -- fall is onStep, not a collision block.
-  onStep = function(game, ow, x, y)
-    if x == 23 and y == 15 then
-      require("src.core.Sound").play(game.data, "Faint_Fall")
-      ow:startWarpTo("VICTORY_ROAD_2F", 22, 16, ow.player.facing)
-      return true
-    end
-    return false
-  end,
 }
 
 -- -------------------------------------------------------------------
@@ -960,16 +694,6 @@ M.VICTORY_ROAD_3F = {
 -- IndigoPlateauLobby.asm) so the champion is re-fightable on rematches,
 -- like pokered's re-entry cutscene.  EVENT_BEAT_CHAMPION_RIVAL stays set
 -- forever (postgame gates like the Cerulean cave guard read it).
---
--- pokered forces the fight on map entry: Agatha's victory arms
--- SCRIPT_CHAMPIONSROOM_PLAYER_ENTERS (scripts/AgathasRoom.asm), and
--- ChampionsRoomPlayerEntersScript then runs RivalEntrance_RLEMovement
--- (up 1, right 1, up 3) before ChampionsRoomRivalReadyToBattleScript.
--- The rival object has no trainer header / sight range, so without that
--- entrance script the player can walk past (issue #99).  We arm on the
--- run flag instead of Agatha's victory bit: same observable effect for
--- first clear and Indigo rematches, without a cross-map script pointer.
---
 -- scripts/ChampionsRoom.asm ChampionsRoomRivalDefeatedScript ->
 -- OakArrivesScript -> OakCongratulatesPlayerScript ->
 -- OakDisappointedWithRivalScript -> OakComeWithMeScript -> OakExitsScript,
@@ -978,74 +702,43 @@ M.VICTORY_ROAD_3F = {
 -- itself is NOT run here: it belongs to the HALL_OF_FAME room script
 -- (scripts/HallOfFame.asm), so we set a one-shot marker and warp; the room
 -- onEnter (M.HALL_OF_FAME below) drives the HoF Oak speech + record.
-local championsRoomRivalScript = {
-  { "face_player" },                                        -- 1
-  { "check_flag", "EVENT_BEAT_CHAMPION_RIVAL_THIS_RUN" },   -- 2
-  { "jump_if_true", 26 },                                   -- 3  past end
-  { "show_text", "_ChampionsRoomRivalIntroText" },          -- 4
-  -- ChampionsRoomRivalReadyToBattleScript plays MUSIC_FINAL_BATTLE after
-  -- the intro text, before the battle itself (#706); pushBattle's wipe-time
-  -- playBattle("final") then no-ops on the same song, so the theme stays
-  -- continuous into the fight
-  { "play_music", "Music_FinalBattle" },                    -- 5
-  { "rival_battle", "OPP_RIVAL3", 1 },                      -- 6
-  { "jump_if_false", 26 },                                  -- 6  past end
-  { "set_flag", "EVENT_BEAT_CHAMPION_RIVAL_THIS_RUN" },     -- 7
-  { "set_flag", "EVENT_BEAT_CHAMPION_RIVAL" },              -- 8
-  -- ChampionsRoomRivalDefeatedScript re-displays TEXT_CHAMPIONSROOM_RIVAL,
-  -- whose text_asm takes the EVENT_BEAT_CHAMPION_RIVAL branch =
-  -- _ChampionsRoomRivalAfterBattleText (the in-battle _RivalDefeatedText
-  -- is the port's generic "<PLAYER> defeated BLUE!" engine line instead).
-  { "show_text", "_ChampionsRoomRivalAfterBattleText" },    -- 9
-  -- ChampionsRoomOakArrivesScript: Music_Cities1AlternateTempo
-  -- (Cities1, kept into HALL_OF_FAME like BIT_NO_MAP_MUSIC after
-  -- defeating RIVAL3), then Oak's "{PLAYER}!" + reveal + walk in
-  { "play_music", "Music_Cities1", { keep = true } },       -- 10
-  { "show_text", "_ChampionsRoomOakText" },                 -- 11
-  { "show_object", "CHAMPIONS_ROOM", "CHAMPIONSROOM_OAK" },  -- 12
-  { "move_npc", 2, "up", 5 },                               -- 13 OakEntranceAfterVictoryMovement
-  -- OakCongratulatesPlayerScript: rival faces left, Oak faces down
-  { "face_object", 1, "left" },                             -- 14
-  { "face_object", 2, "down" },                             -- 15
-  { "show_text", "_ChampionsRoomOakCongratulatesPlayerText" }, -- 16
-  -- OakDisappointedWithRivalScript: Oak turns to the rival (right)
-  { "face_object", 2, "right" },                            -- 17
-  { "show_text", "_ChampionsRoomOakDisappointedWithRivalText" }, -- 18
-  -- OakComeWithMeScript: Oak faces down again, then exits up
-  { "face_object", 2, "down" },                             -- 19
-  { "show_text", "_ChampionsRoomOakComeWithMeText" },       -- 20
-  { "move_npc", 2, "up", 2 },                               -- 21 OakExitChampionsRoomMovement
-  { "hide_object", "CHAMPIONS_ROOM", "CHAMPIONSROOM_OAK" },  -- 22
-  -- hand the induction off to the HALL_OF_FAME room (consumed by its
-  -- onEnter), then warp up into it (destWarp 1 lands at (4,7) facing up)
-  { "set_field", "pendingHallOfFame", true },               -- 23
-  { "warp", "HALL_OF_FAME", 4, 7, "up" },                   -- 24
-}
-
 M.CHAMPIONS_ROOM = {
-  onEnter = function(game, ow)
-    if game.save.flags.EVENT_BEAT_CHAMPION_RIVAL_THIS_RUN then return end
-    -- Lance entrance warps land at y=7; HoF return warps land at y=0.
-    -- Only the south entry should run ChampionsRoomPlayerEntersScript.
-    if ow.player.cellY < 7 then return end
-    local rival
-    for _, npc in ipairs(ow.npcs) do
-      if npc.def and npc.def.name == "CHAMPIONSROOM_RIVAL" then
-        rival = npc
-        break
-      end
-    end
-    -- RivalEntrance_RLEMovement, then the battle/Oak script (queued
-    -- separately so talk-script jump indices stay 1-based as written).
-    ow:queueScript({
-      { "move_player", "up", 1 },
-      { "move_player", "right", 1 },
-      { "move_player", "up", 3 },
-    })
-    ow:queueScript(championsRoomRivalScript, { npc = rival })
-  end,
   talk = {
-    TEXT_CHAMPIONSROOM_RIVAL = championsRoomRivalScript,
+    TEXT_CHAMPIONSROOM_RIVAL = {
+      { "face_player" },                                        -- 1
+      { "check_flag", "EVENT_BEAT_CHAMPION_RIVAL_THIS_RUN" },   -- 2
+      { "jump_if_true", 24 },                                   -- 3
+      { "show_text", "_ChampionsRoomRivalIntroText" },          -- 4
+      { "rival_battle", "OPP_RIVAL3", 1 },                      -- 5
+      { "jump_if_false", 24 },                                  -- 6
+      { "set_flag", "EVENT_BEAT_CHAMPION_RIVAL_THIS_RUN" },     -- 7
+      { "set_flag", "EVENT_BEAT_CHAMPION_RIVAL" },              -- 8
+      -- ChampionsRoomRivalDefeatedScript re-displays TEXT_CHAMPIONSROOM_RIVAL,
+      -- whose text_asm takes the EVENT_BEAT_CHAMPION_RIVAL branch =
+      -- _ChampionsRoomRivalAfterBattleText (the in-battle _RivalDefeatedText
+      -- is the port's generic "<PLAYER> defeated BLUE!" engine line instead).
+      { "show_text", "_ChampionsRoomRivalAfterBattleText" },    -- 9
+      -- ChampionsRoomOakArrivesScript: Oak's "{PLAYER}!" then reveal + walk in
+      { "show_text", "_ChampionsRoomOakText" },                 -- 10
+      { "show_object", "CHAMPIONS_ROOM", "CHAMPIONSROOM_OAK" },  -- 11
+      { "move_npc", 2, "up", 5 },                               -- 12 OakEntranceAfterVictoryMovement (3,7)->(3,2)
+      -- OakCongratulatesPlayerScript: rival faces left, Oak faces down
+      { "face_object", 1, "left" },                             -- 13
+      { "face_object", 2, "down" },                             -- 14
+      { "show_text", "_ChampionsRoomOakCongratulatesPlayerText" }, -- 15
+      -- OakDisappointedWithRivalScript: Oak turns to the rival (right)
+      { "face_object", 2, "right" },                            -- 16
+      { "show_text", "_ChampionsRoomOakDisappointedWithRivalText" }, -- 17
+      -- OakComeWithMeScript: Oak faces down again, then exits up
+      { "face_object", 2, "down" },                             -- 18
+      { "show_text", "_ChampionsRoomOakComeWithMeText" },       -- 19
+      { "move_npc", 2, "up", 2 },                               -- 20 OakExitChampionsRoomMovement (3,2)->(3,0)
+      { "hide_object", "CHAMPIONS_ROOM", "CHAMPIONSROOM_OAK" },  -- 21
+      -- hand the induction off to the HALL_OF_FAME room (consumed by its
+      -- onEnter), then warp up into it (destWarp 1 lands at (4,7) facing up)
+      { "set_field", "pendingHallOfFame", true },               -- 22
+      { "warp", "HALL_OF_FAME", 4, 7, "up" },                   -- 23
+    },
   },
 }
 
@@ -1136,23 +829,16 @@ M.HALL_OF_FAME = {
 
 M.CERULEAN_CITY = {
   talk = {
-    -- CeruleanCityRivalText: Bill line once beaten; pre-battle otherwise.
-    -- Post-fight walk matches CeruleanCityMovement4 (right then into town).
     TEXT_CERULEANCITY_RIVAL = {
-      { "face_player" },                                         -- 1
-      { "check_flag", "EVENT_BEAT_CERULEAN_RIVAL" },             -- 2
-      { "jump_if_true", 13 },                                    -- 3
-      { "show_text", "_CeruleanCityRivalPreBattleText" },        -- 4
-      { "rival_battle", "OPP_RIVAL1", 7 },                       -- 5
-      { "jump_if_false", "end" },                                -- 6
-      { "set_flag", "EVENT_BEAT_CERULEAN_RIVAL" },               -- 7
-      { "show_text", "_CeruleanCityRivalDefeatedText" },         -- 8
-      { "show_text", "_CeruleanCityRivalIWentToBillsText" },     -- 9
-      { "walk_npc", 1, { "right", "down", "down", "down",
-                         "down", "down", "down" } },             -- 10
-      { "hide_object", "CERULEAN_CITY", "CERULEANCITY_RIVAL" },  -- 11
-      { "jump", "end" },                                         -- 12
-      { "show_text", "_CeruleanCityRivalIWentToBillsText" },     -- 13
+      { "face_player" },                                    -- 1
+      { "check_flag", "EVENT_BEAT_CERULEAN_RIVAL" },        -- 2
+      { "jump_if_true", 9 },                                -- 3
+      { "show_text", "_CeruleanCityRivalPreBattleText" },   -- 4
+      { "rival_battle", "OPP_RIVAL1", 7 },                  -- 5
+      { "jump_if_false", 10 },                              -- 6
+      { "set_flag", "EVENT_BEAT_CERULEAN_RIVAL" },          -- 7
+      { "show_text", "_CeruleanCityRivalDefeatedText" },    -- 8
+      { "jump", 10 },                                       -- 9
     },
   },
 }

data/scripts/story2.lua

@@ -1,10 +1,6 @@
 -- More hand-ported events: the Pallet Town intro, the thirsty Saffron
 -- gate guards, the Bike Voucher chain, fossils and the day-care.
--- Registered via data/scripts/init.lua; Red/Blue cite pokered, Yellow
--- cites pokeyellow (Pallet stop row, Oak spawn, walk RLE, and the
--- wild-Pikachu beat before the lab escort).
-
-local GameVersion = require("src.core.GameVersion")
+-- Registered via data/scripts/init.lua; each cites its pokered source.
 
 local M = {}
 
@@ -39,79 +35,72 @@ function escort.findPath(fromX, fromY, toX, toY)
   return path
 end
 
--- Red: Oak object (8,5) -> one tile below the player at y=1.
--- Yellow: Oak object (10,4); stop fires at y=0 (pokeyellow PalletTown).
+-- PalletTownOakWalksToPlayerScript: Oak appears at his object spot
+-- (8,5) and zigzags to one tile below the player (hNPCPlayerYDistance
+-- is pre-decremented before predef FindPathToPlayer).
 function escort.oakApproach(playerX)
-  if GameVersion.isYellow() then
-    return escort.findPath(10, 4, playerX, 1)
-  end
   return escort.findPath(8, 5, playerX, 2)
 end
 
--- RLEList_ProfOakWalkToLab (engine/overworld/auto_movement.asm).
--- Yellow differs: first DOWN is x6 (Oak starts one tile farther north).
-local function buildOakSteps()
-  if GameVersion.isYellow() then
-    return {
-      "down", "down", "down", "down", "down", "down",
-      "left",
-      "down", "down", "down", "down", "down",
-      "right", "right", "right",
-      "up",
-    }
-  end
-  return {
-    "down", "down", "down", "down", "down",
-    "left",
-    "down", "down", "down", "down", "down",
-    "right", "right", "right",
-    "up",
-  }
-end
+-- RLEList_ProfOakWalkToLab (engine/overworld/auto_movement.asm):
+-- DOWN x5, LEFT, DOWN x5, RIGHT x3, UP -- Oak's last step lands on the
+-- lab door (12,11).  (The trailing NPC_CHANGE_FACING is a march-in-
+-- place beat on the mat; here Oak just stands his final beat.)
+escort.oakSteps = {
+  "down", "down", "down", "down", "down",
+  "left",
+  "down", "down", "down", "down", "down",
+  "right", "right", "right",
+  "up",
+}
 
-escort.oakSteps = buildOakSteps()
-
--- Player stays one step behind Oak (simplified reverse-RLE port).
+-- RLEList_PlayerWalkToLab decodes to UP x2, RIGHT x3, DOWN x5, LEFT,
+-- DOWN x6 and plays in REVERSE buffer order (wSimulatedJoypadStatesEnd
+-- grows downward): DOWN x6, LEFT, DOWN x5, RIGHT x3, UP x2 -- Oak's
+-- exact path one step behind.  The 17th press (the second UP) is eaten
+-- by the door-warp frame (WarpFound clears hJoyHeld via EnterMap), so
+-- only 16 real steps happen; the walk ends on the door at (12,11).
 escort.playerSteps = { "down" }
 for _, d in ipairs(escort.oakSteps) do
   escort.playerSteps[#escort.playerSteps + 1] = d
 end
 
-local function npcNamed(ow, name)
-  for _, n in ipairs(ow.npcs or {}) do
-    if n.def and n.def.name == name then return n end
-  end
-  return nil
-end
-
 M.PALLET_TOWN = {
   talk = require("data.scripts.pallet_town").talk,
   escort = escort,
-  -- Red: stop at y==1 from (8,5).  Yellow: stop at y==0 from (10,4),
-  -- then a wild Pikachu battle before the lab escort (pokeyellow
-  -- PalletTownPikachuBattleScript).
+  -- Oak stops you at the north row (PalletTownDefaultScript's
+  -- `wYCoord == 1` check), walks up from (8,5), and leads you to his
+  -- lab with the player one step behind (scripts/PalletTown.asm +
+  -- PalletMovementScriptPointerTable in
+  -- engine/overworld/auto_movement.asm), then the lab walk-in and the
+  -- choose-mon exchange (scripts/OaksLab.asm OaksLabDefaultScript ..
+  -- OaksLabOakChooseMonSpeechScript).
   onStep = function(game, ow, x, y)
-    local yellow = GameVersion.isYellow()
-    local stopY = yellow and 0 or 1
-    if y ~= stopY or game.save.flags.EVENT_FOLLOWED_OAK_INTO_LAB
+    if y ~= 1 or game.save.flags.EVENT_FOLLOWED_OAK_INTO_LAB
        or game.save.flags.EVENT_GOT_STARTER then
       return false
     end
     local TextBox = require("src.render.TextBox")
     local Commands = require("src.script.Commands")
     local Music = require("src.core.Music")
-    local BattleState = require("src.battle.BattleState")
     local t = game.data.text
     local ctx = { save = game.save, game = game, overworld = ow }
 
-    -- Red turns the player down; Yellow faces up at the north exit.
-    ow.player.facing = yellow and "up" or "down"
+    -- PalletTownDefaultScript: stop the player, turn them around
+    -- (wPlayerMovingDirection = PLAYER_DIR_DOWN applies on the very
+    -- next frame, before the text box opens) and strike up the "oak
+    -- appears" theme (MUSIC_MEET_PROF_OAK)
+    ow.player.facing = "down"
     Music.play(game.data, "Music_MeetProfOak")
 
+    -- DelayFrames-style hold: the world pauses (input stays locked)
+    -- for `frames` frames, then cb runs.  Reuses the emote pause slot;
+    -- with an `npc` the "!" bubble draws above it (EmotionBubble).
     local function hold(frames, npc, cb)
       ow.emote = { frames = frames, npc = npc, onDone = cb }
     end
 
+    -- chain single-tile scriptMoves through a direction list
     local function walkList(entity, steps, done)
       local i = 0
       local function nextStep()
@@ -125,8 +114,10 @@ M.PALLET_TOWN = {
       nextStep()
     end
 
-    -- OaksLabOakChooseMonSpeechScript.  Yellow's OakChooseMon text is
-    -- the single-ball speech, not Red's "there are 3 POKéMON".
+    -- ---- Oak's Lab side (scripts/OaksLab.asm) ----------------------
+
+    -- OaksLabOakChooseMonSpeechScript: the fed-up / choose-mon /
+    -- what-about-me / be-patient exchange, Delay3 between boxes
     local function chooseMonSpeech()
       local function say(key, fb, next)
         game.stack:push(TextBox.new(game, t[key] or fb, next))
@@ -135,9 +126,7 @@ M.PALLET_TOWN = {
           "{RIVAL}: Gramps!\nI'm fed up with\nwaiting!", function()
         hold(3, nil, function()
           say("_OaksLabOakChooseMonText",
-              yellow
-                and "OAK: Look, {PLAYER}! Do\nyou see that ball\non the table?"
-                or "OAK: Here, {PLAYER}!\fThere are 3\nPOKéMON here!\fYou can have one!\nChoose!", function()
+              "OAK: Here, {PLAYER}!\fThere are 3\nPOKéMON here!\fYou can have one!\nChoose!", function()
             hold(3, nil, function()
               say("_OaksLabRivalWhatAboutMeText",
                   "{RIVAL}: Hey!\nGramps! What\nabout me?", function()
@@ -154,18 +143,30 @@ M.PALLET_TOWN = {
       end)
     end
 
-    -- Door Oak is OAKSLAB_OAK2: Red index 8, Yellow index 6 (one ball).
+    -- entering the lab: the door Oak (OAKSLAB_OAK2, (5,10)) walks up 3
+    -- ahead of the player (OaksLabOakEntersLabScript OakEntryMovement),
+    -- swaps for the desk Oak (OAKSLAB_OAK1, (5,2)), then the player
+    -- walks up 8 from the mat (PlayerEntryMovementRLE) while the rival
+    -- and Oak turn with them (OaksLabPlayerEntersLabScript /
+    -- OaksLabFollowedOakScript)
     local function labWalkIn()
-      local oak2 = npcNamed(ow, "OAKSLAB_OAK2") or ow:npcByIndex(yellow and 6 or 8)
+      local oak2 = ow:npcByIndex(8)
       local function swapOaks()
         Commands.hide_object(ctx, "OAKS_LAB", "OAKSLAB_OAK2")
         Commands.show_object(ctx, "OAKS_LAB", "OAKSLAB_OAK1")
-        hold(3, nil, function()
-          Commands.face_object(ctx, 1, "down")
+        hold(3, nil, function() -- Delay3
+          Commands.face_object(ctx, 1, "down") -- rival watches you pass
           ow:scriptMove(ow.player, "up", 8, function()
+            -- OaksLabFollowedOakScript: flags only after the walk-in, so a
+            -- stray step on the door mat can't fire the "don't go away"
+            -- push-up (oaks_lab.lua onStep) mid-cutscene.  Outdoor escort
+            -- still re-arms on F1 mid-escort -- these flags stay clear
+            -- until the lab walk finishes.
             game.save.flags.EVENT_FOLLOWED_OAK_INTO_LAB = true
             game.save.flags.EVENT_FOLLOWED_OAK_INTO_LAB_2 = true
             Commands.face_object(ctx, 1, "up")
+            -- res BIT_NO_MAP_MUSIC + PlayDefaultMusic: the lab theme
+            -- only starts once the walk-in is done
             Music.playMap(game.data, "OAKS_LAB")
             chooseMonSpeech()
           end)
@@ -178,6 +179,9 @@ M.PALLET_TOWN = {
       end
     end
 
+    -- PalletMovementScript_Done + the door warp: Oak is hidden as the
+    -- player steps into the doorway; PALLET_TOWN warp 3 -> OAKS_LAB
+    -- warp 2 = (5,11), with the door SFX (WarpFound -> SFX_GO_INSIDE)
     local function enterLab()
       Commands.hide_object(ctx, "PALLET_TOWN", "PALLETTOWN_OAK")
       Commands.show_object(ctx, "OAKS_LAB", "OAKSLAB_OAK2")
@@ -186,6 +190,10 @@ M.PALLET_TOWN = {
                      { keepMusic = true })
     end
 
+    -- PalletMovementScript_WalkToLab: Oak's NPC movement and the
+    -- player's simulated joypad run simultaneously, in lockstep; the
+    -- player retraces Oak's path one step behind and follows him into
+    -- the doorway on the final beat
     local function walkToLab(oak)
       local i = 0
       local function tick()
@@ -198,6 +206,9 @@ M.PALLET_TOWN = {
         if oak and escort.oakSteps[i] then
           ow:scriptMove(oak, escort.oakSteps[i], 1)
         elseif oak then
+          -- RLEList_ProfOakWalkToLab's trailing NPC_CHANGE_FACING beat:
+          -- Oak marches in place on the door mat while the player takes
+          -- the final step up behind him (movement.asm ChangeFacingDirection)
           ow:marchInPlace(oak)
         end
         ow:scriptMove(ow.player, playerStep, 1, tick)
@@ -205,6 +216,9 @@ M.PALLET_TOWN = {
       tick()
     end
 
+    -- PalletMovementScript_OakMoveLeft/_PlayerMoveLeft: from the right
+    -- tile (x == 11) Oak sidesteps left first, then the player follows
+    -- left (wNumStepsToTake = wXCoord - 10), and only then both walk
     local function escortToLab(oak)
       local numSteps = x - 10
       if oak and numSteps > 0 then
@@ -218,65 +232,37 @@ M.PALLET_TOWN = {
       end
     end
 
-    -- After Oak reaches the player: Red goes straight to "It's unsafe!".
-    -- Yellow (PalletTownOakGreetsPlayerScript..AfterPikachuBattleScript):
-    -- ThatWasClose -> Oak faces the grass patch -> BATTLE_TYPE_PIKACHU
-    -- (the old-man-style simulated battle where PROF.OAK throws the ball
-    -- and always catches the lv5 Pikachu) -> Whew -> ComeWithMe.
-    local function afterOakArrives(oak)
-      if not yellow then
-        game.stack:push(TextBox.new(game,
-          t._PalletTownOakItsUnsafeText
-          or "OAK: It's unsafe!\nWild POKéMON\nlive in tall grass!",
-          function() escortToLab(oak) end))
-        return
-      end
-      local function comeWithMe()
-        game.stack:push(TextBox.new(game,
-          t._PalletTownOakComeWithMe
-          or "OAK: Here, come with\nme!",
-          function() escortToLab(oak) end))
-      end
-      local function afterPikaBattle()
-        if oak then oak.facing = "up" end
-        game.stack:push(TextBox.new(game,
-          t._PalletTownOakWhewText or "OAK: Whew...",
-          comeWithMe))
-      end
-      game.stack:push(TextBox.new(game,
-        t._PalletTownOakThatWasCloseText
-        or "OAK: That was\nclose!\fWild POKéMON live\nin tall grass!",
-        function()
-          -- Oak turns toward the horizontally adjacent grass (left exit
-          -- looks right, right exit looks left -- the
-          -- EVENT_PLAYER_AT_RIGHT_EXIT_TO_PALLET_TOWN branch)
-          if oak then oak.facing = x == 10 and "right" or "left" end
-          local battle = BattleState.newWild(game, "PIKACHU", 5)
-          battle:makeOldManDemo("PROF.OAK")
-          battle.onFinish = function()
-            afterPikaBattle()
-          end
-          game.stack:push(battle)
-        end))
-    end
+    -- ---- Pallet Town side (scripts/PalletTown.asm) -----------------
 
+    -- PalletTownOakWalksToPlayerScript: Oak appears at (8,5), faces up
+    -- (SetSpriteFacingDirectionAndDelay + Delay3), then zigzags to the
+    -- player; the "It's unsafe!" text follows and the escort begins
     local function oakAppearsAndWalks()
       Commands.show_object(ctx, "PALLET_TOWN", "PALLETTOWN_OAK")
-      local oak = npcNamed(ow, "PALLETTOWN_OAK") or ow:npcByIndex(1)
+      local oak = ow:npcByIndex(1)
       if oak then oak.facing = "up" end
       hold(6, nil, function()
         walkList(oak, escort.oakApproach(x), function()
-          afterOakArrives(oak)
+          -- PalletTownOakNotSafeComeWithMeScript: the second text waits
+          -- for a button, then the escort starts
+          game.stack:push(TextBox.new(game,
+            t._PalletTownOakItsUnsafeText
+            or "OAK: It's unsafe!\nWild POKéMON\nlive in tall grass!",
+            function() escortToLab(oak) end))
         end)
       end)
     end
 
+    -- The "Hey! Wait!" box ends without a button wait (auto), then the
+    -- "!" bubble shows over the player WHILE the box is still on screen
+    -- (PalletTownOakText: DelayFrames 10 then EmotionBubble, box not yet
+    -- cleared).  onOverlap sets the bubble during the box's last frames;
+    -- the box pops after `overlap`, and the bubble's 60-frame hold then
+    -- runs to Oak's appearance (the bubble is static while the box is up,
+    -- since the overworld pauses under it, so 10 overlap + 50 = 60).
     game.stack:push(TextBox.new(game,
       t._PalletTownOakHeyWaitDontGoOutText or "OAK: Hey! Wait!\nDon't go out!",
       nil, { auto = { delay = 10, overlap = 10, onOverlap = function()
-        -- .HeyWaitDontGoOutText turns the player to face down (toward
-        -- the approaching Oak) before the exclamation bubble
-        ow.player.facing = "down"
         ow.emote = { npc = ow.player, frames = 50, onDone = oakAppearsAndWalks }
       end } }))
     return true
@@ -413,141 +399,22 @@ M.POKEMON_FAN_CLUB = {
   },
 }
 
--- BikeShopClerkText (scripts/BikeShop.asm) runs three ways: the BICYCLE is
--- already yours, you are carrying the BIKE VOUCHER, or you get the sales
--- pitch.  The pitch draws its own window (TextBoxBorder hlcoord 0,0, b=4
--- c=15) holding BikeShopMenuText and BikeShopMenuPrice, and leaves it up
--- while the clerk keeps talking in the bottom box: the original never
--- erases it before TextScriptEnd (#568).
-local BikeShopWindow = {}
-BikeShopWindow.__index = BikeShopWindow
-
-function BikeShopWindow.new(game, footer, onChoose)
-  local self = setmetatable({}, BikeShopWindow)
-  self.game = game
-  self.onChoose = onChoose
-  self.index = 1
-  self.active = true
-  -- BikeShopClerkDoYouLikeItText stays on screen under the window for as
-  -- long as the menu is up.  The text box pushed on top types it out and
-  -- pops itself; this copy of its last page takes over from there, so the
-  -- bottom box never blanks between the pitch and the answer.  Paginated
-  -- with the themed column budget so the copy breaks where the box did.
-  local TextBox = require("src.render.TextBox")
-  local box = require("src.ui.Theme").textBox or {}
-  local pages = TextBox.paginate(TextBox.substitute(game, footer), box.maxCols)
-  self.footer = pages[#pages]
-  return self
-end
-
-function BikeShopWindow:update()
-  -- one answer only: the boxes pushed by onChoose sit on top of this
-  -- state, but a second A on the same frame must not fire it twice
-  if not self.active then return end
-  local input = self.game.input
-  -- HandleMenuInput with wMenuWrappingEnabled clear: the two rows clamp
-  if input:wasPressed("up") then
-    self.index = 1
-  elseif input:wasPressed("down") then
-    self.index = 2
-  elseif input:wasPressed("a") or input:wasPressed("b") then
-    local cancelled = input:wasPressed("b") -- bit B_PAD_B -> .cancel
-    require("src.core.Sound").play(self.game.data, "Press_AB")
-    self.active = false
-    self.onChoose(not cancelled and self.index == 1)
-  end
-end
-
-function BikeShopWindow:draw()
-  local Font = require("src.render.Font")
-  local Strings = require("src.core.Strings")
-  local Theme = require("src.ui.Theme")
-  Font.drawBox(0, 0, 17, 6)
-  love.graphics.setColor(0, 0, 0, 1)
-  local bike = self.game.data.items.BICYCLE
-  Font.draw(bike and bike.name or "BICYCLE", 16, 16)  -- hlcoord 2, 2
-  Font.draw("¥1000000", 64, 24)                       -- hlcoord 8, 3
-  Font.draw(Strings("CANCEL"), 16, 32)                -- `next` skips a row
-  -- wTopMenuItemX 1, wTopMenuItemY 2, rows two apart
-  Font.drawCode(Theme.cursor, 8, self.index == 1 and 16 or 32)
-  if self.footer then
-    -- same geometry TextBox resolves against, so a themed box matches
-    local box = Theme.textBox or {}
-    local tx, ty = box.tx or 0, box.ty or 12
-    love.graphics.setColor(1, 1, 1, 1)
-    Font.drawBox(tx, ty, box.tw or 20, box.th or 6)
-    love.graphics.setColor(0, 0, 0, 1)
-    for i, line in ipairs(self.footer) do
-      Font.draw(line, (tx + 1) * 8, (ty + 2 * i) * 8)
-    end
-  end
-  love.graphics.setColor(1, 1, 1, 1)
-end
-
 M.BIKE_SHOP = {
   talk = {
     TEXT_BIKESHOP_CLERK = function(game, ow, npc, done)
-      local Bag = require("src.inventory.Bag")
-      local Flags = require("src.script.Flags")
       local TextBox = require("src.render.TextBox")
-      local t = game.data.text
-      local function say(text, after, opts)
-        game.stack:push(TextBox.new(game, text, after, opts))
+      if (game.save.inventory.BICYCLE or 0) > 0 then
+        game.stack:push(TextBox.new(game, "How's the\nBICYCLE treating\nyou?", done))
+      elseif (game.save.inventory.BIKE_VOUCHER or 0) > 0 then
+        game.save.inventory.BIKE_VOUCHER = nil
+        game.save.inventory.BICYCLE = 1
+        game.stack:push(TextBox.new(game,
+          ("Oh, that's a\nBIKE VOUCHER!\f%s exchanged\nit for a BICYCLE!")
+          :format(game.save.player.name), done))
+      else
+        game.stack:push(TextBox.new(game,
+          "A BICYCLE costs\n¥1000000. Sorry,\nno instalments!", done))
       end
-
-      -- CheckEvent EVENT_GOT_BICYCLE.  Saves made before the clerk started
-      -- setting the event still have the bike in the bag, so either counts.
-      if (game.save.inventory.BICYCLE or 0) > 0
-          or Flags.get(game.save, "EVENT_GOT_BICYCLE") then
-        say(t._BikeShopClerkHowDoYouLikeYourBicycleText, done)
-        return
-      end
-
-      -- .dontHaveBike: IsItemInBag BIKE_VOUCHER
-      if (game.save.inventory.BIKE_VOUCHER or 0) > 0 then
-        say(t._BikeShopClerkOhThatsAVoucherText, function()
-          -- GiveItem's `jr nc, .BagFull`: the voucher is only spent once
-          -- the BICYCLE is actually in the bag
-          if not Bag.add(game.save, "BICYCLE", 1) then
-            say(t._BikeShopBagFullText, done)
-            return
-          end
-          Bag.remove(game.save, "BIKE_VOUCHER", 1)
-          Flags.set(game.save, "EVENT_GOT_BICYCLE")
-          -- BikeShopExchangedVoucherText carries sound_get_key_item; the
-          -- map runs EnableAutoTextBoxDrawing, so the box still waits for
-          -- a button once the jingle has played (auto.wait, #247)
-          say(t._BikeShopExchangedVoucherText, done, {
-            auto = { wait = true, sound = function()
-              return require("src.core.Sound").play(game.data, "Get_Key_Item")
-            end },
-          })
-        end)
-        return
-      end
-
-      -- .dontHaveVoucher: welcome, then the BICYCLE/CANCEL window
-      say(t._BikeShopClerkWelcomeText, function()
-        local pitch = t._BikeShopClerkDoYouLikeItText
-        game.stack:push(BikeShopWindow.new(game, pitch, function(bought)
-          local function comeAgain()
-            say(t._BikeShopComeAgainText, function()
-              game.stack:pop() -- the window, still up under the text
-              done()
-            end)
-          end
-          if bought then
-            -- a million is out of anyone's reach: BikeShopCantAffordText
-            say(t._BikeShopCantAffordText, comeAgain)
-          else
-            comeAgain()
-          end
-        end))
-        -- PrintText BikeShopClerkDoYouLikeItText, then straight into
-        -- HandleMenuInput: the box types out and hands over without
-        -- waiting, leaving the window's copy of the line on screen
-        say(pitch, nil, { auto = { delay = 0 } })
-      end)
     end,
   },
 }
@@ -578,67 +445,33 @@ local function engageSuperNerd(game, ow, onDone)
   ow:engageTrainer(nerd, onDone)
 end
 
--- MtMoonB2FMoveSuperNerdScript: player-near-dome coords walk RIGHT then
--- UP (MoveRight falls through into MoveUp); near-helix walks UP only.
-local function mtMoonNerdWalk(px, py, itemId)
-  if (px == 12 and py == 7) or (px == 11 and py == 6) or (px == 12 and py == 5) then
-    return { "right", "up" }
-  end
-  if (px == 13 and py == 7) or (px == 14 and py == 6) or (px == 14 and py == 5) then
-    return { "up" }
-  end
-  return (itemId == "DOME_FOSSIL") and { "right", "up" } or { "up" }
-end
-
--- scripts/MtMoonB2F.asm Dome/Helix fossil text_asm + MoveSuperNerd +
--- SuperNerdTakesOtherFossil: pick one, hide it, walk the nerd to the
--- other, "All right. Then this is mine!", hide the other.
-local function mtMoonFossil(itemId, otherName, gotFlag)
+local function mtMoonFossil(itemId, otherName)
   return function(game, ow, npc, done)
     local TextBox = require("src.render.TextBox")
-    local t = game.data.text
-    local flags = game.save.flags
-    if flags.EVENT_GOT_DOME_FOSSIL or flags.EVENT_GOT_HELIX_FOSSIL then
-      done()
+    local ChoiceBox = require("src.ui.ChoiceBox")
+    if game.save.flags.EVENT_GOT_A_FOSSIL then
+      game.stack:push(TextBox.new(game, "You already took\na fossil.", done))
       return
     end
+    -- can't grab a fossil until the Super Nerd is beaten -- he intercepts
     if not superNerdBeaten(ow) then
       engageSuperNerd(game, ow, done)
       return
     end
-    local want = (itemId == "DOME_FOSSIL")
-      and (t._MtMoonB2FDomeFossilYouWantText or "You want the\nDOME FOSSIL?")
-      or (t._MtMoonB2FHelixFossilYouWantText or "You want the\nHELIX FOSSIL?")
-    game.stack:push(TextBox.new(game, want, nil, { choice = function(yes)
-      if not yes then done() return end
-      if not require("src.inventory.Bag").add(game.save, itemId, 1) then
+    local name = game.data.items[itemId].name
+    game.stack:push(TextBox.new(game, ("You want the\n%s?"):format(name), function()
+      game.stack:push(ChoiceBox.new(game, function(yes)
+        if not yes then done() return end
+        game.save.inventory[itemId] = 1
+        game.save.flags.EVENT_GOT_A_FOSSIL = true
+        local Commands = require("src.script.Commands")
+        local ctx = { save = game.save, overworld = ow, game = game }
+        Commands.hide_object(ctx, "MT_MOON_B2F", npc.def.name)
+        Commands.hide_object(ctx, "MT_MOON_B2F", otherName)
         game.stack:push(TextBox.new(game,
-          t._MtMoonB2FYouHaveNoRoomText or "Look, you've got\nno room for this.",
-          done))
-        return
-      end
-      local idef = game.data.items[itemId]
-      game.stringBuffer = idef and idef.name or itemId
-      require("src.core.Sound").play(game.data, "Get_Key_Item")
-      local dirs = mtMoonNerdWalk(ow.player.cellX, ow.player.cellY, itemId)
-      game.stack:push(TextBox.new(game,
-        t._MtMoonB2FReceivedFossilText
-          or ("{PLAYER} got the\n" .. game.stringBuffer .. "!"),
-        function()
-          local Commands = require("src.script.Commands")
-          Commands.hide_object(
-            { save = game.save, overworld = ow, game = game },
-            "MT_MOON_B2F", npc.def.name)
-          flags[gotFlag] = true
-          ow.runner:run({
-            { "walk_npc", 1, dirs },
-            { "text_opts", { auto = true } },
-            { "show_text", "_MtMoonB2FSuperNerdThenThisIsMineText" },
-            { "play_sound", "Get_Key_Item" },
-            { "hide_object", "MT_MOON_B2F", otherName },
-          }, { onDone = done })
-        end))
-    end }))
+          ("%s got the\n%s!"):format(game.save.player.name, name), done))
+      end))
+    end))
   end
 end
 
@@ -653,17 +486,13 @@ M.MT_MOON_B2F = {
     return false
   end,
   talk = {
-    TEXT_MTMOONB2F_DOME_FOSSIL = mtMoonFossil(
-      "DOME_FOSSIL", "MTMOONB2F_HELIX_FOSSIL", "EVENT_GOT_DOME_FOSSIL"),
-    TEXT_MTMOONB2F_HELIX_FOSSIL = mtMoonFossil(
-      "HELIX_FOSSIL", "MTMOONB2F_DOME_FOSSIL", "EVENT_GOT_HELIX_FOSSIL"),
+    TEXT_MTMOONB2F_DOME_FOSSIL = mtMoonFossil("DOME_FOSSIL", "MTMOONB2F_HELIX_FOSSIL"),
+    TEXT_MTMOONB2F_HELIX_FOSSIL = mtMoonFossil("HELIX_FOSSIL", "MTMOONB2F_DOME_FOSSIL"),
   },
 }
 
 -- The ticket clerk (scripts/Museum1F.asm Museum1FScientist1Text):
--- Y50, once.  Declining at the rope shoves the player one tile SOUTH back off
--- the exhibit rope they crossed heading north (#151); the museum floor has no
--- ledges, so a plain scriptMove("down",1) is the correct primitive.
+-- Y50, once; declining at the rope walks you back out.
 local function museumClerk(game, ow, done, onDecline)
   local TextBox = require("src.render.TextBox")
   local ChoiceBox = require("src.ui.ChoiceBox")
@@ -698,7 +527,7 @@ M.MUSEUM_1F = {
     if y == 4 and (x == 9 or x == 10)
        and not game.save.flags.EVENT_BOUGHT_MUSEUM_TICKET then
       museumClerk(game, ow, nil, function()
-        ow:scriptMove(ow.player, "down", 1)
+        ow:scriptMove(ow.player, "right", 1)
       end)
       return true
     end
@@ -894,7 +723,7 @@ M.CINNABAR_LAB_FOSSIL_ROOM = {
 -- #118: do not raise mon.level until a paid retrieve (pokered reverts
 -- wDayCareMonBoxLevel on .leaveMonInDayCare). Fold pending steps into
 -- mon.exp once and clear them so a second talk cannot re-apply the same
--- walk. Fill {RAM:wNameBuffer}/{RAM:wDayCareMonName}/{NUM:...} here --
+-- walk. Fill {RAM:wNameBuffer}/{RAM:wDayCareMonName}/{NUM:...} here —
 -- TextBox.TOKENS.RAM only knows wStringBuffer.
 -- -------------------------------------------------------------------
 
@@ -993,10 +822,6 @@ M.DAYCARE = {
               if def then
                 mon.stats = Stats.calc(def, mon.level, mon.dvs, mon.statExp)
                 mon.hp = mon.stats.hp
-                -- Daycare.asm: WriteMonMoves with wLearningMovesFromDayCare
-                local Pokemon = require("src.pokemon.Pokemon")
-                Pokemon.learnMovesFromDayCare(
-                  game.data, mon, def, startLevel, newLevel)
               end
               table.insert(game.save.party, mon)
               game.save.daycare = nil

data/scripts/story3.lua

@@ -61,59 +61,14 @@ M.ROUTE_12_SUPER_ROD_HOUSE = {
 M.ROUTE_12_SUPER_ROD_HOUSE.talk.TEXT_ROUTE12SUPERRODHOUSE_FISHING_GURU[9] =
   { "show_text", "_Route12SuperRodHouseFishingGuruTryFishingText" }
 
--- -------------------------------------------------------------------
--- Pokemon Tower 5F purified zone (scripts/PokemonTower5F.asm
--- PokemonTower5FDefaultScript): the 2x2 center pad heals the party once
--- per visit.  EVENT_IN_PURIFIED_ZONE latches until the player steps off;
--- while on the pad the map script also sets BIT_NO_BATTLES (we return
--- true from onStep so wild encounters are skipped the same way).
--- -------------------------------------------------------------------
-
-local TOWER_5F_PURIFIED = {
-  [10 * 256 + 8] = true, [11 * 256 + 8] = true,
-  [10 * 256 + 9] = true, [11 * 256 + 9] = true,
-}
-
--- HealParty -> GBFadeOutToWhite -> Delay3 -> Delay3 -> GBFadeInFromWhite
--- -> TEXT_POKEMONTOWER5F_PURIFIEDZONE (no Music_PkmnHealed).
-local TOWER_5F_HEAL = {
-  { "heal_party" },
-  { "fade", "out", "white" },
-  { "wait", 3 },
-  { "wait", 3 },
-  { "fade", "in", "white" },
-  { "show_text", "_PokemonTower5FPurifiedZoneText" },
-}
-
-M.POKEMON_TOWER_5F = {
-  onStep = function(game, ow, x, y)
-    if not TOWER_5F_PURIFIED[x * 256 + y] then
-      game.save.flags.EVENT_IN_PURIFIED_ZONE = nil
-      return false
-    end
-    if game.save.flags.EVENT_IN_PURIFIED_ZONE then
-      return true
-    end
-    if ow.runner and ow.runner:isRunning() then return false end
-    game.save.flags.EVENT_IN_PURIFIED_ZONE = true
-    if ow.runner then
-      ow.runner:run(TOWER_5F_HEAL)
-    elseif ow.queueScript then
-      ow:queueScript(TOWER_5F_HEAL)
-    end
-    return true
-  end,
-}
-
 -- -------------------------------------------------------------------
 -- The ghost Marowak (scripts/PokemonTower6F.asm): blocks the stairs at
 -- (10,16) until defeated.
 --
 -- PokemonTower6FDefaultScript starts the RESTLESS SOUL battle with NO
 -- Silph Scope check at the trigger -- the scope only decides whether the
--- disguise sticks (IsGhostBattle -> makeGhost: "too scared to move", balls
--- dodged) or comes off in the unveil (makeUnveiledGhost, #492). An earlier
--- version of this port turned the player back
+-- battle is disguised (IsGhostBattle -> makeGhost: "too scared to move",
+-- balls dodged). An earlier version of this port turned the player back
 -- without the scope and never opened the battle, which made 6F
 -- impassable on any route that skips Rocket Hideout; vanilla lets the
 -- battle open and a POKE_DOLL end it (see wBattleResult below).
@@ -129,18 +84,7 @@ M.POKEMON_TOWER_6F = {
       t._PokemonTower6FBeGoneText or "Be gone...\nIntruders...", function()
       local BattleState = require("src.battle.BattleState")
       local battle = BattleState.newWild(game, "MAROWAK", 30)
-      -- ItemUseBall .notOldManBattle (item_effects.asm:166-175): a ball
-      -- thrown on POKEMON_TOWER_6F at the RESTLESS SOUL is dodged whether
-      -- or not the scope revealed it, so the "can't be caught" state rides
-      -- the battle instead of IsGhostBattle alone (#444)
-      battle.noCatch = true
-      -- InitWildBattle enters disguised for the RESTLESS SOUL either way
-      -- (core.asm:6698-6700).  The scope does not skip the disguise, it
-      -- buys the unveil PrintBeginningBattleText .isMarowak plays over it
-      -- before the battle proceeds as an ordinary wild one (#492).
-      if game.save.inventory.SILPH_SCOPE then
-        battle:makeUnveiledGhost()
-      else
+      if not game.save.inventory.SILPH_SCOPE then
         battle:makeGhost()
       end
       battle.onFinish = function(result)
@@ -194,16 +138,17 @@ M.POKEMON_TOWER_6F = {
 -- preFrames: the shake's lead-in delays -- ShakeElevator's own Delay3s
 -- come to 9 frames; Silph/Rocket's ...ShakeScript prefixes another
 -- Delay3 (12) while CeladonMartElevatorShakeScript farjps straight in
--- The panel is a bg_event, not a map-entry script: data/maps/objects/
--- CeladonMartElevator.asm has `bg_event 3, 0, TEXT_CELADONMARTELEVATOR`
--- and CeladonMartElevatorText is what runs DisplayElevatorFloorMenu, so
--- the menu waits for the player to face the panel and press A (#395).
--- Map entry only stores the car's exit warps (CeladonMartElevator
--- StoreWarpEntriesScript), which is elevatorSeedExit below.
 -- After the ride the original does NOT jump-cut to the floor: choosing a
--- floor rewrites the elevator car's own warp entries (wWarpEntries, via
--- .UpdateWarp) to the chosen floor's exit warp and returns control, and
--- the player walks out of the car onto that warp themselves.
+-- floor in engine/events/elevator.asm DisplayElevatorFloorMenu rewrites
+-- the elevator car's own warp entries (wWarpEntries, via .UpdateWarp) to
+-- the chosen floor's exit warp, then the player walks out of the car onto
+-- that warp themselves (scripts/SilphCoElevator.asm etc.).  Reproduce
+-- that here: rewrite the car's exit warps, then drive a short scripted
+-- walk-out onto an exit tile and take the (now rewritten) warp, reusing
+-- ow:scriptMove / ow:takeWarp (the Oak-escort primitives).
+local WALK_DIRVEC = { up = { 0, -1 }, down = { 0, 1 }, left = { -1, 0 }, right = { 1, 0 } }
+local WALK_OPP = { up = "down", down = "up", left = "right", right = "left" }
+local WALK_ORDER = { "up", "down", "left", "right" }
 
 -- .UpdateWarp: point EVERY car exit warp at the same floor's elevator
 -- door (warp id, map id).  Shared generated map data, but the car's
@@ -216,6 +161,46 @@ local function elevatorSetExit(ow, floor)
   end
 end
 
+local function elevatorWalkOut(ow, floor)
+  local m, p = ow.map, ow.player
+  elevatorSetExit(ow, floor)
+  -- leave by the exit tile under the player (they warped in onto one),
+  -- else the nearest
+  local door
+  for _, w in ipairs(m.def.warps) do
+    if w.x == p.cellX and w.y == p.cellY then door = w break end
+  end
+  if not door then
+    local best
+    for _, w in ipairs(m.def.warps) do
+      local d = math.abs(w.x - p.cellX) + math.abs(w.y - p.cellY)
+      if not best or d < best then best, door = d, w end
+    end
+  end
+  -- the car interior sits on the door's walkable side; "out" is the
+  -- doorway direction (the map edge for Silph/Celadon, the top doorway
+  -- for the Rocket car).  Fixed direction order keeps the step
+  -- deterministic when a door tile has several walkable neighbours
+  -- (Silph/Celadon step up into the car, the Rocket car steps down).
+  local into
+  for _, dir in ipairs(WALK_ORDER) do
+    local v = WALK_DIRVEC[dir]
+    local nx, ny = door.x + v[1], door.y + v[2]
+    if m:inBounds(nx, ny) and m:isWalkableCell(nx, ny) then into = dir break end
+  end
+  into = into or "up"
+  local out = WALK_OPP[into]
+  local function leave()
+    ow:takeWarp(door) -- door SFX + warp to the rewritten floor target
+  end
+  -- step one tile into the car, then walk back through the doorway onto
+  -- the exit tile and take the warp: a visible walk-out on valid tiles
+  -- for either door orientation, instead of a jump cut
+  ow:scriptMove(p, into, 1, function()
+    ow:scriptMove(p, out, 1, leave)
+  end)
+end
+
 local function elevatorFloors(elevatorMapId, game)
   local floors = {}
   for mapId, def in pairs(game.data.maps) do
@@ -243,9 +228,9 @@ local function elevatorFloors(elevatorMapId, game)
 end
 
 local function elevatorSeedExit(ow, floors, fromMapId)
-  -- Seed a walk-out destination on entry (before the panel is ever
-  -- read): entry floor when known, else the first listed floor (1F).
-  -- Choosing a floor rewrites it again; B-cancel / no-key leave
+  -- Seed a walk-out destination before the menu (or key-gate text):
+  -- entry floor when known, else the first listed floor (1F).  Choosing
+  -- a floor still rewrites via elevatorWalkOut; B-cancel / no-key leave
   -- keeps this seed so walking out of the car cannot hit a missing ROM
   -- placeholder (#123) or the car's static default floor (#90: Rocket
   -- Hideout defaults to B1F even when entered from B2F/B4F).
@@ -259,68 +244,68 @@ local function elevatorSeedExit(ow, floors, fromMapId)
   return exitFloor
 end
 
-local function elevator(elevatorMapId, panelText, keyGate, preFrames)
-  -- the panel bg_event: DisplayElevatorFloorMenu runs from this text
-  -- script, never from map entry (#395)
-  local function panel(game, ow, npc, done)
-    done = done or function() end
-    local floors = elevatorFloors(elevatorMapId, game)
-    -- Rocket Hideout: without LIFT_KEY the panel only prints the need-
-    -- a-key line and shows no floor menu
-    -- (scripts/RocketHideoutElevator.asm).
-    if keyGate and not game.save.inventory[keyGate.item] then
-      local TextBox = require("src.render.TextBox")
-      game.stack:push(TextBox.new(game,
-        game.data.text[keyGate.text] or "It appears to\nneed a key.", done))
-      return
-    end
-    local items = {}
-    for _, f in ipairs(floors) do
-      table.insert(items, { label = f.token, value = f })
-    end
-    local ListMenu = require("src.ui.ListMenu")
-    game.stack:push(ListMenu.new(game, "WHICH FLOOR?", items, {
-      onChoose = function(item, list)
-        list:close()
-        -- the whole ShakeElevator ride runs in place -- music stop, 100
-        -- collision-thud scroll bounces, the PA chime -- and only then
-        -- does .UpdateWarp's rewrite land, with the player still stood
-        -- at the panel: they walk out to the car door themselves
-        local ElevatorShake = require("src.world.ElevatorShake")
-        game.stack:push(ElevatorShake.new(game, ow, {
-          preFrames = preFrames,
-          onDone = function()
-            elevatorSetExit(ow, item.value)
-            done()
-          end,
-        }))
-      end,
-      onCancel = function()
-        -- DisplayElevatorFloorMenu: `ret c` on B -- no warp, nothing
-        -- happens, the player just stays in the car (exit warps were
-        -- already seeded on entry)
-        done()
-      end,
-    }))
-  end
+local function elevator(elevatorMapId, keyGate, preFrames)
   return {
     -- fromMapId: the floor the player just left (setMap passes it), so a
     -- B-cancel can still walk out onto a real map.  Silph's ROM car warps
     -- default to UNUSED_MAP_ED, which is not in Data.maps -- Warp.resolve
     -- asserted and hard-crashed (#123).
     onEnter = function(game, ow, fromMapId)
-      elevatorSeedExit(ow, elevatorFloors(elevatorMapId, game), fromMapId)
+      local floors = elevatorFloors(elevatorMapId, game)
+      elevatorSeedExit(ow, floors, fromMapId)
+      -- Rocket Hideout: without LIFT_KEY the panel only prints the need-
+      -- a-key line (scripts/RocketHideoutElevator.asm).  Exit warps are
+      -- still seeded above so walking out returns to the entry floor
+      -- instead of the car's ROM default (B1F) — #90 / #105.
+      if keyGate and not game.save.inventory[keyGate.item] then
+        local TextBox = require("src.render.TextBox")
+        game.stack:push(TextBox.new(game,
+          game.data.text[keyGate.text] or "It appears to\nneed a key."))
+        return
+      end
+      local items = {}
+      for _, f in ipairs(floors) do
+        table.insert(items, { label = f.token, value = f })
+      end
+      local ListMenu = require("src.ui.ListMenu")
+      game.stack:push(ListMenu.new(game, "WHICH FLOOR?", items, {
+        onChoose = function(item, list)
+          list:close()
+          -- the map-entry Transition (startWarpTo) calls onEnter from
+          -- its OWN midpoint callback, so this menu was pushed on top
+          -- of that still-active Transition; only the top state
+          -- updates, so it froze mid-fade instead of finishing.  Left
+          -- alone it would resurface after the ride and play a stray
+          -- fade at the wrong time -- pop it now, before it can happen.
+          local Transition = require("src.render.Transition")
+          if getmetatable(game.stack:top()) == Transition then
+            game.stack:pop()
+          end
+          -- the whole ShakeElevator ride runs in place -- music stop,
+          -- 100 collision-thud scroll bounces, the PA chime -- and only
+          -- then does the player walk out of the car onto the chosen
+          -- floor (elevatorWalkOut rewrites the car's exit warps first)
+          local ElevatorShake = require("src.world.ElevatorShake")
+          game.stack:push(ElevatorShake.new(game, ow, {
+            preFrames = preFrames,
+            onDone = function()
+              elevatorWalkOut(ow, item.value)
+            end,
+          }))
+        end,
+        onCancel = function()
+          -- DisplayElevatorFloorMenu: `ret c` on B -- no warp, nothing
+          -- happens, the player just stays in the car (exit warps were
+          -- already seeded to the entry floor above)
+        end,
+      }))
     end,
-    talk = { [panelText] = panel },
   }
 end
 
-M.SILPH_CO_ELEVATOR = elevator("SILPH_CO_ELEVATOR",
-  "TEXT_SILPHCOELEVATOR_ELEVATOR")
-M.CELADON_MART_ELEVATOR = elevator("CELADON_MART_ELEVATOR",
-  "TEXT_CELADONMARTELEVATOR", nil, 9)
+M.SILPH_CO_ELEVATOR = elevator("SILPH_CO_ELEVATOR")
+M.CELADON_MART_ELEVATOR = elevator("CELADON_MART_ELEVATOR", nil, 9)
 M.ROCKET_HIDEOUT_ELEVATOR = elevator("ROCKET_HIDEOUT_ELEVATOR",
-  "TEXT_ROCKETHIDEOUTELEVATOR",
   { item = "LIFT_KEY", text = "_RocketHideoutElevatorAppearsToNeedKeyText" })
 
 -- -------------------------------------------------------------------
@@ -360,38 +345,6 @@ M.ROCKET_HIDEOUT_B4F = {
         end))
     end,
 
-    -- Yellow swaps Rocket1/Rocket2 for Jessie & James and keeps a single
-    -- grunt, spelled ROCKETHIDEOUTB4F_ROCKET / TEXT_ROCKETHIDEOUTB4F_ROCKET
-    -- (pokeyellow/scripts/RocketHideoutB4F.asm), so the Red/Blue key above
-    -- never matched there and the LIFT KEY never dropped (#552, a
-    -- regression of #105).  Yellow also moves the drop off the second
-    -- talk: RocketHideoutB4FRocketEndBattleText is text_promptbutton +
-    -- text_asm, so its SetEvent EVENT_ROCKET_DROPPED_LIFT_KEY / ShowObject
-    -- TOGGLE_ROCKET_HIDEOUT_B4F_ITEM_5 run the instant the battle ends.
-    TEXT_ROCKETHIDEOUTB4F_ROCKET = function(game, ow, npc, done)
-      if not ow:trainerDefeated(npc) then
-        ow:engageTrainer(npc, function()
-          -- engageTrainer records the win before it calls back, so this
-          -- is the end-battle text's SetEvent + ShowObject
-          if ow:trainerDefeated(npc)
-             and not game.save.flags.EVENT_ROCKET_DROPPED_LIFT_KEY then
-            game.save.flags.EVENT_ROCKET_DROPPED_LIFT_KEY = true
-            local Commands = require("src.script.Commands")
-            Commands.show_object(
-              { game = game, save = game.save, overworld = ow },
-              "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_LIFT_KEY")
-          end
-          done()
-        end)
-        return
-      end
-      -- RocketHideoutB4FRocketAfterBattleText: later talks only reprint
-      local TextBox = require("src.render.TextBox")
-      game.stack:push(TextBox.new(game,
-        game.data.text._RocketHideoutB4FRocketAfterBattleText
-        or "Oh no! I dropped\nthe LIFT KEY!", done))
-    end,
-
     TEXT_ROCKETHIDEOUTB4F_GIOVANNI = function(game, ow, npc, done)
       -- Giovanni has no trainer-header row (def_trainers 2); his text_asm
       -- owns both the engage and the BeatGiovanniScript aftermath.
@@ -459,23 +412,14 @@ M.GAME_CORNER = {
   -- EVENT_FOUND_ROCKET_HIDEOUT is unset, $43 after)
   onEnter = function(game, ow)
     local poster = game.data.field.gameCornerPoster
-    if poster then
-      local block = game.save.flags[poster.event] and poster.openBlock
-                    or poster.closedBlock
-      ow:replaceBlock(poster.x, poster.y, block)
-    end
+    if not poster then return end
+    local block = game.save.flags[poster.event] and poster.openBlock
+                  or poster.closedBlock
+    ow:replaceBlock(poster.x, poster.y, block)
     -- pick this visit's lucky slot machine
     -- (wLuckySlotHiddenEventIndex, engine/slots/game_corner_slots2.asm)
     local seats = game.data.field.slotMachines.GAME_CORNER
     ow.luckySlot = love.math.random(1, #seats)
-    -- #131: pre-#50 saves beat the poster grunt (defeatedTrainers) but
-    -- never hid him; clear the tile if he is already marked defeated
-    local rocketId = "GAME_CORNER_obj_11"
-    if game.save.defeatedTrainers and game.save.defeatedTrainers[rocketId] then
-      local Commands = require("src.script.Commands")
-      Commands.hide_object({ game = game, save = game.save, overworld = ow },
-                           "GAME_CORNER", "GAMECORNER_ROCKET")
-    end
   end,
   talk = {
     -- the poster bg event: pressing A reveals the hidden switch
@@ -504,16 +448,7 @@ M.GAME_CORNER = {
     -- losing he warns the BOSS and leaves the floor for good, freeing
     -- the tile in front of the hideout switch
     TEXT_GAMECORNER_ROCKET = function(game, ow, npc, done)
-      local Commands = require("src.script.Commands")
-      local function hideRocket()
-        Commands.hide_object({ game = game, save = game.save,
-                               overworld = ow },
-                             "GAME_CORNER", "GAMECORNER_ROCKET")
-      end
-      -- already beaten: hide anyway so pre-#50 saves that only have
-      -- defeatedTrainers (no objectToggles hide) clear the poster tile
       if ow:trainerDefeated(npc) then
-        hideRocket()
         done()
         return
       end
@@ -527,70 +462,53 @@ M.GAME_CORNER = {
           game.data.text._GameCornerRocketAfterBattleText
           or "Our hideout might\nbe discovered! I\nbetter tell BOSS!",
           function()
-            -- #198: GameCornerRocketExitScript (scripts/GameCorner.asm)
-            -- ApplyMovementData walks the grunt one tile UP into the poster
-            -- (the hideout's secret entrance at 9,4) before HideObject, so
-            -- he leaves the floor rather than popping out of existence on
-            -- (9,5).  scriptMove locks player input (#scriptMoves>0) and
-            -- ignores collision, so we despawn + unfreeze (done) only once
-            -- the step lands.
-            ow:scriptMove(npc, "up", 1, function()
-              hideRocket()
-              done()
-            end)
+            local Commands = require("src.script.Commands")
+            Commands.hide_object({ game = game, save = game.save,
+                                   overworld = ow },
+                                 "GAME_CORNER", "GAMECORNER_ROCKET")
+            done()
           end))
       end)
     end,
-    -- GameCornerClerk1Text (scripts/GameCorner.asm): the offer, a
-    -- YesNoChoice, then ¥1000 for 50 coins.  Yellow drops the "1" from the
-    -- object const and from every one of his text labels
-    -- (GameCornerClerkText, pokeyellow/scripts/GameCorner.asm) with an
-    -- identical body, so each line resolves under both spellings and the
-    -- handler is bound to both text ids just below (#552).
     TEXT_GAMECORNER_CLERK1 = function(game, ow, npc, done)
       local TextBox = require("src.render.TextBox")
       local ChoiceBox = require("src.ui.ChoiceBox")
       local t = game.data.text
-      local function line(suffix, fallback)
-        return t["_GameCornerClerk1" .. suffix]
-               or t["_GameCornerClerk" .. suffix]
-               or fallback
-      end
       game.stack:push(TextBox.new(game,
-        line("DoYouNeedSomeGameCoinsText",
-             "Do you need some\ngame coins?\f¥1000 for 50."), function()
+        (t._GameCornerClerk1DoYouNeedSomeGameCoinsText
+         or "Do you need some\ngame coins?\f¥1000 for 50."), function()
         game.stack:push(ChoiceBox.new(game, function(yes)
           if not yes then
             game.stack:push(TextBox.new(game,
-              line("PleaseComePlaySometimeText",
-                   "No? Please come\nplay sometime!"), done))
+              t._GameCornerClerk1PleaseComePlaySometimeText
+              or "No? Please come\nplay sometime!", done))
             return
           end
           -- scripts/GameCorner.asm GameCornerClerk1Text: coins need
           -- the COIN CASE and room for at least 9 coins (Has9990Coins)
           if not game.save.inventory.COIN_CASE then
             game.stack:push(TextBox.new(game,
-              line("DontHaveCoinCaseText",
-                   "You don't have a\nCOIN CASE!"), done))
+              t._GameCornerClerk1DontHaveCoinCaseText
+              or "You don't have a\nCOIN CASE!", done))
             return
           end
           if (game.save.coins or 0) >= 9990 then
             game.stack:push(TextBox.new(game,
-              line("CoinCaseIsFullText",
-                   "Oops! Your COIN\nCASE is full."), done))
+              t._GameCornerClerk1CoinCaseIsFullText
+              or "Oops! Your COIN\nCASE is full.", done))
             return
           end
           if game.save.money < 1000 then
             game.stack:push(TextBox.new(game,
-              line("CantAffordTheCoinsText",
-                   "You can't afford\nthe coins!"), done))
+              t._GameCornerClerk1CantAffordTheCoinsText
+              or "You can't afford\nthe coins!", done))
             return
           end
           game.save.money = game.save.money - 1000
           game.save.coins = math.min(9999, (game.save.coins or 0) + 50)
           game.stack:push(TextBox.new(game,
-            line("ThanksHereAre50CoinsText",
-                 "Thanks! Here are\nyour 50 coins!")
+            (t._GameCornerClerk1ThanksHereAre50CoinsText
+             or "Thanks! Here are\nyour 50 coins!")
             .. ("\fCOINS: %d"):format(game.save.coins), done))
         end))
       end))
@@ -598,13 +516,6 @@ M.GAME_CORNER = {
   },
 }
 
--- Yellow's coin clerk is GAMECORNER_CLERK / TEXT_GAMECORNER_CLERK where Red
--- and Blue spell him CLERK1, and the two text_asm bodies are identical, so
--- one handler answers both ids.  Without the alias the Yellow clerk fell
--- through to his extracted offer line with no yes/no box behind it (#552).
-M.GAME_CORNER.talk.TEXT_GAMECORNER_CLERK =
-  M.GAME_CORNER.talk.TEXT_GAMECORNER_CLERK1
-
 -- Game Corner prize lists (data/events/prizes.asm, prize_mon_levels.asm).
 -- The six mon prizes differ between Red and Blue; the three TM prizes are
 -- identical, so they are shared and appended to each version's mon list.
@@ -636,62 +547,40 @@ local function activePrizes()
   return require("src.core.GameVersion").isBlue() and BLUE_PRIZES or RED_PRIZES
 end
 
--- Prize counters (engine/menus/prize_menu.asm CeladonPrizeMenu; the prize
--- list itself is data/events/prizes.asm, prize_mon_levels.asm).  Gen1 gates
--- the prize window on the COIN CASE: it does IsItemInBag COIN_CASE first, and
--- with no case prints RequireCoinCaseText and returns without ever opening a
--- window; only with the case does it print ExchangeCoinsForPrizesText and then
--- show the prizes.  #194: the port used to open the window unconditionally and
--- skip both text boxes.
 local function prizeCounter(game, ow, npc, done)
   local ListMenu = require("src.ui.ListMenu")
   local Commands = require("src.script.Commands")
-  local TextBox = require("src.render.TextBox")
-  local t = game.data.text
-  -- IsItemInBag COIN_CASE: without the case, deny and open no window
-  -- (COIN_CASE is a numeric count in save.inventory, nil when absent).
-  if not game.save.inventory.COIN_CASE then
-    game.stack:push(TextBox.new(game,
-      t._RequireCoinCaseText or "A COIN CASE is\nrequired!", done))
-    return
+  local items = {}
+  for _, p in ipairs(activePrizes()) do
+    local label
+    if p.kind == "mon" then
+      label = ("%s L%d"):format(game.data.pokemon[p.species].name, p.level)
+    else
+      label = game.data.items[p.item].name
+    end
+    table.insert(items, { label = label, right = tostring(p.cost), value = p })
   end
-  -- ExchangeCoinsForPrizesText plays before the prize window opens.
-  game.stack:push(TextBox.new(game,
-    t._ExchangeCoinsForPrizesText or "We exchange your\ncoins for prizes.",
-    function()
-      local items = {}
-      for _, p in ipairs(activePrizes()) do
-        local label
-        if p.kind == "mon" then
-          label = ("%s L%d"):format(game.data.pokemon[p.species].name, p.level)
-        else
-          label = game.data.items[p.item].name
-        end
-        table.insert(items,
-          { label = label, right = tostring(p.cost), value = p })
+  local list
+  list = ListMenu.new(game, "PRIZES (COINS)", items, {
+    footer = ("COINS %d"):format(game.save.coins or 0),
+    onChoose = function(item)
+      local p = item.value
+      if (game.save.coins or 0) < p.cost then
+        list.footer = "Not enough coins!"
+        return
       end
-      local list
-      list = ListMenu.new(game, "PRIZES (COINS)", items, {
-        footer = ("COINS %d"):format(game.save.coins or 0),
-        onChoose = function(item)
-          local p = item.value
-          if (game.save.coins or 0) < p.cost then
-            list.footer = "Not enough coins!"
-            return
-          end
-          game.save.coins = game.save.coins - p.cost
-          if p.kind == "mon" then
-            Commands.give_pokemon({ save = game.save, game = game },
-                                  p.species, p.level)
-          else
-            game.save.inventory[p.item] = (game.save.inventory[p.item] or 0) + 1
-          end
-          list.footer = ("Got it! COINS %d"):format(game.save.coins)
-        end,
-        onCancel = done,
-      })
-      game.stack:push(list)
-    end))
+      game.save.coins = game.save.coins - p.cost
+      if p.kind == "mon" then
+        Commands.give_pokemon({ save = game.save, game = game },
+                              p.species, p.level)
+      else
+        game.save.inventory[p.item] = (game.save.inventory[p.item] or 0) + 1
+      end
+      list.footer = ("Got it! COINS %d"):format(game.save.coins)
+    end,
+    onCancel = done,
+  })
+  game.stack:push(list)
 end
 
 M.GAME_CORNER_PRIZE_ROOM = {
@@ -716,16 +605,6 @@ local DOCK_SHIP_BLOCKS = {
   { bx = 7, by = 2, water = 13 }, { bx = 8, by = 2, water = 13 },
 }
 
--- her four hull columns bow-to-stern (upper-half / lower-half block ids)
--- and the open-water ids of the rows she sits in
-local DOCK_SHIP_COLUMNS = {
-  { bx = 5, top = 4, bottom = 8 },
-  { bx = 6, top = 5, bottom = 9 },
-  { bx = 7, top = 6, bottom = 10 },
-  { bx = 8, top = 7, bottom = 11 },
-}
-local DOCK_WATER_TOP, DOCK_WATER_BOTTOM = 1, 13
-
 M.VERMILION_DOCK = {
   onEnter = function(game, ow)
     local Flags = require("src.script.Flags")
@@ -760,39 +639,17 @@ M.VERMILION_DOCK = {
         ow:startDustAnim(cx, 1, function() puff(n - 1, cx + 2) end)
       end
       puff(3, 15)
-      -- VermilionDock_EraseSSAnne deliberately leaves the blocks under the
-      -- player alone ("south of the player and won't be redrawn"), so skip
-      -- his own block: he must not spend the walk-out standing on water
-      local pbx = math.floor(ow.player.cellX / 2)
-      local pby = math.floor(ow.player.cellY / 2)
       local rows = {}
-      local function setBlock(bx, by, block)
-        if bx < 1 or bx > 8 then return end
-        if bx == pbx and by == pby then return end
-        rows[#rows + 1] = { "replace_block", bx, by, block }
-      end
-      rows[#rows + 1] = { "wait", 120 }
+      rows[#rows + 1] = { "wait", 100 }
       rows[#rows + 1] = { "play_sound", "SS_Anne_Horn" }
-      -- .shift_columns_up slides her tile columns west behind a mid-frame
-      -- rSCX split; with no split scroll here she sails one block per beat
-      -- and the water closes in astern (#360)
-      for step = 1, 8 do
-        for _, col in ipairs(DOCK_SHIP_COLUMNS) do
-          setBlock(col.bx - step, 1, col.top)
-          setBlock(col.bx - step, 2, col.bottom)
-        end
-        setBlock(9 - step, 1, DOCK_WATER_TOP)
-        setBlock(9 - step, 2, DOCK_WATER_BOTTOM)
-        rows[#rows + 1] = { "wait", 20 }
+      for _, b in ipairs(DOCK_SHIP_BLOCKS) do
+        rows[#rows + 1] = { "replace_block", b.bx, b.by, b.water }
       end
-      -- the second horn as she clears the dock, then EraseSSAnne's 120
-      -- frames before the walk out
-      rows[#rows + 1] = { "play_sound", "SS_Anne_Horn" }
-      rows[#rows + 1] = { "wait", 120 }
+      rows[#rows + 1] = { "wait", 30 }
       rows[#rows + 1] = { "move_player", "up", 2 }
-      -- no keepMusic on this warp: Music_Surfing belongs to the dock's
-      -- cutscene, and VERMILION_CITY's own theme has to take over as the
-      -- player crosses in (EnterMap's PlayDefaultMusic)
+      -- keep Music_Surfing across the city warp (pokered stays on it
+      -- through the exit-ship walk)
+      rows[#rows + 1] = { "play_music", "Music_Surfing", { keep = true } }
       rows[#rows + 1] = { "warp", "VERMILION_CITY", 18, 31, "up" }
       rows[#rows + 1] = { "move_player", "up", 2 }
       ow:queueScript(rows)

data/scripts/story4.lua

@@ -37,15 +37,16 @@ local function countOwned(save)
   return n
 end
 
-local function oaksAide(threshold, itemId, repeatText)
+local function oaksAide(threshold, itemId)
   return function(game, ow, npc, done)
     local t = text(game)
     local flags = game.save.flags
     local itemName = game.data.items[itemId].name
     local flag = "EVENT_GOT_" .. itemId
     if flags[flag] then
-      push(game, t[repeatText] or
-        fill("I already gave\nyou the {RAM:}!", { ram = itemName }), done)
+      push(game, fill(t._OaksAideComeBackText or
+        "I already gave\nyou the {RAM:}!",
+        { num = threshold, ram = itemName }), done)
       return
     end
     ask(game, fill(t._OaksAideHiText or
@@ -82,16 +83,13 @@ local function oaksAide(threshold, itemId, repeatText)
 end
 
 M.ROUTE_2_GATE = {
-  talk = { TEXT_ROUTE2GATE_OAKS_AIDE = oaksAide(10, "HM_FLASH",
-    "_Route2GateOaksAideFlashExplanationText") },
+  talk = { TEXT_ROUTE2GATE_OAKS_AIDE = oaksAide(10, "HM_FLASH") },
 }
 M.ROUTE_11_GATE_2F = {
-  talk = { TEXT_ROUTE11GATE2F_OAKS_AIDE = oaksAide(30, "ITEMFINDER",
-    "_Route11Gate2FOaksAideItemfinderDescriptionText") },
+  talk = { TEXT_ROUTE11GATE2F_OAKS_AIDE = oaksAide(30, "ITEMFINDER") },
 }
 M.ROUTE_15_GATE_2F = {
-  talk = { TEXT_ROUTE15GATE2F_OAKS_AIDE = oaksAide(50, "EXP_ALL",
-    "_Route15Gate2FOaksAideExpAllText") },
+  talk = { TEXT_ROUTE15GATE2F_OAKS_AIDE = oaksAide(50, "EXP_ALL") },
 }
 
 -- -------------------------------------------------------------------
@@ -136,19 +134,12 @@ M.MT_MOON_POKECENTER = {
 -- Karate Master, take HITMONLEE or HITMONCHAN (the other disappears)
 -- -------------------------------------------------------------------
 
--- ownBall/otherBall keep their spots for signature symmetry; only ownBall
--- is ever hidden (Gen1 removes just the chosen ball).
 local function dojoBall(species, ownBall, otherBall, askKey)
   return function(game, ow, npc, done)
     local t = text(game)
     local flags = game.save.flags
-    -- Already took one prize: the OTHER ball is still on the mat, so
-    -- talking to it now gives the "Better not get greedy..." refusal
-    -- (FightingDojo.asm .gotThePokemon / _FightingDojoBetterNotGetGreedyText),
-    -- not a silent no-op (#197).
     if flags.EVENT_GOT_HITMONLEE or flags.EVENT_GOT_HITMONCHAN then
-      push(game, t._FightingDojoBetterNotGetGreedyText
-        or "Better not get\ngreedy...", done)
+      done()
       return
     end
     if not flags.EVENT_BEAT_KARATE_MASTER then
@@ -162,37 +153,13 @@ local function dojoBall(species, ownBall, otherBall, askKey)
       local Commands = require("src.script.Commands")
       local ctx = { save = game.save, game = game, overworld = ow }
       Commands.give_pokemon(ctx, species, 30)
-      -- Hide ONLY the chosen ball; the other stays (FightingDojo.asm hides
-      -- just the picked object's index) and routes to the greedy line above
-      -- when talked to (#197).
       Commands.hide_object(ctx, "FIGHTING_DOJO", ownBall)
+      Commands.hide_object(ctx, "FIGHTING_DOJO", otherBall)
       push(game, ("%s got\n%s!"):format(game.save.player.name, species), done)
     end)
   end
 end
 
--- FightingDojoDefaultScript does not use the Master's facing direction for
--- this battle.  It checks exactly the cell left of him, turns both sprites
--- toward one another, and then displays his trainer text.  Keeping this out
--- of trainer sight also lets him keep his original downward-facing pose.
-local function dojoMasterGate(game, ow, x, y)
-  if x ~= 4 or y ~= 3 or game.save.flags.EVENT_BEAT_KARATE_MASTER then
-    return false
-  end
-  local master
-  for _, npc in ipairs(ow.npcs) do
-    if npc.def and npc.def.name == "FIGHTINGDOJO_KARATE_MASTER" then
-      master = npc
-      break
-    end
-  end
-  if not master or ow:trainerDefeated(master) then return false end
-  ow.player.facing = "right"
-  master:facePlayer(ow.player)
-  ow:engageTrainer(master)
-  return true
-end
-
 M.FIGHTING_DOJO = {
   talk = {
     TEXT_FIGHTINGDOJO_HITMONLEE_POKE_BALL =
@@ -204,22 +171,6 @@ M.FIGHTING_DOJO = {
                "FIGHTINGDOJO_HITMONLEE_POKE_BALL",
                "_FightingDojoHitmonchanPokeBallText"),
   },
-  -- The two dojo posters on the north wall (FightingDojo.asm bg_events at
-  -- the top of the room, cells (4,0)/(5,0) directly above the prize balls)
-  -- print _EnemiesOnEverySideText.  The map extractor dropped the dojo
-  -- bg_events (signs = {}), so wire the poster read here, the same
-  -- facing-up + coord shape the mansion switches use.  Reachable only once
-  -- a claimed prize frees the ball cell below the poster (#197).
-  onInteract = function(game, ow, fx, fy)
-    if ow.player.facing ~= "up" then return false end
-    if fy == 0 and (fx == 4 or fx == 5) then
-      push(game, text(game)._EnemiesOnEverySideText
-        or "Enemies on every\nside!")
-      return true
-    end
-    return false
-  end,
-  onStep = dojoMasterGate,
 }
 
 -- -------------------------------------------------------------------
@@ -261,31 +212,30 @@ M.COPYCATS_HOUSE_2F = {
   talk = {
     TEXT_COPYCATSHOUSE2F_COPYCAT = function(game, ow, npc, done)
       local t = text(game)
-      local Bag = require("src.inventory.Bag")
       if game.save.flags.EVENT_GOT_TM31 then
-        push(game, t._CopycatsHouse2FCopycatTM31Explanation2Text, done)
+        push(game, t._CopycatsHouse2FCopycatWhirlingText
+          or "Huh? Huh? Huh?", done)
         return
       end
-      -- Mimic line first; auto-trade POKE DOLL for TM31 (no YES/NO).
-      push(game, t._CopycatsHouse2FCopycatDoYouLikePokemonText, function()
-        if (game.save.inventory.POKE_DOLL or 0) <= 0 then
-          done()
-          return
-        end
-        push(game, t._CopycatsHouse2FCopycatTM31PreReceiveText, function()
-          if not Bag.add(game.save, "TM_MIMIC", 1) then
-            push(game, t._CopycatsHouse2FCopycatTM31NoRoomText, done)
+      if (game.save.inventory.POKE_DOLL or 0) > 0 then
+        ask(game, t._CopycatsHouse2FCopycatPokeDollText
+          or "Oh wow!\nA POKé DOLL!\fFor me?\nCan I have it?", function(yes)
+          if not yes then done() return end
+          game.save.inventory.POKE_DOLL = game.save.inventory.POKE_DOLL - 1
+          if game.save.inventory.POKE_DOLL == 0 then
+            game.save.inventory.POKE_DOLL = nil
+          end
+          if not require("src.inventory.Bag").add(game.save, "TM_MIMIC", 1) then
+            push(game, "You don't have\nroom for TM31!", done)
             return
           end
-          game.stringBuffer = game.data.items.TM_MIMIC.name
-          require("src.core.Sound").play(game.data, "Get_Item1")
-          Bag.remove(game.save, "POKE_DOLL", 1)
           game.save.flags.EVENT_GOT_TM31 = true
-          push(game, t._CopycatsHouse2FCopycatReceivedTM31Text, function()
-            push(game, t._CopycatsHouse2FCopycatTM31Explanation1Text, done)
-          end)
+          push(game, ("%s got\nTM31!"):format(game.save.player.name), done)
         end)
-      end)
+        return
+      end
+      push(game, t._CopycatsHouse2FCopycatText
+        or "I like to mimic\npeople!", done)
     end,
   },
 }
@@ -695,44 +645,12 @@ local function e4ExitSeal(flag, closedBlock, openBlock, dontRunText, autoFlag)
   }
 end
 
--- Lorelei/Bruno/Agatha EndBattleScript (pokered): EndTrainerBattle then
--- DisplayTextID -> TalkToTrainer, which prints the AfterBattle text on a
--- win.  engageTrainer only shows the won line, so wrap talk like Lance /
--- Game Corner Rocket and push header.after immediately after a win.
-local function e4LeaderTalk(afterLabel)
-  return function(game, ow, npc, done)
-    done = done or function() end
-    if ow:trainerDefeated(npc) then
-      local after = text(game)[afterLabel]
-      if after then push(game, after, done) else done() end
-      return
-    end
-    ow:engageTrainer(npc, function()
-      if not ow:trainerDefeated(npc) then
-        done()
-        return
-      end
-      local after = text(game)[afterLabel]
-      if after then push(game, after, done) else done() end
-    end)
-  end
-end
-
 M.LORELEIS_ROOM = e4ExitSeal("EVENT_BEAT_LORELEIS_ROOM_TRAINER_0", 0x24, 0x05,
   "_LoreleisRoomLoreleiDontRunAwayText", "EVENT_AUTOWALKED_INTO_LORELEIS_ROOM")
-M.LORELEIS_ROOM.talk = {
-  TEXT_LORELEISROOM_LORELEI = e4LeaderTalk("_LoreleisRoomLoreleiAfterBattleText"),
-}
 M.BRUNOS_ROOM = e4ExitSeal("EVENT_BEAT_BRUNOS_ROOM_TRAINER_0", 0x24, 0x05,
   "_BrunosRoomBrunoDontRunAwayText", "EVENT_AUTOWALKED_INTO_BRUNOS_ROOM")
-M.BRUNOS_ROOM.talk = {
-  TEXT_BRUNOSROOM_BRUNO = e4LeaderTalk("_BrunoAfterBattleText"),
-}
 M.AGATHAS_ROOM = e4ExitSeal("EVENT_BEAT_AGATHAS_ROOM_TRAINER_0", 0x3b, 0x0e,
   "_AgathasRoomAgathaDontRunAwayText", "EVENT_AUTOWALKED_INTO_AGATHAS_ROOM")
-M.AGATHAS_ROOM.talk = {
-  TEXT_AGATHASROOM_AGATHA = e4LeaderTalk("_AgathaAfterBattleText"),
-}
 
 -- -------------------------------------------------------------------
 -- Lance's room (scripts/LancesRoom.asm). Unlike the other three E4
@@ -754,21 +672,13 @@ M.AGATHAS_ROOM.talk = {
 --                 EVENT_LANCES_ROOM_LOCK_DOOR: first crossing seals
 --                 the door behind the player with SFX_GO_INSIDE
 --   (24,16)       the entrance staircase -> WalkToLance: an auto-walk
---                 landing on (6,11). Vanilla WalkToLance_RLEList is
---                 up 12 / left 12 / down 7 / left 6 and skips collision
---                 through void tiles; our camera follows that literally
---                 and briefly shows the empty upper chamber (reads as
---                 "Gary's room"). We keep the same landing cell but
---                 route along the open-door floor corridor instead.
+--                 (up 12, left 12, down 7, left 6) landing on (6,11).
+--                 It marches straight across the room's water decor:
+--                 pokered's CollisionCheckOnLand skips collision
+--                 entirely while simulated joypad states run, and our
+--                 scriptMove is collision-free the same way.
 -- -------------------------------------------------------------------
 
--- Floor corridor (24,16) -> (6,11) with EVENT_LANCES_ROOM_LOCK_DOOR
--- unset (entrance blocks $31/$32). Exposed for parity tests.
-local LANCE_WALK_IN = {
-  { "down", 2 }, { "left", 6 }, { "down", 5 }, { "left", 10 },
-  { "up", 9 }, { "left", 2 }, { "up", 3 },
-}
-
 local function lanceEntranceBlocks(game, ow)
   local locked = game.save.flags.EVENT_LANCES_ROOM_LOCK_DOOR
   ow:replaceBlock(2, 6, locked and 0x72 or 0x31)
@@ -783,24 +693,21 @@ local function lanceLockDoor(game, ow)
 end
 
 local function lanceWalkIn(game, ow)
-  local i = 0
-  local function step()
-    i = i + 1
-    local seg = LANCE_WALK_IN[i]
-    if not seg then
-      -- lands on (6,11); vanilla's per-frame coord poll then locks the
-      -- door at once. scriptMove landings do not fire onStep, so lock
-      -- here.
-      lanceLockDoor(game, ow)
-      return
-    end
-    ow:scriptMove(ow.player, seg[1], seg[2], step)
-  end
-  step()
+  ow:scriptMove(ow.player, "up", 12, function()
+    ow:scriptMove(ow.player, "left", 12, function()
+      ow:scriptMove(ow.player, "down", 7, function()
+        ow:scriptMove(ow.player, "left", 6, function()
+          -- the walk lands on (6,11); vanilla's per-frame coord poll
+          -- then locks the door at once. scriptMove landings do not
+          -- fire onStep, so lock here.
+          lanceLockDoor(game, ow)
+        end)
+      end)
+    end)
+  end)
 end
 
 M.LANCES_ROOM = {
-  walkInRoute = LANCE_WALK_IN,
   onEnter = function(game, ow)
     lanceEntranceBlocks(game, ow)
     -- the warp arrival lands ON the staircase trigger, and onStep only
@@ -820,14 +727,7 @@ M.LANCES_ROOM = {
       end
       if not lance or ow:trainerDefeated(lance) then return false end
       lance:facePlayer(ow.player)
-      -- LancesRoomLanceEndBattleScript DisplayTextID -> TalkToTrainer
-      -- after-battle text (rival became champion first). engageTrainer
-      -- only shows the won line, so push the after text on a win.
-      ow:engageTrainer(lance, function()
-        if not ow:trainerDefeated(lance) then return end
-        local after = text(game)._LancesRoomLanceAfterBattleText
-        if after then push(game, after) end
-      end)
+      ow:engageTrainer(lance, function() end)
       return true
     end
     if (x == 5 or x == 6) and y == 11 then

data/scripts/story5.lua

@@ -135,9 +135,6 @@ M.SILPH_CO_2F = {
   talk = {
     TEXT_SILPHCO2F_SILPH_WORKER_F = gift({
       flag = "EVENT_GOT_TM36", item = "TM_SELFDESTRUCT",
-      -- the label carries no leading underscore: pokered keeps this one in
-      -- the script bank, not the far-text bank (#393)
-      pre = "SilphCo2FSilphWorkerFPleaseTakeThisText",
       received = "_SilphCo2FSilphWorkerFReceivedTM36Text",
       explain = "_SilphCo2FSilphWorkerFTM36ExplanationText",
       noRoom = "_SilphCo2FSilphWorkerFTM36NoRoomText",
@@ -176,20 +173,6 @@ M.ROUTE_18_GATE_2F = {
       { "face_player" },
       { "trade", 6, "EVENT_TRADED_SLOWBRO_FOR_LICKITUNG" }, -- MARC
     },
-    -- Yellow replaces the youngster with a cook trading SPIKE
-    -- (TANGELA -> PARASECT): pokeyellow/scripts/Route18Gate2F.asm
-    -- Route18Gate2FCookText runs TRADE_FOR_SPIKE, index 6 in the Yellow
-    -- TradeMons table that Data:applyVersionedFieldData swaps in.  Red
-    -- maps have no COOK object here and Yellow maps have no YOUNGSTER,
-    -- so each version only ever fires its own row (#651).  Both rows
-    -- share the Red-flavoured done flag on purpose: a .sav tracks
-    -- "trade slot 6 completed" in one wCompletedInGameTradeFlags bit
-    -- either version reads, and the save codec maps that bit to this
-    -- flag name (src/save_convert/GenSave.lua EXTRA_FLAG_BITS).
-    TEXT_ROUTE18GATE2F_COOK = {
-      { "face_player" },
-      { "trade", 6, "EVENT_TRADED_SLOWBRO_FOR_LICKITUNG" }, -- SPIKE (Yellow)
-    },
   },
 }
 
@@ -213,24 +196,14 @@ local function inCoords(coords, x, y)
   return false
 end
 
--- coordinate block: show a line and shove the player back one step.  pokered
--- shoves with a SIMULATED JOYPAD press (scripts/ViridianCity.asm ViridianCity-
--- CheckGymOpenScript), which runs the normal overworld step pipeline including
--- HandleLedges (engine/overworld/ledges.asm), so the shove must HOP a ledge
--- when one sits in front: the tile below the Viridian Gym door is a down-ledge
--- (#151).  Gates with no ledge in front (Cinnabar gym lock at (18,4)) get
--- checkLedgeHop == false and fall back to the plain forced step, unchanged.
+-- coordinate block: show a line and push the player back one step
 local function stepGate(opts)
   return function(game, ow, x, y)
     if not inCoords(opts.coords, x, y) then return false end
     if not opts.blocked(game) then return false end
     require("src.core.Sound").play(game.data, "Denied")
-    push(game, text(game)[opts.text] or opts.fallback, function()
-      ow.player.facing = opts.push
-      if not ow:checkLedgeHop(opts.push) then
-        ow:scriptMove(ow.player, opts.push, 1)
-      end
-    end)
+    push(game, text(game)[opts.text] or opts.fallback,
+         function() ow:scriptMove(ow.player, opts.push, 1) end)
     return true
   end
 end
@@ -310,11 +283,7 @@ pewterEscort.guySteps = {
   "right", "right", "right",
 }
 
--- Reverse of guySteps with opposite facings, i.e. the gym-to-spawn
--- mirror of RLEList_PewterGymGuy.  Kept as the documented inverse that
--- tests/parity_pewter_escort.lua checks; the youngster does NOT walk it
--- home any more, because its first step is LEFT through the player
--- parked on (11,18) (#241).  See walkHome below.
+-- Walk home: reverse of guySteps with opposite facings (gym → spawn).
 do
   local opp = { up = "down", down = "up", left = "right", right = "left" }
   local ret = {}
@@ -392,44 +361,20 @@ local function pewterGymEscort(game, ow)
   local head = plan.guyHeadStart
 
   -- After the walk: face the player, restore map music, "Go take on
-  -- BROCK", then MovementData_PewterGymGuyExit -- five steps RIGHT out of
-  -- (12,18), the cell PewterCityYoungsterShowsPlayerGymScript pins him to
-  -- with SetSpritePosition1 (hSpriteMapXCoord 16 / hSpriteMapYCoord 22,
-  -- minus the +4 border offset object_event coords carry per
-  -- macros/scripts/maps.asm) and exactly where the escort leaves him.
-  -- That lands him on (17,18), the last walkable cell before the fence at
-  -- (18,18) and one column past the screen edge with the player parked on
-  -- (11,18).  PewterCityHideYoungsterScript then HideObject's him and
-  -- PewterCityResetYoungsterScript's SetSpritePosition2 + ShowObject put
-  -- him back on his object_event spawn (35,16) facing DOWN, which is the
-  -- snap below (the vanish/reappear is off screen, same as the original).
-  --
-  -- The old code retraced guyReturnSteps instead, whose first step is
-  -- LEFT into (11,18) -- the cell the player is standing on -- and
-  -- scriptMove is a pure tween with no entity test, so he walked straight
-  -- through Red (#241).  There is no honest route home: (17,18) is a
-  -- dead-end pocket ((18,18) fence, (17,17) wall), which is precisely why
-  -- the original teleports.  guyReturnSteps stays as the documented
-  -- mirror of RLEList_PewterGymGuy that parity_pewter_escort asserts.
-  -- Brock victory still HideObject's him.
+  -- BROCK", then retrace RLEList_PewterGymGuy back to his spawn (35,16).
+  -- (pokered teleports him via MovementData_PewterGymGuyExit; we walk
+  -- the same route home instead.  Brock victory still HideObject's him.)
   local function walkHome()
     if not guy then return end
+    local ret = pewterEscort.guyReturnSteps
     local i = 0
     local function tick()
       i = i + 1
-      if i > 5 then
-        -- SetSpritePosition2: same field writes as Commands.place_npc,
-        -- including the target clear -- a stale targetX/targetY would
-        -- leave OverworldState:npcAtCell reserving (17,18) forever and
-        -- silently wall the player out of that pocket.
-        guy.cellX, guy.cellY = 35, 16
-        guy.px, guy.py = 35 * 16, 16 * 16
-        guy.moving = false
-        guy.targetX, guy.targetY = nil, nil
+      if not ret[i] then
         guy.facing = "down"
         return
       end
-      ow:scriptMove(guy, "right", 1, tick)
+      ow:scriptMove(guy, ret[i], 1, tick)
     end
     tick()
   end
@@ -512,79 +457,36 @@ end
 -- EVENT_ROUTE22_RIVAL_WANTS_BATTLE in Oak's lab (expired by Pewter
 -- Gym) and again in Viridian Gym; we derive the same windows from the
 -- surrounding story flags so old saves work too.
--- Rival1Exit → Viridian (right/down); Rival2Exit → League (left).
--- Both exit lists are keyed on wSavedCoordIndex -- WHICH entry of
--- Route22DefaultScript.Route22RivalBattleCoords the player matched -- not
--- on where the rival ended up.  CheckCoords (home/map_objects.asm:107)
--- zeroes wCoordIndex and `inc [hl]` BEFORE each compare, so the first
--- entry reports 1: index 1 is (29,4), index 2 is (29,5).
--- Route22Rival1AfterBattleScript (Route22.asm:175) takes
--- ...ExitMovementData1 on index 1 and ...Data2 otherwise.  From the top
--- tile the rival stands BELOW the player on (29,5) and leaves east along
--- row 5; from the bottom tile he stands LEFT of him on (28,5) and has to
--- step UP to row 4 to get around him.  The port had the two branches
--- swapped, so the top tile started the walk with UP out of (28,4) into
--- the cliff cell (28,3), which is not walkable (#236).
-local function route22ExitDirs(n, py)
-  if n == 2 then
-    -- Route22Rival2ExitMovementData1 falls through into ...Data2: LEFT x4
-    -- from (29,5), LEFT x3 from (28,5), both back onto the spawn (25,5).
-    if py == 4 then return { "left", "left", "left", "left" } end
-    return { "left", "left", "left" }
-  end
-  -- Route22Rival1ExitMovementData1: (29,5) -> (31,5) -> (31,10)
-  if py == 4 then
-    return { "right", "right", "down", "down", "down", "down", "down" }
-  end
-  -- Route22Rival1ExitMovementData2: (28,5) -> (28,4) -> (31,4) -> (31,10)
-  return { "up", "right", "right", "right",
-           "down", "down", "down", "down", "down", "down" }
-end
-
 local function route22Scene(n, objIndex, objName, oppClass, baseParty, beatFlag, py)
-  -- Route22MoveRivalRightScript (Route22.asm:39) walks him RIGHT along his
-  -- own row from the object_event spawn (25,5): the full four-RIGHT
-  -- Route22RivalMovementData on coord index 1 (player on (29,4)), so he
-  -- stops BELOW the player on (29,5); `inc de` drops one RIGHT on index 2
-  -- (player on (29,5)), so he stops LEFT of him on (28,5).  He never
-  -- leaves row 5.  Route22Rival{1,2}StartBattleScript (Route22.asm:110)
-  -- then faces him UP on index 1 and RIGHT otherwise (#236).
-  local rx = (py == 4) and 29 or 28
-  local rivalFacing = (py == 4) and "up" or "right"
   return {
     { "show_object", "ROUTE_22", objName },                    -- 1
-    { "move_npc_to", objIndex, rx, 5 },                        -- 2
-    { "face_object", objIndex, rivalFacing },                  -- 3
+    { "move_npc_to", objIndex, 28, py },                       -- 2
+    { "face_object", objIndex, "right" },                      -- 3
     { "show_text", "_Route22RivalBeforeBattleText" .. n },     -- 4
     { "rival_battle", oppClass, baseParty },                   -- 5
     { "jump_if_false", 11 },                                   -- 6
     { "set_flag", beatFlag },                                  -- 7
     { "show_text", "_Route22Rival" .. n .. "DefeatedText" },   -- 8
     { "show_text", "_Route22RivalAfterBattleText" .. n },      -- 9
-    { "walk_npc", objIndex, route22ExitDirs(n, py) },          -- 10
+    { "move_npc_to", objIndex, 25, 5 },                        -- 10
     { "hide_object", "ROUTE_22", objName },                    -- 11
   }
 end
 
--- Route22Rival{1,2}StartBattleScript turns the player toward him too:
--- PLAYER_DIR_DOWN on coord index 1 (the (29,4) tile, rival below him),
--- and the PLAYER_DIR_LEFT Route22DefaultScript already set on index 2
--- (the (29,5) tile, rival to his left) (#236).
 M.ROUTE_22 = {
   onStep = function(game, ow, x, y)
     if not inCoords({ { 29, 4 }, { 29, 5 } }, x, y) then return false end
     local f = game.save.flags
-    local playerFacing = (y == 4) and "down" or "left"
     if f.EVENT_GOT_POKEDEX and not f.EVENT_BEAT_BROCK
        and not f.EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE then
       return runAmbush(game, ow,
         route22Scene(1, 1, "ROUTE22_RIVAL1", "OPP_RIVAL1", 4,
-                     "EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE", y), playerFacing)
+                     "EVENT_BEAT_ROUTE22_RIVAL_1ST_BATTLE", y), "left")
     end
     if f.EVENT_BEAT_GIOVANNI and not f.EVENT_BEAT_ROUTE22_RIVAL_2ND_BATTLE then
       return runAmbush(game, ow,
         route22Scene(2, 2, "ROUTE22_RIVAL2", "OPP_RIVAL2", 10,
-                     "EVENT_BEAT_ROUTE22_RIVAL_2ND_BATTLE", y), playerFacing)
+                     "EVENT_BEAT_ROUTE22_RIVAL_2ND_BATTLE", y), "left")
     end
     return false
   end,
@@ -593,14 +495,6 @@ M.ROUTE_22 = {
 -- Cerulean City: the Nugget Bridge rival ambush (CeruleanCityCoords2),
 -- the TM28 rocket thief with his forced-fight cells (Coords1), and the
 -- cave guard who steps aside once you are Champion.
--- Post-battle: Bill text then CeruleanCityMovement3/4 into town.
-local function ceruleanRivalExitDirs(px)
-  if px == 20 then
-    return { "right", "down", "down", "down", "down", "down", "down" }
-  end
-  return { "left", "down", "down", "down", "down", "down", "down" }
-end
-
 local function ceruleanRivalScene(px, py)
   return {
     { "show_object", "CERULEAN_CITY", "CERULEANCITY_RIVAL" },  -- 1
@@ -608,43 +502,41 @@ local function ceruleanRivalScene(px, py)
     { "face_object", 1, "down" },                              -- 3
     { "show_text", "_CeruleanCityRivalPreBattleText" },        -- 4
     { "rival_battle", "OPP_RIVAL1", 7 },                       -- 5
-    { "jump_if_false", 11 },                                   -- 6
+    { "jump_if_false", 10 },                                   -- 6
     { "set_flag", "EVENT_BEAT_CERULEAN_RIVAL" },               -- 7
     { "show_text", "_CeruleanCityRivalDefeatedText" },         -- 8
-    { "show_text", "_CeruleanCityRivalIWentToBillsText" },     -- 9
-    { "walk_npc", 1, ceruleanRivalExitDirs(px) },              -- 10
-    { "hide_object", "CERULEAN_CITY", "CERULEANCITY_RIVAL" },  -- 11
+    { "move_npc_to", 1, 20, 2 },                               -- 9
+    { "hide_object", "CERULEAN_CITY", "CERULEANCITY_RIVAL" },  -- 10
   }
 end
 
 -- scripts/CeruleanCity.asm CeruleanCityRocketText: fight the thief,
--- then he returns TM28 (DIG) and hurries off.  CeruleanHideRocket
--- (CeruleanCity_2.asm) is GBFadeOutToBlack → Show GUARD1 / Hide GUARD2 /
--- Hide ROCKET → GBFadeInFromBlack -- not a bare hide_object.
+-- then he returns TM28 (DIG) and hurries off
 local rocketRows = {
   { "face_player" },                                           -- 1
   { "check_flag", "EVENT_GOT_TM28" },                          -- 2
-  { "jump_if_true", 15 },                                      -- 3 → CeruleanHideRocket
+  { "jump_if_true", 15 },                                      -- 3
   { "check_flag", "EVENT_BEAT_CERULEAN_ROCKET_THIEF" },        -- 4
   { "jump_if_true", 9 },                                       -- 5
   { "show_text", "_CeruleanCityRocketText" },                  -- 6
   { "start_battle", "trainer", "OPP_ROCKET", 5 },              -- 7
-  { "jump_if_false", "end" },                                  -- 8
+  { "jump_if_false", 18 },                                     -- 8
   { "show_text", "_CeruleanCityRocketIllReturnTheTMText" },    -- 9
   { "set_flag", "EVENT_BEAT_CERULEAN_ROCKET_THIEF" },          -- 10
   { "give_item", "TM_DIG", 1, false },                         -- 11 (row 13 prints)
   { "set_flag", "EVENT_GOT_TM28" },                            -- 12
   { "show_text", "_CeruleanCityRocketReceivedTM28Text" },      -- 13
   { "show_text", "_CeruleanCityRocketIBetterGetMovingText" },  -- 14
-  { "fade", "out" },                                           -- 15 GBFadeOutToBlack
-  -- CeruleanHideRocket while black: GUARD1 (28,12) appears, GUARD2
-  -- (27,12) and the ROCKET go.  GUARD2 blocks the trashed-house south
-  -- door neighbour -- the swap reconnects the city (Bill's ticket does
-  -- the same in story.lua; either route is enough).
+  { "hide_object", "CERULEAN_CITY", "CERULEANCITY_ROCKET" },   -- 15
+  -- CeruleanHideRocket (scripts/CeruleanCity_2.asm) does all three behind
+  -- one fade: the ROCKET goes, GUARD1 (28,12) appears and GUARD2 (27,12)
+  -- disappears.  GUARD2 stands on the only walkable neighbour of the
+  -- trashed house's south door, which is one of the two ways through the
+  -- fence dividing Cerulean, so this swap is what reconnects the city.
+  -- Bill's ticket performs the same swap (data/scripts/story.lua), and
+  -- both are idempotent, so whichever the player reaches first opens it.
   { "show_object", "CERULEAN_CITY", "CERULEANCITY_GUARD1" },   -- 16
   { "hide_object", "CERULEAN_CITY", "CERULEANCITY_GUARD2" },   -- 17
-  { "hide_object", "CERULEAN_CITY", "CERULEANCITY_ROCKET" },   -- 18
-  { "fade", "in" },                                            -- 19 GBFadeInFromBlack
 }
 
 M.CERULEAN_CITY = {
@@ -703,83 +595,13 @@ M.MUSEUM_1F = {
 }
 
 -- The Pewter Center's singing JIGGLYPUFF (scripts/PewterPokecenter.asm
--- PewterPokecenterJigglypuffText).  The text_asm sets
--- wDoNotWaitForButtonPressAfterDisplayingText before PrintText, so the box
--- prints with no A prompt and the script keeps running underneath it:
--- SFX_STOP_ALL_MUSIC, DelayFrames 32, PlayMusic MUSIC_JIGGLYPUFF_SONG,
--- then .spinMovementLoop writes the next of DOWN -> LEFT -> UP -> RIGHT (a
--- clockwise turn) every 24 frames for as long as the song's CHAN1/CHAN2
--- still sound, DelayFrames 48, PlayDefaultMusic, TextScriptEnd.  Only that
--- last step closes the box, so the whole dance plays out unskippably
--- (#249).  Music.playOnce's pendingRestore stands in for both the channel
--- poll and PlayDefaultMusic, so the Center's theme comes back the frame
--- the song ends rather than 48 frames later.
-local JIGGLYPUFF_SPIN = { "down", "left", "up", "right" }
-local JIGGLYPUFF_SILENCE, JIGGLYPUFF_STEP, JIGGLYPUFF_TAIL = 32, 24, 48
-
--- Built as a TextBox `auto` table: auto.sound fires the frame the last
--- page has typed out (PrintText returning), and auto.tick then runs once
--- per frame while the gate it returns still reads as playing.
-local function jigglypuffDance(game, npc)
-  local Music = require("src.core.Music")
-  -- .findMatchingFacingDirectionLoop: the rotation picks up at the entry
-  -- matching the sprite's current facing (showMapText has just turned it
-  -- toward the player), and the first write is that same facing, so the
-  -- first visible quarter turn lands 24 frames in
-  local step = 1
-  for i, dir in ipairs(JIGGLYPUFF_SPIN) do
-    if npc and npc.facing == dir then step = i end
-  end
-  local frames, phase = 0, "silence"
-  return {
-    sound = function()
-      Music.stop() -- SFX_STOP_ALL_MUSIC
-      return { isPlaying = function() return phase ~= "done" end }
-    end,
-    tick = function()
-      frames = frames + 1
-      if phase == "silence" then
-        if frames < JIGGLYPUFF_SILENCE then return end
-        frames = 0
-        if Music.playOnce(game.data, "Music_JigglypuffSong") then
-          phase = "spin"
-        else
-          -- no song def (or headless): Music.stop above already took the
-          -- map theme down and nothing armed pendingRestore, so put it
-          -- back by hand and fall through to the tail rather than hold
-          -- the box on a poll that would never clear
-          Music.restoreMap(game.data)
-          phase = "tail"
-        end
-        return
-      end
-      if phase == "spin" then
-        if frames < JIGGLYPUFF_STEP then return end
-        frames = 0
-        -- the loop tests the channels after the delay and before the next
-        -- write, so a song that just ended costs no extra quarter turn
-        if not Music.oneShotPlaying() then
-          phase = "tail"
-          return
-        end
-        step = step % #JIGGLYPUFF_SPIN + 1
-        if npc then npc.facing = JIGGLYPUFF_SPIN[step] end
-        return
-      end
-      if frames >= JIGGLYPUFF_TAIL then phase = "done" end
-    end,
-  }
-end
-
+-- plays MUSIC_JIGGLYPUFF_SONG, then the map theme resumes)
 M.PEWTER_POKECENTER = {
   talk = {
     TEXT_PEWTERPOKECENTER_JIGGLYPUFF = function(game, ow, npc, done)
-      -- not the local push() helper: this box needs opts.auto, which is
-      -- also what suppresses the blinking arrow and the A dismissal
-      local TextBox = require("src.render.TextBox")
-      game.stack:push(TextBox.new(game,
-        text(game)._PewterPokecenterJigglypuffText or "JIGGLYPUFF: Puu\npupuu!",
-        done, { auto = jigglypuffDance(game, npc) }))
+      require("src.core.Music").playOnce(game.data, "Music_JigglypuffSong")
+      push(game, text(game)._PewterPokecenterJigglypuffText
+        or "JIGGLYPUFF: Puu\npupuu!", done)
     end,
   },
 }
@@ -804,19 +626,8 @@ local function bikeGateGuard(coords, stopText, explainText)
     local t = text(game)
     push(game, t[stopText] or "Hey! Wait up!", function()
       push(game, t[explainText] or "You need a\nBICYCLE for\nCYCLING ROAD!", function()
-        -- pokered's Route16Gate1FGuardScript / Route18Gate1FGuardScript
-        -- (scripts/Route16Gate1F.asm, Route18Gate1F.asm) simulate one
-        -- PAD_RIGHT step after the refusal text, and only clear
-        -- wJoyIgnore / hand control back once that step finishes
-        -- (PlayerMovingRightScript). Without it the player was left
-        -- parked beside the guard's counter with no way past. #518
-        local function shoveRight()
-          ow:scriptMove(ow.player, "right", 1)
-        end
         if dist > 0 then
-          ow:scriptMove(ow.player, "up", dist, shoveRight)
-        else
-          shoveRight()
+          ow:scriptMove(ow.player, "up", dist)
         end
       end)
     end)
@@ -864,19 +675,6 @@ M.SILPH_CO_7F = {
   end,
 }
 
--- SSAnne2FRivalAfterBattleScript's exit walk is keyed on the player's X,
--- not on where the rival stopped: from (37,8) the rival stands below him on
--- (36,8) and takes .RivalDownFourMovement straight down out of the room;
--- from (36,8) he stands above him on (36,7) and takes
--- .RivalWalkAroundPlayerMovement, which steps RIGHT and then falls through
--- into the same four DOWNs, so five downs in all (#360).
-local function ssAnne2FRivalExitDirs(onLeft)
-  if onLeft then
-    return { "right", "down", "down", "down", "down", "down" }
-  end
-  return { "down", "down", "down", "down" }
-end
-
 -- S.S. Anne 2F rival ambush (scripts/SSAnne2F.asm; coords 36/37,8)
 M.SS_ANNE_2F = {
   onStep = function(game, ow, x, y)
@@ -889,12 +687,11 @@ M.SS_ANNE_2F = {
       { "face_object", 2, onLeft and "down" or "right" },      -- 3
       { "show_text", "_SSAnne2FRivalText" },                   -- 4
       { "rival_battle", "OPP_RIVAL2", 1 },                     -- 5
-      { "jump_if_false", 11 },                                 -- 6
+      { "jump_if_false", 10 },                                 -- 6
       { "set_flag", "EVENT_BEAT_SS_ANNE_RIVAL" },              -- 7
       { "show_text", "_SSAnne2FRivalDefeatedText" },           -- 8
-      { "show_text", "_SSAnne2FRivalCutMasterText" },          -- 9
-      { "walk_npc", 2, ssAnne2FRivalExitDirs(onLeft) },        -- 10
-      { "hide_object", "SS_ANNE_2F", "SSANNE2F_RIVAL" },       -- 11
+      { "move_npc_to", 2, 36, 4 },                             -- 9
+      { "hide_object", "SS_ANNE_2F", "SSANNE2F_RIVAL" },       -- 10
     }, onLeft and "up" or "left")
   end,
 }

data/scripts/story6.lua

@@ -118,7 +118,6 @@ local MANSION_HOLES = {
 M.POKEMON_MANSION_3F.onStep = function(game, ow, x, y)
   for _, h in ipairs(MANSION_HOLES) do
     if x == h[1] and y == h[2] then
-      require("src.core.Sound").play(game.data, "Faint_Fall")
       ow:startWarpTo(h[3], h[4], h[5], ow.player.facing)
       return true
     end
@@ -174,46 +173,7 @@ local function syncGymGatesAfterBattle(game, ow)
   applyGymGates(game, ow)
 end
 
--- Yellow's quiz-first rule (scripts/CinnabarGym.asm SuperNerd2..7): a
--- gate guardian refuses to battle until his quiz was attempted -- a
--- wrong answer sics him on you (the onInteract path below), a right one
--- opens his gate; walking up and talking first just gets the room's
--- CinnabarGymText_N lecture (Func_f2150's pointer table).
-local function yellowQuizTalk(machineIndex)
-  return function(game, ow, npc, done)
-    local yellow = require("src.core.GameVersion").isYellow()
-    local defeated = ow:trainerDefeated(npc)
-    local gateOpen = game.save.flags[gymGateFlag(machineIndex)]
-    if yellow and not defeated and not gateOpen then
-      local TextBox = require("src.render.TextBox")
-      local t = game.data.text
-      game.stack:push(TextBox.new(game,
-        t["_CinnabarGymText_" .. machineIndex]
-        or "You have to take\nthe quiz first!", done))
-      return
-    end
-    -- gate open (or Red/Blue): the ordinary trainer engagement /
-    -- after-battle line, mirroring talkTo's generic trainer branch
-    npc:facePlayer(ow.player)
-    if not defeated then
-      ow:engageTrainer(npc, done)
-      return
-    end
-    local header = game.data:trainerHeader(ow.map.def.label, npc.def.index)
-    local after = header and header.after and game.data.text[header.after]
-    local TextBox = require("src.render.TextBox")
-    game.stack:push(TextBox.new(game, after or "...", done))
-  end
-end
-
 M.CINNABAR_GYM = {
-  talk = (function()
-    local talk = {}
-    for i = 1, 6 do
-      talk["TEXT_CINNABARGYM_SUPER_NERD" .. (i + 1)] = yellowQuizTalk(i)
-    end
-    return talk
-  end)(),
   onEnter = applyGymGates,
   onVictory = syncGymGatesAfterBattle,
   onInteract = function(game, ow, fx, fy)

data/scripts/victories.lua

@@ -12,12 +12,6 @@
 -- "; deactivate gym trainers" / SetEventRange in the other gyms, and
 -- FightingDojo.asm SetEventRange EVENT_BEAT_KARATE_MASTER ..
 -- EVENT_BEAT_FIGHTING_DOJO_TRAINER_3).
---
--- `dialogue` is the end-battle + post-battle text chain each gym leader
--- runs (SaveEndBattleTextPointers then the map's *PostBattle / ReceiveTM
--- script).  Leaders are not def_trainers entries, so engageTrainer has
--- no header.won -- checkVictoryRewards shows this chain instead of a
--- synthetic "received badge/TM" stub.
 
 local function range(prefix, first, last)
   local t = {}
@@ -37,76 +31,28 @@ return {
                       hide = {
                         { "PEWTER_CITY", "PEWTERCITY_YOUNGSTER" },
                         { "ROUTE_22", "ROUTE22_RIVAL1" },
-                      },
-                      dialogue = {
-                        "_PewterGymBrockReceivedBoulderBadgeText",
-                        "_PewterGymBrockBoulderBadgeInfoText",
-                        "_PewterGymBrockWaitTakeThisText",
-                        "_PewterGymReceivedTM34Text",
-                        "_TM34ExplanationText",
                       } },
   ["OPP_MISTY#1"] = { badge = "CASCADEBADGE", flag = "EVENT_BEAT_MISTY",
                       item = "TM_BUBBLEBEAM",
-                      deactivate = range("EVENT_BEAT_CERULEAN_GYM_TRAINER_", 0, 1),
-                      dialogue = {
-                        "_CeruleanGymMistyReceivedCascadeBadgeText",
-                        "_CeruleanGymMistyCascadeBadgeInfoText",
-                        "_CeruleanGymMistyReceivedTM11Text",
-                      } },
+                      deactivate = range("EVENT_BEAT_CERULEAN_GYM_TRAINER_", 0, 1) },
   ["OPP_LT_SURGE#1"] = { badge = "THUNDERBADGE", flag = "EVENT_BEAT_LT_SURGE",
                          item = "TM_THUNDERBOLT",
-                         deactivate = range("EVENT_BEAT_VERMILION_GYM_TRAINER_", 0, 2),
-                         dialogue = {
-                           "_VermilionGymLTSurgeReceivedThunderBadgeText",
-                           "_VermilionGymLTSurgeThunderBadgeInfoText",
-                           "_VermilionGymLTSurgeReceivedTM24Text",
-                           "_TM24ExplanationText",
-                         } },
+                         deactivate = range("EVENT_BEAT_VERMILION_GYM_TRAINER_", 0, 2) },
   ["OPP_ERIKA#1"] = { badge = "RAINBOWBADGE", flag = "EVENT_BEAT_ERIKA",
                       item = "TM_MEGA_DRAIN",
-                      deactivate = range("EVENT_BEAT_CELADON_GYM_TRAINER_", 0, 6),
-                      dialogue = {
-                        "_CeladonGymErikaReceivedRainbowBadgeText",
-                        "_CeladonGymRainbowBadgeInfoText",
-                        "_CeladonGymReceivedTM21Text",
-                        "_TM21ExplanationText",
-                      } },
+                      deactivate = range("EVENT_BEAT_CELADON_GYM_TRAINER_", 0, 6) },
   ["OPP_KOGA#1"] = { badge = "SOULBADGE", flag = "EVENT_BEAT_KOGA",
                      item = "TM_TOXIC",
-                     deactivate = range("EVENT_BEAT_FUCHSIA_GYM_TRAINER_", 0, 5),
-                     dialogue = {
-                       "_FuchsiaGymKogaReceivedSoulBadgeText",
-                       "_FuchsiaGymKogaSoulBadgeInfoText",
-                       "_FuchsiaGymKogaReceivedTM06Text",
-                       "_FuchsiaGymKogaTM06ExplanationText",
-                     } },
+                     deactivate = range("EVENT_BEAT_FUCHSIA_GYM_TRAINER_", 0, 5) },
   ["OPP_SABRINA#1"] = { badge = "MARSHBADGE", flag = "EVENT_BEAT_SABRINA",
                         item = "TM_PSYWAVE",
-                        deactivate = range("EVENT_BEAT_SAFFRON_GYM_TRAINER_", 0, 6),
-                        dialogue = {
-                          "_SaffronGymSabrinaReceivedMarshBadgeText",
-                          "_SaffronGymSabrinaMarshBadgeInfoText",
-                          "_SaffronGymSabrinaReceivedTM46Text",
-                          "_TM46ExplanationText",
-                        } },
+                        deactivate = range("EVENT_BEAT_SAFFRON_GYM_TRAINER_", 0, 6) },
   ["OPP_BLAINE#1"] = { badge = "VOLCANOBADGE", flag = "EVENT_BEAT_BLAINE",
                        item = "TM_FIRE_BLAST",
-                       deactivate = range("EVENT_BEAT_CINNABAR_GYM_TRAINER_", 0, 6),
-                       dialogue = {
-                         "_CinnabarGymBlaineReceivedVolcanoBadgeText",
-                         "_CinnabarGymBlaineVolcanoBadgeInfoText",
-                         "_CinnabarGymBlaineReceivedTM38Text",
-                         "_CinnabarGymBlaineTM38ExplanationText",
-                       } },
+                       deactivate = range("EVENT_BEAT_CINNABAR_GYM_TRAINER_", 0, 6) },
   ["OPP_GIOVANNI#3"] = { badge = "EARTHBADGE", flag = "EVENT_BEAT_GIOVANNI",
                          item = "TM_FISSURE",
-                         deactivate = range("EVENT_BEAT_VIRIDIAN_GYM_TRAINER_", 0, 7),
-                         dialogue = {
-                           "_ViridianGymGiovanniReceivedEarthBadgeText",
-                           "_ViridianGymGiovanniEarthBadgeInfoText",
-                           "_ViridianGymGiovanniReceivedTM27Text",
-                           "_ViridianGymGiovanniTM27ExplanationText",
-                         } },
+                         deactivate = range("EVENT_BEAT_VIRIDIAN_GYM_TRAINER_", 0, 7) },
 
   -- Silph Co. Giovanni: unlocks the president's Master Ball gift
   ["OPP_GIOVANNI#2"] = { flag = "EVENT_BEAT_SILPH_CO_GIOVANNI" },
@@ -114,12 +60,9 @@ return {
   -- Fighting Dojo Karate Master (scripts/FightingDojo.asm
   -- FightingDojoKarateMasterPostBattleScript sets EVENT_BEAT_KARATE_MASTER,
   -- which gates the HITMONLEE/HITMONCHAN gift).  OPP_BLACKBELT party 1 is
-  -- only him (data/maps/objects/FightingDojo.asm).  `dialogue` is the
-  -- concede + prize offer he speaks after the win (his header supplies the
-  -- "Hwa! Arrgh! Beaten!" won line first; #197).
+  -- only him (data/maps/objects/FightingDojo.asm).
   ["OPP_BLACKBELT#1"] = { flag = "EVENT_BEAT_KARATE_MASTER",
-                          deactivate = range("EVENT_BEAT_FIGHTING_DOJO_TRAINER_", 0, 3),
-                          dialogue = { "_FightingDojoKarateMasterIWillGiveYouAPokemonText" } },
+                          deactivate = range("EVENT_BEAT_FIGHTING_DOJO_TRAINER_", 0, 3) },
 
   -- Elite Four progress flags (their rooms' door logic isn't ported, but
   -- the flags make the Hall of Fame checkable)

data/scripts/yellow_beach_house.lua

@@ -1,131 +0,0 @@
--- Summer Beach House (scripts/SummerBeachHouse.asm), Yellow's Route 19
--- surf shack.  The Surfin' Dude only lets a party Pikachu that knows
--- SURF ride (IsSurfingPikachuInParty, home/map_objects.asm); saying yes
--- runs the Surfing Pikachu minigame (src/ui/SurfingMinigame.lua).  The
--- corner printer shows/prints the high score once you have surfed this
--- visit (BIT_PIKACHU_MAP_SURF_SELECT is a per-map-load flag, so the
--- session markers live on the overworld state, not the save).
-
-local function surfingPikachu(game)
-  for _, mon in ipairs(game.save.party or {}) do
-    if mon.species == "PIKACHU" then
-      for _, mv in ipairs(mon.moves or {}) do
-        if mv.id == "SURF" then return mon end
-      end
-    end
-  end
-  return nil
-end
-
-local function push(game, text, done)
-  local TextBox = require("src.render.TextBox")
-  game.stack:push(TextBox.new(game, text, done))
-end
-
--- the two-variant posters: the surf-capable line once a surfing
--- Pikachu is along, the plain one otherwise
-local function poster(n)
-  return function(game, ow, npc, done)
-    local t = game.data.text
-    local key = ("_SummerBeachHousePoster%dText%d"):format(
-      n, surfingPikachu(game) and 1 or 2)
-    push(game, t[key] or "A surfing poster.", done)
-  end
-end
-
-return {
-  SUMMER_BEACH_HOUSE = {
-    talk = {
-      TEXT_SUMMERBEACHHOUSE_SURFINDUDE = function(game, ow, npc, done)
-        local t = game.data.text
-        if not surfingPikachu(game) then
-          push(game, t._SummerBeachHouseSurfinDudeText4
-            or "Dogs and burgers\non special today!", done)
-          return
-        end
-        -- Text1 on the first ask each visit, the short Text3 after
-        local ask = ow.surfinDudeAsked
-          and (t._SummerBeachHouseSurfinDudeText3 or "Wanna go SURF?")
-          or (t._SummerBeachHouseSurfinDudeText1
-              or "Whoa!\nYour PIKACHU knows\nhow to SURF!\fGive it a go?")
-        ow.surfinDudeAsked = true
-        push(game, ask, function()
-          local ChoiceBox = require("src.ui.ChoiceBox")
-          game.stack:push(ChoiceBox.new(game, function(yes)
-            if not yes then
-              push(game, t._SummerBeachHouseSurfinDudeText2
-                or "Come SURF anytime,\nmy friend!", done)
-              return
-            end
-            local SurfingMinigame = require("src.ui.SurfingMinigame")
-            game.stack:push(SurfingMinigame.new(game, function()
-              ow.surfedThisVisit = true -- BIT_PIKACHU_MAP_SURF_SELECT
-              require("src.core.Music").playMap(game.data, ow.map.id)
-              done()
-            end))
-          end))
-        end)
-      end,
-
-      TEXT_SUMMERBEACHHOUSE_PIKACHU = function(game, ow, npc, done)
-        local t = game.data.text
-        push(game, t._SummerBeachHousePikachuText or "PIKACHU: Pikaa!",
-          function()
-            require("src.core.Sound").playCry(game.data, "PIKACHU")
-            done()
-          end)
-      end,
-
-      TEXT_SUMMERBEACHHOUSE_POSTER1 = poster(1),
-      TEXT_SUMMERBEACHHOUSE_POSTER2 = poster(2),
-      TEXT_SUMMERBEACHHOUSE_POSTER3 = poster(3),
-
-      TEXT_SUMMERBEACHHOUSE_PRINTER = function(game, ow, npc, done)
-        local t = game.data.text
-        if not surfingPikachu(game) then
-          push(game, t._SummerBeachHousePrinterText1
-            or "It's some sort of\na machine...", done)
-          return
-        end
-        push(game, t._SummerBeachHousePrinterText2
-          or "SUMMER BEACH HOUSE\nPRINTER, it says.", function()
-          if not ow.surfedThisVisit then
-            done()
-            return
-          end
-          push(game, t._SummerBeachHousePrinterText3
-            or "The Hi-Score is\nshown.\fPRINT it out?", function()
-            local ChoiceBox = require("src.ui.ChoiceBox")
-            game.stack:push(ChoiceBox.new(game, function(yes)
-              if not yes then
-                done()
-                return
-              end
-              -- PrintSurfingMinigameHighScore -> PNG stand-in
-              local Printer = require("src.core.Printer")
-              local Font = require("src.render.Font")
-              local Strings = require("src.core.Strings")
-              local hi = game.save.surfingHighScore or 0
-              local name = game.save.player.name or "RED"
-              local saved, err = Printer.save("surf_hiscore", 160, 64,
-                function()
-                  love.graphics.setColor(1, 1, 1, 1)
-                  love.graphics.rectangle("fill", 0, 0, 160, 64)
-                  love.graphics.setColor(0, 0, 0, 1)
-                  love.graphics.rectangle("line", 2.5, 2.5, 155, 59)
-                  Font.draw(Strings("SUMMER BEACH HOUSE"), 8, 10)
-                  Font.draw(Strings("SURFING Hi-Score"), 8, 24)
-                  Font.draw(name, 8, 40)
-                  Font.draw(Strings("%d pts", hi), 96, 40)
-                end)
-              push(game, saved
-                and Strings("Printed!\fSaved as\n%s\vin the save\nfolder.",
-                            saved)
-                or Strings("Printer error!\n%s", tostring(err)), done)
-            end))
-          end)
-        end)
-      end,
-    },
-  },
-}

data/scripts/yellow_gifts.lua

@@ -1,113 +0,0 @@
--- Yellow's three Kanto-starter side-quests, hand-ported from
--- scripts/CeruleanMelaniesHouse.asm, scripts/Route24.asm
--- (Route24CooltrainerM4Text) and scripts/VermilionCity_2.asm
--- (VermilionCityPrintOfficerJennyText).  Registered on top of the shared
--- Red map scripts by data/scripts/init.lua on a Yellow boot only, so the
--- table keys compose with story.lua / story4.lua's existing entries.
-
-local M = {}
-
--- Melanie hands over her Bulbasaur once the starter Pikachu trusts you
--- (wPikachuHappiness >= 147).
-M.CERULEAN_MELANIES_HOUSE = {
-  talk = {
-    TEXT_CERULEANMELANIESHOUSE_MELANIE = function(game, ow, npc, done)
-      local rows = { { "face_player" } }
-      if game.save.flags.EVENT_GOT_BULBASAUR_IN_CERULEAN then
-        rows[#rows + 1] = { "show_text", "MelanieText4" }
-      elseif (game.save.pikachuHappiness or 90) < 147 then
-        rows[#rows + 1] = { "show_text", "MelanieText1" }
-      else
-        rows[#rows + 1] = { "show_text", "MelanieText1" }
-        rows[#rows + 1] = { "ask", "MelanieText2" }
-        rows[#rows + 1] = { "jump_if_false", "declined" }
-        rows[#rows + 1] = { "give_pokemon", "BULBASAUR", 10 }
-        rows[#rows + 1] = { "jump_if_false", "end" } -- party + box full
-        -- Event and HideObject before MelanieText3: give_pokemon's nickname
-        -- prompt and the received text both yield, and a script that dies
-        -- in that window used to leave the BULBASAUR given with the event
-        -- clear, so Melanie offered a second one (#426).  The flag is only
-        -- read at script entry, so the order is invisible in play.
-        rows[#rows + 1] = { "set_flag", "EVENT_GOT_BULBASAUR_IN_CERULEAN" }
-        rows[#rows + 1] = { "hide_object", "CERULEAN_MELANIES_HOUSE",
-                            "CERULEANMELANIESHOUSE_BULBASAUR" }
-        rows[#rows + 1] = { "show_text", "MelanieText3" }
-        rows[#rows + 1] = { "jump", "end" }
-        rows[#rows + 1] = { "label", "declined" }
-        rows[#rows + 1] = { "show_text", "MelanieText5" }
-      end
-      ow.runner:run(rows, { npc = npc, onDone = done })
-    end,
-    -- pet flavor: the text with the species' cry over it
-    TEXT_CERULEANMELANIESHOUSE_BULBASAUR = {
-      { "play_cry", "BULBASAUR" },
-      { "show_text", "MelanieBulbasaurText" },
-    },
-    TEXT_CERULEANMELANIESHOUSE_ODDISH = {
-      { "play_cry", "ODDISH" },
-      { "show_text", "MelanieOddishText" },
-    },
-    TEXT_CERULEANMELANIESHOUSE_SANDSHREW = {
-      { "play_cry", "SANDSHREW" },
-      { "show_text", "MelanieSandshrewText" },
-    },
-  },
-}
-
--- Damian gives away the Charmander he thinks is too weak (EVENT_54F).
-M.ROUTE_24 = {
-  talk = {
-    TEXT_ROUTE24_COOLTRAINER_M4 = {
-      { "face_player" },
-      { "check_flag", "EVENT_54F" },
-      { "jump_if_true", "after" },
-      { "ask", "_Route24DamianText1" },
-      { "jump_if_false", "declined" },
-      { "give_pokemon", "CHARMANDER", 10 },
-      { "jump_if_false", "end" },
-      -- SetEvent hoisted ahead of the received text (Route24.asm writes it
-      -- after Route24Text_515e3, where nothing in between can fail): the
-      -- nickname prompt and the text both yield, and a script death in that
-      -- window left the CHARMANDER given with EVENT_54F clear, so Damian
-      -- handed out a second one on the next talk (#426).
-      { "set_flag", "EVENT_54F" },
-      { "show_text", "_Route24DamianText2" },
-      { "jump", "end" },
-      { "label", "declined" },
-      { "show_text", "_Route24DamianText3" },
-      { "jump", "end" },
-      { "label", "after" },
-      { "show_text", "_Route24DamianText4" },
-    },
-  },
-}
-
--- Officer Jenny's Squirtle: kept until you carry the Thunder Badge.
-M.VERMILION_CITY = {
-  talk = {
-    TEXT_VERMILIONCITY_OFFICER_JENNY = function(game, ow, npc, done)
-      local rows = { { "face_player" } }
-      if game.save.flags.EVENT_GOT_SQUIRTLE_FROM_OFFICER_JENNY then
-        rows[#rows + 1] = { "show_text", "_OfficerJennyText5" }
-      elseif not (game.save.inventory
-                  and game.save.inventory.THUNDERBADGE) then
-        rows[#rows + 1] = { "show_text", "_OfficerJennyText1" }
-      else
-        rows[#rows + 1] = { "ask", "_OfficerJennyText2" }
-        rows[#rows + 1] = { "jump_if_false", "declined" }
-        rows[#rows + 1] = { "give_pokemon", "SQUIRTLE", 10 }
-        rows[#rows + 1] = { "jump_if_false", "end" }
-        -- event before the received text, as above (#426)
-        rows[#rows + 1] = { "set_flag",
-                            "EVENT_GOT_SQUIRTLE_FROM_OFFICER_JENNY" }
-        rows[#rows + 1] = { "show_text", "_OfficerJennyText3" }
-        rows[#rows + 1] = { "jump", "end" }
-        rows[#rows + 1] = { "label", "declined" }
-        rows[#rows + 1] = { "show_text", "_OfficerJennyText4" }
-      end
-      ow.runner:run(rows, { npc = npc, onDone = done })
-    end,
-  },
-}
-
-return M

data/scripts/yellow_jessie_james.lua

@@ -1,275 +0,0 @@
--- Jessie & James, Yellow's Team Rocket duo, at all four ambush sites:
--- Mt Moon B2F (scripts/MtMoonB2F.asm), Rocket Hideout B4F
--- (scripts/RocketHideoutB4F.asm), Pokemon Tower 7F
--- (scripts/PokemonTower7F.asm) and Silph Co 11F (scripts/SilphCo11F.asm).
--- Every site shares one shape: a coordinate trigger swaps the map theme
--- for Music_MeetJessieJames, the motto plays, the duo closes in, one
--- battle against the shared OPP_ROCKET party fights them both, and after
--- their parting lines they vanish together under a second sting of the
--- theme before the map theme resumes (PlayDefaultMusic ->
--- play_default_music).
---
--- Registered on top of the shared tables by data/scripts/init.lua on a
--- Yellow boot; MT_MOON_B2F's onStep chains story2's Super Nerd / fossil
--- trigger and SILPH_CO_11F's chains story's Giovanni trigger, since
--- non-talk hooks replace rather than merge.
-
-local M = {}
-
--- Capture the FUNCTION, not the table: attachBase stores the module
--- table itself, so once this file's onStep is attached the table's slot
--- points back here -- delegating through the table would self-recurse.
-local baseMtMoonStep = require("data.scripts.story2").MT_MOON_B2F.onStep
-local baseSilph11Step = require("data.scripts.story").SILPH_CO_11F.onStep
-
-M.MT_MOON_B2F = {
-  talk = {
-    TEXT_MTMOONB2F_JESSIE = {
-      { "face_player" }, { "show_text", "_MtMoonJessieJamesText1" },
-    },
-    TEXT_MTMOONB2F_JAMES = {
-      { "face_player" }, { "show_text", "_MtMoonJessieJamesText1" },
-    },
-  },
-
-  onStep = function(game, ow, x, y)
-    if baseMtMoonStep and baseMtMoonStep(game, ow, x, y) then
-      return true
-    end
-    local f = game.save.flags
-    if x ~= 3 or y ~= 5 then return false end
-    if f.EVENT_BEAT_MT_MOON_3_JESSIE_JAMES then return false end
-    if not (f.EVENT_GOT_DOME_FOSSIL or f.EVENT_GOT_HELIX_FOSSIL) then
-      return false
-    end
-    ow.runner:run({
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "show_object", "MT_MOON_B2F", "MTMOONB2F_JESSIE" },
-      { "show_object", "MT_MOON_B2F", "MTMOONB2F_JAMES" },
-      { "show_text", "_MtMoonJessieJamesText1" },
-      { "face_player_dir", "up" },
-      { "emote", "player", "shock", 30 },
-      -- MtMoonB2FScript_49e15 simulates PAD_UP for one player step, then
-      -- Script6/Script9 walk Jessie (object 2, MovementData_f9e65: six
-      -- $06) and James (object 6, f9e66: five $06); both objects' movement
-      -- byte 2 is LEFT, so .determineDirection makes those LEFT steps --
-      -- Jessie (9,3)->(3,3) above the player at (3,4), James (9,4)->(4,4)
-      -- beside him. #423
-      { "walk_npc", "player", { "up" } },
-      { "walk_npc", 2, { "left", "left", "left", "left", "left", "left" } },
-      { "face_object", 2, "down" },
-      { "walk_npc", 6, { "left", "left", "left", "left", "left" } },
-      { "face_object", 6, "left" },
-      { "show_text", "_MtMoonJessieJamesText2" },
-      { "start_battle", "trainer", "OPP_ROCKET", 42 },
-      { "check_battle_result", "win" },
-      { "jump_if_false", "end" },
-      { "show_text", "_MtMoonJessieJamesText3" },
-      { "show_text", "_MtMoonJessieJamesText4" },
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "fade", "out" },
-      { "hide_object", "MT_MOON_B2F", "MTMOONB2F_JESSIE" },
-      { "hide_object", "MT_MOON_B2F", "MTMOONB2F_JAMES" },
-      { "fade", "in" },
-      { "play_default_music" },
-      { "set_flag", "EVENT_BEAT_MT_MOON_3_JESSIE_JAMES" },
-    }, {})
-    return true
-  end,
-}
-
--- -------------------------------------------------------------------
--- Rocket Hideout B4F (RocketHideoutB4FScript_455a5..Script13): the
--- motto plays from off-screen FIRST, then the duo pops in at (25,10) /
--- (24,10) and whichever of them shares the player's column ($18=24 or
--- $19=25, EVENT_ROCKET_HIDEOUT_4_JESSIE_JAMES_ON_LEFT) walks the three
--- tiles down to loom over the player while the other steps one.  A loss
--- re-hides them (RocketHideoutB4FResetScripts via EVENT_6A0), so the
--- trigger re-arms clean.
--- -------------------------------------------------------------------
-
-M.ROCKET_HIDEOUT_B4F = {
-  talk = {
-    TEXT_ROCKETHIDEOUTB4F_JESSIE = {
-      { "face_player" }, { "show_text", "_RocketHideoutJessieJamesText1" },
-    },
-    TEXT_ROCKETHIDEOUTB4F_JAMES = {
-      { "face_player" }, { "show_text", "_RocketHideoutJessieJamesText1" },
-    },
-  },
-
-  onStep = function(game, ow, x, y)
-    local f = game.save.flags
-    if y ~= 14 or (x ~= 24 and x ~= 25) then return false end
-    if f.EVENT_BEAT_ROCKET_HIDEOUT_4_JESSIE_JAMES then return false end
-    -- ON_LEFT: player under James's column (25); movement data pairs
-    -- RocketHideoutB4FJessieJamesMovementData_45605/45606 swap so the
-    -- column-mate walks 3, the other 1.
-    local onLeft = (x == 25)
-    ow.runner:run({
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "show_text", "_RocketHideoutJessieJamesText1" },
-      { "face_player_dir", "up" },
-      { "emote", "player", "shock", 30 },
-      { "show_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JAMES" },
-      { "show_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JESSIE" },
-      -- James (object 2) then Jessie (object 3), Script4..Script9 order
-      { "walk_npc", 2, onLeft and { "down", "down", "down" } or { "down" } },
-      { "face_object", 2, onLeft and "down" or "left" },
-      { "walk_npc", 3, onLeft and { "down" } or { "down", "down", "down" } },
-      { "face_object", 3, onLeft and "right" or "down" },
-      { "show_text", "_RocketHideoutJessieJamesText2" },
-      { "start_battle", "trainer", "OPP_ROCKET", 43 },
-      { "check_battle_result", "win" },
-      { "jump_if_false", "lost" },
-      { "show_text", "_RocketHideoutJessieJamesText3" },
-      { "show_text", "_RocketHideoutJessieJamesText4" },
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "fade", "out" },
-      { "hide_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JAMES" },
-      { "hide_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JESSIE" },
-      { "fade", "in" },
-      { "play_default_music" },
-      { "set_flag", "EVENT_BEAT_ROCKET_HIDEOUT_4_JESSIE_JAMES" },
-      { "jump", "end" },
-      { "label", "lost" },
-      { "hide_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JAMES" },
-      { "hide_object", "ROCKET_HIDEOUT_B4F", "ROCKETHIDEOUTB4F_JESSIE" },
-    }, {})
-    return true
-  end,
-}
-
--- -------------------------------------------------------------------
--- Pokemon Tower 7F (PokemonTower7FScript_60d2a..Script10): same beat
--- one floor below Fuji, except the duo pops in BEFORE the motto and
--- Jessie ($a=10 column) leads the walk-down; ON_LEFT ($b=11) hands the
--- three-tile walk to James instead.  On a loss vanilla only resets the
--- script counter (the blackout warp reloads the map anyway).
--- -------------------------------------------------------------------
-
-M.POKEMON_TOWER_7F = {
-  talk = {
-    TEXT_POKEMONTOWER7F_JESSIE = {
-      { "face_player" }, { "show_text", "_PokemonTowerJessieJamesText1" },
-    },
-    TEXT_POKEMONTOWER7F_JAMES = {
-      { "face_player" }, { "show_text", "_PokemonTowerJessieJamesText1" },
-    },
-  },
-
-  onStep = function(game, ow, x, y)
-    local f = game.save.flags
-    if y ~= 12 or (x ~= 10 and x ~= 11) then return false end
-    if f.EVENT_BEAT_POKEMONTOWER_7_JESSIE_JAMES then return false end
-    local onLeft = (x == 11)   -- EVENT_POKEMONTOWER_7_JESSIE_JAMES_ON_LEFT
-    ow.runner:run({
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "show_object", "POKEMON_TOWER_7F", "POKEMONTOWER7F_JESSIE" },
-      { "show_object", "POKEMON_TOWER_7F", "POKEMONTOWER7F_JAMES" },
-      { "show_text", "_PokemonTowerJessieJamesText1" },
-      { "face_player_dir", "up" },
-      { "emote", "player", "shock", 30 },
-      -- Jessie (object 1) then James (object 2), Script1..Script6 order
-      { "walk_npc", 1, onLeft and { "down" } or { "down", "down", "down" } },
-      { "face_object", 1, onLeft and "right" or "down" },
-      { "walk_npc", 2, onLeft and { "down", "down", "down" } or { "down" } },
-      { "face_object", 2, onLeft and "down" or "left" },
-      { "show_text", "_PokemonTowerJessieJamesText2" },
-      { "start_battle", "trainer", "OPP_ROCKET", 44 },
-      { "check_battle_result", "win" },
-      { "jump_if_false", "end" },
-      { "show_text", "_PokemonTowerJessieJamesText3" },
-      { "show_text", "_PokemonTowerJessieJamesText4" },
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "fade", "out" },
-      { "hide_object", "POKEMON_TOWER_7F", "POKEMONTOWER7F_JESSIE" },
-      { "hide_object", "POKEMON_TOWER_7F", "POKEMONTOWER7F_JAMES" },
-      { "fade", "in" },
-      { "play_default_music" },
-      { "set_flag", "EVENT_BEAT_POKEMONTOWER_7_JESSIE_JAMES" },
-    }, {})
-    return true
-  end,
-}
-
--- -------------------------------------------------------------------
--- Silph Co 11F (SilphCo11FScript_6229c..Script14): the only site where
--- the duo starts VISIBLE (toggleable_objects.asm keeps SILPHCO11F_JAMES
--- / _JESSIE ON), flanking Giovanni at (2,8)/(3,8), so they are talkable
--- before the ambush (SilphCo11FJessieJamesText = the full motto).  The
--- trigger is the top row (y=3, x<4); EVENT_780/EVENT_781 pick one of
--- three approach paths (SilphCo11FMovementData_622f5..62311, $5=up
--- $6=left) that route James then Jessie up to the player without ever
--- crossing the player's tile.  Their duo text lives in
--- text/SilphCo10F.asm (_SilphCoJessieJamesText*).
--- -------------------------------------------------------------------
-
-M.SILPH_CO_11F = {
-  talk = {
-    TEXT_SILPHCO11F_JESSIE = {
-      { "face_player" }, { "show_text", "_SilphCoJessieJamesText1" },
-    },
-    TEXT_SILPHCO11F_JAMES = {
-      { "face_player" }, { "show_text", "_SilphCoJessieJamesText1" },
-    },
-  },
-
-  onStep = function(game, ow, x, y)
-    if baseSilph11Step and baseSilph11Step(game, ow, x, y) then
-      return true
-    end
-    local f = game.save.flags
-    if y ~= 3 or x > 3 then return false end
-    if f.EVENT_BEAT_SILPH_CO_11F_JESSIE_JAMES then return false end
-    -- x==3 -> base path, x==2 -> EVENT_780 variant, x<=1 -> EVENT_781
-    local jamesDirs, jamesFace, jessieDirs, jessieFace
-    if x == 3 then
-      jamesDirs, jamesFace = { "up", "up", "up", "up", "up" }, "right"
-      jessieDirs, jessieFace = { "up", "up", "up", "up" }, "up"
-    elseif x == 2 then
-      jamesDirs, jamesFace = { "up", "up", "up", "up" }, "up"
-      jessieDirs, jessieFace = { "up", "up", "up", "up", "up" }, "left"
-    else
-      jamesDirs = { "up", "up", "left", "up", "up" }
-      jamesFace = "up"
-      jessieDirs = { "up", "up", "up", "left", "up", "up" }
-      jessieFace = "left"
-    end
-    ow.runner:run({
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "show_text", "_SilphCoJessieJamesText1" },
-      { "face_player_dir", "down" },
-      { "emote", "player", "shock", 30 },
-      -- James (object 4) then Jessie (object 6), Script5..Script10 order
-      { "walk_npc", 4, jamesDirs },
-      { "face_object", 4, jamesFace },
-      { "walk_npc", 6, jessieDirs },
-      { "face_object", 6, jessieFace },
-      { "show_text", "_SilphCoJessieJamesText2" },
-      { "start_battle", "trainer", "OPP_ROCKET", 45 },
-      { "check_battle_result", "win" },
-      { "jump_if_false", "end" },
-      { "show_text", "_SilphCoJessieJamesText3" },
-      { "show_text", "_SilphCoJessieJamesText4" },
-      { "stop_music" },
-      { "play_music", "Music_MeetJessieJames" },
-      { "fade", "out" },
-      { "hide_object", "SILPH_CO_11F", "SILPHCO11F_JAMES" },
-      { "hide_object", "SILPH_CO_11F", "SILPHCO11F_JESSIE" },
-      { "fade", "in" },
-      { "play_default_music" },
-      { "set_flag", "EVENT_BEAT_SILPH_CO_11F_JESSIE_JAMES" },
-    }, {})
-    return true
-  end,
-}
-
-return M

data/scripts/yellow_viridian_old_man.lua

@@ -1,145 +0,0 @@
--- The Viridian City old-man catch tutorial, Yellow's way
--- (pokeyellow scripts/ViridianCity.asm, scripts/ViridianCity_2.asm,
---  scripts/OaksLab.asm).  Registered on top of the shared tables by
--- data/scripts/init.lua on a Yellow boot.
---
--- Yellow has TWO gambler objects where Red/Blue have one:
---   * VIRIDIANCITY_OLD_MAN    at (17,5) -- a Red/Blue leftover; its
---     toggle stays OFF forever in Yellow, no script ever shows it.
---   * VIRIDIANCITY_OLD_MAN2   at (18,9) -- replaces the sleeper the
---     moment the Pokédex is given (OaksLabOakGivesPokedexScript:
---     HideObject TOGGLE_LYING_OLD_MAN / ShowObject TOGGLE_OLD_MAN_2).
---
--- This is the tutorial old man.  The Red/Blue "Are you in a hurry?"
--- yes/no script must NOT run against him: Yellow's
--- _ViridianCityOldManHadMyCoffeeNowText is the apology speech ("I've had
--- my coffee now ... I'll show you how to catch POKéMON as my apology"),
--- and the shared story.lua TEXT_VIRIDIANCITY_OLD_MAN rows hang an
--- invented yes/no over it -- YES printed the TimeIsMoney alias
--- (_ViridianCityOldManLosingMyTouchText) and NO ran the demo, every
--- talk, forever (#617).
---
--- The real flow (ViridianCityCheckWaitingOldMan + ViridianCityOldMan2Text
--- + ViridianCityOldManInitialCatchTrainingScript + ...EndInitial... +
--- ViridianCityPostInitialCatchTraining): stepping into (19,9) -- the gap
--- east of the sleeper's cell -- faces the old man right and the player
--- left, prints the apology, and without any choice runs the demo battle
--- (BATTLE_TYPE_OLD_MAN, RATTATA lvl 5).  After it, the same text pointer
--- now prints _ViridianCityOldManLosingMyTouchText ("That didn't work!
--- I must be losing my touch."), the old man walks off (down 6 with the
--- player on (19,9), right 1 otherwise, Pikachu nudged out of the way
--- first) and TOGGLE_OLD_MAN_2 hides.  A direct talk does the same.
-
-local M = {}
-
-local OLD_MAN2 = "VIRIDIANCITY_OLD_MAN2"
-
--- Capture the FUNCTION, not the table: attachBase stores the module
--- table itself, so once this file's onStep is attached the table's slot
--- points back here -- delegating through the table would self-recurse.
--- story5's VIRIDIAN_CITY.onStep chains story.lua's sleeping-old-man
--- gate and its own gym-lock step (same pattern as yellow_jessie_james).
-local baseViridianStep = require("data.scripts.story5").VIRIDIAN_CITY.onStep
-
--- pokeyellow text/ViridianCity.asm, _ViridianCityOldManHadMyCoffeeNowText
--- and _ViridianCityOldManLosingMyTouchText, spelled with the extractor's
--- markers (line -> \n, cont -> \v, para -> \f)
-local function text(game)
-  return {
-    apology = game.data.text._ViridianCityOldManHadMyCoffeeNowText
-      or "Ahh, I've had my\ncoffee now and I\vfeel great!\fSure, you can go\n"
-      .. "through!\fI'm sorry I was\nso rude to you!\fI see you're using\n"
-      .. "a POKéDEX.\fI'll show you how\nto catch POKéMON\vas my apology.",
-    losingMyTouch = game.data.text._ViridianCityOldManLosingMyTouchText
-      or "That didn't work!\nI must be losing\vmy touch.\fI've run out of\n"
-      .. "POKé BALLs too.\fI have to get some\nat POKéMON MART.",
-  }
-end
-
--- The row list for the initial-tutorial branch, keyed by where the
--- player stands when the battle ends (ViridianCityPostInitialCatchTraining
--- reads wXCoord: (19,9) walks the old man down the corridor, anywhere
--- else walks him right 1 after moving the follower Pikachu aside).
-local function oldMan2Rows(game, ow, npc)
-  local rows = {
-    { "show_text", "_ViridianCityOldManHadMyCoffeeNowText" },
-    { "old_man_demo" },
-    { "set_flag", "EVENT_COMPLETED_CATCH_TRAINING" },
-    { "show_text", "_ViridianCityOldManLosingMyTouchText" },
-  }
-  if ow.player and ow.player.cellX == 19 then
-    rows[#rows + 1] =
-      { "walk_npc", npc.def.index,
-        { "down", "down", "down", "down", "down", "down" } }
-  else
-    -- ViridianCityMovePikachu (scripts/ViridianCity_2.asm): Pikachu
-    -- steps out of the old man's way before he turns right
-    local PikachuFollower = require("src.world.PikachuFollower")
-    local pika = ow and PikachuFollower.current(ow)
-    if pika then
-      rows[#rows + 1] = { "walk_npc", pika.def.index, { "right" } }
-    end
-    rows[#rows + 1] = { "walk_npc", npc.def.index, { "right" } }
-  end
-  rows[#rows + 1] =
-    { "hide_object", "VIRIDIAN_CITY", OLD_MAN2 }
-  return rows
-end
-
--- The shared talk handler: TEXT_VIRIDIANCITY_OLD_MAN2's text_asm branch
--- (ViridianCityOldMan2Text) on EVENT_COMPLETED_CATCH_TRAINING.
-local function oldMan2Talk(game, ow, npc, done)
-  if game.save.flags and game.save.flags.EVENT_COMPLETED_CATCH_TRAINING then
-    local TextBox = require("src.render.TextBox")
-    game.stack:push(TextBox.new(game, text(game).losingMyTouch, done))
-    return
-  end
-  ow.runner:run(oldMan2Rows(game, ow, npc), { npc = npc, onDone = done })
-end
-
-M.VIRIDIAN_CITY = {
-  talk = {
-    TEXT_VIRIDIANCITY_OLD_MAN2 = oldMan2Talk,
-  },
-
-  -- Re-apply the Pokédex swap for a save that already holds the flag but
-  -- was never standing here when it fired (converted .sav imports, same
-  -- shape as story.lua's VIRIDIAN_CITY.onEnter).  Yellow shows OLD_MAN2,
-  -- not the Red/Blue OLD_MAN at (17,5), and also puts away a stray
-  -- OLD_MAN a save made by the pre-#617 build left standing.
-  onEnter = function(game, ow)
-    if not (game.save.flags and game.save.flags.EVENT_GOT_POKEDEX) then
-      return
-    end
-    local Commands = require("src.script.Commands")
-    local ctx = { save = game.save, game = game, overworld = ow }
-    Commands.hide_object(ctx, "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN_SLEEPY")
-    Commands.hide_object(ctx, "VIRIDIAN_CITY", "VIRIDIANCITY_OLD_MAN")
-    Commands.show_object(ctx, "VIRIDIAN_CITY", OLD_MAN2)
-  end,
-
-  -- ViridianCityCheckWaitingOldMan: with the Pokédex held and the
-  -- tutorial undone, (19,9) -- the gap east of the old man, the same
-  -- cell the sleeper used to gate -- faces him right, turns the player
-  -- left and starts the OLD_MAN2 flow with no choice.
-  onStep = function(game, ow, x, y)
-    if baseViridianStep and baseViridianStep(game, ow, x, y) then
-      return true
-    end
-    local flags = game.save.flags
-    if not flags.EVENT_GOT_POKEDEX then return false end
-    if flags.EVENT_COMPLETED_CATCH_TRAINING then return false end
-    if x ~= 19 or y ~= 9 then return false end
-    local man
-    for _, npc in ipairs(ow.npcs) do
-      if npc.def and npc.def.name == OLD_MAN2 then man = npc break end
-    end
-    if not man then return false end
-    man.facing = "right"
-    ow.player.facing = "left"
-    oldMan2Talk(game, ow, man, nil)
-    return true
-  end,
-}
-
-return M

docs/anbernic-rg34xxsp.md

@@ -1,98 +0,0 @@
-# Anbernic RG34XXSP (Stock OS 64-bit MOD)
-
-Download `gen1recomp-*-rg34xxsp-stockos64-mod.zip` from
-[Releases](https://github.com/bryanthaboi/gen1recomp/releases). This build
-targets **Stock OS 64-bit MOD** on the RG34XXSP with PortMaster installed
-(TF1).
-
-## Install
-
-1. Unzip the release on your computer. You get `Gen1recomp.sh` and a
-   `gen1recomp/` folder.
-2. Copy **both** onto the SD card under **`Roms/PORTS/`** so the layout is:
-
-   ```
-   Roms/PORTS/Gen1recomp.sh
-   Roms/PORTS/gen1recomp/
-   ```
-
-   On the device that path is `/mnt/mmc/Roms/PORTS/`. Keep the launcher and
-   the `gen1recomp/` folder as siblings — do not nest the `.sh` inside the
-   folder.
-3. Put your legal US Red and/or Blue `.gb` files inside the game folder:
-
-   ```
-   Roms/PORTS/gen1recomp/lovegame/
-   ```
-
-   Example: `Roms/PORTS/gen1recomp/lovegame/Pokemon - Red Version.gb`
-4. Eject the card, boot the handheld, open **Ports → Gen1recomp**.
-5. On the launcher, move the cursor with the D-pad or left stick, press **A**
-   to click. Choose the Red or Blue tab, then **Choose ROM** — with no file
-   picker on stock OS, that scans `lovegame/` for the `.gb` you dropped in.
-
-The port ships with `portable.txt` already in place, so after import the
-saves and ROM-derived cache stay next to the game on the SD card. See
-[Portable Mode](../README.md#portable-mode) for what that means.
-
-Only the canonical 1 MiB US carts import:
-
-- Red: `ea9bcae617fdf159b045185467ae58b2e4a48b9a`
-- Blue: `d7037c83e1ae5b39bde3c30787637ba1d4c48ce2`
-
-## Launcher controls
-
-| Input              | Action             |
-| ------------------ | ------------------ |
-| D-pad / left stick | Move cursor        |
-| A                  | Click              |
-| L1 / R1            | Switch tabs        |
-| Right stick        | Scroll lists       |
-| Start / Select     | Play or Choose ROM |
-
-In-game controls use the normal PortMaster / SDL pad map, rebindable under
-**OPTIONS → CONTROLS**.
-
-## Notes
-
-**GBC FX is off on this device.** The launcher exports `POKEPORT_GBCFX=0`,
-which hides the GBC FX row from OPTIONS, pins the level to OFF, and clears a
-level carried over in an `options.lua` from another machine. The H700's Mali
-GPU is in the same class as the phone GPUs that compile that present pass and
-then show a black frame (issue #136), and `love.system.getOS()` reports
-`"Linux"` here, so the Android gate would not have caught it. Every other
-display option — COLORS, TILT, ZOOM, VOID FILL, MAX FPS — works normally. If
-your device turns out to handle the pass, launch with `POKEPORT_GBCFX=1` to
-put the row back.
-
-**PERFORMANCE defaults to LOW here.** The OPTIONS → PERFORMANCE tier defaults
-to AUTO, which reads this device as an ARM Linux handheld and resolves to
-**LOW**: the 3D tilt and survey zoom stay off and the frame rate is capped,
-so the overworld runs smoothly on the H700 out of the box. Bump it to
-BALANCED or HIGH from OPTIONS if you want the extras and your device keeps
-up; see [Performance tier](new-features.md#performance-tier-low-end-devices).
-
-The pack bundles the LÖVE 11.5 aarch64 runtime from
-[PortMaster](https://portmaster.games/), so the device does not need a
-separate `love_11.5` runtime download on first launch. The launcher resolves
-paths relative to its own directory rather than PortMaster's `$directory`,
-because stock Anbernic firmware runs ports out of `roms/PORTS/` with its own
-casing and mount points.
-
-If a launch fails, `Roms/PORTS/gen1recomp/log.txt` holds the output of the
-last run.
-
-## Building the port
-
-Release runs build this automatically (see `.github/workflows/release.yml`).
-To build it by hand:
-
-```sh
-./build-rg34xxsp.sh --version 0.1.0   # -> dist/rg34xxsp/gen1recomp-rg34xxsp-stockos64-mod.zip
-```
-
-`install-rg34xxsp.sh` copies that pack straight onto a mounted SD card for
-local testing.
-
-Stock OS 64-bit MOD comes from
-[cbepx-me](https://github.com/cbepx-me/Anbernic-H700-RG-xx-StockOS-Modification).

docs/architecture.md

@@ -59,7 +59,7 @@ the same core data and graphics into the source tree for verification.
 | | `src/battle/Experience.lua`, `Catching.lua`, `TrainerAI.lua` | exp/levels, Gen 1 catch algorithm, AI |
 | | `src/battle/rulesets/` | `gen1_faithful` (default) vs `modern_clean` |
 | ui | `src/ui/*` | start menu, generic menu, yes/no box, party/bag lists |
-| | `tools/save-editor/` | Save editor: shipped in every build, opened from the launcher's Edit button or standalone with `love . --editor` |
+| | `tools/save-editor/` | Standalone save editor (`love . --editor`) |
 
 ## Map scripts
 

docs/blue-version.md

@@ -0,0 +1,131 @@
+# Building a Blue Version of the port
+
+pokered builds Red and Blue from one source tree: the Makefile
+assembles everything twice with `rgbasm -D _RED` or `-D _BLUE`, and
+every in-game difference sits in an `IF DEF(_RED)` / `IF DEF(_BLUE)`
+block. Our extraction pipeline resolves those conditionals the same
+way (`tools/extract/util.py` `ASM_DEFINES`), so most of a Blue build
+falls out of re-running the extractors. Only three things are
+hand-ported on the Lua side and need swapping by hand.
+
+## What differs between Red and Blue
+
+| Where (pokered) | What |
+| --- | --- |
+| `data/wild/maps/*.asm` (34 files) | Version-exclusive encounters (Red: Ekans, Oddish, Growlithe, Mankey, Scyther, Electabuzz,  Blue: Sandshrew, Bellsprout, Vulpix, Meowth, Pinsir, Magmar) |
+| `data/pokemon/title_mons.asm` | The 16 title-screen Pokémon |
+| `engine/movie/title.asm` + `gfx/version.asm` | The "Red Version" / "Blue Version" ribbon |
+| `constants/player_constants.asm` | Preset names (Red: RED/ASH/JACK + BLUE/GARY/JOHN) |
+| `data/sgb/sgb_palettes.asm`, `sgb_border.asm` | Super Game Boy palettes and border |
+| `data/events/prizes.asm`, `prize_mon_levels.asm` | Game Corner prize mons, costs and levels |
+| `engine/movie/intro.asm`, `data/credits/credits_text.asm`, `engine/slots/slot_machine.asm`, `engine/battle/animations.asm`, `audio/sfx/save_3.asm` | Small gated tweaks (credits say "BLUE VERSION STAFF", etc.) |
+
+## Step 1,  flip the extraction define
+
+`tools/extract/util.py`:
+
+```python
+ASM_DEFINES = {"_RED"}   # -> {"_BLUE"}
+```
+
+Then regenerate everything (same as scripts/setup.sh does):
+
+```sh
+cd tools
+../.venv/bin/python3 build_data.py \
+    --pokered /Users/bryanbassett/Documents/development/pokered \
+    --out ../data/generated --assets ../assets/generated
+```
+
+This alone switches the wild encounters, preset names, SGB palettes
+and credits text. **Caveat:** `parse_preset_names` sanity-checks in
+`tools/extract/field.py:1193` expect "RED" in the player presets, 
+relax that check for a Blue build (Blue's presets are BLUE/GARY/JOHN
+for the player and RED/ASH/JACK for the rival).
+
+`tools/extract/palettes.py` uses its own raw reader with hardcoded
+`IF DEF(_BLUE)` skipping (around line 44),  invert that too, or port
+it to `read_asm` so `ASM_DEFINES` covers it.
+
+## Step 2,  title screen (hand-ported)
+
+`src/ui/TitleState.lua`:
+
+1. **Ribbon art.** The extractor writes
+   `assets/generated/title/red_version.png`; add `blue_version.png`
+   to `gfx.extract_title` in `tools/extract/gfx.py` (source:
+   `gfx/title/blue_version.png`, 64×8). In `TitleState:draw()`, the
+   Red strip needs two quads (tiles 0–1 "Red", skip, tiles 5–9
+   "Version",  `title.asm` `VersionOnTitleScreenText`). Blue's strip
+   prints its tiles contiguously (`db $61..$68`), so draw the whole
+   64×8 image at px (56, 64) and verify with the title driver
+   screenshot.
+
+2. **Title mons.** Replace `CYCLE_SPECIES` with Blue's list from
+   `data/pokemon/title_mons.asm`:
+
+   ```lua
+   local CYCLE_SPECIES = {
+     "SQUIRTLE", "CHARMANDER", "BULBASAUR", "MANKEY", "HITMONLEE",
+     "VULPIX", "CHANSEY", "AERODACTYL", "JOLTEON", "SNORLAX",
+     "GLOOM", "POLIWAG", "DODUO", "PORYGON", "GENGAR", "RAICHU",
+   }
+   ```
+
+## Step 3,  Game Corner prizes (hand-ported)
+
+`data/scripts/story3.lua` (~line 209) carries the Red prize tables.
+Blue's values (`prizes.asm` + `prize_mon_levels.asm`):
+
+| Prize | Cost | Level |
+| --- | --- | --- |
+| ABRA | 120 | 6 |
+| CLEFAIRY | 750 | 12 |
+| NIDORINO | 1200 | 17 |
+| PINSIR | 2500 | 20 |
+| DRATINI | 4600 | 24 |
+| PORYGON | 6500 | 18 |
+
+(TM prizes are identical in both versions.)
+
+## Step 4,  verify
+
+```sh
+luajit tests/run_tests.lua
+```
+
+Plus two spot checks:
+
+```sh
+# every grass table must have exactly 10 slots (a conditional-parsing
+# regression shows up as 19–20 slots)
+luajit -e 'local e=dofile("data/generated/encounters.lua")
+for m,d in pairs(e) do if type(d)=="table" and d.grass and #d.grass.slots>0
+  and #d.grass.slots~=10 then print("BAD",m,#d.grass.slots) end end'
+
+# a Blue exclusive should now appear (and Growlithe should not)
+grep -c VULPIX data/generated/encounters.lua
+grep -c GROWLITHE data/generated/encounters.lua
+```
+
+Title screenshot: run the driver in
+`tests/drivers/` style (`SHOT_DIR=... POKEPORT_DRIVER=... love .`) and
+eyeball the ribbon, title mon, and copyright row.
+
+## What you get for free / what to skip
+
+- Free after re-extraction: encounters (incl. Super Rod groups), SGB
+  palettes, preset names, credits text, the gated sfx/animation
+  tweaks.
+- Trades, gift Pokémon, story scripts, gym data: identical in Western
+  Red/Blue,  nothing to touch.
+- Save files: a Red save loads fine, but dex AREA nests and new
+  encounters will be Blue's. Trainer parties are identical.
+
+## Making it a runtime toggle instead
+
+If you want one build with both versions, extraction would need to
+emit both branches keyed by version (e.g. `slots` / `slotsBlue`) and
+the three hand-ported spots would read a `save.version` or
+`conf.lua` flag. That is a bigger change than the rebuild above, 
+the flip-and-regenerate route needs no engine changes at all.

docs/gameboy-hardware-limitations.md

@@ -12,7 +12,7 @@ this port.
 
 | # | Mechanic | Value | Why the Game Boy had this limit | Where it lives here |
 |---|---|---|---|---|
-| 1 | Bag capacity | 20 item slots by default | `wNumBagItems` save block was a fixed 20-entry id/quantity array in SRAM | `Data.constants.bagSize`, read by `src/inventory/Bag.lua` (`Bag.capacity`) |
+| 1 | Bag capacity | 20 item slots | `wNumBagItems` save block was a fixed 20-entry id/quantity array in SRAM | `src/inventory/Bag.lua:8` (`Bag.CAPACITY = 20`) |
 | 2 | Party size | 6 Pokémon | `wPartyMon1..6` were 6 fixed save-RAM slots | `src/pokemon/Party.lua:5` (`Party.MAX = 6`) |
 | 3 | PC storage | 12 boxes × 20 Pokémon | `wBoxDataStart` / Bill's PC allocated a fixed 12×20 SRAM block | `src/pokemon/Boxes.lua:7-8` |
 | 4 | Moves per Pokémon | 4 | Fixed 4-move-slot field in the party/box Pokémon struct | `src/pokemon/Pokemon.lua:20`, enforced again in `src/battle/BattleState.lua:1941` |
@@ -38,10 +38,6 @@ this port.
 
 ## Notes
 
-- Mods may patch `constants.bagSize` through the public content registry. The
-  native `save.lua` format keeps every existing item when the configured
-  limit changes; exporting to a cartridge `.sav` still writes only the first
-  20 bag slots because the original SRAM layout has no room for more.
 - PC Box **overflow handling** was deliberately changed even though the
   20×12 box *shape* was kept faithful: instead of Gen 1's "full box discards
   or blocks the deposit," this port spills into the next box with room.

docs/ios-install.md

@@ -1,116 +0,0 @@
-# Build & install on your iPhone — step by step
-
-Don't want to install Xcode? Download the release IPA and sideload it with
-AltStore instead — see [ios-sideload.md](ios-sideload.md).
-
-This guide assumes **zero** programming experience. Follow it top to
-bottom and you'll have the game running on your own iPhone in roughly an
-hour (most of it is waiting for downloads).
-
-## What you need
-
-- A **Mac** (any Apple-silicon or recent Intel Mac on macOS 14 or newer)
-- An **iPhone** and its **charging cable**
-- A free **Apple ID** (the same account you use for the App Store)
-- Your **own, legally obtained** Pokémon Red or Blue ROM file (a 1 MB
-  `.gb` file). This project ships no game data — the app rebuilds
-  everything from *your* cartridge dump and verifies it before use.
-- About **15 GB free disk space** (Xcode is enormous; the game itself is
-  tiny)
-
-> **Free vs. paid Apple account:** a free Apple ID works. The only catch:
-> apps signed with a free account stop launching after **7 days** — just
-> re-run the install command (step 5) to re-sign; your save data is kept.
-> A paid Apple Developer account ($99/yr) extends that to a year.
-
----
-
-## Step 1 — Install Xcode (once)
-
-1. On the Mac, open the **App Store**, search **Xcode**, click **Get**.
-   It's a ~10 GB download — go make tea.
-2. Open Xcode once. Accept the license. If it offers to install extra
-   components or the **iOS platform**, say yes and let it finish.
-
-## Step 2 — Sign Xcode into your Apple ID (once)
-
-1. In Xcode's menu bar: **Xcode → Settings → Accounts**.
-2. Click the **+** in the bottom-left → **Apple Account** → sign in.
-3. Close the window. (This quietly creates the "signing certificate" the
-   build uses — you never have to touch it again.)
-
-## Step 3 — Get this project onto the Mac
-
-If you received it as a folder, put it somewhere easy like your home
-folder. If it's on GitHub, click the green **Code** button → **Download
-ZIP**, then double-click the zip to unpack it.
-
-## Step 4 — Build it (one command)
-
-1. Open the **Terminal** app (press ⌘-space, type `terminal`, press
-   return).
-2. Type `cd ` (c, d, space — don't press return yet), then **drag the
-   project folder** from Finder onto the Terminal window — it fills in
-   the path — and press **return**.
-3. Paste this and press return:
-
-   ```sh
-   scripts/build_ios.sh --fetch
-   ```
-
-   The first run downloads the LÖVE engine and compiles everything
-   (5–15 minutes). Lines of build output scrolling by is normal. You're
-   done when you see **`==> done`**.
-
-## Step 5 — Put it on your iPhone
-
-1. Plug the iPhone into the Mac with the cable. **Unlock it** and keep it
-   unlocked. If it asks **"Trust This Computer?" → Trust**.
-2. Paste this and press return:
-
-   ```sh
-   scripts/build_ios.sh --device --install
-   ```
-
-   The script finds your signing identity and your phone by itself. If it
-   complains, it tells you exactly what to fix (usually: the phone was
-   locked — unlock and re-run).
-
-3. First time only, the iPhone will want two approvals:
-   - **Developer Mode**: Settings → **Privacy & Security** → scroll to
-     **Developer Mode** → turn on → restart the phone → confirm.
-   - **Trust the developer**: Settings → **General** → **VPN & Device
-     Management** → tap the entry under *Developer App* → **Trust**.
-
-   Then re-run the command in step 5.2 if the install had failed.
-
-## Step 6 — Give it your ROM and play
-
-1. Get your `.gb` file onto the phone — AirDrop it to yourself, or save
-   it in iCloud Drive / Files.
-2. Open the app. On the **RED** tab, tap **Import ROM** and pick your
-   `.gb` file in the file browser that appears. (Alternative: in the
-   **Files** app, drop the `.gb` into **On My iPhone → the game's
-   folder** and just reopen the app — it imports automatically.)
-3. Import takes ~10 seconds, the button turns into **Play Red** — tap it.
-
-## Optional goodies
-
-- **Mods**: launcher → **MODS** tab → **Import mod .zip**.
-- **Save import/export**: buttons on each game's tab, using the normal
-  iOS file picker.
-
-## When things go wrong
-
-| Symptom | Fix |
-|---|---|
-| `xcodebuild not found` | Xcode isn't installed or wasn't opened once — do Step 1 |
-| `no Apple signing identity found` | Do Step 2, then re-run |
-| `no iPhone/iPad found` | Cable in? Phone unlocked? Tapped "Trust"? |
-| Install fails with "locked" | Unlock the phone, keep it unlocked, re-run |
-| App icon appears then won't open | Do the two approvals in Step 5.3 |
-| App stops launching after a week | Free-account 7-day limit — re-run Step 5.2 |
-| "That ROM could not be imported" | The file isn't a canonical 1 MB US Red/Blue dump — the importer checks its fingerprint |
-
-Every build/install command is safe to re-run; your saves live on the
-phone and survive reinstalls.

docs/ios-sideload.md

@@ -1,48 +0,0 @@
-# Sideload the iOS build with AltStore
-
-Every GitHub Release ships an IPA (`gen1recomp-*-ios.ipa`). Install it on
-your iPhone or iPad with [AltStore Classic](https://altstore.io/) — AltStore
-re-signs the app with **your** free Apple ID so you do not need a Mac or
-Xcode.
-
-## 1. Install AltStore
-
-Follow the official guide for your computer:
-
-- [How to Install (Windows)](https://faq.altstore.io/altstore-classic/how-to-install-altstore-windows)
-- [How to Install (macOS)](https://faq.altstore.io/altstore-classic/how-to-install-altstore-macos)
-
-You will install **AltServer** on the computer, then use it to put AltStore
-on the phone. What AltServer is and why it needs to stay running:
-
-- [AltServer](https://faq.altstore.io/altstore-classic/altserver)
-
-Stuck? Start here:
-
-- [Troubleshooting Guide](https://faq.altstore.io/altstore-classic/troubleshooting-guide)
-
-## 2. Install the game
-
-1. Download `gen1recomp-*-ios.ipa` from
-   [Releases](https://github.com/bryanthaboi/gen1recomp/releases).
-2. Open **AltStore** on the phone (AltServer must be running on the same
-   Wi‑Fi, or keep the phone plugged into the computer).
-3. Tap **My Apps → +** (or share the IPA into AltStore) and pick the file.
-4. Sign in with your Apple ID when prompted. Wait for the install to finish.
-5. On first launch: Settings → **Privacy & Security → Developer Mode** (iOS
-   16+), and Settings → **General → VPN & Device Management** → Trust your
-   Apple ID if asked.
-
-Then open the app, import your own legal `.gb` ROM on the Red/Blue tab, and
-play.
-
-## Refresh / 7-day limit
-
-With a free Apple ID, sideloaded apps stop launching after **7 days**. Keep
-AltServer running so AltStore can refresh them, or open AltStore and refresh
-manually before they expire. Saves on the phone are kept across refreshes.
-
-## Prefer building it yourself?
-
-Building from source on a Mac (no AltStore) is covered in
-[ios-install.md](ios-install.md).

docs/launcher.md

@@ -1,265 +0,0 @@
-# Launcher
-
-The launcher is `src/import/RomImporter.lua`, the first-run / title screen
-that runs before `Game:load`. Besides ROM import (see the file's own header)
-it hosts a tabbed shell covering per-game save slots and a mod manager. This
-file documents the runtime model; the visual spec lives separately.
-
-## Android multi-ROM / mod / save import
-
-On Android, `love.system.pickFile([kind])` opens the Storage Access Framework
-picker (`GameActivity.showFilePicker`); the chosen file is copied into the app
-save directory as:
-
-| `kind` | Destination |
-| --- | --- |
-| nil / `"rom"` | `picked_rom.gb` (open) |
-| `"mod"` | `picked_mod.zip` (open) |
-| `"sav"` / `"save"` | `picked_save.sav` (open) |
-
-Export uses a separate API: `love.system.createFile(suggestedName)` →
-`GameActivity.showCreateDocument` (`ACTION_CREATE_DOCUMENT`), which copies
-staged `pending_export.sav` to the user-chosen URI and writes `export_done.flag`
-for the launcher to acknowledge on refocus.
-
-`RomImporter` then imports on refocus / Choose:
-
-- **ROMs** via `findPendingRom`: only a 1 MiB `.gb` whose SHA-1 maps to a
-  version that is **not** yet ready counts as pending. A leftover
-  `picked_rom.gb` from Red therefore cannot block Blue's Choose (issue #167).
-- **Mods** via `findPendingMod`: Prefer `picked_mod.zip`, or (on Choose) any
-  other `.zip` at the save-dir root (USB copy).
-- **Saves** via `findPendingSav`: Prefer `picked_save.sav`, or (on Choose) any
-  other `.sav` at the save-dir root.
-
-After a successful import the consumed save-dir file is removed.
-
-**Manual check (device/emulator):** import Red → switch to Blue → Choose →
-system file picker must appear (not a silent Red re-extract) → pick Blue →
-Blue becomes ready beside Red. On the MODS tab, Import mod .zip must open the
-same system picker and install the chosen archive on return.
-
-## Tab structure
-
-`self.tab` is one of `"red"`, `"blue"`, `"yellow"`, `"mods"`. The tab bar
-draws one chip per game plus a MODS chip and rebuilds `self.tabRects` every
-frame so `mousepressed` can dispatch clicks; switching tabs mid-import is
-allowed (a dropped ROM still routes by SHA-1 regardless of which tab shows).
-
-- A game tab (`_drawGamePanel`) shows the ROM card, the SAVE FILES card, the
-  Play button, and the SAVE SLOT card in a responsive two-column grid (see
-  Responsiveness). The MODS tab (`_drawModsPanel`) shows the mod list instead.
-- The self-updater banner (`self.Check`, see `docs/updater.md`) draws as a
-  centered pill in a reserved band just above the footer, on every tab. That
-  position is unchanged by this redesign, so `docs/updater.md` needed no edits.
-
-## Save slot model
-
-All slot I/O lives in `src/core/SaveData.lua` and goes through the same fs
-abstraction (`persistFs`) every other save/options call uses, so portable
-mode (an `io.*` filesystem used when `portable.txt` marks the install)
-keeps working unchanged.
-
-- **Files.** A version's playthroughs live under `saves/<version>/`, one file
-  per slot: `saves/<version>/slot1.lua` plus a rolling `.bak` and staged
-  `.tmp` witness (`slotNames`), mirroring the write/recovery discipline
-  `SaveData.save`/`load` already use for the flat legacy file. Slot ids match
-  `slot%d+`; `createSlot` allocates one past the highest existing number so a
-  reused id can never collide with a lingering file.
-- **Registry.** The ordered slot list and which one is active persist in
-  `options.lua` (via the existing `SaveData.loadOptions`/`saveOptions`):
-  `options.saveSlots = { [version] = { list = {"slot1", ...}, active = "slot1" } }`.
-  Custom slot labels (#205) live alongside them in the same registry:
-  `options.saveSlots[version].names = { slot1 = "Nuzlocke" }`, written by
-  `SaveData.renameSlot` (trimmed; an empty label clears it) and surfaced on
-  each `listSlots` row as `label` (the launcher row shows `label`, falling
-  back to the player name). `deleteSlot` drops the label with the slot.
-  Renaming never touches the save file, so an empty slot can be labeled.
-  On desktop, right-clicking a slot row opens the inline rename modal
-  (Enter commits, Esc cancels); touch has no secondary button, so the
-  affordance is desktop-only.
-- **Active slot resolution.** `saveNames(version)`, the function every
-  existing caller (`TitleState` hasSave/load/save, recovery order) already
-  goes through, now resolves the *active* slot instead of a fixed flat name.
-  Resolved once per version per process (`ensureVersionSlots`, cached in
-  `activeSlotCache`/`slotsChecked`): a registry entry wins; otherwise a lazy
-  legacy migration may create one; otherwise the flat legacy path is used
-  (`save.lua` / `save_blue.lua`), so a pre-slots install keeps working as before.
-- **Legacy migration.** One-time per version, lazy on first
-  `listSlots`/`load`/`saveNames` call (`tryMigrateLegacy`): if a flat legacy
-  file exists and no `saves/<version>/` registry does, its main + `.bak` are
-  copied into `saves/<version>/slot1.lua(.bak)`, verified readable
-  (`decodeSlot`: main, then `.tmp`, then `.bak`), and only then are the
-  originals removed and `slot1` registered as active. A copy that fails to
-  verify leaves the originals in place; migration never loses data.
-
-The launcher-facing API:
-- `SaveData.listSlots(version)` -> array of `{id, exists, name, meta}` for
-  every registered slot. `name` is the save's player name, or `nil` for an
-  empty slot; `meta` is `{badges, timeText, dexCount}` (the same fields the
-  title screen's `ContinueInfo` shows) or `nil`. The pure part,
-  `SaveData.slotSummary(save)`, is unit-testable with no filesystem.
-- `SaveData.setActiveSlot(version, slotId)` registers the id if new, persists
-  it as active, and updates the process cache so the very next save/load
-  lands there. The launcher calls this the moment a slot row is clicked
-  (`RomImporter:_selectSlot`); pressing Play needs no signature change, since
-  `Game.lua`/`main.lua` still just call `SaveData.load()`/`save()`.
-- `SaveData.createSlot(version)` -> new slot id, registered but with **no
-  save file written**. An empty slot means the title screen offers NEW GAME
-  only, which needs no further changes.
-- `SaveData.deleteSlot(version, slotId)` removes the slot's
-  main/`.bak`/`.tmp` files, drops it from the registry, and if it was active
-  points active at another remaining slot (or clears active when the list is
-  empty). The launcher's SAVE SLOT panel Delete control calls this.
-
-## Launcher mod manager
-
-`src/mods/LauncherMods.lua` is a launcher-only read of the mod set. It runs
-before `Game:load`, so **it never loads a mod's entry chunk**; only
-`manifest.json` is read and validated (`src/mods/Manifest.validate`), the way
-`Loader:_discover` finds mods without running them. The real loader
-(`src/mods/Loader.lua`) still owns the actual load at boot.
-
-- `LauncherMods.list()` scans `mods/` one level deep (first id wins on a
-  duplicate) and returns one row per mod:
-  `{id, name, version, badge, description, enabled, status, statusDetail}`.
-  `badge` is the manifest's `category`, falling back to `profile`, then
-  `"MOD"`, uppercased. `enabled` reads `options.mods[id]` (missing means
-  enabled, matching the loader's own default).
-- `status` is `"ok"`, `"warn"`, or `"conflict"`, computed by the pure
-  `LauncherMods.deriveList`/`statusFor` against `ManagerState.resolveToggle`
-  and the validated manifests: `conflict` when enabling this mod collides
-  with another enabled one; `warn` for an out-of-range `game_version` or an
-  absent/disabled/wrong-version hard dependency; `ok` otherwise. Having no
-  `love.*` calls, this half is table-driven by the test suite on its own.
-- `LauncherMods.setEnabled(id, bool)` persists `options.mods[id]` as a plain
-  boolean, the exact shape `Loader:_saveState` writes, so the running game
-  and the in-game `ManagerState` see the change on next boot. The mods panel
-  calls this on every toggle and re-derives the list right away
-  (`RomImporter:_refreshMods`) so a status change (e.g. a new conflict)
-  shows without waiting for a reload.
-- `LauncherMods.installZip(path)` mounts the archive with
-  `love.filesystem.mount`, locates the mod root via `locateRoot` (manifest at
-  the zip root, or inside one top-level folder), validates its manifest, and
-  copies the tree into the save-dir `mods/<id>/` before unmounting. Rejects a
-  duplicate of an already-installed mod id, and accepts either an external
-  path string or a LOVE `DroppedFile`, staging a dropped file into a save-dir
-  temp first (mount only reaches save-dir-relative paths), the same way
-  `RomImporter` handles a dropped ROM. A failed copy rolls its partial tree
-  back, and every path unmounts and clears the staged temp file.
-- `LauncherMods.uninstall(id)` removes `mods/<id>/` and clears
-  `options.mods[id]` so a later reinstall starts from the loader's default
-  (enabled). The mods panel Delete control calls this and re-derives the list.
-
-## Import / Export save
-
-The SAVE FILES card wires a raw Gen1 `.sav` battery image to the save slots
-through `src/import/SaveFileIO.lua`, which sits on top of
-`src/save_convert/SaveConvert.lua` and the slot API in `SaveData`.
-
-- **Import save** is live once the game's ROM is imported (playable). It opens
-  a native `.sav` picker (`chooseSav` on desktop; on Android,
-  `love.system.pickFile("sav")` → `picked_save.sav`, same SAF path as ROMs).
-  `SaveFileIO.importToSlot` reads the bytes (an absolute path, a save-dir
-  relative name, a dropped LOVE file, or raw bytes),
-  guards the 32768-byte size, runs `SaveConvert.importSav` (which also rejects
-  a bad main-data checksum), then registers a fresh slot (`SaveData.createSlot`),
-  writes it (`SaveData.writeSlot`), and makes it active (`SaveData.setActiveSlot`).
-  The meta stamp is re-stamped off `gen1_import` to the current numeric format
-  so `SaveData.load`'s migration pass accepts the slot. On success the SAVE SLOT
-  panel is refreshed with the new slot selected.
-- **Export save** is live only when the active slot actually holds a save
-  (checked against `listSlots`). `SaveFileIO.exportActiveSlot` loads the active
-  slot, encodes it back with `SaveConvert.exportSav` (a slot never keeps
-  `rawImport`, so this is a zero-filled template export, which is valid), and
-  writes `exports/gen1recomp-<version>-<slotId>.sav` in the save directory
-  (`love.filesystem.createDirectory("exports")`). On desktop it returns the
-  absolute path (`love.filesystem.getSaveDirectory()`), which the notice line
-  shows with an "Open folder" affordance (`love.system.openURL("file://" .. dir)`).
-  On Android the bytes are also staged as `pending_export.sav` and
-  `love.system.createFile(suggestedName)` opens `ACTION_CREATE_DOCUMENT` so the
-  player can save to Downloads / Drive / etc.; on return `export_done.flag`
-  makes focus show "Save exported."
-- **Drag-drop.** `filedropped` routes a `.sav` to the import path for the
-  currently active game tab; when a non-game tab (mods, or the locked yellow
-  placeholder) is showing it defaults to red, the always-present first game
-  (`_savedropTarget`). `.gb` (ROM) and `.zip` (mod) routing is unchanged.
-- **Failure UX.** Every error path (wrong size, bad checksum, write failure,
-  nothing to export, ROM not imported yet) surfaces as a red notice line on the
-  card. Nothing raises and nothing silently no-ops.
-
-`SaveFileIO` is love-free enough to unit-test through the same in-memory
-filesystem stub the slot backend uses (`tests/engine/save_file_io_tests.lua`).
-
-## Responsiveness
-
-Every measurement derives from `love.graphics.getDimensions()` each frame
-plus the existing global scale `s = clamp(height / 768, 0.7, 1.6)`; nothing
-assumes a fixed window size. The game panel's two-column grid (ROM/SAVE
-FILES/Play on the left, SAVE SLOT on the right) collapses to one stacked
-column, slot card below Play, when the window is too narrow for both
-`~300 * s`-wide columns. The save-slot list and the mod list both scroll
-(wheel, or drag on touch/desktop) clamped to their own content extent,
-recomputed every draw. The tab bar labels only the active chip so it stays
-narrow-safe, and content caps out at `~1440 * s` wide, centered.
-
-The desktop window has a floor of 480x360 (`conf.lua` `minwidth`/`minheight`),
-under which the cards stop being readable at all. Mobile ignores it: those
-windows are fullscreen.
-
-### Page scroll
-
-Two columns fit any window the launcher is likely to open in; one stacked
-column does not. On a phone-shaped window the ROM card, SAVE FILES, Play and
-SAVE SLOT together run past the bottom, and a footer pinned to the window
-bottom painted over them with the overflow unreachable.
-
-So the whole column under the tab bar -- panel, updater banner, footer --
-scrolls as one page whenever it is taller than the room below the tab bar:
-
-- The strip, logo and tab bar stay pinned, so navigation is always on screen.
-  Everything else draws at `contentTop - pageScroll` inside a scissor, and the
-  footer is laid out downward from `footerTop` right after the content instead
-  of upward from the window bottom.
-- `RomImporter.pageScrollFor(naturalH, viewportH, scroll)` is the whole
-  decision, pure and pinned by `tests/engine/launcher_page_scroll.lua`. A
-  window that grows back drags the offset down with it, so the page can never
-  stay parked past its own end.
-- The panels report their natural height as they draw (`_drawGamePanel` and
-  `_drawModsPanel` return it), so the decision reads the previous frame's
-  measurement -- the same one-frame settle the two lists already rely on.
-- **One scroll axis at a time.** While the page scrolls, the panels draw
-  `paged`: the slot and mod lists take their natural height, keep no inner
-  scroll region and report a max of 0, so the wheel, the right stick and a drag
-  all move the page and never fight a list for the same gesture. Two-column
-  layouts do not overflow, `paged` stays false, and every one of these behaves
-  exactly as it did before.
-- Hit testing follows the clip: `inside` (clicks) and `_ptIn` (hover) reject a
-  rect that scrolled out of the viewport, so a control that slid under the tab
-  bar cannot be clicked through it. Tab chips carry `pinned = true` and are
-  exempt. `pageScroll` resets on a tab change, each tab being a different
-  length.
-- A press on empty background pans the page, resolved in `_updateSlotDrag` like
-  every other drag here.
-
-### Dragging on Android
-
-The launcher is handed no move events on any platform: `main.lua` forwards
-neither `touchmoved` nor `mousemoved` while it is up, which is why every drag
-here is resolved by polling inside `draw` instead. Desktop polls the mouse;
-Android used to poll nothing at all ("no reliable pointer polling" meant its
-mouse emulation), so it had no scroll gesture whatsoever -- fine while every
-scroll region was an inner list with a wheel alternative, useless the moment
-the page itself became the thing that scrolls, since a phone is exactly where
-it overflows.
-
-`love.touch` is pollable, so `_pointerHold` reads the first active touch there
-and hands `_updateSlotDrag` the same (held, y) pair the mouse gives on desktop.
-Consequences:
-
-- Slot rows and mod toggles ARM on press and commit on release on Android too,
-  matching desktop, so a swipe that starts on a card scrolls instead of
-  selecting the row it started on.
-- `touchPollable` (set once in `new`) gates all of it. Where `love.touch` is
-  missing, every Android path is exactly what it was: act on press, never arm,
-  no drag.

docs/modding.md

@@ -1,145 +1,23 @@
 # Native modding
 
 The modding book lives on the
-[project wiki](https://github.com/bryanthaboi/gen1recomp/wiki).
+[project wiki](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki).
 
-- [Getting started](https://github.com/bryanthaboi/gen1recomp/wiki/Getting-Started)
+- [Getting started](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Getting-Started)
   — install a mod, write a first one, enable and disable it.
-- [Tutorials](https://github.com/bryanthaboi/gen1recomp/wiki/Tutorials)
+- [Tutorials](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Tutorials)
   — twelve dependency-ordered rungs, each a runnable mod.
-- [Cookbook](https://github.com/bryanthaboi/gen1recomp/wiki/Cookbook)
+- [Cookbook](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Cookbook)
   — task-sized recipes.
-- [Registry reference](https://github.com/bryanthaboi/gen1recomp/wiki/Reference-Registries)
+- [Registry reference](https://github.com/bryanthaboi/pokemon-gen1-recomp-project/wiki/Reference-Registries)
   — every registry, generated from `src/mods/Schemas.lua`.
 
 Regenerate the reference straight into a wiki checkout:
 
 ```sh
-luajit tools/gen_registry_docs.lua ../gen1recomp.wiki
+luajit tools/gen_registry_docs.lua ../pokemon-gen1-recomp-project.wiki
 ```
 
-## Editing maps in Tiled
-
-Maps are data, not assets, so they can be authored in a real map editor and
-exported as a mod. `tools/tiled_export.py` builds a
-[Tiled](https://www.mapeditor.org) workspace out of the imported ROM cache:
-
-```sh
-python3 tools/tiled_export.py          # -> build/tiled/ (gitignored)
-```
-
-Open `build/tiled/gen1.tiled-project`, edit any of the 222 maps (or
-`kanto.world` for the stitched overworld), and export with the
-`gen1-mod-export` extension — one map file, or a whole loadable mod folder.
-An edited vanilla map becomes a `mod.content.maps:patch` carrying only the
-fields that moved; a new map becomes a `:register`. See
-`docs/new-features.md` and the extension's own README.
-
-## Rendering pipelines
-
-Most registries hand the engine *content*. `render_pipelines` hands it
-*drawing*: a pipeline is a display mode a mod owns, which may replace the
-overworld's world pass with geometry of its own and/or post-process the
-finished image. `mods/voxel_world` is the worked example — a 3D diorama
-overworld plus a tilt-shift miniature pass, in about 120 lines of glue over
-its renderer.
-
-A record declares what the mode *is*; the engine
-(`src/render/Pipelines.lua`) supplies everything about *being a display
-mode*: the OFF/1/2/3 ladder, an options row next to TILT, a hotkey,
-persistence in `save.options.pipelines`, and the rule that a world pipeline
-and the engine's own TILT are mutually exclusive.
-
-```lua
-mod.content.render_pipelines:register("diorama", {
-  label = "DIORAMA",                    -- options row label
-  levels = { "OFF", "15", "35", "50" }, -- ladder; defaults to OFF/ON
-  hotkey = "6",                         -- checked after the engine's keys
-  priority = 20,                        -- highest eligible wins the world
-  available = function() return Renderer3D.ok() end,
-  update = function(dt, level) Camera.ease(dt, level) end,
-  drawWorld = function(ctx) return renderScene(ctx) end,
-})
-```
-
-Three draw stages, each optional; a record needs at least one:
-
-| stage | signature | runs |
-| --- | --- | --- |
-| `drawWorld` | `(ctx) -> canvas \| nil` | instead of the flat/tilt world pass |
-| `worldPresent` | `(canvas, ctx) -> canvas` | over the world, **before** the UI composites |
-| `present` | `(canvas, ctx) -> canvas` | over the whole frame, world and UI alike |
-
-`worldPresent` is the one to reach for when an effect must leave dialog
-boxes and menus crisp — a depth-of-field or colour grade on the world only.
-`present` is for effects that genuinely own the screen, like a CRT curve.
-
-`ctx` carries the frame: `state`, `cam`, `vw`/`vh` (world-pixel view),
-`width`/`height` (window pixels), `scale`, `level`, `paletteFor(map)` and
-`spriteColors(map)`. It also carries `ctx.drawFx(project, scale)` — call it
-with your own projection and the engine draws every active field effect
-(the "!" bubble, the Poké Center heal machine, the Fly bird, the fishing
-rod, Rock Tunnel darkness) at its correct anchor under your camera. There
-is exactly one copy of each effect, so a new engine effect works in your
-pipeline without you touching anything.
-
-Three rules worth knowing:
-
-- **`gate` governs input, never the draw.** It decides whether the player
-  may *change* the mode (default: free-roam overworld only). A mode that
-  stopped rendering during a warp would flash the flat 2D world every time
-  the player walked through a door.
-- **`available` is re-read every frame** and is the only thing that decides
-  whether the mode can render at all. Answer `false` on a headless run or a
-  driver with no depth canvas and the engine silently keeps the vanilla 2D
-  path — which is why shipping a pipeline enabled is safe.
-- **A callback that throws retires its pipeline**, attributed to your mod in
-  the manager's error feed, and the frame falls back to 2D. A broken
-  renderer costs the player a display mode, never the game.
-
-Returning `nil` from `drawWorld` is a normal answer meaning "not this
-frame"; the engine draws the vanilla world instead.
-
-## Battle sprite scaling
-
-The enemy's front pic draws at 1x and the player's back pic at 2x, the way
-the Game Boy did. A mod can override either, per species or per image.
-
-Per species, on the `pokemon` record:
-
-```lua
--- MEW's back pic renders 1.5x; its front pic is untouched
-mod.content.pokemon:patch("MEW", { battleScaleBack = 1.5 })
-```
-
-`battleScaleFront` scales the enemy pic, `battleScaleBack` the player pic;
-both take a number in `0.25 .. 4.0`.
-
-Per image, on the `battle_sprite_scales` registry, keyed by the asset path
-exactly as the data references it:
-
-```lua
-mod.content.battle_sprite_scales:register("abra_back", {
-  path = "assets/generated/battle/back/abrab.png",
-  scale = 1.5,
-})
-```
-
-An image-level entry beats the species scale for that one pic, and it is
-the only way to scale a pic that is not species-keyed — the player's
-trainer back sprite, held on screen until "Go!", is a bare image path.
-
-The resolution order at draw time is **image-level → species-level →
-default** (1x front, 2x back).
-
-- **The pic stays grounded at every scale.** The player pic keeps its feet
-  flush on the text-box top (`y = 96`); the enemy pic keeps its bottom edge
-  and horizontal centre pinned in its 7×7 slot. A larger pic grows upward
-  and outward from that anchor, never off the shelf.
-- **Scaling composes with the send-out grow.** The `AnimateSendingOutMon`
-  ball-to-pic grow multiplies your scale through each stage, so a rescaled
-  mon still grows into place from the ball, grounded the whole way.
-
 ## Developer console
 
 Boot with developer mode on to unlock the in-game console and hot-reload
@@ -167,38 +45,5 @@ The console understands these verbs (anything else is evaluated as Lua):
 - `trace PAT | trace off` — trace events/hooks matching a glob pattern.
 - `help` — list the verbs.
 
-## Tool input and title-menu hooks
-
-Tool mods that need to act once per game logic tick can wrap `input.step`.
-It runs immediately before queued button edges are promoted, so input added by
-the wrapper is visible during that same fixed step. The callback receives
-`(next, game, dt)` and must call `next(game, dt)`.
-
-`ui.title_menu.items` receives `(next, game, items)` and follows the same
-decorate-after-`next` convention as `ui.start_menu.items`. It is the safe place
-for a tool to offer a fresh-session action before gameplay begins.
-
-Ephemeral tools can wrap `save.write(next, game)` and return `false` to veto a
-progress write before world state is captured or any bytes reach disk.
-
-`render.hud` receives `(next, game, viewport)` after the finished game frame is
-composited and before touch controls draw. The window-space viewport contains
-`width`, `height`, `gameX`, `gameY`, `gameWidth`, `gameHeight`, `scale`, `dpiX`,
-and `dpiY`, so a tool can use the letterbox margins without drawing over the
-playfield or pushing an updating game state.
-
-`render.compose` wraps the whole-window composite in `Renderer:endFrame`. It
-receives `(next, renderer, ctx)`; returning `true` without calling `next` hands
-the mod full control of the window, while calling `next` runs the engine's
-normal single-window composite so the mod can decorate around it. `ctx` carries
-the finished `worldCanvas` and `uiCanvas` with their SGB `zones` / `worldZones`,
-`worldActive`, the frame metrics (`ww`, `wh`, `pw`, `ph`, `ox`, `oy`, `vpw`,
-`vph`, `scale`, `Sx`, `Sy`, `dpiX`, `dpiY`), `renderer:blitCanvas(...)` for a
-palette-correct blit of either canvas into an arbitrary screen rect, and the
-`secondScreen` bridge (`available()` / `push(imageData, w, h)` / `setEnabled`)
-for driving a second physical display. This is what lets a mod lay the two
-passes out as two stacked Game Boy screens, or push one onto a second screen,
-without the engine knowing the layout.
-
 Developer mode also arms the mod loader's dev tripwire, which flags mods
 that reach outside their permission set.

docs/new-features.md

@@ -8,42 +8,27 @@ behavior is in docs/behavior-porting-notes.md.
 
 ## Survey zoom
 
-The mouse wheel (or `-`/`=`), the Options **ZOOM** row, or hotkey `4`
-zooms the overworld between 1 pixel per world pixel (full survey) and 2×
-the window fit scale (close-up), in crisp integer steps. This has no Game
-Boy equivalent:
+The mouse wheel (or `-`/`=`) zooms the overworld between 1 pixel per world
+pixel (full survey) and 2× the window fit scale (close-up), in crisp
+integer steps. This has no Game Boy equivalent:
 
 - Connected maps render their full bodies, and their NPCs appear as
   visual-only "ghosts",  they wander but have no sight lines, triggers,
   dialogue, or collision until the map is actually entered.
 - Menus, text boxes, and battles draw at normal scale on top of the
   zoomed world. Zoom input is ignored while a script, menu, or battle is
-  active; the zoom offset is persisted as `save.options.zoom` (default
-  `0` = FIT) and survives New Game via `options.lua`.
-- Hotkey `4` ticks through every integer zoom level (survey → FIT →
-  close-up → wrap). The Options row shows `FIT` / `OUTn` / `INn`.
-- Beyond the border ring the void fill repeats indefinitely (see VOID
-  FILL below); interiors keep their own border block. Each visible map
-  area is colorized with its own SGB palette (the original recolored the
-  whole screen per map).
+  active; the zoom level persists across warps and is never saved.
+- Beyond the border ring the border block repeats indefinitely (interiors
+  stay black, seaside towns stay water,  except OVERWORLD-tileset maps,
+  whose beyond-edge space fills with the solid tree wall instead of the
+  per-map border block), and each visible map area is colorized with its
+  own SGB palette (the original recolored the whole screen per map).
 - Neighbor maps load two connection hops out so corner-adjacent maps
   don't pop in and out, and ghost NPCs share instances with the real ones
   so their wander positions persist across seamless connection crossings
   (a warp or fresh map entry still respawns everything at its script
   position, like the original's per-entry sprite init).
 
-## VOID FILL
-
-The Options **VOID FILL** row picks what paints the infinite beyond-edge
-space on OVERWORLD-tileset maps during survey zoom:
-
-- **TREES** (default): solid tree wall block `$0F`.
-- **WATER**: animated water tile `$14` (same hshift cycle as on-map water).
-- **BLACK**: solid black.
-
-Other tilesets are unchanged (house/cave borders stay as authored).
-Persisted as `save.options.voidFill`.
-
 ## Tilt mode
 
 The `3` key (and the Options menu TILT row) cycles a visual-only perspective
@@ -86,26 +71,19 @@ Game Boy equivalent:
 ## Colors mode
 
 The `2` key (and the Options menu COLORS row) cycles the display mode
-through **OG RED → SGB → ADVANCED → OG → OG INV → SGB INV → CLASSIC → OG RED**
-(on Blue the first slot labels **OG BLUE**; on Yellow, **OG YELLOW**).
+through **OG RED → SGB → RED++ → OG → OG INV → SGB INV → CLASSIC → OG RED**.
 The first three are the real colorizations; the rest are DMG-shade novelties:
 
-- **OG RED** / **OG BLUE**: the Game Boy Color boot-ROM look for that cart --
-  one global BG palette + one OBJ palette, every map, no per-map variation
-  (Red/Blue ship no CGB code, so on a GBC the boot ROM colors them globally).
-  The player/NPCs keep the boot-ROM OBJ color over the terrain via the OBP
-  bake + post-zone redraw (`PaletteFX.GBC_BG` / `GBC_OBJ`, or Blue's blue/pink
-  pair).
-- **OG YELLOW** (Yellow playthrough, same `ogred` save id): Pokemon Yellow's
-  authentic GBC look from `CGBBasePalettes` (`data/palettes_yellow.lua`,
-  sourced from pret/pokeyellow). Per-map / per-species colors, not a single
-  boot-ROM ramp -- Yellow was CGB-enhanced.
+- **OG RED**: the Game Boy Color boot-ROM look for Pokemon Red -- one global
+  red BG palette + one green OBJ palette, every map, no per-map variation
+  (Pokemon Red has no CGB code, so on a GBC the boot ROM colors it globally).
+  The player/NPCs stay green over the red terrain via the OBP bake +
+  post-zone redraw (`PaletteFX.GBC_BG` / `GBC_OBJ`).
 - **SGB** (default): the per-map Super Game Boy region palettes
   (`data/sgb/sgb_palettes.asm`). Sprites tint with the region palette, as on
   real SGB. (This is the mode formerly mislabeled "GBC".)
-- **ADVANCED**: pokered-gbc SuperPalettes -- real per-tile GBC coloring plus
-  per-species mon colors (`data/palettes_gbc.lua`). (Formerly labeled
-  "RED++"; it is the richest colorization rather than anything Red-specific.)
+- **RED++**: pokered-gbc SuperPalettes -- real per-tile GBC coloring plus
+  per-species mon colors (`data/palettes_gbc.lua`).
 - **OG**: force the four DMG grays (colorization off).
 - **OG INV**: inverted DMG grays.
 - **SGB INV**: each SGB zone palette with shade order reversed.
@@ -116,8 +94,7 @@ The shade-remap transform is applied centrally in `PaletteFX.sendColors`, so
 it covers overworld, menus, battles, and tilt upright billboards. OG RED's
 global BG palette is supplied by `OverworldState:overworldBgColors` (per-map
 override in the overworld pass). Persisted as `save.options.colors`; the
-`gbc` / `gbc_inv` / `redpp` save ids are kept for back-compat under the new
-labels.
+`gbc` / `gbc_inv` save ids are kept for back-compat under the new labels.
 
 ## GBC FX
 
@@ -135,49 +112,6 @@ It runs as a final present pass after world + UI composite in
 ([github.com/mattakins/Pixel_Transparency](https://github.com/mattakins/Pixel_Transparency)).
 Default OFF; persisted as `save.options.gbcfx`.
 
-Mobile GPUs often compile the pass but present a black frame, so Android and
-iOS hide the row entirely, pin the level to OFF, and rewrite a level already
-persisted in `options.lua` (issue #136). `POKEPORT_GBCFX` overrides that
-decision either way, same tri-state as `POKEPORT_TOUCH`: `=0` refuses the
-effect, `=1` forces it available. The Anbernic handheld pack exports `0` from
-its launcher because the device reports `"Linux"` while its GPU is in the
-phone class (see [Anbernic RG34XXSP](anbernic-rg34xxsp.md)).
-
-## Performance tier (low-end devices)
-
-The Options **PERFORMANCE** row scales the port's optional presentation
-extras down for weaker hardware. The extras it governs are the three
-heaviest things the port adds on top of the original -- the whole-screen 3D
-**TILT** (transforms the entire map as a ground plane), the **GBC FX**
-post-process shader (a fullscreen pass), and survey **ZOOM** (zooming out
-renders the connected neighbor maps, a lot of extra overdraw) -- plus a hard
-FPS ceiling. None of this touches game logic, which is fixed-step off `dt`
-(`src/core/FixedStep.lua`), so every tier plays identically; they differ
-only in how much eye-candy the renderer is allowed to do.
-
-| Tier         | TILT | GBC FX | Survey ZOOM | Extra FPS ceiling |
-| ------------ | ---- | ------ | ----------- | ----------------- |
-| **HIGH**     | on   | on     | on          | none              |
-| **BALANCED** | off  | off    | on          | none              |
-| **LOW**      | off  | off    | off         | 60                |
-| **AUTO**     | picks a default from the device (below) |||
-
-- **AUTO** (the default) reads the device once at boot: ARM Linux handhelds
-  (e.g. the RG34XXSP) resolve to **LOW**, phones/tablets and very-low-core
-  desktops to **BALANCED**, and everything else -- a normal desktop, and
-  every existing `options.lua` that predates this option -- to **HIGH**,
-  so the common case is unchanged. See `src/core/Performance.detect`.
-- AUTO only chooses the *default*; all four tiers are selectable, so a
-  wrong guess is one row away from being overridden.
-- The clamps are applied **live** against your stored options and never
-  rewrite them (`Game:applyOptions`), so a lower tier hides your TILT / GBC
-  FX / ZOOM without forgetting them -- raising the tier restores exactly
-  what you had. (This is why the TILT / GBC FX / ZOOM rows still show your
-  saved choice on a clamped tier: it's your preference, waiting for a tier
-  that can afford it.)
-- Persisted as `save.options.performance` (`auto` | `high` | `balanced` |
-  `low`); unit-tested in `tests/engine/performance_tiers.lua`.
-
 ## Peer-to-peer link play (lua-enet)
 
 Trades and link battles connect two copies of the game directly over
@@ -192,42 +126,6 @@ tradeoff vs. the relay). Headless tests drive the protocol over an
 in-memory loopback (`Net.loopbackPair`); under LÖVE the same test file
 also exercises real UDP pairing.
 
-Red, Blue, and Yellow copies link with each other, as the real cable
-does. The compatibility fingerprint hashes only data a link mode can
-actually read, so Yellow's Dragonair/Dragonite catch-rate retunes (the
-only R/B/Y link-surface difference) no longer read as different games
-(issue #511). Moving the fingerprint is a link parity change: builds
-from before this fix will refuse to pair with builds after it.
-
-## Fair play in link and online matches
-
-A link session is decided by the battle and nothing else, so for its
-duration:
-
-- **Game speed is pinned to normal.** The GAME SPEED option and
-  `POKEPORT_SPEED` are ignored from the moment LINK PLAY opens until it
-  closes, and apply again after. Fast-forward otherwise runs one peer's
-  queue faster than the peer it is locked to and drains a tournament shot
-  clock faster than the opponent racing it.
-- **Online play runs vanilla, except for your language.** Picking ONLINE
-  MATCH or TOURNAMENT with mods enabled offers to switch the gameplay ones
-  off and relaunch (mods merge at boot, so a restart is the only way). The
-  restart is confirmed, not silent. They stay listed as disabled, ready to
-  switch back on. A mod that declares itself a translation and provably
-  writes nothing but text stays on: the two games hash the same link
-  surface, so a Spanish install and an English one can battle and trade,
-  each reading the game in its own language and naming the other player's
-  party out of its own text.
-- **Only a meaningful split ends a match.** The per-turn state signature
-  both peers exchange is split three ways: `actives` and `bench` carry
-  species, HP, status, stat stages, PP and the rest of the party, and a
-  divergence there ends the match as a draw. `volatile` carries per-turn
-  flags both sides recompute anyway - a divergence there is logged and
-  reported to mods, and play continues.
-
-The relay logs which component diverged on which turn, so a desync report
-names something specific.
-
 ## Custom boot text
 
 The boot sequence replaces the Nintendo / GAME FREAK identifiers with
@@ -241,270 +139,17 @@ Nidorino-vs-Gengar attract scene) mirror the original.
 Options persist in a standalone `options.lua` (separate from the game
 progress `save.lua`), so audio/display/battle preferences survive New Game
 and aren't wiped when a save slot is cleared. Changing a row in the Options
-menu or cycling hotkeys `2`/`3`/`4`/`5` writes immediately; an in-game save also
+menu or cycling hotkeys `2`/`3`/`5` writes immediately; an in-game save also
 flushes the live options. Old saves that still embed an `options` table are
 migrated once into `options.lua` on load.
 
 - Music / SFX volume
-- PIKACHU VOL (0-7, Yellow only): trims Pikachu's PCM voice clips under the
-  SFX level, so the follower's constant chatter, the title-screen cry and
-  every in-battle "Pika!" can be pulled down (or muted at 0) without
-  quieting the rest of the sound effects. The row is hidden on Red/Blue,
-  which have no voice clips.
 - Music Filter
 - OG GLITCHES on / off (Gen 1 quirks vs. modern-clean battle rules)
-- BATTLE LAYOUT (OG / WIDE); see "Widescreen battle layout" below
-- COLORS (OG RED / SGB / ADVANCED / OG / OG INV / SGB INV / CLASSIC),  also
-  hotkey `2` (OG RED = GBC boot-ROM look; ADVANCED uses pokered-gbc
+- COLORS (OG RED / SGB / RED++ / OG / OG INV / SGB INV / CLASSIC),  also
+  hotkey `2` (OG RED = GBC boot-ROM look; RED++ uses pokered-gbc
   SuperPalettes + per-species mon colors)
 - TILT (OFF / 15 / 35 / 50),  also hotkey `3` while free-roaming
-- ZOOM (FIT / OUTn / INn),  also hotkey `4` while free-roaming; wheel and
-  `-`/`=` step one level and save
-- VOID FILL (TREES / WATER / BLACK) for OVERWORLD beyond-edge space
 - GBC FX (OFF / 1 / 2 / 3 / 4),  also hotkey `5`
 - MAX FPS (30 / 40 / 50 / 60 / 75 / 90 / 100 / 120 / 144 / 160, default 60),
-  a hard render frame-rate cap (`save.options.fpsCap`).
-
-## Battle transition cascade + white battle letterbox
-
-Into-battle wipes still run the original eight styles inside the classic
-160×144 letterbox. On wide/tall windows (survey zoom), matching black 8×8
-blocks cascade outward from that square into the surrounding world so the
-void outside the OG wipe fills in lockstep. Once the battle state is up,
-letterbox voids around the battle canvas fill **white** instead of black
-so the whole window reads as one continuous battle screen.
-
-## Widescreen battle layout
-
-Options **BATTLE LAYOUT** picks the battle screen's composition: **OG**
-(the default: the original 160×144 arrangement, unchanged) or **WIDE**,
-which gives battles a 304×144 native-pixel surface and a Gen 3-style
-arrangement on it:
-
-- the foe's status box upper left, the foe's picture upper right;
-- the player's picture lower left, the player's status box lower right,
-  with a longer HP bar and the numeric HP under it;
-- a full-width message window;
-- a split "What will X do?" prompt / 2×2 command window;
-- a 2×2 move menu, navigated with all four directions, with a PP and type
-  panel attached to its right.
-
-Only the composition changes. Pictures, palettes, HP-bar colors, font
-pages, window borders, sounds, animations, timing and every battle rule
-stay the engine's, so a COLORS mode or an asset mod still owns the look.
-Each side's picture keeps its original pixels and placement math and is
-composited into its own region of the wider battlefield -- nothing is
-scaled or squeezed -- and animations, which are authored in the original
-160-pixel space, shift as one rigid group onto whichever side they play
-on. The whole screen is drawn at the window's integer fit scale for the
-wider surface, so a 304-pixel screen is drawn a step smaller than a
-160-pixel one in the same window.
-
-The wide surface is live only while the battle itself is the screen on
-top: a party menu, the bag or a nickname prompt is a 160×144 screen and
-brings the classic surface back with it.
-
-## On-screen touch controls (mobile)
-
-On Android/iOS the game draws a translucent d-pad (bottom-left), A/B
-buttons (bottom-right, Game Boy diagonal), and +/- START/SELECT (bottom
-center) over the frame, using Xelu's CC0 controller prompts
-(`assets/touch/`). Real buttons, not gestures: press lands the frame the
-finger does, sliding on the d-pad changes direction without lifting, and
-multi-touch chords (e.g. hold a direction + tap B) work. The overlay only
-appears while no controller is being used: the first gamepad button or
-stick push hides it, the next screen touch brings it back, and unplugging
-the last controller restores it immediately. Layout re-derives from the
-window size on rotation. Desktop testing: `POKEPORT_TOUCH=1 love .` forces
-the overlay on and lets the mouse act as a finger (`=0` forces it off).
-
-The launcher's **Touch Controls** button opens a drag editor: move each
-button freely, resize the whole pad with **-/+** (60% to 160%), **Disable**
-to hide the overlay permanently (for controllers / emulation handhelds --
-distinct from the temporary gamepad auto-hide), **Reset** for defaults,
-**Done** to save into `options.lua` as normalized window fractions so a
-different screen keeps the relative placement.
-
-Portrait and landscape are edited and saved separately (#633): the editor
-follows whichever orientation is on screen, and **Reset** only clears that
-one, so a layout that works held upright does not have to double as the
-one used sideways. An `options.lua` from before this split keeps its single
-layout in both orientations until one of them is edited. In-game, Options →
-**TOUCH PAD** toggles the same on/off flag without leaving a play session.
-
-## Translation support
-
-Every string the player can read is now reachable from a mod, so a
-translation is an ordinary content mod rather than a fork.
-
-Two things had to change. Text layout stopped counting bytes: the dialogue
-box measures a line in glyphs (charmap sequences), so a 3-byte character
-costs one column, a cut never lands inside a character, and a page with a
-non-default `advance` re-measures instead of overflowing. That also fixed
-25 vanilla English lines that were wrapping early because `é` in POKéMON
-and POKéDEX costs two bytes ("I study POKéMON as" is 19 bytes and 18
-glyphs, and the box was breaking it).
-
-Second, the text the engine writes itself - battle messages, item results,
-menu labels, the link-play screens - moved behind `src/core/Strings.lua`
-and the new `strings` registry. Extracted script text was already
-overridable through `text`; this covers the other half. Entries are keyed
-by the English source, so a translation that has not reached a string yet
-keeps rendering in English and a half-finished translation stays playable.
-
-Authors generate the whole thing:
-
-```sh
-python3 tools/modkit.py translation francais --language "Francais"
-```
-
-That scaffolds a mod with every translatable string as an empty catalog,
-plus a glyph-page and charmap stub, a naming-grid stub, and a
-`francais-worksheet/` directory holding the English to translate from
-(deliberately outside the mod: extracted text is ROM content and must not
-be packed). `--refresh` re-harvests after an engine update, keeping
-existing translations and parking orphaned keys rather than dropping them.
-
-See the wiki's Translations guide.
-
-## Save editor (bundled, reachable from the launcher)
-
-The save editor ships inside every build instead of being a developer-only
-script, and the launcher's SAVE SLOT card grows an **Edit** label next to
-Delete on every slot that actually holds a save. Edit suspends the
-launcher, opens that slot's file in the editor, and **Close** hands the
-process back to the launcher with the slot list re-read (a rename, a badge
-or a dex change shows up on the row immediately). Unsaved edits arm a
-confirm first, so leaving cannot lose work. `love . --editor` still opens
-it standalone, where Close quits instead; `--save <path>` points it at any
-file, and a save can be dragged onto the window.
-
-The editor now wears the launcher's visual language - the same navy radial
-field, 16px translucent cards, tri-colour version rail and green/yellow/red
-semantics - so the two windows read as one app. Six tabs:
-
-- **Party**: the roster with sprites, HP bars and level chips on the left,
-  and the mon inspector permanently docked on the right instead of floating
-  over the list. Species, level, DVs and moves all round-trip through the
-  Gen 1 formulas, so the inspector can never show illegal stats.
-- **Boxes**: the 12 PC boxes as a 5x4 grid with a fill meter per box and a
-  party dock, so deposit and withdraw live in one place. Empty slots are
-  clickable and create a mon there.
-- **Items**: money, a searchable item picker (replacing the arrows that
-  cycled one id at a time through ~250 items), the configurable bag (20 slots
-  by default), PC storage
-  with no slot cap, and the eight badges as toggle chips. The picker, the bag
-  and PC storage all scroll under the mouse wheel, so the whole catalog is
-  reachable one-handed without typing a query.
-- **Events**: flags, defeated trainers, taken items and per-map object
-  toggles, with a real filter field and a two-column paged grid.
-- **Map**: any map rendered with the game's own renderer, warps followable,
-  and the player / lastHeal / lastOutdoor spawn points settable by clicking
-  a cell. Setting lastOutdoor on a map the game would not accept as an
-  outdoor source is refused with the reason.
-- **Dex**: seen / owned completion meters and a four-column grid; owning
-  implies seen and un-seeing clears owned, exactly as the game requires.
-
-Two rules run through all of it. Every mutation goes through one funnel
-that sets the dirty flag and writes the status line together, so nothing
-changes silently and no branch can quietly no-op - "Party is full", "Bag is
-full", "click a cell first" all say so. And every destructive verb (Remove,
-Release, Clear all, Wipe dex) arms on the first click and commits on the
-second, relabelling itself to `Confirm?` in between.
-
-A validation pill in the tab rail mirrors what the running game would
-quarantine on load; clicking it jumps to the tab holding the first problem.
-
-## Tiled map editing (mod authoring)
-
-`tools/tiled_export.py` turns the imported ROM cache into a Tiled workspace,
-so maps can be edited in a real map editor and exported back out as a mod.
-It has its own document: docs/tiled-map-editing.md.
-
-## Pokédex diploma (both versions)
-
-The Celadon Mansion 3F game designer shows the dex-completion diploma
-once 150 species are owned. On Yellow, the graphic artist next to him
-then offers to print it, saving the certificate as a PNG under `prints/`
-in the save directory, and Bill's PC gains Yellow's PRINT BOX item which
-exports the current box list the same way.
-
-## Pokédex printing (Yellow)
-
-Yellow's Game Boy Printer PRNT option in the Pokédex side menu is stood in
-for by an image export: choosing PRNT renders the mon's entry page (sprite,
-kind, number, height/weight, dex text) to a PNG at 4x scale under
-`prints/` in the save directory, then reports the filename in a dialog.
-No printer hardware or link cable emulation involved; the file is the
-printout.
-
-## Find Mods (community mod indexes)
-
-A FIND MODS tab sits beside MODS in the launcher and browses a published
-mod index: a metadata-only feed listing mods that live in their authors'
-own repositories. No index ships with the launcher and none is ever added
-automatically, so the tab opens on an "Add an index" prompt until you name
-one; paste an index URL or its `owner/repo` and it is remembered in
-`options.lua`. More than one index can be added, and the listings merge.
-
-## Soft reset (all versions)
-
-Holding A, B, START and SELECT together restarts the game the way flicking
-a Game Boy's power switch did, dropping straight back to the title screen.
-It works from anywhere, including mid-battle, which the QUIT entry on the
-start menu cannot do: the original combo is how stationary and gift
-Pokemon get their stats rerolled without sitting through a full relaunch.
-Unsaved progress is discarded, exactly as on hardware.
-
-As on the original, the four buttons have to stay held for 16 straight
-polls (better than a quarter of a second) and any direction in the mix
-cancels it, so it is hard to hit by accident -- including on the on-screen
-touch controls, where it would take four fingers held on four separate
-controls.
-
-## Controls rebinding (CONTROLS screen)
-
-OPTIONS -> CONTROLS lists every Game Boy button with its current keyboard
-key and controller button side by side (Z/A). Press A on a row, then press
-and release the key or pad button you want; the rebind commits on the
-release. If that input already belongs to another row, the two rows swap,
-so no button is ever stranded without an input and no input ever serves
-two buttons. Holding a second key or pad button while the first is still
-down backs out of the capture without touching a keyboard; Escape still
-cancels too. SELECT clears one row back to its default, and START resets
-every binding after a confirmation.
-
-Controllers a system has no mapping for (common on Linux handhelds and
-off-brand pads) report bare button numbers rather than names. Those are
-rebindable on the same screen and show up as JOY1, JOY2 and so on in the
-controller column. Recognized controllers are read only through their
-named buttons, so a rebind on those is never shadowed by the factory
-layout underneath it.
-
-## Mod profiles (#593)
-
-The mod manager's PROFILES tab holds named setups. A profile remembers which
-mods are on, every mod's own options, and which save slot each game version
-plays, so swapping profiles swaps the whole playthrough and not just the mod
-list. The setup that existed before profiles shipped becomes PROFILE 1 the
-first time the manager opens.
-
-EXPORT.. writes the selected profile to `profiles/<NAME>.g1rmodlist` in the
-save directory; drop a `.g1rmodlist` someone shared into that folder and
-IMPORT.. adds it. Imported profiles never overwrite an existing one (a name
-clash gets a number). Mods the shared profile names but that are not installed
-are reported when the profile is applied; installing them is still a manual
-trip through the mods list or Find Mods.
-
-## Windows: no console windows on launcher actions
-
-Checking for updates, browsing a mod index, adding a mod repo, installing a
-mod and picking a ROM all run a host tool (curl, PowerShell) in a child
-process. On Windows those children used to each open their own console
-window, so a session could end up buried under half a dozen of them. The
-game now claims one console for itself at boot and hides it; the children
-inherit that invisible console and nothing pops up. Nothing else changes:
-file pickers are ordinary desktop dialogs and still appear normally, and a
-run started from a terminal (`lovec.exe`, what `scripts\run.ps1` prefers)
-keeps its terminal and its printed output. Set `POKEPORT_CONSOLE=1` to opt
-out.
+  a hard render frame-rate cap (`save.options.fpsCap`).

docs/rfcs/0001-surfing-pikachu-sprite.md

@@ -1,96 +0,0 @@
-# RFC 0001 — Port Yellow's `IsSurfingPikachuInParty` surf sprite
-
-## Status
-
-Proposed. Engine: `Player.lua`, `FieldDefaults.lua`,
-`OverworldController.lua`, `RomExtractor.lua`, `PaletteFX.lua`. Tools:
-`build_rom_data.py`, `extract/sprites.py`, `make_rom_manifest.py`,
-`make_yellow_manifest.py`. Tests: `parity_surfing_pikachu_sprite.lua`,
-`mod_world_tests.lua`.
-
-**Regeneration required.** The manifest and sprite sheet update by
-re-running `make_yellow_manifest.py` against a `pret/pokeyellow`
-checkout, then re-importing the Yellow ROM.
-
-## Motivation
-
-Yellow's `IsSurfingPikachuInParty` + `LoadSurfingPlayerSpriteGraphics2`
-(`home/map_objects.asm`, `home/overworld.asm`) swap the player's
-overworld sheet to `SurfingPikachuSprite` (`gfx/sprites/
-surfing_pikachu.2bpp`, a 16×96 walk sheet — not the minigame sheets)
-when the party mon that knows SURF is a Pikachu. The recomp misses this
-in two places:
-
-1. **Extraction.** `SurfingPikachuSprite` is not in
-   `SpriteSheetPointerTable` — loaded by its own `ld de,` like
-   `RedBikeSprite`. The extractor never sees it, and the symbol is not
-   in the Yellow manifest.
-2. **Engine rule.** `field.playerSprites.surf` is one static
-   (`SPRITE_SEEL`), cached at boot. No seam for "swap when the SURF-mon
-   is a Pikachu."
-
-## The decision it extends
-
-No prior D-number. Extends the surf-field-move port in
-`docs/behavior-porting-notes.md` (the `IsSurfingAllowed` exact port)
-with the player-sprite swap vanilla runs alongside it.
-
-## The exact API delta
-
-Backward-compatible, additive-only.
-
-### `field.playerSprites.surfPikachu`
-
-New optional key alongside `walk`/`surf`/`bike`/`fly`, defaults to
-`SPRITE_SURFING_PIKACHU`. Guarded in `Player.new` so before extraction
-lands the ride keeps the Seel — no plain on-water Pikachu.
-
-### `Player.surfPikachuSprite`
-
-`Player.new` builds a second `SpriteRenderer` when the field resolves.
-`pose()` picks it when `surfing and surfingPikachu`.
-
-### `Player.surfingPikachu` (runtime)
-
-Runtime-only boolean (not persisted); re-derived so a party change
-between save and load is honored.
-
-### `OverworldState:syncSurfingPikachu()`
-
-Sets `player.surfingPikachu` from `partyKnows("SURF")`. Called at every
-surf-state toggle: trySurf, dismount, flyTo, beginTeleportOut,
-warpToHealPoint, forced-surf tile, setMap boot-restore.
-
-### Importer — `SPRITE_SURFING_PIKACHU`
-
-`make_yellow_manifest.py` adds `SurfingPikachuSprite` to
-`YELLOW_EXTRA_SYMBOLS`. `make_rom_manifest.py`'s `sprite_metadata()`
-gains a `surfPikachu` entry (guarded, so Red/Blue unchanged).
-`RomExtractor.extractSprites` + `build_rom_data.py` + `extract/sprites.py`
-each gain a parallel extract mirroring `RedBikeSprite`.
-
-### `PaletteFX.spriteObp`
-
-`SurfingPikachuSprite` joins `RedBikeSprite` in the no-bracket-index
-special case, wearing the player's OBP palette so it colors in GBC mode.
-
-## Migration note for existing mods
-
-**Nothing.** `surf` still defaults to `SPRITE_SEEL`; `surfPikachu`
-only resolves on a Yellow import after regeneration. No manifest or
-`mod.save` shape changes. An eligibility hook that swaps a rental
-SURF-mon still drives the sprite pick via `partyKnows`.
-
-## Parity tests
-
-- **No-mod** (`mod_world_tests.lua`): `surf == "SPRITE_SEEL"`,
-  `surfPikachu == "SPRITE_SURFING_PIKACHU"` seeded at boot. The 19229-check
-  `world & maps v2` suite stays green.
-- **Mod-API** (`parity_surfing_pikachu_sprite.lua`): `syncSurfingPikachu`
-  + `Player:pose` across four party shapes (12/12). The existing
-  `parity_cinnabar_east_surf.lua` (24/24) stays green.
-
-## Deprecation etiquette
-
-Nothing deprecated. Additive: a new `field.playerSprites` key, a new
-runtime flag, a new engine method, a new sprite id.

docs/tiled-map-editing.md

@@ -1,65 +0,0 @@
-# Tiled map editing (mod authoring)
-
-`tools/tiled_export.py` turns the imported ROM cache into a
-[Tiled](https://www.mapeditor.org) workspace, so maps can be edited in a
-real map editor and exported back out as a mod. The original had no map
-editor at all; the port's own map data is plain Lua, which is what makes
-this a data path rather than an asset path.
-
-Editing is done in our own Tiled build,
-[bryanthaboi/tiled_gen1recomp](https://github.com/bryanthaboi/tiled_gen1recomp/releases),
-which ships the `gen1-mod-export` extension the workspace relies on. Grab it
-from that repo's releases; upstream Tiled opens the workspace but cannot
-export a mod out of it.
-
-```sh
-python3 tools/tiled_export.py          # -> build/tiled/ (gitignored)
-```
-
-Then open `build/tiled/gen1.tiled-project` in that build of Tiled.
-
-- **The overworld is one surface.** All 222 maps become `maps/*.tmj`, and
-  `kanto.world` places the 36 connected overworld maps at their real
-  connection offsets. That world is pre-loaded (seeded into the workspace's
-  Tiled session), so opening any one overworld map draws its neighbors around
-  it and you scroll and edit straight across the seams. Everything else is a
-  double-click away in Tiled's project panel.
-- **Extending Kanto wires both ends.** A connection lives on both maps, so
-  hooking a new map onto a base map also emits the return connection as a
-  patch on that base map, keeping its other directions intact. The return
-  offset is derived, not guessed: all 78 vanilla reciprocal pairs satisfy
-  `back.offset == -offset`.
-- **A Tiled tile is a gen1 block.** Each of the 24 tilesets becomes a Tiled
-  tileset whose tiles are its 32x32 blocks, composited from the 8x8 sheet,
-  so a tile layer *is* the map's `blocks` array. Warps, signs and objects
-  sit on the 16px cell grid in object layers, which is the grid the engine
-  addresses them on.
-- **Collision is visible.** View > Show Tile Collision Shapes draws the real
-  walkability: a rectangle covers each cell whose feet tile is not in the
-  tileset's `walkable` list, which is the rule `src/world/Map.lua` applies.
-- **Maps are shown in their real colors.** Each map is atlased in the SGB
-  palette it renders with, so Cerulean is blue and Lavender is purple in the
-  editor exactly as in game. Vanilla resolves that through a cascade with
-  interiors inheriting the last outdoor map, so the workspace mirrors the
-  cascade and walks the warp graph to colour interiors. Changing a map's
-  `palette` exports `palette = "..."` on the record, which beats the cascade,
-  and the editor offers the real palette names as a dropdown.
-- **New blocks and new tilesets.** `blocksets/*.tmj` show a tileset's blocks
-  as raw 8x8 tiles, four by four, so new blocks can be composed there;
-  per-tile flags on `tilesets/tiles_*.tsj` become `walkable`, `waterTiles`,
-  `doorTiles` and the rest.
-- **Export is a diff, not a fork of the data.** The `gen1-mod-export`
-  extension (shipped in `tiled_gen1recomp`) writes either one map file or a whole
-  loadable mod folder. An edited vanilla map diffs against the imported data
-  and emits `mod.content.maps:patch` carrying *only* the fields that moved, so
-  a mod covers the parts it changes and leaves the rest to the base game; a
-  new map gets `:register` at an index of 1000 or above. An unchanged map
-  exports nothing at all. Exports pass `tools/modkit.py validate` and `lint`.
-- **Or the whole record, on request.** Ticking `exactExport` on a map switches
-  it to `mod.content.maps:override`, pinning the map to exactly what the
-  editor shows. It is off by default because an override wins outright over
-  any other mod patching that map, where a patch composes.
-
-No ROM-derived art travels into an exported mod: a tileset still drawing on
-the player's own imported sheet references that path rather than shipping the
-pixels, and only a sheet the author supplied is copied in.

docs/timing-parity.md

@@ -1,382 +0,0 @@
-# Timing parity with the Game Boy
-
-The port's clock is faithful: `src/core/FixedStep.lua` advances game logic in
-whole 1/60 s steps off wall-clock `dt`, the default speed multiplier is 1x
-(`src/core/GameSpeed.lua:22`), and audio runs on its own real-time accumulator
-so fast-forward cannot pitch it. Almost nothing in `src/` is seconds-based.
-
-What diverges is the **frame budget of composed sequences**. The original
-spends a large fraction of its running time inside `DelayFrames` calls that
-produce no visible change - the pause after a page break, the beat before a
-status move resolves, the drain of an HP bar one point at a time. Those are
-invisible in a screenshot and easy to drop when porting behavior rather than
-timing. Dropping them is why the port reads as faster and snappier than
-hardware even though every individual animation is correct.
-
-This document is the specification: what each sequence costs on hardware, and
-where that number comes from.
-
-## Method
-
-`tools/scan_pokered_delays.ps1` walks the disassembly and reports every
-frame-consuming wait with its enclosing routine label:
-
-| Kind | Meaning | Frames |
-| --- | --- | --- |
-| `DelayFrames` | `ld c, N` + `call DelayFrames` (`home/delay.asm:1`) | N |
-| `DelayFrame` | one vblank wait (`home/vblank.asm:92`) | 1 |
-| `Delay3` | `home/palettes.asm:14`, three frames for a full bg-map update | 3 |
-| `Fade` | the `GBFade*` helpers, expanded to their totals below | 24 or 32 |
-
-Current inventory against `pokered-master`: **450 sites** - 181 `DelayFrames`,
-164 `Delay3`, 65 `DelayFrame`, 31 `GBFade*`, and 9 `DelayFrames` calls whose
-count is computed at runtime.
-
-The four fades all live in `home/fade.asm` and are loops of
-`ld c, 8 / call DelayFrames`:
-
-| Routine | Iterations | Frames | Source |
-| --- | --- | --- | --- |
-| `GBFadeInFromBlack` | 4 | **32** | `home/fade.asm:21` |
-| `GBFadeOutToBlack` | 4 | **32** | `home/fade.asm:43` |
-| `GBFadeOutToWhite` | 3 | **24** | `home/fade.asm:26` |
-| `GBFadeInFromWhite` | 3 | **24** | `home/fade.asm:48` |
-
-## The metric
-
-For each catalog entry, `delta = |port - truth| / truth`; the entry passes at
-`delta <= 0.05`. The headline number is the **exposure-weighted** pass rate,
-weighting each sequence by how often it occurs in ordinary play - a 30-frame
-error on every page of dialogue matters more than a 30-frame error in the Hall
-of Fame. Weights are in the tier column: T1 sequences recur constantly, T2 are
-frequent, T3 are set pieces seen once or twice per playthrough.
-
-## Tier 1 - constant exposure
-
-These recur every few seconds of play and dominate perceived pacing. Both
-sides are verified.
-
-### Overworld and transitions
-
-| Sequence | Hardware | Source | Port | Port source | Delta |
-| --- | --- | --- | --- | --- | --- |
-| Overworld loop iteration | 2 frames (two `DelayFrame`) | `home/overworld.asm:41-44` | 1 step | `src/core/Game.lua:174` | see note |
-| Warp / door: fade out | **32** | `home/overworld.asm:703` -> `GBFadeOutToBlack` | 32 | `src/render/Transition.lua` | **fixed** |
-| Warp / door: fade in | **0** (map is drawn under blacked palettes, no fade) | `home/overworld.asm:690-703` | 0 | `src/render/Transition.lua` | **fixed** |
-| Return to overworld after a battle | **10** hold, then `GBFadeInFromWhite` **24** | `home/overworld.asm:351-352`, `:22`, `:749-753` | 10 + 24 | `Transition.battleReturn` | **fixed** |
-| Special warp entry (fly / teleport / dungeon) | `Delay3` + `GBFadeInFromWhite` = **27** | `engine/overworld/player_animations.asm:5-7` | - | - | unmeasured |
-| Dungeon-warp arrival hold | **50** | `engine/overworld/player_animations.asm:43` | - | - | unmeasured |
-| Player step (walk) | 16 | 8 loop iterations x 2 frames | 16 | `src/world/Player.lua:14` | **ok** |
-| Turn in place | 2 | one extra loop pass | 2 | `src/world/Player.lua:18` | **ok** |
-
-Note on the overworld loop: `OverworldLoop` calls `DelayFrame` and then falls
-through to `OverworldLoopLessDelay`, which calls it again - so a full pass
-costs 2 frames, and input is sampled every other frame. The port steps logic
-and samples input every frame. This does not change walking speed (the 2-frame
-loop moves 2 px, giving the same 16 frames per tile) but it does halve input
-latency versus hardware. Flagged rather than "wrong": matching it exactly would
-make the port feel less responsive than the original does on a modern display,
-and it is the one place where a deliberate divergence is defensible.
-
-### Text
-
-The typewriter cadence itself is already correct - 1/3/5 frames per character
-from `TextSpeedOptionData`, implemented at `src/render/TextBox.lua:267`. The
-gaps around it are missing.
-
-| Sequence | Hardware | Source | Port | Port source | Delta |
-| --- | --- | --- | --- | --- | --- |
-| `<CONT>` line scroll (after the A press) | `ProtectedDelay3` 3 + 2x `ScrollTextUpOneLine` 5 = **13** | `home/text.asm:262-277`, `:283-307` | 13 | `src/render/TextBox.lua` | **fixed** |
-| `<PARA>` paragraph break | `ProtectedDelay3` 3 + clear + **20** = **23** | `home/text.asm:230-243` | 23 | `src/render/TextBox.lua` | **fixed** |
-| Page break (`PageChar`) | 3 + **20** = **23** | `home/text.asm:245-260` | 23 | `src/render/TextBox.lua` | **fixed** |
-| `TextCommand_PAUSE` | **30** | `home/text.asm:500` | - | - | unmeasured |
-| `TextCommand_DOTS` | **10** per dot | `home/text.asm:576` | - | - | unmeasured |
-
-The three ProtectedDelay3 frames are a *pre*-input hold: the arrow is already
-up and the button is ignored, because `ManualTextScroll` only starts watching
-the joypad after the delay returns. Mashing A through a long conversation
-therefore cannot go faster than 3 frames per line on hardware, and now cannot
-here either. `PromptText` (`home/text.asm:209-217`) has the same shape, so a
-finished page holds three frames before it can be dismissed too.
-
-**Battle text is a second, separate engine.** `BattleState` types its own
-messages rather than going through `src/render/TextBox.lua`, so none of the
-fixes above reached it and it had drifted further than the overworld box:
-
-| Sequence | Hardware | Source | Was | Now |
-| --- | --- | --- | --- | --- |
-| Per character | 1 glyph per `wOptions & $f` frames (1/3/5, default **3**) | `home/print_text.asm:4-45` | 2 glyphs **per frame**, option ignored | 3 |
-| Per character, A or B held | **1** frame | `print_text.asm:27-36` | 2 glyphs per frame | 1 |
-| `<CONT>` pre-input hold | **3** | `home/text.asm:263-267` | 0 | 3 |
-| `<CONT>` scroll after the press | **10** | `home/text.asm:280-305` | 0 | 10 |
-| Finished page, pre-input hold | **3** | `home/text.asm:213-217` | 0 | 3 |
-
-At the default text speed the battle typewriter was running **six times**
-hardware speed, which is most of why battle text read as a blur, and it
-ignored the OPTION text-speed setting entirely.
-
-`ScrollTextUpOneLine` is `ld b, 5` of `DelayFrame` (`home/text.asm:301-305`)
-and its own comment notes it is "always called twice in a row", so a CONT
-scroll blocks for 10 frames. The port's `scrollPx` slide at
-`src/render/TextBox.lua:305-307` is a cosmetic 8 px at 2 px/frame running in
-`draw()`, not on the logic step, and it does not gate the typewriter.
-
-### Menus
-
-| Sequence | Hardware | Source | Port | Port source | Delta |
-| --- | --- | --- | --- | --- | --- |
-| Yes/no answer (either option) | **15** | `engine/menus/text_box.asm:322-323`, `:333-334` | 15 | `src/ui/ChoiceBox.lua` | **fixed** |
-| List menu open (bag, PC, party-as-list) | **10** | `home/list_menu.asm:55-56` | 0 | `src/ui/ListMenu.lua` | **-100%, open** |
-| List menu redraw per input | `Delay3` = **3** | `home/list_menu.asm:64` | 0 | - | **-100%, open** |
-| Field move from the party menu | `Delay3` = **3** | `engine/menus/start_sub_menus.asm:4,27,175-203` | 7 (white flash) | `src/render/Transition.lua:8` | see note |
-| Teleport from the party menu | **60** + `Delay3` | `engine/menus/start_sub_menus.asm:224-225` | - | - | unmeasured |
-
-The port's 7-frame `white_flash` models `GBPalWhiteOutWithDelay3` plus the
-screen-tile restore, which is a defensible reading of the same sequence; it is
-listed here to be reconciled against the exact path rather than treated as a
-bug.
-
-### Battle entry
-
-The wipe into a battle and the silhouette slide behind it. Numbers here come
-from **pokered-c** (`C:\Users\Anthony\pokered`), whose `battle_transition.c`
-derives each wipe from `battle_transitions.asm` and then corrects it against a
-live side-by-side with the ROM. Where that project's measured value and a
-naive reading of the asm disagree, the measured value wins - see the inward
-spiral below.
-
-| Sequence | Hardware | Was | Now |
-| --- | --- | --- | --- |
-| DoubleCircle wipe (wild, weak) | 10 x 3 = **30** | 40 | 30 |
-| Circle wipe (wild, strong) | 20 x 3 = **60** | 40 | 60 |
-| Spiral outward (trainer, strong) | 360 fills / 3 per frame = **120** | 40 | 120 |
-| Spiral inward (trainer, weak) | 7 tiles per `Delay3` = **~150** | 40 | 156 |
-| HStripes (dungeon wild, weak) | 20 x 3 = **60** | 24 | 60 |
-| VStripes (dungeon wild, strong) | 18 x 3 = **54** | 24 | 54 |
-| Shrink (dungeon trainer, weak) | 9 x 6 = **54** | 24 | 54 |
-| Split (dungeon trainer, strong) | 9 x 6 = **54** | 24 | 54 |
-| Flash before the circle wipes | 12 x 2 x 3 = **72** | 72 | 72 |
-| Black hold before the battle draws | not stated by pokered; ~30 floor, calibrated **60** | 30 | 60 |
-| Silhouette slide in | 144 px at 2 px/frame = **72** | 40 (160 px at 4 px/frame) | 72 |
-| Trainer intro, before balls + text | `WaitForSoundToFinish` + `DelayFrames 20` | 0 | sfx wait + 20 |
-
-The trainer intro's sound is `SFX_Silph_Scope`, extracted here as
-`Trainer_Appeared` (`tools/rom_manifest.json` `audio.sfxHeaders`, bank 8 /
-`$42bb`). It was being extracted and never played by anything. It now plays
-into a clear window: `PrintBeginningBattleText .trainerBattle` does
-`PlaySound` then `WaitForSoundToFinish`, which **blocks**, and only then
-`DelayFrames 20` before `DrawAllPokeballs` and the text. `BattleState`'s
-message queue grew a `waitSound` row for that, since `WaitForSoundToFinish`
-waits on the sound actually stopping rather than on a fixed frame count.
-
-**Scripted battles were skipping the transition entirely.** `BattleTransition`
-runs from `DoBattleTransitionAndInitBattleVariables`, which both
-`InitBattleCommon` (`core.asm:6680`, trainers) and `InitWildBattle` (`:6699`)
-call unconditionally - every battle on hardware enters through a wipe. In the
-port only `OverworldState:pushBattle` built one, and `Commands.start_battle`
-pushed the `BattleState` straight onto the stack. The trainer-*sight* path
-went through `pushBattle`, but every **script-driven** battle did not: gym
-leaders, the rival, Giovanni, and every scripted wild encounter cut straight
-to the battle screen with no transition at all. The catch tutorial
-(`old_man_demo`) had the same gap; `InitWildBattle` has no
-`BATTLE_TYPE_OLD_MAN` special case, so it gets a wipe too.
-
-**Beyond 160x144.** Both halves of the transition used to stop at the classic
-letterbox. The flash filled the 160x144 UI canvas, and the wipe handed the
-surrounding window a generic centre-out square cascade
-(`Renderer:drawBattleCascade`) regardless of which of the eight styles was
-running - so at any zoom a spiral read as "a spiral in a box, with something
-else happening around it".
-
-- The flash is a palette write (`rBGP`), and a palette register tints every
-  pixel the LCD shows; there is no "outside the screen" for it to miss. It is
-  now published to the renderer as a screen-space veil and painted over the
-  finished composite, so it covers the whole surface at any zoom.
-- The spiral and circle walks are now generated for whatever grid the window
-  works out to (`BattleTransition.gridOrder`), and the area outside the
-  letterbox is filled in that order instead of the square cascade. The
-  authentic 20x18 builders still own the letterbox itself, overrun and all,
-  so nothing changes at 1x. The generic builders are deliberately *not* the
-  ROM's walk - out there the hardware has no behaviour to be faithful to,
-  only a shape to continue.
-- `shrink`, `split` and the two stripe styles are plain geometry rather than
-  a tile order, so they keep the cascade for now. Extending them is
-  rectangles, not a walk, and has not been done.
-
-Note that the **flash is wild-only**: `BattleTransition_FlashScreen` is called
-from `BattleTransition_Circle` (`:585`) and `BattleTransition_DoubleCircle`
-(`:628`) and nowhere else. A trainer battle's transition is the spiral -
-inward against a weaker foe, outward against a stronger one
-(`wBattleTransitionSpiralDirection`, `:119-126`) - with no flash in front of
-it. The port's `flash` mapping was already correct; the transition simply
-never ran for those battles.
-
-Two of these deserve their reasoning recorded:
-
-**The inward spiral** writes one tile per iteration and calls
-`BattleTransition_TransferDelay3` every seventh tile. That helper is not a
-one-frame transfer - it is `ld a,1 / ldh [hAutoBGTransferEnabled] / call
-Delay3 / xor a / ldh [...]` (`battle_transitions.asm:619`), so the cadence is
-7 tiles per **three** frames. Reading it as one frame runs the whole wipe 3x
-too fast, ~46 frames against the ROM's ~150. pokered-c hit that exact bug and
-caught it on a live comparison.
-
-**The black hold** is not a number pokered states anywhere; it is incidental
-load cost that a modern port does not pay. The derivable floor is ~13 frames
-(`LoadHpBarAndStatusTilePatterns` 4, `LoadHudTilePatterns` 2, `ClearScreen`'s
-`Delay3` 3, the `DisableLCD` LY wait 1, `Delay3` after `EnableLCD` 3), but the
-two sprite decompressors (`UncompressSpriteFromDE` for the 7x7 front pic and
-`LoadPlayerBackPic`'s uncompress + `ScaleSpriteByTwo`) are bit-level RLE/delta
-decoders that cannot be cycle-counted from the asm at all. So the derivation
-bottoms out around 25-30 with an unbounded remainder. pokered-c set 60 by ear
-against the real ROM and marked it ~95% right rather than frame-matched. The
-credible range is 30-60; it should not be "corrected" down toward the floor on
-the strength of the derivation, because the omitted decompressors are exactly
-the unbounded part. Pinning it exactly wants a frame-by-frame capture.
-
-### Battle turns
-
-| Sequence | Hardware | Source | Port | Port source | Delta |
-| --- | --- | --- | --- | --- | --- |
-| Player HP bar drain of D HP over P pixels | **D + 2P + 6** | `engine/gfx/hp_bar.asm:81-135`, `:140-159`, `:234` | D + 2P + 6 | `src/battle/BattleState.lua` `stepHPDrain` | **fixed** |
-| Enemy HP bar drain over P pixels | **2P + 5** (no per-HP frame) | same, gated at `:207-209` | 2P + 5 | same | **fixed** |
-| Status move / missed move beat | **30** | `engine/battle/core.asm:3145,3158,3185-3186`; enemy `:5588` | 30 | `EffectRegistry` `missBeat`, `BattleState:performMove` | **fixed** |
-| Applying anim type 1, vertical shake b=8 | **48** | `animations.asm:500-503` | 48 | `BattleState:applyHitFx` | ok |
-| Applying anim type 2, fast horizontal b=8 | **72** | `animations.asm:505-508` | 72 | same | ok |
-| Applying anim type 3, slow horizontal 6,2 | **48** | `animations.asm:510-512,526-549` | 48 | same | ok |
-| Applying anim type 4, `AnimationBlinkMon` | **60** | `animations.asm:514-516`, `:1360-1376` | 60 | same | **fixed** |
-| Applying anim type 5, fast horizontal b=2 | **18** | `animations.asm:518-521` | 18 | same | ok |
-| Applying anim type 6, slow horizontal 3,2 | **24** | `animations.asm:523-525` | 24 | same | ok |
-| Faint slide-down | **14** (`PIC_HEIGHT` x `DelayFrames 2`) | `engine/battle/core.asm:1186-1222` | 14 | `BattleState:onFaint` | **fixed** |
-| Before every move animation | `Delay3` = **3** | `engine/battle/core.asm:6635-6640` | 3 | `BattleState:updateQueue` | **fixed** |
-| Battle start, after enemy send-out | **40** | `engine/battle/core.asm:152-156` | 40 | `BattleState:enter` | **fixed** |
-| Poison / burn / leech-seed tick | **20** | `engine/battle/core.asm:529-530` | 20 | `src/battle/BattleState.lua:1817` | **ok** |
-| Switch player mon | **50** | `engine/battle/core.asm:2421-2422` | 50 | `src/battle/BattleState.lua:1666-1668` | **ok** |
-| Post-hit hold (crit text or not) | **20** | `engine/battle/core.asm:3798-3814` | 20 | `EffectRegistry.runDamaging` | **fixed** |
-| Fainted mon slide-down | **2** per row | `engine/battle/core.asm:1216-1217` | - | - | unmeasured |
-| Trainer pic slide off | **2** per column | `engine/battle/core.asm:1267-1268` | - | - | unmeasured |
-| Trainer battle victory | **40** | `engine/battle/core.asm:940-941` | - | - | unmeasured |
-| Player blackout | **40** | `engine/battle/core.asm:1143-1144` | - | - | unmeasured |
-| No moves left (Struggle) | **60** | `engine/battle/core.asm:2753-2754` | - | - | unmeasured |
-| Send-out animation | `Delay3` + **4** + **5** | `engine/battle/core.asm:6814-6830` | - | - | unmeasured |
-
-The HP bar was the single largest battle divergence. `UpdateHPBar` steps **one
-HP point per loop iteration**; each iteration pays 1 frame in
-`UpdateHPBar_PrintHPNumber` whenever `wHPBarType != 0` - the player's own HUD
-and the party menu, but not the enemy HUD - plus 2 frames for each pixel the
-bar actually moves. The tail (`.animateHPBarDone`, `:132-135`) prints the
-number once more, animates one last pixel and falls into `Delay3`, so it costs
-6 frames player-side and 5 enemy-side.
-
-A 150 HP mon losing everything therefore costs 150 + 96 + 6 = **252 frames
-(4.2 s)** on the player's HUD, against 96 + 5 = 101 on the enemy's. The port
-used a flat `maxHP/96` - the enemy-side rate applied to both sides - and ran
-that same drain in 96 frames (1.6 s).
-
-## Tier 2 - frequent
-
-Status-effect failures (`engine/battle/effects.asm:161,1162,1205`) hold **50**
-frames each. `SwitchAndTeleportEffect` uses 50 and 20
-(`:834-901`). Evolution holds **50** then **40**
-(`engine/pokemon/evos_moves.asm:123,155`). The healing machine
-(`engine/overworld/healing_machine.asm`), item effects
-(`engine/items/item_effects.asm`, 259 frames across 8 sites), and the fishing
-animation (**10** then **100**, `engine/overworld/player_animations.asm:380,399`)
-are all in this tier.
-
-## Tier 3 - set pieces
-
-Highest total budgets in the scan, all seen rarely:
-`engine/movie/hall_of_fame.asm` (529 frames / 7 sites),
-`engine/link/cable_club.asm` (507 / 12), `engine/movie/credits.asm` (502 / 7),
-`engine/movie/trade.asm` (494 / 19), `engine/movie/intro.asm` (317 / 7),
-`engine/menus/main_menu.asm` (271 / 15), `engine/menus/save.asm` (250 / 3),
-`engine/battle/end_of_battle.asm` (200 / 1, the link-battle win/lose string).
-Several of these already have faithful implementations - see
-`src/ui/IntroMovie.lua`, `src/ui/Credits.lua`, `src/ui/HallOfFame.lua`, whose
-constants cite their asm sources directly.
-
-## Status
-
-Closed, and locked by `tests/engine/timing_parity.lua`:
-
-1. **Text page and CONT breaks** - were 0 frames where hardware spends 13-23,
-   on every page of every dialogue in the game. Now exact, including the
-   three-frame pre-input hold that swallows a mashed A.
-2. **Player HP bar drain** - was ~2.5x too fast on a typical mon. Now steps
-   one HP point at a time at the hardware rate, with the enemy HUD correctly
-   cheaper than the player's.
-3. **Warp fade** - was a symmetric 12/12; now 32 out and no fade in, which is
-   both the right duration and the right shape.
-4. **Yes/no answer** - was 0 frames where hardware spends 15, with the cursor
-   snapping to NO on B for the duration as `.choseSecondMenuItem` does.
-
-5. **Battle entry** - every wipe ran at a flat 40/24 against budgets of 30-156,
-   the silhouette slide was 40 frames against 72, the black hold was half
-   what pokered-c calibrated, and the trainer intro's 20-frame gap before the
-   balls and text was missing entirely. This was the single most compressed
-   stretch in the game.
-
-6. **Battle turns** - the type-4 blink ran at 20 frames against 60. That is
-   the applying animation for every plain damaging move the player uses, so
-   it was the single most-repeated timing error in the game. The 30-frame
-   beat that hardware spends on every status move and every miss was missing
-   entirely. The faint slide, unusually, ran *slower* than hardware (30
-   against 14).
-
-Two things worth recording about that last batch, because both contradict a
-plausible reading:
-
-- **`PrintCriticalOHKOText`'s 20-frame hold is not conditional.** The
-  "no critical hit" early-out at `core.asm:3799` jumps to `.done`, and
-  `.done` *is* the `ld c, 20 / jp DelayFrames`. Every landed hit pays it,
-  which is where the beat before "It's super effective!" comes from.
-- **`StartBattle`'s 40-frame hold is not conditional either.** The `call nz`
-  at `core.asm:154` gates only `EnemySendOutFirstMon`; the `DelayFrames 40`
-  under it runs for wild battles too, and it lands *between* the enemy's
-  send-out and `.playerSendOutFirstMon` (`:166`) rather than at the end of
-  the intro.
-
-Trainer victory (24-frame scroll-in + 40-frame hold) and the ball shake
-(`SFX_TINK` + `DelayFrames 40` per rock) were already correct -
-`BattleState.lua`'s `wait = 64` and `AnimPlayer.lua`'s `emit(40)`. Note that
-pokered-c's `BUI_TRAINER_VICTORY_SLIDE` comment calls the scroll-in 14
-frames; `_ScrollTrainerPicAfterBattle` is 6 loop passes of `DelayFrames 4`,
-so 24 is right and this port already had it.
-
-**Leaving a battle was a cut, not a fade.** `EnterMap` checks
-`BIT_BATTLE_OVER_OR_BLACKOUT` and calls `MapEntryAfterBattle`
-(`home/overworld.asm:22`), which is `GBFadeInFromWhite` - so the map fades up
-from white over 24 frames, behind the 10-frame hold at `:351-352`. The port
-popped the battle and the overworld was simply there. `Transition.battleReturn`
-supplies both halves, and steps the veil in three palette stages of 8 frames
-rather than tweening it, because `GBFadeIncCommon` writes a palette and holds
-it with `ld c, 8 / call DelayFrames` (`home/fade.asm:30-41`) three times over.
-
-It is wrapped around `battle.onFinish` in `OverworldState:pushBattle` - the
-one funnel every battle goes through - rather than living in `afterBattle`.
-That placement matters: a script-driven **win** defers `afterBattle` into
-`ctx.afterScript` so an evolution screen cannot be buried under the trainer's
-follow-up text (`Commands.start_battle`), and a fade inside `afterBattle`
-inherited that deferral. On a rival battle it fired after the post-battle
-dialogue *and* the rival's walk-off, rather than when the battle ended.
-
-The rest of `onFinish` runs as the fade's `onDone`, which is also the hardware
-order: `MapEntryAfterBattle` fades the map back in and only then does the map
-script run. The overworld is frozen meanwhile - `StateStack` updates the top
-state only - so nothing moves under the white.
-
-Hardware skips the fade on a dark map (`wMapPalOffset` nonzero takes the
-`LoadGBPal` branch at `:754`). This port has no `wMapPalOffset` equivalent -
-no map needs FLASH to be lit - so that branch is unreachable here;
-`battleReturn` accepts `opts.instant` for it if that ever changes.
-
-Still open, hardware number confirmed but not yet wired:
-
-- List menu open (10) and per-input redraw (`Delay3`).
-- Every battle-table row marked "unmeasured" above - the status/miss beat (30)
-  is the highest-exposure of them, since it is paid on every status move and
-  every miss.
-
-Entries marked "unmeasured" have confirmed hardware numbers but the port side
-has not been traced; they are remaining work, not known-good.

docs/updater.md

@@ -1,126 +0,0 @@
-# Updater
-
-A fused build (`love.filesystem.isFused()` true) ships a bundled `game.love`
-baked into the executable, but that bundled copy is only ever the *fallback*.
-On every launch, before anything else runs, `Boot.run` (`src/update/Boot.lua`)
-looks in the save directory's `updates/` folder for a downloaded
-`gen1recomp-X.Y.Z.love` payload that is both strictly newer than the bundled
-engine version and runnable on this shell. If one qualifies, it is mounted
-over `/` (so its files win over the fused source for every subsequent
-`require`) and chainloaded in place: the payload's `main.lua` and `love.load`
-run as if they had shipped in the executable. A dev/source checkout is never
-fused, so `Boot.run` no-ops there and the working tree always runs itself.
-
-The pieces are deliberately layered so the risky part is small. `Boot.select`
-is a pure function (no `love.*` calls) that, given probed candidates and the
-bundled `engine`/`shell`, decides what to run and what stale payloads to
-delete. `Boot.probePayload` mounts one archive at an isolated mountpoint and
-reads its `src/core/Version.lua` with `loadstring` (never `require`, so it is
-never cached as a module) to learn its `engine` and `minShell`. `Boot.run`
-orchestrates the crash guard, enumeration, selection, and the mount +
-chainload, with full rollback on any failure. Checking for and fetching a
-new payload is a separate, slower path: `src/update/Check.lua` is a thin
-main-thread state machine the launcher screen polls, while the curl calls,
-JSON parsing, and sha256 verification run on a background `love.thread`
-(`src/update/check_worker.lua`) so a hung network call never blocks a frame.
-
-## Version.lua fields
-
-`src/core/Version.lua` carries three fields the updater reads directly (the
-existing `modApi`, `linkProtocol`, `saveFormat`, and `cache` fields are
-untouched):
-
-- `engine` - the semver release, e.g. `"1.4.0"`. The repo default is the
-  `"0.0.0-dev"` placeholder; CI stamps the real `X.Y.Z` into the packed
-  `game.love` only, never the working tree. A `"0.0.0-dev"` engine always
-  reports itself up to date (it never chases a release, and it never counts
-  as a valid payload to chainload).
-- `shell` - the native-shell contract this build's fused executable
-  implements.
-- `minShell` - the lowest shell contract required to *run* this payload.
-
-Bump `minShell` only when a payload needs something the currently-shipped
-native shell cannot provide, for example a LOVE version bump, a new required
-system binary, or a change to `love.run` itself (see Known limitations
-below). An older shell refuses to chainload a payload whose `minShell`
-exceeds the shell it provides; `Boot.select` keeps that payload in `updates/`
-rather than deleting it, in case a future shell upgrade can run it, and
-`Check`'s worker reports `needs_full` so the player is pointed at a full
-installer instead. Do not bump `minShell` for an ordinary Lua/data release;
-that is exactly the case the updater exists to avoid a reinstall for.
-
-## Release assets
-
-Each tagged release `vX.Y.Z` carries the existing per-platform archives
-(`gen1recomp-X.Y.Z-macos.zip`, `-windows.zip`, `-linux.zip`,
-`-android.apk`) plus two assets the updater itself consumes:
-
-- `gen1recomp-X.Y.Z.love` - the payload, matched by the exact pattern
-  `gen1recomp-<version>.love` (see `isPayloadName` in `Boot.lua` and
-  `Check.parseRelease`).
-- `sha256sums.txt` - `shasum -a 256` output (`<hex>  <filename>`, bare
-  filenames) covering at least the `.love` payload. `Check.parseSums`
-  tolerates a leading `*` binary marker and a `./` prefix but expects the
-  filename otherwise to match the asset name exactly.
-
-A release missing either asset is treated as "no in-place update available":
-`Check` reports `needs_full` and sends the player to `Check.releaseUrl()`
-(`https://github.com/bryanthaboi/gen1recomp/releases/latest`).
-
-## Save-directory layout
-
-Under the save directory (identity `pokemon-love2d`):
-
-```
-updates/gen1recomp-<X.Y.Z>.love   downloaded payload(s)
-updates/pending.txt                crash-guard marker
-```
-
-`pending.txt` holds the filename of the payload currently being chainloaded.
-`Boot.run`'s `chainload` writes it immediately before mounting, and removes it
-on both a successful handoff and a clean rollback. If it is still present the
-*next* time `Boot.run` starts, the previous boot died mid-handoff, so that
-named payload is distrusted: it and the marker are deleted before candidates
-are enumerated. Boot may still fall back to an older valid payload, or to the
-bundled game, in that case.
-
-## Update flow
-
-1. **Boot** (every launch, fused builds only): crash-guard check, enumerate
-   and probe every `updates/*.love`, pick the highest engine that is
-   strictly newer than the bundled one and whose `minShell` this shell
-   satisfies, delete stale payloads, chainload the winner (or run the
-   bundled game if none qualifies).
-2. **Check** (launcher screen): `Check.start()` kicks off an async check
-   against the GitHub releases API; safe to call every frame, it is a no-op
-   once a check is in flight or has reached a terminal state. `Check.state()`
-   reports `idle | checking | uptodate | available | downloading | ready |
-   needs_full | error` plus the latest version and download progress.
-3. **Download + verify**: on `available`, `Check.download()` tells the
-   worker to fetch the payload, polling the growing `.part` file for
-   progress. On completion the worker re-fetches `sha256sums.txt`, verifies
-   the payload's sha256, and probes it with `Boot.probePayload` to gate its
-   `minShell` against this shell's `shell`. A verified, runnable payload is
-   renamed into place and reported as `ready`; anything else reports
-   `error` or `needs_full` and leaves `updates/` clean.
-4. **Restart to apply**: a `ready` payload just sits in `updates/` until the
-   player relaunches; the next launch's Boot step (1) is what actually
-   mounts and runs it. There is no in-session hot-swap.
-
-## Known limitations
-
-- **`love.run` persists across handoff.** By the time `chainload` runs, the
-  bundled `love.run` has already returned its stepper to LOVE; redefining the
-  global `love.run` from the payload's `main.lua` does not affect the loop
-  already driving the frame. A payload that must change `love.run` itself
-  needs a `minShell` bump so an older shell refuses to chainload it rather
-  than running with half its intended behavior.
-- **Android has no in-app download transport yet.** `check_worker.lua`
-  shells out to curl for both the release check and the download; curl is
-  absent on Android, so `Check` degrades to `status = "error"` there (the
-  launcher UI hides on that status) and the player is directed to the
-  releases page via `Check.releaseUrl()` instead.
-- **Dev/source runs never self-update.** `Boot.run` returns immediately when
-  `love.filesystem.isFused()` is false, and a working tree's `engine` is the
-  `"0.0.0-dev"` placeholder that always reports up to date, so a source
-  checkout is always "the game" itself; updating it means pulling the repo.

install-rg34xxsp.sh

@@ -1,93 +0,0 @@
-#!/usr/bin/env bash
-# After first boot of the freshly flashed Stock OS Mod, reinsert the SD card
-# and run this to install gen1recomp + Red/Blue ROMs into roms/PORTS.
-set -euo pipefail
-
-ROOT="$(cd "$(dirname "$0")" && pwd)"
-STAGE="$ROOT/.bazinga/work/rg34xxsp-install"
-DECPREP="$(cd "$ROOT/../decprep" && pwd)"
-ZIP="$ROOT/dist/rg34xxsp/gen1recomp-rg34xxsp.zip"
-
-say()  { printf '\033[1;32m==>\033[0m %s\n' "$*"; }
-fail() { printf '\033[1;31merror:\033[0m %s\n' "$*" >&2; exit 1; }
-
-# Find the Anbernic user/ROMs volume (usually "NO NAME" after first-boot expand).
-find_roms_root() {
-  local v candidate
-  for v in /Volumes/*; do
-    [ -d "$v" ] || continue
-    # Prefer a volume that already has Roms/ or PORTS/
-    if [ -d "$v/Roms" ] || [ -d "$v/roms" ] || [ -d "$v/PORTS" ] || [ -d "$v/ports" ]; then
-      echo "$v"
-      return 0
-    fi
-  done
-  # Fallback: large FAT volume named NO NAME on disk8
-  for v in "/Volumes/NO NAME" /Volumes/NO\ NAME /Volumes/ROMS /Volumes/EASYROMS; do
-    if [ -d "$v" ]; then
-      echo "$v"
-      return 0
-    fi
-  done
-  return 1
-}
-
-say "looking for Anbernic ROMs volume"
-ROMS_ROOT="$(find_roms_root)" || fail "no ROMs volume mounted. Boot the RG34XXSP once (wait for first-boot setup), power off, reinsert the SD, then rerun."
-
-say "using: $ROMS_ROOT"
-# Resolve PORTS dir (stock uses Roms/PORTS)
-if [ -d "$ROMS_ROOT/Roms/PORTS" ]; then
-  PORTS="$ROMS_ROOT/Roms/PORTS"
-elif [ -d "$ROMS_ROOT/roms/PORTS" ]; then
-  PORTS="$ROMS_ROOT/roms/PORTS"
-elif [ -d "$ROMS_ROOT/Roms/ports" ]; then
-  PORTS="$ROMS_ROOT/Roms/ports"
-elif [ -d "$ROMS_ROOT/PORTS" ]; then
-  PORTS="$ROMS_ROOT/PORTS"
-else
-  mkdir -p "$ROMS_ROOT/Roms/PORTS"
-  PORTS="$ROMS_ROOT/Roms/PORTS"
-fi
-say "PORTS: $PORTS"
-
-# Refresh staged payload
-mkdir -p "$STAGE/PORTS"
-if [ -f "$ZIP" ]; then
-  rm -rf "$STAGE/PORTS/Gen1recomp.sh" "$STAGE/PORTS/gen1recomp" "$STAGE/PORTS/port.json" \
-    "$STAGE/PORTS/gameinfo.xml" "$STAGE/PORTS/README.md"
-  unzip -q -o "$ZIP" -d "$STAGE/PORTS"
-else
-  fail "missing $ZIP — run ./build-rg34xxsp.sh first"
-fi
-
-# Ensure ROMs are in lovegame (Choose ROM scans this folder on stock OS)
-[ -f "$DECPREP/Pokemon - Red Version.gb" ] || fail "missing Red ROM in $DECPREP"
-[ -f "$DECPREP/Pokemon - Blue Version.gb" ] || fail "missing Blue ROM in $DECPREP"
-cp -f "$DECPREP/Pokemon - Red Version.gb" "$STAGE/PORTS/gen1recomp/lovegame/"
-cp -f "$DECPREP/Pokemon - Blue Version.gb" "$STAGE/PORTS/gen1recomp/lovegame/"
-
-say "copying gen1recomp port"
-rm -rf "$PORTS/gen1recomp" "$PORTS/Gen1recomp.sh"
-cp -R "$STAGE/PORTS/gen1recomp" "$PORTS/"
-cp -f "$STAGE/PORTS/Gen1recomp.sh" "$PORTS/"
-cp -f "$STAGE/PORTS/port.json" "$PORTS/gen1recomp/" 2>/dev/null || true
-cp -f "$STAGE/PORTS/README.md" "$PORTS/gen1recomp/" 2>/dev/null || true
-chmod +x "$PORTS/Gen1recomp.sh" "$PORTS/gen1recomp/bin/love.aarch64"
-
-# Also drop carts in the stock GB folder for the emulator library
-GB_DIR=""
-for candidate in "$ROMS_ROOT/Roms/GB" "$ROMS_ROOT/roms/GB" "$ROMS_ROOT/Roms/gb"; do
-  if [ -d "$candidate" ]; then GB_DIR="$candidate"; break; fi
-done
-if [ -n "$GB_DIR" ]; then
-  say "copying .gb into $GB_DIR"
-  cp -f "$DECPREP/Pokemon - Red Version.gb" "$GB_DIR/"
-  cp -f "$DECPREP/Pokemon - Blue Version.gb" "$GB_DIR/"
-fi
-
-sync
-say "installed:"
-ls -lh "$PORTS/Gen1recomp.sh"
-ls -lh "$PORTS/gen1recomp/lovegame/"*.gb
-say "eject the SD, insert TF1 in the RG34XXSP, open Ports → Gen1recomp, Choose ROM."

libs/flexlove/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2025 Mike Freno
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

libs/flexlove/modules/Behavior.lua

@@ -1,188 +0,0 @@
--- modules/Behavior.lua
---
--- Base module for the pluggable behavior system that drives the Behavior &
--- Mode Unification refactor.
---
--- A *behavior* is a small, stateless table produced by `Behavior.new(spec)`
--- that implements a fixed lifecycle hook set. Concrete behaviors (Clickable,
--- Scrollable, TextEditable, Selectable, ...) each live in their own module and
--- are attached to an Element. The Element's `update`/`draw`/save-restore paths
--- iterate `element.behaviors` and dispatch to the appropriate hooks, replacing
--- the swarm of `if self.scrollable` / immediate-mode-branch checks previously
--- hard-coded in Element.lua.
---
--- Element.new iterates a registry of behavior prototypes and auto-attaches
--- whichever return true from `shouldAttach(props)`. Element therefore never
--- needs to know what an individual behavior does — only that it conforms to
--- this interface.
---
--- Design constraints (locked — tasks 02-13 depend on this API):
---   * Pure Lua — NO `love` import, NO dependency on utils/Color/Units/ErrorHandler.
---     Stays fully stub-testable standalone (see testing/__tests__/behavior_test.lua).
---   * Minimal interface — exactly 6 lifecycle hooks + a `shouldAttach` predicate.
---     Do NOT add hooks "just in case"; new capabilities become new behaviors,
---     not new hooks. Extending HOOK_NAMES is an architectural decision that must
---     be mirrored by every concrete behavior.
---   * Immutable instances — behavior tables are produced once and treated as
---     read-only. Per-element runtime state lives on the element (or a subsystem
---     the behavior attaches), NEVER on the behavior instance itself, so a single
---     behavior instance can be shared across many elements.
---
--- Lifecycle hook contract (each receives the owning element as first argument):
---   onAttach(element)               — called once when the behavior is attached
---                                     (element fully constructed). Allocate
---                                     subsystems / register listeners here.
---   onDetach(element)               — called once when the behavior is detached
---                                     (element destroyed / mode switch). Tear
---                                     down anything onAttach created.
---   onUpdate(element, dt)           — called every frame from Element:update.
---   onDraw(element, ctx)            — called every frame from Element:draw; `ctx`
---                                     is the draw context (viewport transform,
---                                     scissor state, theme renderer, ...).
---   saveState(element) -> state     — called during Element save-state; returns
---                                     a serializable snapshot (or nil) so the
---                                     behavior's runtime state survives the
---                                     immediate-mode recreation cycle.
---   restoreState(element, state)   — called after reconstruction with the
---                                     snapshot previously returned by saveState.
---
--- shouldAttach(props) -> boolean    — class-level predicate (not a hook): given
---                                     an element's props table, return true if
---                                     this behavior should be auto-attached.
---                                     Defaults to false (opt-in).
-
---- A behavior instance: a frozen table of lifecycle hooks + a shouldAttach
---- predicate. All hooks are always present (custom override or no-op default).
----@class Behavior
----@field onAttach fun(element:table)
----@field onDetach fun(element:table)
----@field onUpdate fun(element:table, dt:number)
----@field onDraw fun(element:table, ctx:table)
----@field saveState fun(element:table):any
----@field restoreState fun(element:table, state:any)
----@field shouldAttach fun(props:table):boolean
-
-local Behavior = {}
-
--- The fixed, ordered lifecycle hook set. Order is preserved so downstream tasks
--- (Element behavior iteration) can rely on a deterministic dispatch sequence.
--- HOOK_NAMES is intentionally NOT extended casually — see file header.
-Behavior.HOOK_NAMES = {
-  "onAttach",
-  "onDetach",
-  "onUpdate",
-  "onDraw",
-  "saveState",
-  "restoreState",
-}
-
--- Allowlist of spec keys accepted by Behavior.new. Anything else is rejected so
--- a typo (e.g. `onUpdat`) surfaces immediately instead of silently no-op'ing.
--- Hook keys (HOOK_NAMES + shouldAttach) MUST be functions; metadata keys
--- (drawLayer) may hold any value.
-local ALLOWED_KEYS = {
-  onAttach = true,
-  onDetach = true,
-  onUpdate = true,
-  onDraw = true,
-  saveState = true,
-  restoreState = true,
-  shouldAttach = true,
-  drawLayer = true,
-}
-
--- Spec keys whose values are NOT required to be functions (passive metadata
--- consumed by dispatch sites, e.g. Element:draw's pre/post-children split).
-local NON_FUNCTION_KEYS = {
-  drawLayer = true,
-}
-
--- Default no-op hook. Behaviors override only the hooks they need; every other
--- hook resolves to this so dispatch sites never have to nil-check.
-local function noop() end
-
--- Default shouldAttach predicate: never auto-attach unless the behavior opts in
--- by providing its own predicate. This is the safe default — a behavior with no
--- opinion about which elements it applies to stays inert in the auto-attach
--- pass (it can still be attached explicitly by name in a later task).
-local function defaultShouldAttach()
-  return false
-end
-
--- Module-level default predicate exposed for callers/tests that want to
--- reference the base default directly without constructing an instance.
-Behavior.shouldAttach = defaultShouldAttach
-
---- Factory: create a frozen behavior instance from a spec table.
----
---- `spec` is a table whose keys may be any subset of the 6 lifecycle hook names
---- plus `shouldAttach`; each value (when present) must be a function. The
---- returned table contains every lifecycle hook (custom override OR no-op) and
---- a `shouldAttach` predicate (custom OR always-false default), so dispatch
---- sites can call any hook unconditionally without nil-checking.
----
---- Unknown spec keys and non-function values raise an error immediately so
---- mistakes fail fast at construction rather than as silent no-ops later.
----
----@param spec table|nil spec table overriding select hooks / shouldAttach
----@return Behavior
-function Behavior.new(spec)
-  spec = spec or {}
-
-  -- Validate spec keys up front so typos surface here, not as silent no-ops.
-  for key, value in pairs(spec) do
-    if not ALLOWED_KEYS[key] then
-      error(string.format("Behavior.new: unknown spec key '%s'", tostring(key)), 2)
-    end
-    if not NON_FUNCTION_KEYS[key] and type(value) ~= "function" then
-      error(string.format("Behavior.new: spec key '%s' must be a function, got %s", tostring(key), type(value)), 2)
-    end
-  end
-
-  local instance = {}
-
-  -- Populate every lifecycle hook: custom override when provided, no-op default
-  -- otherwise. Guarantees `instance.hook` is always callable.
-  for _, hook in ipairs(Behavior.HOOK_NAMES) do
-    instance[hook] = spec[hook] or noop
-  end
-
-  -- shouldAttach defaults to always-false; behaviors opt in by supplying one.
-  instance.shouldAttach = spec.shouldAttach or defaultShouldAttach
-
-  -- drawLayer: optional metadata field (default nil = "background"/pre-children).
-  -- Dispatch sites (Element:draw) use it to split rendering into pre-children
-  -- (background layers) and post-children (overlay layers, e.g. scrollbars).
-  instance.drawLayer = spec.drawLayer
-
-  -- Freeze: prevent adding new fields. Behavior instances are shared, stateless
-  -- objects; runtime state belongs on the element, never on the behavior.
-  -- (Reassigning an existing hook is still possible via direct index write —
-  -- Lua metatables cannot intercept that — but the freeze communicates intent
-  -- and catches accidental field additions.)
-  local mt = {
-    __newindex = function(_, key)
-      error(string.format("Behavior: behavior instances are immutable (cannot set '%s')", tostring(key)), 2)
-    end,
-    --- Mark the metatable so consumers can detect a Behavior instance.
-    ---@return string
-    __tostring = function()
-      return "Behavior"
-    end,
-    __metatable = "Behavior",
-  }
-  setmetatable(instance, mt)
-
-  return instance
-end
-
---- Type guard: returns true if `value` is a Behavior instance produced by
---- `Behavior.new`. Used by Element's attach path to validate registry entries
---- without depending on identity.
----@param value any
----@return boolean
-function Behavior.isBehavior(value)
-  return type(value) == "table" and getmetatable(value) == "Behavior"
-end
-
-return Behavior

libs/flexlove/modules/Blur.lua

@@ -1,686 +0,0 @@
--- Lua 5.2+ compatibility for unpack
-local unpack = table.unpack or unpack
-
--- Warning cache to prevent duplicate warnings for the same element
-local warningCache = {}
-
-local Cache = {
-  canvases = {},
-  quads = {},
-  blurInstances = {}, -- Cache blur instances by quality
-  blurredCanvases = {}, -- Cache pre-blurred canvases for immediate mode
-  MAX_CANVAS_SIZE = 20,
-  MAX_QUAD_SIZE = 20,
-  MAX_BLURRED_CANVAS_CACHE = 50, -- Maximum cached blurred canvases
-  RADIUS_THRESHOLD = 0.5, -- Skip blur below this radius
-  LARGE_BLUR_THRESHOLD = 250 * 250, -- Warn if blur area exceeds this (250x250px)
-}
-
---- Round canvas size to nearest bucket for better reuse
----@param size number Size to bucket
----@return number bucketSize Bucketed size
-local function bucketSize(size)
-  if size <= 128 then
-    return math.ceil(size / 32) * 32
-  elseif size <= 512 then
-    return math.ceil(size / 64) * 64
-  elseif size <= 1024 then
-    return math.ceil(size / 128) * 128
-  else
-    return math.ceil(size / 256) * 256
-  end
-end
-
---- Get or create a canvas from cache
----@param width number Canvas width
----@param height number Canvas height
----@return love.Canvas canvas The cached or new canvas
-function Cache.getCanvas(width, height)
-  -- Use bucketed sizes for better cache reuse
-  local bucketedWidth = bucketSize(width)
-  local bucketedHeight = bucketSize(height)
-  local key = string.format("%dx%d", bucketedWidth, bucketedHeight)
-
-  if not Cache.canvases[key] then
-    Cache.canvases[key] = {}
-  end
-
-  local cache = Cache.canvases[key]
-
-  for i, entry in ipairs(cache) do
-    if not entry.inUse then
-      entry.inUse = true
-      return entry.canvas
-    end
-  end
-
-  local canvas = love.graphics.newCanvas(bucketedWidth, bucketedHeight)
-  table.insert(cache, { canvas = canvas, inUse = true })
-
-  if #cache > Cache.MAX_CANVAS_SIZE then
-    local removed = table.remove(cache, 1)
-    if removed and removed.canvas then
-      removed.canvas:release()
-    end
-  end
-
-  return canvas
-end
-
---- Release a canvas back to the cache
----@param canvas love.Canvas Canvas to release
-function Cache.releaseCanvas(canvas)
-  for _, sizeCache in pairs(Cache.canvases) do
-    for _, entry in ipairs(sizeCache) do
-      if entry.canvas == canvas then
-        entry.inUse = false
-        return
-      end
-    end
-  end
-end
-
---- Get or create a quad from cache
----@param x number X position
----@param y number Y position
----@param width number Quad width
----@param height number Quad height
----@param sw number Source width
----@param sh number Source height
----@return love.Quad quad The cached or new quad
-function Cache.getQuad(x, y, width, height, sw, sh)
-  local key = string.format("%d,%d,%d,%d,%d,%d", x, y, width, height, sw, sh)
-
-  if not Cache.quads[key] then
-    Cache.quads[key] = {}
-  end
-
-  local cache = Cache.quads[key]
-
-  for i, entry in ipairs(cache) do
-    if not entry.inUse then
-      entry.inUse = true
-      return entry.quad
-    end
-  end
-
-  local quad = love.graphics.newQuad(x, y, width, height, sw, sh)
-  table.insert(cache, { quad = quad, inUse = true })
-
-  if #cache > Cache.MAX_QUAD_SIZE then
-    table.remove(cache, 1)
-  end
-
-  return quad
-end
-
---- Release a quad back to the cache
----@param quad love.Quad Quad to release
-function Cache.releaseQuad(quad)
-  for _, keyCache in pairs(Cache.quads) do
-    for _, entry in ipairs(keyCache) do
-      if entry.quad == quad then
-        entry.inUse = false
-        return
-      end
-    end
-  end
-end
-
---- Generate cache key for blurred canvas
----@param elementId string Element ID
----@param x number X position
----@param y number Y position
----@param width number Width
----@param height number Height
----@param radius number Blur radius
----@param quality number Blur quality
----@param isBackdrop boolean Whether this is backdrop blur
----@return string key Cache key
-function Cache.generateBlurCacheKey(elementId, x, y, width, height, radius, quality, isBackdrop)
-  return string.format(
-    "%s:%d:%d:%d:%d:%.1f:%d:%s",
-    elementId,
-    x,
-    y,
-    width,
-    height,
-    radius,
-    quality,
-    tostring(isBackdrop)
-  )
-end
-
---- Get cached blurred canvas
----@param key string Cache key
----@return love.Canvas|nil canvas Cached canvas or nil
-function Cache.getBlurredCanvas(key)
-  local entry = Cache.blurredCanvases[key]
-  if entry then
-    entry.lastUsed = os.time()
-    return entry.canvas
-  end
-  return nil
-end
-
---- Store blurred canvas in cache
----@param key string Cache key
----@param canvas love.Canvas Canvas to cache
-function Cache.setBlurredCanvas(key, canvas)
-  -- Limit cache size
-  local count = 0
-  for _ in pairs(Cache.blurredCanvases) do
-    count = count + 1
-  end
-
-  if count >= Cache.MAX_BLURRED_CANVAS_CACHE then
-    -- Remove oldest entry
-    local oldestKey = nil
-    local oldestTime = math.huge
-    for k, v in pairs(Cache.blurredCanvases) do
-      if v.lastUsed < oldestTime then
-        oldestTime = v.lastUsed
-        oldestKey = k
-      end
-    end
-
-    if oldestKey then
-      if Cache.blurredCanvases[oldestKey].canvas then
-        Cache.blurredCanvases[oldestKey].canvas:release()
-      end
-      Cache.blurredCanvases[oldestKey] = nil
-    end
-  end
-
-  Cache.blurredCanvases[key] = {
-    canvas = canvas,
-    lastUsed = os.time(),
-  }
-end
-
---- Clear blurred canvas cache for specific element
----@param elementId string Element ID to clear cache for
-function Cache.clearBlurredCanvasesForElement(elementId)
-  for key, entry in pairs(Cache.blurredCanvases) do
-    if key:match("^" .. elementId .. ":") then
-      if entry.canvas then
-        entry.canvas:release()
-      end
-      Cache.blurredCanvases[key] = nil
-    end
-  end
-end
-
---- Clear all caches
-function Cache.clear()
-  -- Release all blurred canvases
-  for _, entry in pairs(Cache.blurredCanvases) do
-    if entry.canvas then
-      entry.canvas:release()
-    end
-  end
-
-  Cache.canvases = {}
-  Cache.quads = {}
-  Cache.blurInstances = {}
-  Cache.blurredCanvases = {}
-  warningCache = {} -- Clear warning cache on cache clear
-end
-
--- ============================================================================
--- SHADER BUILDER
--- ============================================================================
-
-local ShaderBuilder = {}
-
---- Build Gaussian blur shader with given parameters
----@param taps number Number of samples (must be odd, >= 3)
----@param offset number Offset value
----@param offsetType string "weighted" or "center"
----@param sigma number Sigma value for Gaussian distribution
----@return love.Shader shader The compiled blur shader
-function ShaderBuilder.build(taps, offset, offsetType, sigma)
-  taps = math.floor(taps)
-  sigma = sigma >= 1 and sigma or (taps - 1) * offset / 6
-  sigma = math.max(sigma, 1)
-
-  local steps = (taps + 1) / 2
-
-  local gOffsets = {}
-  local gWeights = {}
-  for i = 1, steps do
-    gOffsets[i] = offset * (i - 1)
-    gWeights[i] = math.exp(-0.5 * (gOffsets[i] - 0) ^ 2 * 1 / sigma ^ 2)
-  end
-
-  local offsets = {}
-  local weights = {}
-  for i = #gWeights, 2, -2 do
-    local oA, oB = gOffsets[i], gOffsets[i - 1]
-    local wA, wB = gWeights[i], gWeights[i - 1]
-    wB = oB == 0 and wB / 2 or wB
-    local weight = wA + wB
-    offsets[#offsets + 1] = offsetType == "center" and (oA + oB) / 2 or (oA * wA + oB * wB) / weight
-    weights[#weights + 1] = weight
-  end
-
-  local code = {
-    [[
-    extern vec2 direction;
-    vec4 effect(vec4 color, Image tex, vec2 tc, vec2 sc) {]],
-  }
-
-  local norm = 0
-  if #gWeights % 2 == 0 then
-    code[#code + 1] = "vec4 c = vec4( 0.0 );"
-  else
-    local weight = gWeights[1]
-    norm = norm + weight
-    code[#code + 1] = string.format("vec4 c = %f * texture2D(tex, tc);", weight)
-  end
-
-  local template = "c += %f * ( texture2D(tex, tc + %f * direction)+ texture2D(tex, tc - %f * direction));\n"
-  for i = 1, #offsets do
-    local offset = offsets[i]
-    local weight = weights[i]
-    norm = norm + weight * 2
-    code[#code + 1] = string.format(template, weight, offset, offset)
-  end
-  code[#code + 1] = string.format("return c * vec4(%f) * color; }", 1 / norm)
-
-  local shaderCode = table.concat(code)
-  return love.graphics.newShader(shaderCode)
-end
-
---- Get or create a blur instance from cache
----@param quality number Quality level (1-10)
----@return table blurData Cached blur data {shader, taps}
-function Cache.getBlurInstance(quality)
-  if not Cache.blurInstances[quality] then
-    local taps = 3 + (quality - 1) * 1.5
-    taps = math.floor(taps)
-    if taps % 2 == 0 then
-      taps = taps + 1
-    end
-
-    local shader = ShaderBuilder.build(taps, 1.0, "weighted", -1)
-    Cache.blurInstances[quality] = {
-      shader = shader,
-      taps = taps,
-    }
-  end
-
-  return Cache.blurInstances[quality]
-end
-
----@class BlurProps
----@field quality number? Quality level (1-10, default: 5)
-
----@class Blur
----@field shader love.Shader The blur shader
----@field quality number Quality level (1-10)
----@field taps number Number of shader taps
----@field _ErrorHandler table? Reference to ErrorHandler module
-local Blur = {}
-Blur.__index = Blur
-
---- Check if we should warn about large blur area in immediate mode
----@param elementId string|nil Element ID for caching warnings
----@param width number Blur area width
----@param height number Blur area height
----@param blurType string "content" or "backdrop"
-local function checkLargeBlurWarning(elementId, width, height, blurType)
-  -- Skip if no ErrorHandler available
-  if not Blur._ErrorHandler then
-    return
-  end
-
-  -- Skip if not in immediate mode
-  if not Blur._blurOptimizations then
-    return
-  end
-
-  -- Calculate blur area
-  local area = width * height
-
-  -- Skip if area is below threshold
-  if area <= Cache.LARGE_BLUR_THRESHOLD then
-    return
-  end
-
-  -- Generate warning key (use elementId if available, otherwise use dimensions)
-  local warningKey = elementId or string.format("%dx%d:%s", width, height, blurType)
-
-  -- Skip if already warned for this element/area
-  if warningCache[warningKey] then
-    return
-  end
-
-  -- Mark as warned
-  warningCache[warningKey] = true
-
-  -- Issue warning
-  local message =
-    string.format("Large %s blur area detected (%dx%d = %d pixels) in immediate mode", blurType, width, height, area)
-
-  local suggestion =
-    "Consider using retained mode for this component to avoid recreating blur effects every frame. Large blur operations are expensive and can cause performance issues in immediate mode."
-
-  Blur._ErrorHandler:warn("Blur", "PERF_003", {
-    area = string.format("%.0fx%.0f", width or 0, height or 0),
-  })
-end
-
---- Create a new blur effect instance
----@param props BlurProps? Blur configuration
----@return Blur blur The new blur instance
-function Blur.new(props)
-  props = props or {}
-
-  local quality = props.quality or 5
-  quality = math.max(1, math.min(10, quality))
-
-  -- Get cached blur instance for this quality level
-  local blurData = Cache.getBlurInstance(quality)
-
-  local self = setmetatable({}, Blur)
-  self.shader = blurData.shader
-  self.quality = quality
-  self.taps = blurData.taps
-
-  return self
-end
-
---- Apply blur to a region of the screen
----@param radius number Blur radius in pixels
----@param x number X position
----@param y number Y position
----@param width number Width of region
----@param height number Height of region
----@param drawFunc function Function to draw content to be blurred
-function Blur:applyToRegion(radius, x, y, width, height, drawFunc)
-  if type(drawFunc) ~= "function" then
-    if Blur._ErrorHandler then
-      Blur._ErrorHandler:warn("Blur", "BLUR_001")
-    end
-    return
-  end
-
-  if radius <= 0 or width <= 0 or height <= 0 then
-    drawFunc()
-    return
-  end
-
-  -- Early exit for very low radius (optimization)
-  if radius < Cache.RADIUS_THRESHOLD then
-    drawFunc()
-    return
-  end
-
-  -- Check for large blur area in immediate mode
-  checkLargeBlurWarning(nil, width, height, "content")
-
-  -- Calculate offset multiplier based on radius and quality
-  -- Higher quality = more samples = smaller steps for same radius
-  local offsetMultiplier = radius / self.quality
-
-  local canvas1 = Cache.getCanvas(width, height)
-  local canvas2 = Cache.getCanvas(width, height)
-
-  local prevCanvas = love.graphics.getCanvas()
-  local prevShader = love.graphics.getShader()
-  local prevColor = { love.graphics.getColor() }
-  local prevBlendMode = love.graphics.getBlendMode()
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  love.graphics.push()
-  love.graphics.origin()
-  love.graphics.translate(-x, -y)
-  drawFunc()
-  love.graphics.pop()
-
-  love.graphics.setShader(self.shader)
-  love.graphics.setColor(1, 1, 1, 1)
-  love.graphics.setBlendMode("alpha", "premultiplied")
-
-  -- Single pass with radius-controlled offset
-  love.graphics.setCanvas(canvas2)
-  love.graphics.clear()
-  self.shader:send("direction", { offsetMultiplier / width, 0 })
-  love.graphics.draw(canvas1, 0, 0)
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  self.shader:send("direction", { 0, offsetMultiplier / height })
-  love.graphics.draw(canvas2, 0, 0)
-
-  love.graphics.setCanvas(prevCanvas)
-  love.graphics.setShader()
-  love.graphics.setBlendMode(prevBlendMode)
-  love.graphics.draw(canvas1, x, y)
-
-  love.graphics.setShader(prevShader)
-  love.graphics.setColor(unpack(prevColor))
-
-  Cache.releaseCanvas(canvas1)
-  Cache.releaseCanvas(canvas2)
-end
-
---- Apply backdrop blur effect (blur content behind a region)
----@param radius number Blur radius in pixels
----@param x number X position
----@param y number Y position
----@param width number Width of region
----@param height number Height of region
----@param backdropCanvas love.Canvas Canvas containing the backdrop content
-function Blur:applyBackdrop(radius, x, y, width, height, backdropCanvas)
-  if not backdropCanvas then
-    if Blur._ErrorHandler then
-      Blur._ErrorHandler:warn("Blur", "BLUR_002")
-    end
-    return
-  end
-
-  if radius <= 0 or width <= 0 or height <= 0 then
-    return
-  end
-
-  -- Early exit for very low radius (optimization)
-  if radius < Cache.RADIUS_THRESHOLD then
-    return
-  end
-
-  -- Calculate offset multiplier based on radius and quality
-  local offsetMultiplier = radius / self.quality
-
-  local canvas1 = Cache.getCanvas(width, height)
-  local canvas2 = Cache.getCanvas(width, height)
-
-  local prevCanvas = love.graphics.getCanvas()
-  local prevShader = love.graphics.getShader()
-  local prevColor = { love.graphics.getColor() }
-  local prevBlendMode = love.graphics.getBlendMode()
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  love.graphics.setColor(1, 1, 1, 1)
-  love.graphics.setBlendMode("alpha", "premultiplied")
-
-  local backdropWidth, backdropHeight = backdropCanvas:getDimensions()
-  local quad = Cache.getQuad(x, y, width, height, backdropWidth, backdropHeight)
-  love.graphics.draw(backdropCanvas, quad, 0, 0)
-
-  love.graphics.setShader(self.shader)
-
-  -- Single pass with radius-controlled offset
-  love.graphics.setCanvas(canvas2)
-  love.graphics.clear()
-  self.shader:send("direction", { offsetMultiplier / width, 0 })
-  love.graphics.draw(canvas1, 0, 0)
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  self.shader:send("direction", { 0, offsetMultiplier / height })
-  love.graphics.draw(canvas2, 0, 0)
-
-  love.graphics.setCanvas(prevCanvas)
-  love.graphics.setShader()
-  love.graphics.setBlendMode(prevBlendMode)
-  love.graphics.draw(canvas1, x, y)
-
-  love.graphics.setShader(prevShader)
-  love.graphics.setColor(unpack(prevColor))
-
-  Cache.releaseCanvas(canvas1)
-  Cache.releaseCanvas(canvas2)
-  Cache.releaseQuad(quad)
-end
-
---- Get the current quality level
----@return number quality Quality level (1-10)
-function Blur:getQuality()
-  return self.quality
-end
-
---- Get the number of shader taps
----@return number taps Number of shader taps
-function Blur:getTaps()
-  return self.taps
-end
-
---- Clear all caches (call on window resize or memory cleanup)
-function Blur.clearCache()
-  Cache.clear()
-end
-
---- Apply backdrop blur with caching support
----@param radius number Blur radius in pixels
----@param x number X position
----@param y number Y position
----@param width number Width of region
----@param height number Height of region
----@param backdropCanvas love.Canvas Canvas containing the backdrop content
----@param elementId string|nil Element ID for caching (nil disables caching)
-function Blur:applyBackdropCached(radius, x, y, width, height, backdropCanvas, elementId)
-  -- If caching is disabled or no element ID, fall back to regular apply
-  if not Blur._blurOptimizations or not elementId then
-    return self:applyBackdrop(radius, x, y, width, height, backdropCanvas)
-  end
-
-  -- Generate cache key
-  local cacheKey = Cache.generateBlurCacheKey(elementId, x, y, width, height, radius, self.quality, true)
-
-  -- Check cache
-  local cachedCanvas = Cache.getBlurredCanvas(cacheKey)
-  if cachedCanvas then
-    -- Draw cached blur
-    local prevCanvas = love.graphics.getCanvas()
-    local prevShader = love.graphics.getShader()
-    local prevColor = { love.graphics.getColor() }
-    local prevBlendMode = love.graphics.getBlendMode()
-
-    love.graphics.setCanvas(prevCanvas)
-    love.graphics.setShader()
-    love.graphics.setBlendMode(prevBlendMode)
-    love.graphics.draw(cachedCanvas, x, y)
-
-    love.graphics.setShader(prevShader)
-    love.graphics.setColor(unpack(prevColor))
-    return
-  end
-
-  -- Not cached, render and cache
-  if not backdropCanvas then
-    if Blur._ErrorHandler then
-      Blur._ErrorHandler:warn("Blur", "BLUR_002")
-    end
-    return
-  end
-
-  if radius <= 0 or width <= 0 or height <= 0 then
-    return
-  end
-
-  -- Early exit for very low radius (optimization)
-  if radius < Cache.RADIUS_THRESHOLD then
-    return
-  end
-
-  -- Check for large blur area in immediate mode
-  checkLargeBlurWarning(elementId, width, height, "backdrop")
-
-  -- Calculate offset multiplier based on radius and quality
-  local offsetMultiplier = radius / self.quality
-
-  local canvas1 = Cache.getCanvas(width, height)
-  local canvas2 = Cache.getCanvas(width, height)
-
-  local prevCanvas = love.graphics.getCanvas()
-  local prevShader = love.graphics.getShader()
-  local prevColor = { love.graphics.getColor() }
-  local prevBlendMode = love.graphics.getBlendMode()
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  love.graphics.setColor(1, 1, 1, 1)
-  love.graphics.setBlendMode("alpha", "premultiplied")
-
-  local backdropWidth, backdropHeight = backdropCanvas:getDimensions()
-  local quad = Cache.getQuad(x, y, width, height, backdropWidth, backdropHeight)
-  love.graphics.draw(backdropCanvas, quad, 0, 0)
-
-  love.graphics.setShader(self.shader)
-
-  -- Single pass with radius-controlled offset
-  love.graphics.setCanvas(canvas2)
-  love.graphics.clear()
-  self.shader:send("direction", { offsetMultiplier / width, 0 })
-  love.graphics.draw(canvas1, 0, 0)
-
-  love.graphics.setCanvas(canvas1)
-  love.graphics.clear()
-  self.shader:send("direction", { 0, offsetMultiplier / height })
-  love.graphics.draw(canvas2, 0, 0)
-
-  -- Cache the result
-  local cachedResult = love.graphics.newCanvas(width, height)
-  love.graphics.setCanvas(cachedResult)
-  love.graphics.clear()
-  love.graphics.setShader()
-  love.graphics.setBlendMode("alpha", "premultiplied")
-  love.graphics.draw(canvas1, 0, 0)
-  Cache.setBlurredCanvas(cacheKey, cachedResult)
-
-  love.graphics.setCanvas(prevCanvas)
-  love.graphics.setShader()
-  love.graphics.setBlendMode(prevBlendMode)
-  love.graphics.draw(canvas1, x, y)
-
-  love.graphics.setShader(prevShader)
-  love.graphics.setColor(unpack(prevColor))
-
-  Cache.releaseCanvas(canvas1)
-  Cache.releaseCanvas(canvas2)
-  Cache.releaseQuad(quad)
-end
-
---- Clear blur cache for specific element
----@param elementId string Element ID
-function Blur.clearElementCache(elementId)
-  Cache.clearBlurredCanvasesForElement(elementId)
-end
-
---- Initialize Blur module with dependencies
----@param deps table Dependencies: { ErrorHandler = ErrorHandler?, immediateModeOptimizations = boolean? }
-function Blur.init(deps)
-  if type(deps) == "table" then
-    Blur._ErrorHandler = deps.ErrorHandler
-    Blur._blurOptimizations = deps.immediateModeOptimizations or false
-  end
-end
-
-Blur.Cache = Cache
-Blur.ShaderBuilder = ShaderBuilder
-
-return Blur

libs/flexlove/modules/Calc.lua

@@ -1,385 +0,0 @@
---- Utility module for parsing and evaluating CSS-like calc() expressions
---- Supports arithmetic operations (+, -, *, /) with mixed units (px, %, vw, vh)
----@class Calc
-local Calc = {}
-
---- Initialize Calc module with dependencies
----@param deps CalcDependencies Dependencies: { ErrorHandler = ErrorHandler? }
-function Calc.init(deps)
-  Calc._ErrorHandler = deps.ErrorHandler
-end
-
---- Token types for lexical analysis
-local TokenType = {
-  NUMBER = "NUMBER",
-  UNIT = "UNIT",
-  PLUS = "PLUS",
-  MINUS = "MINUS",
-  MULTIPLY = "MULTIPLY",
-  DIVIDE = "DIVIDE",
-  LPAREN = "LPAREN",
-  RPAREN = "RPAREN",
-  EOF = "EOF",
-}
-
---- Tokenize a calc expression string into tokens
----@param expr string The expression to tokenize (e.g., "50% - 10vw")
----@return CalcToken[]? tokens Array of tokens with type, value, unit
----@return string? error Error message if tokenization fails
-local function tokenize(expr)
-  local tokens = {}
-  local i = 1
-  local len = #expr
-
-  while i <= len do
-    local char = expr:sub(i, i)
-
-    -- Skip whitespace
-    if char:match("%s") then
-      i = i + 1
-    -- Number (including decimals, but NOT negative - handled separately below)
-    elseif char:match("%d") or (char == "." and expr:sub(i + 1, i + 1):match("%d")) then
-      local numStr = ""
-
-      -- Parse integer and decimal parts
-      while i <= len and (expr:sub(i, i):match("%d") or expr:sub(i, i) == ".") do
-        numStr = numStr .. expr:sub(i, i)
-        i = i + 1
-      end
-
-      local num = tonumber(numStr)
-      if not num then
-        return nil, "Invalid number: " .. numStr
-      end
-
-      -- Check for unit following the number
-      local unitStr = ""
-      while i <= len and expr:sub(i, i):match("[%a%%]") do
-        unitStr = unitStr .. expr:sub(i, i)
-        i = i + 1
-      end
-
-      -- Default to px if no unit
-      if unitStr == "" then
-        unitStr = "px"
-      end
-
-      -- Validate unit
-      local validUnits = { px = true, ["%"] = true, vw = true, vh = true }
-      if not validUnits[unitStr] then
-        return nil, "Invalid unit: " .. unitStr
-      end
-
-      table.insert(tokens, {
-        type = TokenType.NUMBER,
-        value = num,
-        unit = unitStr,
-      })
-    -- Operators
-    elseif char == "+" then
-      table.insert(tokens, { type = TokenType.PLUS })
-      i = i + 1
-    elseif char == "-" then
-      -- Check if this is a negative number or subtraction
-      -- It's a negative number if previous token is an operator or opening paren
-      local prevToken = tokens[#tokens]
-      if
-        not prevToken
-        or prevToken.type == TokenType.PLUS
-        or prevToken.type == TokenType.MINUS
-        or prevToken.type == TokenType.MULTIPLY
-        or prevToken.type == TokenType.DIVIDE
-        or prevToken.type == TokenType.LPAREN
-      then
-        -- This is a negative number, continue to number parsing
-        local numStr = "-"
-        i = i + 1
-
-        -- Parse integer and decimal parts
-        while i <= len and (expr:sub(i, i):match("%d") or expr:sub(i, i) == ".") do
-          numStr = numStr .. expr:sub(i, i)
-          i = i + 1
-        end
-
-        local num = tonumber(numStr)
-        if not num then
-          return nil, "Invalid number: " .. numStr
-        end
-
-        -- Check for unit following the number
-        local unitStr = ""
-        while i <= len and expr:sub(i, i):match("[%a%%]") do
-          unitStr = unitStr .. expr:sub(i, i)
-          i = i + 1
-        end
-
-        -- Default to px if no unit
-        if unitStr == "" then
-          unitStr = "px"
-        end
-
-        -- Validate unit
-        local validUnits = { px = true, ["%"] = true, vw = true, vh = true }
-        if not validUnits[unitStr] then
-          return nil, "Invalid unit: " .. unitStr
-        end
-
-        table.insert(tokens, {
-          type = TokenType.NUMBER,
-          value = num,
-          unit = unitStr,
-        })
-      else
-        -- This is subtraction operator
-        table.insert(tokens, { type = TokenType.MINUS })
-        i = i + 1
-      end
-    elseif char == "*" then
-      table.insert(tokens, { type = TokenType.MULTIPLY })
-      i = i + 1
-    elseif char == "/" then
-      table.insert(tokens, { type = TokenType.DIVIDE })
-      i = i + 1
-    elseif char == "(" then
-      table.insert(tokens, { type = TokenType.LPAREN })
-      i = i + 1
-    elseif char == ")" then
-      table.insert(tokens, { type = TokenType.RPAREN })
-      i = i + 1
-    else
-      return nil, "Unexpected character: " .. char
-    end
-  end
-
-  table.insert(tokens, { type = TokenType.EOF })
-  return tokens
-end
-
---- Parser for calc expressions using recursive descent
----@class Parser
----@field tokens CalcToken[] Array of tokens
----@field pos number Current token position
-local Parser = {}
-Parser.__index = Parser
-
---- Create a new parser
----@param tokens CalcToken[] Array of tokens
----@return Parser
-function Parser.new(tokens)
-  local self = setmetatable({}, Parser)
-  self.tokens = tokens
-  self.pos = 1
-  return self
-end
-
---- Get current token
----@return CalcToken token Current token
-function Parser:current()
-  return self.tokens[self.pos]
-end
-
---- Advance to next token
-function Parser:advance()
-  self.pos = self.pos + 1
-end
-
---- Parse expression (handles + and -)
----@return CalcASTNode ast Abstract syntax tree node
-function Parser:parseExpression()
-  local left = self:parseTerm()
-
-  while self:current().type == TokenType.PLUS or self:current().type == TokenType.MINUS do
-    local op = self:current().type
-    self:advance()
-    local right = self:parseTerm()
-    left = {
-      type = op == TokenType.PLUS and "add" or "subtract",
-      left = left,
-      right = right,
-    }
-  end
-
-  return left
-end
-
---- Parse term (handles * and /)
----@return CalcASTNode ast Abstract syntax tree node
-function Parser:parseTerm()
-  local left = self:parseFactor()
-
-  while self:current().type == TokenType.MULTIPLY or self:current().type == TokenType.DIVIDE do
-    local op = self:current().type
-    self:advance()
-    local right = self:parseFactor()
-    left = {
-      type = op == TokenType.MULTIPLY and "multiply" or "divide",
-      left = left,
-      right = right,
-    }
-  end
-
-  return left
-end
-
---- Parse factor (handles numbers and parentheses)
----@return CalcASTNode ast Abstract syntax tree node
-function Parser:parseFactor()
-  local token = self:current()
-
-  if token.type == TokenType.NUMBER then
-    self:advance()
-    return {
-      type = "number",
-      value = token.value,
-      unit = token.unit,
-    }
-  elseif token.type == TokenType.LPAREN then
-    self:advance()
-    local expr = self:parseExpression()
-    if self:current().type ~= TokenType.RPAREN then
-      error("Expected closing parenthesis")
-    end
-    self:advance()
-    return expr
-  else
-    error("Unexpected token: " .. token.type)
-  end
-end
-
---- Parse the tokens into an AST
----@return CalcASTNode ast Abstract syntax tree
-function Parser:parse()
-  local ast = self:parseExpression()
-  if self:current().type ~= TokenType.EOF then
-    error("Unexpected tokens after expression")
-  end
-  return ast
-end
-
---- Create a calc expression object that can be resolved later
---- This is the main API function that users call
----@param expr string The calc expression (e.g., "50% - 10vw")
----@return CalcObject calcObject A calc expression object with AST
-function Calc.new(expr)
-  -- Tokenize
-  local tokens, err = tokenize(expr)
-  if not tokens then
-    if Calc._ErrorHandler then
-      Calc._ErrorHandler:warn("Calc", "VAL_006", {
-        expression = expr,
-        error = err,
-      })
-    end
-    -- Return a fallback calc object that resolves to 0
-    return {
-      _isCalc = true,
-      _expr = expr,
-      _ast = nil,
-      _error = err,
-    }
-  end
-
-  -- Parse
-  local parser = Parser.new(tokens)
-  local success, ast = pcall(function()
-    return parser:parse()
-  end)
-
-  if not success then
-    if Calc._ErrorHandler then
-      Calc._ErrorHandler:warn("Calc", "VAL_006", {
-        expression = expr,
-        error = ast, -- ast contains error message on failure
-      })
-    end
-    -- Return a fallback calc object that resolves to 0
-    return {
-      _isCalc = true,
-      _expr = expr,
-      _ast = nil,
-      _error = ast,
-    }
-  end
-
-  return {
-    _isCalc = true,
-    _expr = expr,
-    _ast = ast,
-  }
-end
-
---- Check if a value is a calc expression
----@param value any The value to check
----@return boolean isCalc True if value is a calc expression
-function Calc.isCalc(value)
-  return type(value) == "table" and value._isCalc == true
-end
-
---- Resolve a calc expression to pixel value
----@param calcObj CalcObject The calc expression object
----@param viewportWidth number Viewport width in pixels
----@param viewportHeight number Viewport height in pixels
----@param parentSize number? Parent dimension for percentage units
----@return number resolvedValue Resolved pixel value
-function Calc.resolve(calcObj, viewportWidth, viewportHeight, parentSize)
-  if not calcObj._ast then
-    -- Error during parsing, return 0
-    return 0
-  end
-
-  --- Evaluate AST node recursively
-  ---@param node table AST node
-  ---@return number value Evaluated value in pixels
-  local function evaluate(node)
-    if node.type == "number" then
-      -- Convert unit to pixels
-      local value = node.value
-      local unit = node.unit
-
-      if unit == "px" then
-        return value
-      elseif unit == "%" then
-        if not parentSize then
-          if Calc._ErrorHandler then
-            Calc._ErrorHandler:warn("Calc", "LAY_003", {
-              unit = "%",
-              issue = "parent dimension not available",
-            })
-          end
-          return 0
-        end
-        return (value / 100) * parentSize
-      elseif unit == "vw" then
-        return (value / 100) * viewportWidth
-      elseif unit == "vh" then
-        return (value / 100) * viewportHeight
-      else
-        return 0
-      end
-    elseif node.type == "add" then
-      return evaluate(node.left) + evaluate(node.right)
-    elseif node.type == "subtract" then
-      return evaluate(node.left) - evaluate(node.right)
-    elseif node.type == "multiply" then
-      return evaluate(node.left) * evaluate(node.right)
-    elseif node.type == "divide" then
-      local divisor = evaluate(node.right)
-      if divisor == 0 then
-        if Calc._ErrorHandler then
-          Calc._ErrorHandler:warn("Calc", "VAL_006", {
-            expression = calcObj._expr,
-            error = "Division by zero",
-          })
-        end
-        return 0
-      end
-      return evaluate(node.left) / divisor
-    else
-      return 0
-    end
-  end
-
-  return evaluate(calcObj._ast)
-end
-
-return Calc

libs/flexlove/modules/Color.lua

@@ -1,346 +0,0 @@
----@class Color
-local Color = {}
-Color.__index = Color
-
---- Initialize module with shared dependencies
----@param deps table Dependencies {ErrorHandler}
-function Color.init(deps)
-  if type(deps) == "table" then
-    Color._ErrorHandler = deps.ErrorHandler
-  end
-end
-
---- Build type-safe color objects with automatic validation and clamping
---- Use this to avoid invalid color values and ensure consistent LÖVE-compatible colors (0-1 range)
----@param r number? Red component (0-1), defaults to 0
----@param g number? Green component (0-1), defaults to 0
----@param b number? Blue component (0-1), defaults to 0
----@param a number? Alpha component (0-1), defaults to 1
----@return Color color The new color instance
-function Color.new(r, g, b, a)
-  -- Sanitize and clamp color components
-  local _, sanitizedR = Color.validateColorChannel(r or 0, 1)
-  local _, sanitizedG = Color.validateColorChannel(g or 0, 1)
-  local _, sanitizedB = Color.validateColorChannel(b or 0, 1)
-  local _, sanitizedA = Color.validateColorChannel(a or 1, 1)
-
-  -- FFI structs don't support metatables/methods without wrapping
-  -- The wrapping overhead negates the FFI benefits
-  local self = setmetatable({}, Color)
-  self.r = sanitizedR or 0
-  self.g = sanitizedG or 0
-  self.b = sanitizedB or 0
-  self.a = sanitizedA or 1
-  return self
-end
-
---- Extract individual color channels for use with love.graphics.setColor()
---- Use this to pass colors to LÖVE's rendering functions
----@return number r Red component (0-1)
----@return number g Green component (0-1)
----@return number b Blue component (0-1)
----@return number a Alpha component (0-1)
-function Color:toRGBA()
-  return self.r, self.g, self.b, self.a
-end
-
---- Parse CSS-style hex colors into Color objects for designer-friendly workflows
---- Use this to work with colors from design tools that export hex values
----@param hexWithTag string Hex color string (e.g. "#RRGGBB" or "#RRGGBBAA")
----@return Color color The parsed color (returns white on error with warning)
-function Color.fromHex(hexWithTag)
-  -- Validate input type
-  if type(hexWithTag) ~= "string" then
-    Color._ErrorHandler:warn("Color", "VAL_004", {
-      input = tostring(hexWithTag),
-      issue = "not a string",
-      fallback = "white (#FFFFFF)",
-    })
-    return Color.new(1, 1, 1, 1)
-  end
-
-  local hex = hexWithTag:gsub("#", "")
-  if #hex == 6 then
-    local r = tonumber("0x" .. hex:sub(1, 2))
-    local g = tonumber("0x" .. hex:sub(3, 4))
-    local b = tonumber("0x" .. hex:sub(5, 6))
-    if not r or not g or not b then
-      Color._ErrorHandler:warn("Color", "VAL_004", {
-        input = hexWithTag,
-        issue = "invalid hex digits",
-        fallback = "white (#FFFFFF)",
-      })
-      return Color.new(1, 1, 1, 1) -- Return white as fallback
-    end
-    return Color.new(r / 255, g / 255, b / 255, 1)
-  elseif #hex == 8 then
-    local r = tonumber("0x" .. hex:sub(1, 2))
-    local g = tonumber("0x" .. hex:sub(3, 4))
-    local b = tonumber("0x" .. hex:sub(5, 6))
-    local a = tonumber("0x" .. hex:sub(7, 8))
-    if not r or not g or not b or not a then
-      Color._ErrorHandler:warn("Color", "VAL_004", {
-        input = hexWithTag,
-        issue = "invalid hex digits",
-        fallback = "white (#FFFFFFFF)",
-      })
-      return Color.new(1, 1, 1, 1) -- Return white as fallback
-    end
-    return Color.new(r / 255, g / 255, b / 255, a / 255)
-  else
-    Color._ErrorHandler:warn("Color", "VAL_004", {
-      input = hexWithTag,
-      expected = "#RRGGBB or #RRGGBBAA",
-      hexLength = #hex,
-      fallback = "white (#FFFFFF)",
-    })
-    return Color.new(1, 1, 1, 1) -- Return white as fallback
-  end
-end
-
---- Verify and sanitize individual color components to prevent rendering errors
---- Use this to safely process user input or external color data
----@param value any Value to validate
----@param max number? Maximum value (255 for 0-255 range, 1 for 0-1 range), defaults to 1
----@return boolean valid True if valid
----@return number? clamped Clamped value in 0-1 range, nil if invalid
-function Color.validateColorChannel(value, max)
-  max = max or 1
-
-  if type(value) ~= "number" then
-    return false, nil
-  end
-
-  -- Check for NaN
-  if value ~= value then
-    return false, nil
-  end
-
-  -- Check for Infinity
-  if value == math.huge or value == -math.huge then
-    return false, nil
-  end
-
-  -- Normalize to 0-1 range
-  local normalized = value
-  if max == 255 then
-    normalized = value / 255
-  end
-
-  -- Clamp to valid range
-  normalized = math.max(0, math.min(1, normalized))
-
-  return true, normalized
-end
-
---- Validate hex color format
----@param hex string Hex color string (with or without #)
----@return boolean valid True if valid format
----@return string? error Error message if invalid, nil if valid
-function Color.validateHexColor(hex)
-  if type(hex) ~= "string" then
-    return false, "Hex color must be a string"
-  end
-
-  -- Remove # prefix
-  local cleanHex = hex:gsub("^#", "")
-
-  -- Check length (3, 6, or 8 characters)
-  if #cleanHex ~= 3 and #cleanHex ~= 6 and #cleanHex ~= 8 then
-    return false, string.format("Invalid hex length: %d. Expected 3, 6, or 8 characters", #cleanHex)
-  end
-
-  -- Check for valid hex characters
-  if not cleanHex:match("^[0-9A-Fa-f]+$") then
-    return false, "Invalid hex characters. Use only 0-9, A-F"
-  end
-
-  return true, nil
-end
-
---- Validate RGB/RGBA color values
----@param r number Red component
----@param g number Green component
----@param b number Blue component
----@param a number? Alpha component (optional, defaults to max)
----@param max number? Maximum value (255 or 1), defaults to 1
----@return boolean valid True if valid
----@return string? error Error message if invalid, nil if valid
-function Color.validateRGBColor(r, g, b, a, max)
-  max = max or 1
-  a = a or max
-
-  local rValid = Color.validateColorChannel(r, max)
-  local gValid = Color.validateColorChannel(g, max)
-  local bValid = Color.validateColorChannel(b, max)
-  local aValid = Color.validateColorChannel(a, max)
-
-  if not rValid then
-    return false, string.format("Invalid red channel: %s", tostring(r))
-  end
-  if not gValid then
-    return false, string.format("Invalid green channel: %s", tostring(g))
-  end
-  if not bValid then
-    return false, string.format("Invalid blue channel: %s", tostring(b))
-  end
-  if not aValid then
-    return false, string.format("Invalid alpha channel: %s", tostring(a))
-  end
-
-  return true, nil
-end
-
---- Check if a value is a valid color format
----@param value any Value to check
----@return string? format Format type ("hex", "named", "table"), nil if invalid
-function Color.isValidColorFormat(value)
-  local valueType = type(value)
-
-  -- Check for hex string
-  if valueType == "string" then
-    if value:match("^#?[0-9A-Fa-f]+$") then
-      local valid = Color.validateHexColor(value)
-      if valid then
-        return "hex"
-      end
-    end
-
-    return nil
-  end
-
-  -- Check for table format
-  if valueType == "table" then
-    -- Check for Color instance
-    if getmetatable(value) == Color then
-      return "table"
-    end
-
-    -- Check for array format {r, g, b, a}
-    if value[1] and value[2] and value[3] then
-      local valid = Color.validateRGBColor(value[1], value[2], value[3], value[4])
-      if valid then
-        return "table"
-      end
-    end
-
-    -- Check for named format {r=, g=, b=, a=}
-    if value.r and value.g and value.b then
-      local valid = Color.validateRGBColor(value.r, value.g, value.b, value.a)
-      if valid then
-        return "table"
-      end
-    end
-
-    return nil
-  end
-
-  return nil
-end
-
---- Convert any color format to a valid Color object with graceful fallbacks
---- Use this to robustly handle colors from any source without crashes
----@param value any Color value to sanitize (hex, named, table, or Color instance)
----@param default Color? Default color if invalid (defaults to black)
----@return Color color Sanitized color instance (guaranteed non-nil)
-function Color.sanitizeColor(value, default)
-  default = default or Color.new(0, 0, 0, 1)
-
-  local format = Color.isValidColorFormat(value)
-
-  if not format then
-    return default
-  end
-
-  -- Handle hex format
-  if format == "hex" then
-    local cleanHex = value:gsub("^#", "")
-
-    -- Expand 3-digit hex to 6-digit
-    if #cleanHex == 3 then
-      cleanHex = cleanHex:gsub("(.)", "%1%1")
-    end
-
-    -- Try to parse
-    local success, result = pcall(Color.fromHex, "#" .. cleanHex)
-    if success then
-      return result
-    else
-      return default
-    end
-  end
-
-  if format == "table" then
-    -- Color instance
-    if getmetatable(value) == Color then
-      return value
-    end
-
-    -- Array format
-    if value[1] then
-      local _, r = Color.validateColorChannel(value[1], 1)
-      local _, g = Color.validateColorChannel(value[2], 1)
-      local _, b = Color.validateColorChannel(value[3], 1)
-      local _, a = Color.validateColorChannel(value[4] or 1, 1)
-
-      if r and g and b and a then
-        return Color.new(r, g, b, a)
-      end
-    end
-
-    -- Named format
-    if value.r then
-      local _, r = Color.validateColorChannel(value.r, 1)
-      local _, g = Color.validateColorChannel(value.g, 1)
-      local _, b = Color.validateColorChannel(value.b, 1)
-      local _, a = Color.validateColorChannel(value.a or 1, 1)
-
-      if r and g and b and a then
-        return Color.new(r, g, b, a)
-      end
-    end
-  end
-
-  return default
-end
-
---- Universally convert any color format (hex, named, table) into a Color object
---- Use this as your main color input handler to accept flexible color specifications
----@param value any Color value (hex string, named color, table, or Color instance)
----@return Color color Parsed color instance (defaults to black on error)
-function Color.parse(value)
-  return Color.sanitizeColor(value, Color.new(0, 0, 0, 1))
-end
-
---- Smoothly transition between two colors for animations and gradients
---- Use this to create color-based animations without manual channel calculations
----@param colorA Color Starting color
----@param colorB Color Ending color
----@param t number Interpolation factor (0-1)
----@return Color color Interpolated color
-function Color.lerp(colorA, colorB, t)
-  -- Sanitize inputs
-  if type(colorA) ~= "table" or getmetatable(colorA) ~= Color then
-    colorA = Color.new(0, 0, 0, 1)
-  end
-  if type(colorB) ~= "table" or getmetatable(colorB) ~= Color then
-    colorB = Color.new(0, 0, 0, 1)
-  end
-  if type(t) ~= "number" or t ~= t or t == math.huge or t == -math.huge then
-    t = 0
-  end
-
-  -- Clamp t to 0-1 range
-  t = math.max(0, math.min(1, t))
-
-  -- Linear interpolation for each channel
-  local oneMinusT = 1 - t
-  local r = colorA.r * oneMinusT + colorB.r * t
-  local g = colorA.g * oneMinusT + colorB.g * t
-  local b = colorA.b * oneMinusT + colorB.b * t
-  local a = colorA.a * oneMinusT + colorB.a * t
-
-  return Color.new(r, g, b, a)
-end
-
-return Color

libs/flexlove/modules/Context.lua

@@ -1,596 +0,0 @@
----@class Context
-local modulePath = (...):match("(.-)[^%.]+$")
-local ZIndex = require(modulePath .. "ZIndex")
-local Element = require(modulePath .. "Element")
-local Context = {
-  topElements = {},
-  -- Base scale configuration
-  baseScale = nil, -- {width: number, height: number}
-  -- Current scale factors
-  scaleFactors = { x = 1.0, y = 1.0 },
-  defaultTheme = nil,
-  _focusedElement = nil,
-  _focusedElementId = nil, -- Stable id used to rehydrate focus across immediate-mode frames
-  _activeEventElement = nil,
-  _cachedViewport = { width = 0, height = 0 },
-  -- Immediate mode state
-  _immediateMode = false,
-  _frameNumber = 0,
-  _currentFrameElements = {},
-  _immediateModeState = nil, -- Will be initialized if immediate mode is enabled
-  _frameStarted = false,
-  _autoBeganFrame = false,
-  -- Z-index ordered element tracking for immediate mode
-  _zIndexOrderedElements = {}, -- Array of elements sorted by z-index (lowest to highest)
-  -- Focus management guard
-  _settingFocus = false,
-  -- Hook called whenever focus changes: function(element) or nil
-  _onFocusChanged = nil,
-
-  -- Navigation state
-  _navigationContext = {
-    lastFocusedElement = nil, -- For returning from modals
-    navigationMode = "sequential", -- "sequential" or "directional"
-    containerElement = nil, -- Current navigation container
-  },
-
-  initialized = false,
-
-  -- Expose internal hit-testing helpers for unit testing only.
-  -- These are populated below after their local definitions. They are NOT part
-  -- of the public API and must not be relied on by callers; they exist so the
-  -- shared hit-test core (the single place display:none guarding lives) can be
-  -- exercised directly by the test suite. Subsequent unified-event-routing
-  -- tasks consume these locals through the mode-agnostic query functions.
-  _test = {
-    pointHitsElement = nil,
-    elementHasScrollableOverflow = nil,
-  },
-
-  -- Debug draw overlay
-  _debugDraw = false,
-  _debugDrawKey = nil,
-
-  -- Initialization state tracking
-  ---@type "uninitialized"|"initializing"|"ready"
-  _initState = "uninitialized",
-  ---@type table[] Queue of {props: ElementProps, callback: function(element)|nil}
-  _initQueue = {},
-
-  -- Per-frame cache for findInteractiveAtPosition so Clickable.onUpdate's
-  -- per-element call (unified-event-routing task 05) doesn't re-walk the tree
-  -- + realloc + sort for every interactive element sharing the same cursor.
-  -- Invalidated explicitly by Context.clearInteractiveCache() at the start of
-  -- each flexlove.update (both modes) and in clearFrameElements (immediate
-  -- mid-frame rebuild). It also self-invalidates when the topElements table
-  -- reference changes (tests replace it per-case; immediate-mode beginFrame
-  -- reassigns it each frame), so direct callers that never go through
-  -- flexlove.update still see fresh results across tree swaps.
-  _interactiveLookupCache = {
-    valid = false,
-    x = nil,
-    y = nil,
-    result = nil,
-    topElementsRef = nil,
-    frameNumber = -1,
-  },
-}
-
---- Check if a point hits an element, accounting for scroll offsets and display:none.
---- All mode-agnostic query functions use this as their single hit-test entry point,
---- ensuring fixes like display:none guarding apply everywhere.
----
---- This is the single canonical place where `element.display == false` short-
---- circuits hit testing. Parent-chain clipping/scroll-offset accumulation is
---- the caller's responsibility: callers walk the parent chain (using
---- `elementHasScrollableOverflow` to decide which ancestors clip) and pass the
---- accumulated scroll offset in here. Keeping the parent walk outside this core
---- lets retained-mode (recursive tree descent) and immediate-mode (flat
---- z-index list) callers share the exact same primitive bounds/display logic.
----@param element Element
----@param mx number Screen X coordinate
----@param my number Screen Y coordinate
----@param scrollOffsetX number? Accumulated scroll offset from parent chain
----@param scrollOffsetY number? Accumulated scroll offset from parent chain
----@return boolean hits
-local function pointHitsElement(element, mx, my, scrollOffsetX, scrollOffsetY)
-  scrollOffsetX = scrollOffsetX or 0
-  scrollOffsetY = scrollOffsetY or 0
-
-  -- Skip display:none elements entirely
-  if element.display == false then
-    return false
-  end
-
-  local bx = element.x
-  local by = element.y
-  local bw = element._borderBoxWidth or (element.width + element.padding.left + element.padding.right)
-  local bh = element._borderBoxHeight or (element.height + element.padding.top + element.padding.bottom)
-
-  local adjustedX = mx + scrollOffsetX
-  local adjustedY = my + scrollOffsetY
-
-  return adjustedX >= bx and adjustedX <= bx + bw and adjustedY >= by and adjustedY <= by + bh
-end
-
---- Check if an element has scrollable/clipped overflow (for scroll offset accumulation).
---- Returns true for `scroll`, `auto`, and `hidden` on either axis. These are the
---- overflow values that clip/translate descendant content and therefore require
---- scroll-offset compensation when hit testing descendants.
----@param element Element
----@return boolean
-local function elementHasScrollableOverflow(element)
-  local overflowX = element.overflowX or element.overflow
-  local overflowY = element.overflowY or element.overflow
-  return overflowX == "scroll"
-    or overflowX == "auto"
-    or overflowY == "scroll"
-    or overflowY == "auto"
-    or overflowX == "hidden"
-    or overflowY == "hidden"
-end
-
--- Expose the two core helpers for unit testing only (see Context._test above).
-Context._test.pointHitsElement = pointHitsElement
-Context._test.elementHasScrollableOverflow = elementHasScrollableOverflow
-
--- Public exposure of the canonical hit-test primitive so other modules
--- (e.g. FlexLove's `getElementAtPosition` / `_getTouchElementAtPosition`
--- tree walks) can share the single implementation of bounds + display:none
--- guarding instead of duplicating the `display == false` check inline.
--- This keeps "display == false" in exactly one place for hit-testing.
-Context.pointHitsElement = pointHitsElement
-Context.elementHasScrollableOverflow = elementHasScrollableOverflow
-
---- Find the first scrollable element at a screen position, regardless of mode.
---- This is the mode-agnostic successor to the two duplicated scrollable lookups
---- that previously lived inline in `flexlove.wheelmoved`:
----   * immediate mode — walked `Context._zIndexOrderedElements` in reverse and
----     re-implemented bounds + parent-chain clipping + scroll-offset math; and
----   * retained mode — recursed through `Context.topElements` with a private
----     `findScrollableAtPosition(elements, x, y)` helper.
---- Both paths now collapse into this single function, which routes every
---- hit test through `pointHitsElement` (the single place `display == false`
---- is guarded) and every scroll-offset decision through
---- `elementHasScrollableOverflow`. As a result display:none elements are never
---- returned in either mode, fixing the latent bug where the immediate-mode
---- path's `isPointInElement` did not skip display:none elements.
----
---- The retained-mode branch intentionally mirrors the original
---- `findScrollableAtPosition` helper's tree walk (deepest scrollable wins,
---- children checked before self) but is upgraded to thread accumulated scroll
---- offsets through `pointHitsElement` so nested scrolled containers are tested
---- against their visible position. The original helper is removed once
---- `flexlove.wheelmoved` is rerouted onto this function in task 04.
----@param x number Screen X coordinate
----@param y number Screen Y coordinate
----@return Element|nil The scrollable element, or nil
-function Context.findScrollableAtPosition(x, y)
-  if Context.isImmediateMode() then
-    -- Immediate mode: iterate the z-index ordered list (reverse order =
-    -- topmost first). pointHitsElement supplies the bounds + display guard.
-    for i = #Context._zIndexOrderedElements, 1, -1 do
-      local element = Context._zIndexOrderedElements[i]
-      if pointHitsElement(element, x, y) then
-        local overflowX = element.overflowX or element.overflow
-        local overflowY = element.overflowY or element.overflow
-        if
-          (overflowX == "scroll" or overflowX == "auto" or overflowY == "scroll" or overflowY == "auto")
-          and (element._overflowX or element._overflowY)
-        then
-          return element
-        end
-      end
-    end
-    return nil
-  else
-    -- Retained mode: recursive tree walk from topElements. Children are
-    -- checked before self (deepest scrollable wins); accumulated scroll
-    -- offsets are threaded through pointHitsElement so descendants of
-    -- scrolled containers are hit-tested against their translated position.
-    local function findInTree(elements, scrollOffsetX, scrollOffsetY)
-      scrollOffsetX = scrollOffsetX or 0
-      scrollOffsetY = scrollOffsetY or 0
-      for i = #elements, 1, -1 do
-        local element = elements[i]
-        if pointHitsElement(element, x, y, scrollOffsetX, scrollOffsetY) then
-          if #element.children > 0 then
-            local childScrollOffsetX = scrollOffsetX
-            local childScrollOffsetY = scrollOffsetY
-            if elementHasScrollableOverflow(element) then
-              childScrollOffsetX = childScrollOffsetX + (element._scrollX or 0)
-              childScrollOffsetY = childScrollOffsetY + (element._scrollY or 0)
-            end
-            local childResult = findInTree(element.children, childScrollOffsetX, childScrollOffsetY)
-            if childResult then
-              return childResult
-            end
-          end
-          -- No descendant was scrollable — check self.
-          local overflowX = element.overflowX or element.overflow
-          local overflowY = element.overflowY or element.overflow
-          if
-            (overflowX == "scroll" or overflowX == "auto" or overflowY == "scroll" or overflowY == "auto")
-            and (element._overflowX or element._overflowY)
-          then
-            return element
-          end
-        end
-      end
-      return nil
-    end
-    return findInTree(Context.topElements)
-  end
-end
-
---- Check whether immediate mode is active.
---- This is the single canonical accessor for the mode flag consumed throughout
---- the framework. Mode-aware branches elsewhere call this instead of reading
---- `Context._immediateMode` directly, so the literal mode flag only appears
---- here (its definition) and in StateManager (its mirrored storage) — never
---- scattered across Element / behaviors / managers (behavior-mode-unification
---- task 11).
----@return boolean
-function Context.isImmediateMode()
-  return Context._immediateMode
-end
-
----@return number, number -- scaleX, scaleY
-function Context.getScaleFactors()
-  return Context.scaleFactors.x, Context.scaleFactors.y
-end
-
---- Register an element in the z-index ordered tree (for immediate mode)
----@param element Element The element to register
-function Context.registerElement(element)
-  if not Context.isImmediateMode() then
-    return
-  end
-
-  table.insert(Context._zIndexOrderedElements, element)
-end
-
-function Context.clearFrameElements()
-  Context._zIndexOrderedElements = {}
-  Context.clearInteractiveCache()
-end
-
---- Compute the composite z-index key for an element.
---- rootZ * ROOT_WEIGHT + depth * DEPTH_WEIGHT + ownZ
----
---- ROOT_WEIGHT (10^10) gives the top-level ancestor's z-index 10 digits of significance.
---- DEPTH_WEIGHT (10^3) gives nesting depth 3 digits, ensuring children always sort above
---- their ancestors. The element's own z (capped to ±999 by ZIndex.clamp) fits within the
---- remaining 3 digits without interfering with the depth component.
----
---- These weights assume |z| <= ZIndex.MAX_Z and practical tree depths (< 10^7), which
---- keeps the composite key well within Lua's exact integer range (2^53 ≈ 9 × 10^15).
----
---- This is the SINGLE canonical z-index ordering function, used by both
---- sortElementsByZIndex (the immediate-mode flat list sort) and
---- findInteractiveAtPosition (the mode-agnostic occlusion sort). Keeping them
---- on the same key ensures the interactive topmost element matches the visual
---- draw order — a button in a z=50 MainMenu window must occlude a button in a
---- z=0 BottomBar even when both buttons default to own z=0.
-local function getEffectiveZIndex(elem)
-  local ownZ = elem.z or 0
-  local rootZ = ownZ
-  local depth = 0
-  local current = elem.parent
-  while current do
-    rootZ = current.z or 0
-    depth = depth + 1
-    current = current.parent
-  end
-  return rootZ * ZIndex.ROOT_WEIGHT + depth * ZIndex.DEPTH_WEIGHT + ownZ
-end
-
--- Public exposure so FlexLove.getElementAtPosition shares the single
--- implementation instead of duplicating the parent-chain walk as a closure.
-Context.getEffectiveZIndex = getEffectiveZIndex
-
---- Sort elements by z-index (called after all elements are registered)
-function Context.sortElementsByZIndex()
-  -- Precompute the composite key ONCE per element so the sort comparator is a
-  -- pure table lookup (O(1)) instead of re-walking the parent chain on every
-  -- O(N log N) comparison. This function runs every frame in immediate mode.
-  local elements = Context._zIndexOrderedElements
-  local zIndices = {}
-  for i = 1, #elements do
-    zIndices[elements[i]] = getEffectiveZIndex(elements[i])
-  end
-  table.sort(elements, function(a, b)
-    return zIndices[a] < zIndices[b]
-  end)
-end
-
---- Find the topmost interactive element at a screen position, regardless of mode.
---- Replaces the former immediate-mode-only `Context.getTopElementAt()` (removed
---- in unified-event-routing task 05) and the retained-mode `_activeEventElement`
---- mechanism — both are now funneled through this single entry point.
----
---- In immediate mode this replaces Context.getTopElementAt() (which only worked
---- in immediate mode). In retained mode this provides the same role as the
---- _activeEventElement set by flexlove.getElementAtPosition().
----
---- An element is "interactive" if it has an onEvent handler, themeComponent, or is editable.
----@param x number Screen X coordinate
----@param y number Screen Y coordinate
----@return Element|nil The topmost interactive element, or nil
-function Context.findInteractiveAtPosition(x, y)
-  -- Per-frame cache: Clickable.onUpdate runs this for every interactive
-  -- element under the same cursor, but the result for a given (x,y) is
-  -- identical across all of them within a single update pass. Returning a
-  -- cached element restores the old 1x/frame cost of the _activeEventElement
-  -- mechanism that task 05 replaced. Cache auto-invalidates when the
-  -- topElements table reference changes (so tests and mid-frame rebuilds get
-  -- fresh results) and is cleared explicitly per-frame in flexlove.update.
-  local cache = Context._interactiveLookupCache
-  if
-    cache.valid
-    and cache.x == x
-    and cache.y == y
-    and cache.topElementsRef == Context.topElements
-    and cache.frameNumber == Context._frameNumber
-  then
-    return cache.result
-  end
-
-  local interactiveCandidates = {}
-
-  local function collectInteractive(element, scrollOffsetX, scrollOffsetY)
-    scrollOffsetX = scrollOffsetX or 0
-    scrollOffsetY = scrollOffsetY or 0
-
-    if not pointHitsElement(element, x, y, scrollOffsetX, scrollOffsetY) then
-      return
-    end
-
-    -- Check if this element is interactive
-    if element.onEvent or element.themeComponent or element.editable then
-      table.insert(interactiveCandidates, element)
-    end
-
-    -- Recurse into children with accumulated scroll offset
-    local childScrollOffsetX = scrollOffsetX
-    local childScrollOffsetY = scrollOffsetY
-    if elementHasScrollableOverflow(element) then
-      childScrollOffsetX = childScrollOffsetX + (element._scrollX or 0)
-      childScrollOffsetY = childScrollOffsetY + (element._scrollY or 0)
-    end
-
-    for _, child in ipairs(element.children) do
-      collectInteractive(child, childScrollOffsetX, childScrollOffsetY)
-    end
-  end
-
-  -- Always traverse the tree (works in both modes — topElements exists always)
-  for _, element in ipairs(Context.topElements) do
-    collectInteractive(element)
-  end
-
-  -- Sort by composite z-index descending — topmost wins. The composite key
-  -- (rootZ * ROOT_WEIGHT + depth * DEPTH_WEIGHT + ownZ) matches the ordering
-  -- used by sortElementsByZIndex / _zIndexOrderedElements, so the interactive
-  -- topmost element matches the visual draw order. This is critical for the
-  -- game's multi-window layout: a button inside a z=50 MainMenu window must
-  -- occlude a button inside a z=0 BottomBar even when both buttons default to
-  -- own z=0. Sorting by own-z alone (the original implementation) couldn't
-  -- distinguish them, so the wrong window's button could win, leaving the
-  -- visible button's isActiveElement=false and clicks/hover dead.
-  local zIndices = {}
-  for _, el in ipairs(interactiveCandidates) do
-    zIndices[el] = getEffectiveZIndex(el)
-  end
-  table.sort(interactiveCandidates, function(a, b)
-    return zIndices[a] > zIndices[b]
-  end)
-
-  local result = interactiveCandidates[1]
-
-  cache.x = x
-  cache.y = y
-  cache.result = result
-  cache.topElementsRef = Context.topElements
-  cache.frameNumber = Context._frameNumber
-  cache.valid = true
-
-  return result
-end
-
---- Invalidate the per-frame `findInteractiveAtPosition` cache.
---- Called once at the top of `flexlove.update` (the natural per-frame boundary
---- in both modes) and from `clearFrameElements` (immediate-mode mid-frame
---- rebuild). After invalidation the next lookup recomputes fresh.
-function Context.clearInteractiveCache()
-  local cache = Context._interactiveLookupCache
-  cache.valid = false
-  cache.x = nil
-  cache.y = nil
-  cache.result = nil
-  cache.topElementsRef = nil
-  cache.frameNumber = -1
-end
-
---- Set the focused element (centralizes focus management)
---- Automatically blurs the previously focused element if different
----@param element Element|nil The element to focus (nil to clear focus)
-function Context.setFocused(element)
-  if Context._focusedElement == element then
-    return -- Already focused
-  end
-
-  -- Prevent re-entry during focus change
-  if Context._settingFocus then
-    return
-  end
-  Context._settingFocus = true
-
-  -- Save reference to previously focused element before updating
-  local oldFocusedElement = Context._focusedElement
-
-  -- Blur previously focused element
-  if oldFocusedElement and oldFocusedElement ~= element then
-    if oldFocusedElement._textEditor then
-      oldFocusedElement._textEditor:blur(oldFocusedElement)
-    end
-  end
-
-  -- Set new focused element and persist its id for immediate-mode rehydration
-  Context._focusedElement = element
-  Context._focusedElementId = element and (element.id ~= "" and element.id or nil) or nil
-
-  -- Notify any registered focus change hook (e.g. FocusIndicator)
-  if Context._onFocusChanged then
-    Context._onFocusChanged(element)
-  end
-
-  -- Focus the new element's text editor if it has one
-  if element and element._textEditor then
-    element._textEditor._focused = true
-  end
-
-  Context._settingFocus = false
-end
-
---- Recursively search for an element by id in an element tree
----@param root Element The root element to start searching from
----@param targetId string The id to search for
----@return Element|nil The element with the matching id, or nil if not found
-local function findElementById(root, targetId)
-  if root.id == targetId then
-    return root
-  end
-  for _, child in ipairs(root.children or {}) do
-    local found = findElementById(child, targetId)
-    if found then
-      return found
-    end
-  end
-  return nil
-end
-
---- Rehydrate _focusedElement from _focusedElementId by scanning live elements.
---- Called at the start of getFocused() in immediate mode so stale references
---- are always replaced with the current-frame object before use.
-function Context._rehydrateFocus()
-  if not Context._focusedElementId then
-    Context._focusedElement = nil
-    return
-  end
-
-  -- First, try a fast linear search through all registered elements
-  for _, elem in ipairs(Context._zIndexOrderedElements) do
-    if elem.id == Context._focusedElementId then
-      Context._focusedElement = elem
-      return
-    end
-  end
-
-  -- If not found, recursively search from top-level elements
-  -- This handles cases where elements may not be in _zIndexOrderedElements
-  for _, topLevel in ipairs(Context.topElements or {}) do
-    local found = findElementById(topLevel, Context._focusedElementId)
-    if found then
-      Context._focusedElement = found
-      return
-    end
-  end
-
-  -- Element with that id is not present this frame (e.g. screen changed)
-  Context._focusedElement = nil
-end
-
---- Get the currently focused element
----@return Element|nil The focused element, or nil if none
-function Context.getFocused()
-  if Context.isImmediateMode() then
-    Context._rehydrateFocus()
-  end
-  return Context._focusedElement
-end
-
---- Clear focus from any element
-function Context.clearFocus()
-  Context._focusedElementId = nil
-  Context.setFocused(nil)
-end
-
---- Get all focusable elements in tab order, regardless of mode.
---- In immediate mode this extracts from _zIndexOrderedElements (flat, z-sorted).
---- In retained mode it walks the element tree (DOM order).
---- In both modes, display:none elements are excluded.
----@return table<Element> List of focusable elements in tab order
-function Context.getFocusableElements()
-  local focusable = {}
-
-  local function isFocusable(elem)
-    if elem.display == false then
-      return false
-    end
-    -- Use Element:isFocusable() for consistent behavior
-    return Element.isFocusable(elem)
-  end
-
-  local function collectFromTree(elements)
-    for _, elem in ipairs(elements) do
-      if isFocusable(elem) then
-        table.insert(focusable, elem)
-      end
-      if #elem.children > 0 then
-        collectFromTree(elem.children)
-      end
-    end
-  end
-
-  if Context._immediateMode then
-    -- Immediate mode: _zIndexOrderedElements is already in z-index order (lowest first),
-    -- which approximates tab order for most UIs.
-    for _, elem in ipairs(Context._zIndexOrderedElements) do
-      if isFocusable(elem) then
-        table.insert(focusable, elem)
-      end
-    end
-  else
-    -- Retained mode: walk the top element trees in DOM order
-    collectFromTree(Context.topElements)
-  end
-
-  return focusable
-end
-
--- ====================
--- Navigation Context
--- ====================
-
---- Push current focus onto stack (for modals/dialogs)
----@param element Element?
-function Context.pushFocusStack(element)
-  Context._navigationContext.lastFocusedElement = Context._focusedElement
-  if element then
-    Context.setFocused(element)
-  end
-end
-
---- Pop focus from stack (return from modal)
----@return Element?
-function Context.popFocusStack()
-  local previous = Context._navigationContext.lastFocusedElement
-  Context._navigationContext.lastFocusedElement = nil
-  Context.setFocused(previous)
-  return previous
-end
-
---- Set navigation container (scope for tab navigation)
----@param element Element?
-function Context.setNavigationContainer(element)
-  Context._navigationContext.containerElement = element
-end
-
---- Get navigation container
----@return Element?
-function Context.getNavigationContainer()
-  return Context._navigationContext.containerElement
-end
-
-return Context