407f649e9d
fix(mod-api): harden deferred trainer preparation
2026-08-14 17:57:59 +02:00
a77210799f
feat(mod-api): add trainer battle party scope
2026-08-14 17:33:17 +02:00
a94fecfec8
Closes #919 , closes #982 , closes #1003 , closes #1012 , closes #1022 , closes #1028 , closes #1033
2026-08-14 10:05:51 -04:00
fceaa2b54c
Merge pull request #1240 from AverageConsumer/codex/gen2-battle-ui-visibility
2026-08-14 05:54:22 -04:00
1586aec9f6
fix(gen2): sell TMs at Poké Marts instead of opening the teach party
...
Selecting a TM in the mart's SELL pack (and the item PC's DEPOSIT pack) opened the teach-party screen: PackMenu:useSelected taught any item carrying `teaches`, even when the pack was built as a chooser (DepositSellPack, world = {}). On the cart that chooser's jumptable is four ScrollingMenus and never reaches tmhm.asm, so the row must hand back to the caller instead.
Gate the teach and field-NOUSE branches behind world.useFieldItem so only the real field PACK teaches; choosers now hand TMs to onChoose. Selling then prices a TM at half its ItemAttributes price -- exactly half of what the Goldenrod/Celadon TM shelves charge, and half of the hidden price for the rest, the way SelectQuantityToSell -> GetItemPrice -> Sell_HalvePrice does on the cart.
Closes #1243
2026-08-13 23:55:31 +01:00
7b8cb127a8
feat(gen2): share battle UI visibility hooks
2026-08-13 22:41:26 +02:00
37051a26b5
CLOSES #1206 , CLOSES #1189 , CLOSES #1175 , CLOSES #1129 , CLOSES #1119 , CLOSES #1089 , CLOSES #1073 , CLOSES #1069 , CLOSES #1065 , CLOSES #1010 , CLOSES #990 , CLOSES #989 , CLOSES #988 , CLOSES #978 , CLOSES #944 , CLOSES #936 , CLOSES #1221 , CLOSES #1220 , CLOSES #1193 , CLOSES #1101 , CLOSES #1066 , CLOSES #1056 , CLOSES #1041 , CLOSES #984 , CLOSES #1225 , CLOSES #1214 , CLOSES #1011 , CLOSES #1035 , CLOSES #1219 , CLOSES #1048 , CLOSES #1047 , CLOSES #964 , CLOSES #949 , CLOSES #1149 , CLOSES #1007 , CLOSES #914 , CLOSES #1115 , CLOSES #1146 , CLOSES #999 , CLOSES #1207 , CLOSES #1029 , CLOSES #1120 , CLOSES #987 , CLOSES #983
2026-08-13 13:07:20 -04:00
df35193ad3
Merge pull request #1204 from castdrian/ios-improvements
...
feat(ios): improve branding and fix haptic feedback
2026-08-13 06:06:31 -04:00
52e36ad7e4
fix testsZ
2026-08-13 06:05:27 -04:00
6864173f35
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-13 05:30:35 -04:00
e9d431b3ff
CLOSES #1091 , CLOSES #1097 , CLOSES #1100 , CLOSES #1104 , CLOSES #1135 , CLOSES #1155 , CLOSES #1157 , CLOSES #1158 , CLOSES #1159 , CLOSES #1160 , CLOSES #1167 , CLOSES #1208
2026-08-13 05:30:33 -04:00
d648990a81
feat(ios): brand app and tune haptic feedback
2026-08-13 02:19:45 +02:00
517170f1c8
Merge pull request #1068 from anxiousintrovert/agent/fix-disabled-battle-ui-background
...
Fix hidden battle UI overlay backgrounds
2026-08-12 16:56:46 -04:00
3320eacc26
Merge pull request #1079 from MaxTomahawk/feat/mod-pokemon-icon
...
feat(mods): expose canonical Pokémon icon presentation
2026-08-12 16:55:55 -04:00
6731937841
Pulled every open Gold bug (bodies, comments, screenshots/videos), matched them against the port and ../pokegold, then split them so each fixer owns a disjoint file set. Duplicates collapsed: #1164 and #1188 are the same Radio Tower stair softlock. #1150 and #1190 are the same Gold rebind freeze. Enhancements ( #1161 , #1130 , #1112 , #1100 ) were left out. Battle 1 src/battle/gen2/*, src/ui/gen2/BattleState.lua #1168 multi-hit always 2 #1180 DV / stats #1185 learn-move text order after a trainer fight #1152 no "Use next POKéMON?" / run after a wild faint Overworld 2 src/world/gen2/*, trade anim, hidden items #1184 Kurt blocking Slowpoke Well #1164 / #1188 Radio Tower gentleman on the stairs #1173 Rock Smash rocks walk left each visit #1172 last item name used Rock Smash #1167 Ilex Forest hidden items #1165 trade movie + ledge hop still missing ( #1121 / #1126 ) UI 3 naming, party, mart, pokegear #1166 grey nickname screen #1162 TM/HM missing ABLE / NOT ABLE #1169 underground herb lady whites out the map #1151 Pokegear black player icon + extra A/B on the phone card Platform 4 Gold options, save slots, pack, mod tab #1150 / #1190 controls freeze #1178 no vibration row #1177 cannot move Gold touch controls #1107 SAVE with no launcher slot #1145 Gold mod tab still lists Gen 1-only mods #1192 RGXX missing tools/rom_manifest_gold.json Drivers only for the progress / data-loss ones (faint-run, multi-hit, Kurt, Radio Tower, Rock Smash shift, herb shop, save slot). No new unit tests. New comments are pokegold file.asm:line only. A verifier agent will get this same list once the four finish and check that the diffs actually fix the reports. Verifier checked the batch against pokegold. Almost everything landed. I closed the two leftovers that were still real bugs: #1185 : the active mon no longer reprints GrewToLevel (engine/battle/core.asm:7044). Bench mons still print it, then the stats box, then the learn-move line. #1180 : the party list recalcs stats on open, same as Summary. Gold boot now applies options.touchControls / haptics from the Gold options block, not the shared Red pad. # Verdict 1168 multi-hit FIXED 1180 DVs / stats FIXED 1185 learn-move order FIXED (was partial) 1152 run after faint FIXED 1184 Kurt FIXED 1164 / 1188 Radio Tower FIXED 1173 rocks slide FIXED 1172 Rock Smash name FIXED 1167 Ilex hidden items SKIP-OK (already in the Gold cache) 1165 trade + ledge FIXED 1166 nickname color FIXED 1162 TM ABLE / NOT ABLE FIXED 1169 herb shop white-out FIXED 1151 Pokegear FIXED 1150 / 1190 rebind freeze FIXED 1178 vibration FIXED 1177 touch layout FIXED 1107 save slot FIXED 1145 mod tab filter FIXED 1192 RGXX Gold manifest FIXED Nothing is committed. Drivers, from the repo root: POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/multihit_bug1168_test.lua love . Fury Attack should hit 2-5 times. Always twice is still broken. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/use_next_mon_bug1152_test.lua love . After the lead faints: "Use next POKéMON?" YES opens the party. NO/B tries to run. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/kurt_well_bug1184_test.lua love . Kurt at the well entrance (16, 14), not on the inner path. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/radiotower_softlock_bug1164_test.lua love . Gentleman in the 5F office (3, 6). Stairs at (12, 0) clear. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/rocksmash_shift_bug1173_test.lua love . Route 40 rocks stay put. A slide one cell left is the old bug. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/herbshop_bug1169_test.lua love . Herb shop intro over the Underground map, not a white screen. POKEPORT_GAME=gold POKEPORT_IDENTITY=gold-bug1107 POKEPORT_DRIVER=tests/drivers/gold_save_slot_bug1107_test.lua love . Look for PASS and a saves/gold/slot*.lua path. CONTINUE should see it. Worth a hand check with no driver: nickname color, a TM for ABLE/NOT ABLE, Pokegear phone B-to-close, OPTION > CONTROLS, a ledge hop, a trade movie, and on a phone OPTION > TOUCH LAYOUT / VIBRATION. give me CLOSES #93939 , in a comma separated list each saying CLOSES before each issue number that is fixed CLOSES #1107 , CLOSES #1145 , CLOSES #1150 , CLOSES #1151 , CLOSES #1152 , CLOSES #1162 , CLOSES #1164 , CLOSES #1165 , CLOSES #1166 , CLOSES #1168 , CLOSES #1169 , CLOSES #1172 , CLOSES #1173 , CLOSES #1177 , CLOSES #1178 , CLOSES #1180 , CLOSES #1184 , CLOSES #1185 , CLOSES #1188 , CLOSES #1190 , CLOSES #1192
2026-08-12 16:51:27 -04:00
29a2b9a123
Merge remote-tracking branch 'origin/dev' into feat/mod-pokemon-icon
...
# Conflicts:
# docs/modding.md
2026-08-12 09:46:44 +02:00
e8eccfd4df
Merge pull request #1080 from MaxTomahawk/feat/device-date-time
...
feat(mods): add shared local date and time formatting
2026-08-11 21:21:51 -04:00
0136429d3e
CLOSES #1090 , CLOSES #1093 , CLOSES #1094 , CLOSES #1095 , CLOSES #1098 , CLOSES #1102 , CLOSES #1105 , CLOSES #1106 , CLOSES #1108 , CLOSES #1109 , CLOSES #1110 , CLOSES #1111 , CLOSES #1113 , CLOSES #1114 , CLOSES #1117 , CLOSES #1118 , CLOSES #1121 , CLOSES #1122 , CLOSES #1123 , CLOSES #1124 , CLOSES #1126 , CLOSES #1127 , CLOSES #1128 , CLOSES #1131 , CLOSES #1132 , CLOSES #1134 , CLOSES #1137 , CLOSES #1141
2026-08-11 21:19:36 -04:00
3d2d53362d
Add trueColor to Gen 2's BattleState.lua
...
Without the trueColor option from Gen 1's BattleState, custom sprites are rendered with the orignial sprites color pallete.
2026-08-11 17:51:23 -04:00
ae6cac89e1
G2 support
2026-08-11 11:53:30 -04:00
2c8c800584
feat: add shared date and time formatting
2026-08-11 11:17:32 +02:00
ccb5358aad
feat: expose public Pokemon icon presentation
2026-08-11 11:16:58 +02:00
d21a0edffc
Fix hidden battle UI overlay backgrounds
2026-08-10 20:03:33 -05:00
79ed37699e
Merge pull request #1055 from AverageConsumer/codex/mod-grid-navigation-hooks
...
Mod API: allow alternate battle grids to own navigation
2026-08-10 17:08:24 -04:00
c3855cebec
more buggies CLOSES #960 , CLOSES #961 , CLOSES #968 , CLOSES #995 , CLOSES #1006 , CLOSES #1009 , CLOSES #1013 , CLOSES #1021 , CLOSES #1031 , CLOSES #1044 , CLOSES #1049 , CLOSES #1050 , CLOSES #1045,,
2026-08-10 17:06:24 -04:00
6a990bf79f
feat(mods): allow alternate battle grids to own navigation
2026-08-10 21:22:09 +02:00
9d73ff4110
yellow copyright diff
2026-08-10 14:27:00 -04:00
9302bbcbf3
Merge branch 'fix1037' into fix1038
...
# Conflicts:
# docs/modding.md
2026-08-10 14:12:21 -04:00
e74beec32d
Merge pull request #970 from swuff-star/modded-evo-item
...
add modding support for custom item effects
2026-08-10 14:09:23 -04:00
b52d183dba
Merge pull request #1024 from AverageConsumer/feature/semantic-pc-list-kinds
...
Mod API: expose semantic PC list kinds
2026-08-10 14:09:01 -04:00
12c2677dc2
title screen issues, audio issues, and replacing gf c
2026-08-10 14:00:26 -04:00
3c71afb9fa
Per-category GAME SPEED: overworld/battle/menu + core.logic_speed hook (RFC 0007)
...
GameSpeed is a single fast-forward multiplier applied uniformly to the
whole logic clock -- overworld walking, menu navigation and battle turns
all scale together. A player who wants 4X battles but 1X overworld (so a
cutscene or NPC dialogue doesn't blur past) has no way to get both.
Splits save.options.speed into speedOverworld/speedBattle/speedMenu, each
cycling independently, with an automatic migration so an existing save's
speed choice carries over. Game.speedCategoryInStack resolves which
category is active by walking the state stack (the same idiom
wideBattleInStack/fillScaleInStack already use), so a menu opened mid-
battle inherits battle speed rather than resetting to whatever "menu"
defaults to. Adds a new core.logic_speed hook so a mod can read or
override the resolved multiplier for the current frame regardless of
which category produced it, sitting after the link-play and run-argument
overrides so neither is a seam a mod can defeat.
RFC 0007 status: Proposed.
2026-08-09 20:13:21 -07:00
8906133b93
feat(ui): expose semantic PC list kinds
2026-08-09 15:49:28 +02:00
bdd0bf45bd
Merge pull request #973 from hernan0078/options/cancel-through-strings
...
OPTIONS: route CANCEL through Strings so a translation mod can reach it
2026-08-08 05:44:34 -04:00
d756b7cd43
OPTIONS: route CANCEL through Strings so a translation mod can reach it
...
CANCEL is appended after the `ui.options.rows` hook, deliberately -- that is
what stops a mod from orphaning the exit. But it also means no translation
mod can ever see it: there is no row for one to rewrite, and the hook has
already run by the time it is added.
The result is that a fully translated OPTIONS menu has exactly one English
word left on it, and it is the way out. I hit this with a Spanish catalog
where every row translated and the exit did not.
One call, matching how every other label on this screen is already built.
Nothing changes without a catalog loaded: Strings is an identity function
until a mod supplies one.
Follows the same reasoning as #791 .
2026-08-07 22:14:29 -04:00
abb4f3f9f0
better mod item registry
2026-08-07 20:24:11 -04:00
5b0209a7ce
feat(TitleState): add field.title.player
2026-08-07 14:28:25 -04:00
274c728e77
Merge pull request #950 from jherediagu/fix/translation-readiness
...
Translation-readiness: route the last hardcoded labels through the Strings catalog.
2026-08-07 12:36:47 -04:00
5bc7d203a5
Route the last hardcoded UI labels through the Strings catalog
...
Wrap the battle stat box, the PC quantity footer and the dex metric
labels in Strings() (SummaryMenu -- and MoveEffects since #811 --
already do this); give the battle menu a 'battle' lookup context so a
translation can shorten FIGHT/ITEM/RUN independently of the pause menu;
align the metric dex rows with the imperial ones and make the No.
prefix translatable; make the title menu's recolor zone follow Menu's
auto-grown width; honor the declared-but-unread boot.title seam,
drawing an explicit versionRibbon as one centered piece. With an empty
catalog every path is pixel-identical to vanilla.
2026-08-07 13:59:01 +02:00
f1661b62b3
feat(OakSpeech): use field.playerSprites.walk in shrink step
2026-08-07 00:28:24 -04:00
984cefdc7b
launcher updates
2026-08-06 09:57:31 -04:00
cd37aa175c
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-06 06:36:46 -04:00
cb6cfb5556
CLOSES #883 , CLOSES #887 , CLOSES #894
2026-08-06 06:36:12 -04:00
dbc48f377a
feat(trainerCard): enhance player portrait handling with trueColor support
2026-08-06 00:15:07 -03:00
e2820e02c5
CLOSES #604 , CLOSES #666 , CLOSES #716 , CLOSES #727 , CLOSES #763 , CLOSES #781 , CLOSES #784 , CLOSES #799 , CLOSES #801 , CLOSES #810 , CLOSES #828 , CLOSES #834 , CLOSES #838 , CLOSES #849 , CLOSES #852 , CLOSES #857 , CLOSES #863 , CLOSES #864 , CLOSES #867 , CLOSES #869 , CLOSES #870 , CLOSES #872 , CLOSES #839
2026-08-05 16:36:37 -04:00
f56970350a
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
...
# Conflicts:
# data/scripts/story4.lua
# src/ui/DexEntryMenu.lua
# tests/drivers/fighting_dojo_bug197_test.lua
2026-08-05 14:43:05 -04:00
863f371e68
CLOSES #806 , CLOSES #809 , CLOSES #853 , CLOSES #854 , CLOSES #860 , CLOSES #862 , CLOSES #865 , CLOSES #866
2026-08-05 14:38:10 -04:00
78744a6853
Merge pull request #856 from johnjohto/fix-karate-master-dex-entry
...
Show the Pokédex entry for the Fighting Dojo prize balls
2026-08-05 11:18:03 -04:00
104c95a942
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-05 11:15:49 -04:00
f6392e8932
CLOSES #788 , CLOSES #795 , CLOSES #796 , CLOSES #797 , CLOSES #805 , CLOSES #826 , CLOSES #833 , CLOSES #835 , CLOSES #837 , CLOSES #844 , CLOSES #845 , CLOSES #846 , CLOSES #847
2026-08-05 11:09:05 -04:00
MaxTomahawk
bryanthaboi
ShaneMcGovernIE
AverageConsumer
bryanthaboi
Adrian Castro
MaxTomahawk
Dorian Burton
anxiousintrovert
david
hernan
Hanan Rodebaugh
Yukita Mayako
Juan Heredia
Marcelo Machado