a94fecfec8
Closes #919 , closes #982 , closes #1003 , closes #1012 , closes #1022 , closes #1028 , closes #1033
2026-08-14 10:05:51 -04:00
e9d431b3ff
CLOSES #1091 , CLOSES #1097 , CLOSES #1100 , CLOSES #1104 , CLOSES #1135 , CLOSES #1155 , CLOSES #1157 , CLOSES #1158 , CLOSES #1159 , CLOSES #1160 , CLOSES #1167 , CLOSES #1208
2026-08-13 05:30:33 -04:00
6731937841
Pulled every open Gold bug (bodies, comments, screenshots/videos), matched them against the port and ../pokegold, then split them so each fixer owns a disjoint file set. Duplicates collapsed: #1164 and #1188 are the same Radio Tower stair softlock. #1150 and #1190 are the same Gold rebind freeze. Enhancements ( #1161 , #1130 , #1112 , #1100 ) were left out. Battle 1 src/battle/gen2/*, src/ui/gen2/BattleState.lua #1168 multi-hit always 2 #1180 DV / stats #1185 learn-move text order after a trainer fight #1152 no "Use next POKéMON?" / run after a wild faint Overworld 2 src/world/gen2/*, trade anim, hidden items #1184 Kurt blocking Slowpoke Well #1164 / #1188 Radio Tower gentleman on the stairs #1173 Rock Smash rocks walk left each visit #1172 last item name used Rock Smash #1167 Ilex Forest hidden items #1165 trade movie + ledge hop still missing ( #1121 / #1126 ) UI 3 naming, party, mart, pokegear #1166 grey nickname screen #1162 TM/HM missing ABLE / NOT ABLE #1169 underground herb lady whites out the map #1151 Pokegear black player icon + extra A/B on the phone card Platform 4 Gold options, save slots, pack, mod tab #1150 / #1190 controls freeze #1178 no vibration row #1177 cannot move Gold touch controls #1107 SAVE with no launcher slot #1145 Gold mod tab still lists Gen 1-only mods #1192 RGXX missing tools/rom_manifest_gold.json Drivers only for the progress / data-loss ones (faint-run, multi-hit, Kurt, Radio Tower, Rock Smash shift, herb shop, save slot). No new unit tests. New comments are pokegold file.asm:line only. A verifier agent will get this same list once the four finish and check that the diffs actually fix the reports. Verifier checked the batch against pokegold. Almost everything landed. I closed the two leftovers that were still real bugs: #1185 : the active mon no longer reprints GrewToLevel (engine/battle/core.asm:7044). Bench mons still print it, then the stats box, then the learn-move line. #1180 : the party list recalcs stats on open, same as Summary. Gold boot now applies options.touchControls / haptics from the Gold options block, not the shared Red pad. # Verdict 1168 multi-hit FIXED 1180 DVs / stats FIXED 1185 learn-move order FIXED (was partial) 1152 run after faint FIXED 1184 Kurt FIXED 1164 / 1188 Radio Tower FIXED 1173 rocks slide FIXED 1172 Rock Smash name FIXED 1167 Ilex hidden items SKIP-OK (already in the Gold cache) 1165 trade + ledge FIXED 1166 nickname color FIXED 1162 TM ABLE / NOT ABLE FIXED 1169 herb shop white-out FIXED 1151 Pokegear FIXED 1150 / 1190 rebind freeze FIXED 1178 vibration FIXED 1177 touch layout FIXED 1107 save slot FIXED 1145 mod tab filter FIXED 1192 RGXX Gold manifest FIXED Nothing is committed. Drivers, from the repo root: POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/multihit_bug1168_test.lua love . Fury Attack should hit 2-5 times. Always twice is still broken. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/use_next_mon_bug1152_test.lua love . After the lead faints: "Use next POKéMON?" YES opens the party. NO/B tries to run. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/kurt_well_bug1184_test.lua love . Kurt at the well entrance (16, 14), not on the inner path. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/radiotower_softlock_bug1164_test.lua love . Gentleman in the 5F office (3, 6). Stairs at (12, 0) clear. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/rocksmash_shift_bug1173_test.lua love . Route 40 rocks stay put. A slide one cell left is the old bug. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/herbshop_bug1169_test.lua love . Herb shop intro over the Underground map, not a white screen. POKEPORT_GAME=gold POKEPORT_IDENTITY=gold-bug1107 POKEPORT_DRIVER=tests/drivers/gold_save_slot_bug1107_test.lua love . Look for PASS and a saves/gold/slot*.lua path. CONTINUE should see it. Worth a hand check with no driver: nickname color, a TM for ABLE/NOT ABLE, Pokegear phone B-to-close, OPTION > CONTROLS, a ledge hop, a trade movie, and on a phone OPTION > TOUCH LAYOUT / VIBRATION. give me CLOSES #93939 , in a comma separated list each saying CLOSES before each issue number that is fixed CLOSES #1107 , CLOSES #1145 , CLOSES #1150 , CLOSES #1151 , CLOSES #1152 , CLOSES #1162 , CLOSES #1164 , CLOSES #1165 , CLOSES #1166 , CLOSES #1168 , CLOSES #1169 , CLOSES #1172 , CLOSES #1173 , CLOSES #1177 , CLOSES #1178 , CLOSES #1180 , CLOSES #1184 , CLOSES #1185 , CLOSES #1188 , CLOSES #1190 , CLOSES #1192
2026-08-12 16:51:27 -04:00
0136429d3e
CLOSES #1090 , CLOSES #1093 , CLOSES #1094 , CLOSES #1095 , CLOSES #1098 , CLOSES #1102 , CLOSES #1105 , CLOSES #1106 , CLOSES #1108 , CLOSES #1109 , CLOSES #1110 , CLOSES #1111 , CLOSES #1113 , CLOSES #1114 , CLOSES #1117 , CLOSES #1118 , CLOSES #1121 , CLOSES #1122 , CLOSES #1123 , CLOSES #1124 , CLOSES #1126 , CLOSES #1127 , CLOSES #1128 , CLOSES #1131 , CLOSES #1132 , CLOSES #1134 , CLOSES #1137 , CLOSES #1141
2026-08-11 21:19:36 -04:00
ae6cac89e1
G2 support
2026-08-11 11:53:30 -04:00
c3855cebec
more buggies CLOSES #960 , CLOSES #961 , CLOSES #968 , CLOSES #995 , CLOSES #1006 , CLOSES #1009 , CLOSES #1013 , CLOSES #1021 , CLOSES #1031 , CLOSES #1044 , CLOSES #1049 , CLOSES #1050 , CLOSES #1045,,
2026-08-10 17:06:24 -04:00
9302bbcbf3
Merge branch 'fix1037' into fix1038
...
# Conflicts:
# docs/modding.md
2026-08-10 14:12:21 -04:00
a74365a4fd
Merge pull request #1043 from ShaneMcGovernIE/shanemcgovernie-fix-rival-collision
...
Fix champion rival walk-out route
2026-08-10 14:08:49 -04:00
12c2677dc2
title screen issues, audio issues, and replacing gf c
2026-08-10 14:00:26 -04:00
02c4de897d
Fix champion rival walk-out route
...
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com >
2026-08-10 10:59:06 +01:00
3c71afb9fa
Per-category GAME SPEED: overworld/battle/menu + core.logic_speed hook (RFC 0007)
...
GameSpeed is a single fast-forward multiplier applied uniformly to the
whole logic clock -- overworld walking, menu navigation and battle turns
all scale together. A player who wants 4X battles but 1X overworld (so a
cutscene or NPC dialogue doesn't blur past) has no way to get both.
Splits save.options.speed into speedOverworld/speedBattle/speedMenu, each
cycling independently, with an automatic migration so an existing save's
speed choice carries over. Game.speedCategoryInStack resolves which
category is active by walking the state stack (the same idiom
wideBattleInStack/fillScaleInStack already use), so a menu opened mid-
battle inherits battle speed rather than resetting to whatever "menu"
defaults to. Adds a new core.logic_speed hook so a mod can read or
override the resolved multiplier for the current frame regardless of
which category produced it, sitting after the link-play and run-argument
overrides so neither is a seam a mod can defeat.
RFC 0007 status: Proposed.
2026-08-09 20:13:21 -07:00
00f6e3a7b4
CLOSES #889
2026-08-06 14:36:01 -04:00
e2820e02c5
CLOSES #604 , CLOSES #666 , CLOSES #716 , CLOSES #727 , CLOSES #763 , CLOSES #781 , CLOSES #784 , CLOSES #799 , CLOSES #801 , CLOSES #810 , CLOSES #828 , CLOSES #834 , CLOSES #838 , CLOSES #849 , CLOSES #852 , CLOSES #857 , CLOSES #863 , CLOSES #864 , CLOSES #867 , CLOSES #869 , CLOSES #870 , CLOSES #872 , CLOSES #839
2026-08-05 16:36:37 -04:00
f56970350a
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
...
# Conflicts:
# data/scripts/story4.lua
# src/ui/DexEntryMenu.lua
# tests/drivers/fighting_dojo_bug197_test.lua
2026-08-05 14:43:05 -04:00
863f371e68
CLOSES #806 , CLOSES #809 , CLOSES #853 , CLOSES #854 , CLOSES #860 , CLOSES #862 , CLOSES #865 , CLOSES #866
2026-08-05 14:38:10 -04:00
78744a6853
Merge pull request #856 from johnjohto/fix-karate-master-dex-entry
...
Show the Pokédex entry for the Fighting Dojo prize balls
2026-08-05 11:18:03 -04:00
f6392e8932
CLOSES #788 , CLOSES #795 , CLOSES #796 , CLOSES #797 , CLOSES #805 , CLOSES #826 , CLOSES #833 , CLOSES #835 , CLOSES #837 , CLOSES #844 , CLOSES #845 , CLOSES #846 , CLOSES #847
2026-08-05 11:09:05 -04:00
1f878c3098
Show the Pokédex entry for the Fighting Dojo prize balls
2026-08-05 10:18:47 -04:00
4e666303d0
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-04 15:13:07 -04:00
0fa8206321
CLOSES #785 , CLOSES #807 , CLOSES #811 , CLOSES #814
2026-08-04 15:13:06 -04:00
6fe106f55c
Stop offering the route Pokemon Centers as fly destinations
2026-08-04 12:28:08 -04:00
f2d9b74490
CLOSES #644 , CLOSES #703 , CLOSES #726 , CLOSES #737 , CLOSES #750 , CLOSES #752 , CLOSES #764 , CLOSES #765 , CLOSES #768 , CLOSES #773 , CLOSES #774 , CLOSES #775 , CLOSES #777 , CLOSES #780 , CLOSES #782
2026-08-04 09:25:28 -04:00
3a6557ffe2
CLOSES #779 , CLOSES #743 + new font
2026-08-04 06:41:34 -04:00
f89977a8e7
Merge pull request #747 from johnjohto/fix-fly-animation-702
...
Play the full Fly departure and landing animation (#702 )
2026-08-03 16:11:40 -04:00
f19f4e9341
Play the full Fly departure and landing animation ( #702 )
2026-08-03 13:11:40 -04:00
0f7261dd92
CLOSES #623 , CLOSES #624 , CLOSES #636 , CLOSES #637 , CLOSES #639 , CLOSES #650 , CLOSES #697 , CLOSES #704 , CLOSES #722
2026-08-03 13:05:57 -04:00
fe7dcf33ec
feat: UI LAYOUT option, centered by default
...
Edge docking and zoom-linked UI scaling shipped as unconditional
behaviour. Both are departures from how the port composed the screen, so
they become a setting instead: UI LAYOUT = CENTERED (the default) or
DYNAMIC.
CENTERED is a fixed letterbox. Elements stay where they were drawn in the
160x144 canvas, and the UI does not follow the survey zoom, so screen
furniture neither moves nor resizes under the player. That is what the
pre-anchoring builds did. DYNAMIC is the current behaviour, unchanged.
Both halves matter together: gating only the anchoring would stop the
dialogue box moving but leave it resizing with the zoom, which is the same
complaint in a different form.
Gated at Renderer:setUIAnchor and Renderer:uiScale rather than at each
caller, so one switch covers the dialogue box, its YES/NO, the START menu
and anything anchored later, and no caller knows the option exists.
Game.dynamicUI answers true only for an explicit "dynamic", so a save
written before this keeps the layout it already had.
Independent of it, deliberately: BATTLE SIZE still works under either mode
(uiFill overrides the scale later, in endFrame), and a battle still holds
its own prompts inside its screen under DYNAMIC.
Also includes the Oak intro fix (previously #674 ): the speech fills white
over the UI canvas while its dialogue box docks to the window edge, so
under DYNAMIC black showed between the two. letterboxWhite closes it, and
the shrink beat's replica box rides the same anchor as the real box it
stands in for.
2026-08-02 10:47:27 -06:00
cb26367f46
Merge pull request #655 from spiritsnails/fix/warden-yesno-645
2026-08-02 08:26:05 -04:00
35b3fa6d9c
CLOSES #455 , CLOSES #487 , CLOSES #501 , CLOSES #540 , CLOSES #585 , CLOSES #591 , CLOSES #593 , CLOSES #595 , CLOSES #597 , CLOSES #599 , CLOSES #600 , CLOSES #606 , CLOSES #607 , CLOSES #610 , CLOSES #613 , CLOSES #616 , CLOSES #620 , CLOSES #626 , CLOSES #632 , CLOSES #633 , CLOSES #647
2026-08-02 08:19:28 -04:00
9934e4d765
fix: Warden's House gibberish line offers YES/NO
...
WardensHouseWardenText prints Gibberish1, calls YesNoChoice, and answers
with Gibberish2 on yes / Gibberish3 on no (scripts/WardensHouse.asm). The
port printed the question and ended the script. Both reply strings were
already extracted and unused, so this is script wiring only.
The branch targets become labels: they were hand-numbered absolute rows,
already mis-pointed once (#535 ), and any insert meant renumbering jumps
that had no way to announce they were stale.
Also fixes the parity suite's show_text instrumentation, which stopped
forwarding arguments at `subs` and so dropped the extraOpts carrying
Commands.ask's choice callback -- silently turning every ask under test
back into a plain show_text.
2026-08-02 00:34:46 -06:00
9f072285a6
Merge pull request #611 from ShaneMcGovernIE/fix/oak-last-ball-601
2026-08-01 16:00:52 -04:00
0dd187fe30
Fix wrong dialogue on Prof. Oak's leftover ball ( #601 )
...
After the player picks a starter and the rival takes his, every ball on
the lab table fell through to 'Those are POKé BALLs' instead of the
leftover-mon line. Port the pokered OaksLabSelectedPokeBallScript ->
OaksLabLastMonScript beat: with EVENT_GOT_STARTER set, Oak turns to face
the player and reads 'That's PROF.OAK's last Pokémon!'. The ROM's
'#MON' ligature is spelled out as Pokémon.
The renumbering also drops the table's nine out-of-range 'jump 21'
rows (run-time 'end' idioms) for explicit "end" targets, so the
script now validates cleanly.
Tests: T2 suite drives the ball talk table through a ScriptRunner-
compatible executor (leftover text, pre-escort text, pre-pick offer)
plus a T3 driver that talks to the leftover ball in a real game.
2026-08-01 20:55:31 +01:00
d5293dffb8
Merge branch 'dev' of https://github.com/bryanthaboi/gen1recomp into dev
2026-08-01 08:10:22 -04:00
9326b07583
CLOSES #415 , CLOSES #484 , CLOSES #488 , CLOSES #492 , CLOSES #497 , CLOSES #541 , CLOSES #559 , CLOSES #562 , CLOSES #563 , CLOSES #564 , CLOSES #565 , CLOSES #566 , CLOSES #567 , CLOSES #568 , CLOSES #569 , CLOSES #570 , CLOSES #571 , CLOSES #572
2026-08-01 08:10:20 -04:00
6e724cedf7
Honor modded bag capacity
2026-08-01 00:32:00 -03:00
fdab15a6dc
CLOSES #503 , CLOSES #511 , CLOSES #515 , CLOSES #518 , CLOSES #522 , CLOSES #523 , CLOSES #525 , CLOSES #528 , CLOSES #529 , CLOSES #533 , CLOSES #535 , CLOSES #536
2026-07-31 20:20:37 -04:00
6c4c9d14e2
Merge pull request #520 from johnjohto/fix-true-color-evolution-trade-494
...
Fix true-color evolution and trade sprites
2026-07-31 10:18:44 -04:00
d165189032
Merge pull request #521 from johnjohto/fix-fighting-dojo-master-gate-495
...
Fix Karate Master gate
2026-07-31 10:08:02 -04:00
84bf25fcd5
Fix Karate Master gate
2026-07-31 09:47:53 -04:00
6796804593
CLOSES #505 , CLOSES #510 , CLOSES #513
2026-07-31 09:08:56 -04:00
858c5bc9b8
Fix true-color evolution and trade sprites
2026-07-31 09:05:19 -04:00
c62f1334bc
merge main into dev
2026-07-30 11:35:57 -04:00
4b9a326f6b
CLOSES #339 , CLOSES #354 , CLOSES #360 , CLOSES #372 , CLOSES #373 , CLOSES #374 , CLOSES #375 , CLOSES #378 , CLOSES #379 , CLOSES #383 , CLOSES #384 , CLOSES #385 , CLOSES #391 , CLOSES #392 , CLOSES #393 , CLOSES #394 , CLOSES #395 , CLOSES #396 , CLOSES #397 , CLOSES #398 , CLOSES #413 , CLOSES #420 , CLOSES #423 , CLOSES #424 , CLOSES #425 , CLOSES #426 , CLOSES #427 , CLOSES #429 , CLOSES #430 , CLOSES #431 , CLOSES #433 , CLOSES #435 , CLOSES #436 , CLOSES #438 , CLOSES #439 , CLOSES #441 , CLOSES #442 , CLOSES #444
2026-07-30 11:14:51 -04:00
0f581e2f69
so many bugs i cannot even breathe
2026-07-30 07:41:41 -04:00
118c45f8f6
CLOSES #407 , CLOSES #408 , CLOSES #409 , CLOSES #410 , CLOSES #411 , CLOSES #417
...
CLOSES #407 , CLOSES #408 , CLOSES #409 , CLOSES #410 , CLOSES #411 , CLOSES #417
2026-07-29 15:06:33 -04:00
dde25ec7d0
yellow alpha
2026-07-29 11:46:32 -04:00
370ddea0b8
fix the mf grass
2026-07-28 15:14:48 -04:00
a03f69926e
bazinga
2026-07-28 15:01:59 -04:00
8539a6b268
launcher editor and widescreen battle
2026-07-28 12:00:15 -04:00
f9f38d161f
CLOSES #223 , CLOSES #233 , CLOSES #236 , CLOSES #240 , CLOSES #241 , CLOSES #249 , CLOSES #252 , CLOSES #255 , CLOSES #257 , CLOSES #258 , CLOSES #263 , CLOSES #265 , CLOSES #274 , CLOSES #275 , CLOSES #276 , CLOSES #279 , CLOSES #280 , CLOSES #282 , CLOSES #283 , CLOSES #287 , CLOSES #291 , CLOSES #292 , CLOSES #293 , CLOSES #301 , CLOSES #304 , CLOSES #315 , CLOSES #316 , CLOSES #317 , CLOSES #321 , CLOSES #322 , CLOSES #330
2026-07-28 10:29:05 -04:00
bryanthaboi
bryanthaboi
Shane McGovern
david
johnjohto
spiritsnails
Shane McGovern
erereck