pokemon/gen1recomp
1
0
Fork 0
mirror of https://github.com/bryanthaboi/gen1recomp.git synced 2026-08-20 04:31:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixes the greyscale cutoff for boulder.png

Browse Source 
A fixed cutoff (e.g. "<=200 is ink") only makes sense for sprites with a light background to split against; a mostly-opaque 16x16 icon has almost no pixel above that cutoff, so every such icon collapsed onto the same "all ink" hash and was flagged as a near-duplicate of anything else that also collapsed -- which was most of them, boulder.png included. Thresholding against the image's own mean keeps the split meaningful (and roughly balanced) no matter how light or dark the source is.
This commit is contained in:
Dorian Burton
2026-08-19 14:56:08 -04:00
parent def270f7c7
commit 667267d9bb
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/modkit.py
+15 -4
View File
@@ -988,14 +988,25 @@ def cmd_add_release_workflow(args, repo):
# ---------------------------------------------------------------- lint
def ahash(image):
"""Ink-mask hash over the 8x8 downscale: background (the lightest GB
shade) vs ink. Swapping the three ink shades -- the classic recolor --
leaves the mask intact, which is exactly what MK302 wants to catch."""
"""Ink-mask hash over the 8x8 downscale: background vs ink, split at
THIS image's own average brightness rather than a fixed shade. Swapping
the three ink shades -- the classic recolor -- leaves the mask intact,
which is exactly what MK302 wants to catch.
A fixed cutoff (e.g. "<=200 is ink") only makes sense for sprites with a
light background to split against; a mostly-opaque 16x16 icon has almost
no pixel above that cutoff, so every such icon collapsed onto the same
"all ink" hash and was flagged as a near-duplicate of anything else that
also collapsed -- which was most of them, boulder.png included.
Thresholding against the image's own mean keeps the split meaningful
(and roughly balanced) no matter how light or dark the source is."""
from PIL import Image
small = image.convert("L").resize((8, 8), Image.LANCZOS)
raw = (small.get_flattened_data() if hasattr(small, "get_flattened_data")
else small.getdata())
return sum((1 << i) for i, p in enumerate(raw) if p <= 200)
raw = list(raw)
average = sum(raw) / len(raw)
return sum((1 << i) for i, p in enumerate(raw) if p <= average)
def hamming(a, b):