LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-12 00:20:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

opengl: only populate Shader:getWarnings string when there are warnings.

Browse Source
This commit is contained in:
Sasha Szpakowski
2024-02-27 23:17:24 -04:00
parent 57fab45c2c
commit ff06718f8a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/opengl/Shader.cpp
+1 -1
View File
@@ -600,7 +600,7 @@ std::string Shader::getWarnings() const
const std::string &stagewarnings = stage->getWarnings();
if (ShaderStage::getConstant(stage->getStageType(), stagestr))
if (!stagewarnings.empty() && ShaderStage::getConstant(stage->getStageType(), stagestr))
warnings += std::string(stagestr) + std::string(" shader:\n") + stagewarnings;
}
testing/tests/graphics.lua
+1 -1
View File
@@ -803,7 +803,7 @@ love.test.graphics.Shader = function(test)
]]
local shader1 = love.graphics.newShader(pixelcode1, vertexcode1, {debugname = 'testshader'})
test:assertObject(shader1)
test:assertEquals('vertex shader:\npixel shader:\n', shader1:getWarnings(), 'check shader valid')
test:assertEquals('', shader1:getWarnings(), 'check shader valid')
test:assertFalse(shader1:hasUniform('tex1'), 'check invalid uniform')
test:assertTrue(shader1:hasUniform('tex2'), 'check valid uniform')
test:assertEquals('testshader', shader1:getDebugName())