6731937841
Pulled every open Gold bug (bodies, comments, screenshots/videos), matched them against the port and ../pokegold, then split them so each fixer owns a disjoint file set. Duplicates collapsed: #1164 and #1188 are the same Radio Tower stair softlock. #1150 and #1190 are the same Gold rebind freeze. Enhancements ( #1161 , #1130 , #1112 , #1100 ) were left out. Battle 1 src/battle/gen2/*, src/ui/gen2/BattleState.lua #1168 multi-hit always 2 #1180 DV / stats #1185 learn-move text order after a trainer fight #1152 no "Use next POKéMON?" / run after a wild faint Overworld 2 src/world/gen2/*, trade anim, hidden items #1184 Kurt blocking Slowpoke Well #1164 / #1188 Radio Tower gentleman on the stairs #1173 Rock Smash rocks walk left each visit #1172 last item name used Rock Smash #1167 Ilex Forest hidden items #1165 trade movie + ledge hop still missing ( #1121 / #1126 ) UI 3 naming, party, mart, pokegear #1166 grey nickname screen #1162 TM/HM missing ABLE / NOT ABLE #1169 underground herb lady whites out the map #1151 Pokegear black player icon + extra A/B on the phone card Platform 4 Gold options, save slots, pack, mod tab #1150 / #1190 controls freeze #1178 no vibration row #1177 cannot move Gold touch controls #1107 SAVE with no launcher slot #1145 Gold mod tab still lists Gen 1-only mods #1192 RGXX missing tools/rom_manifest_gold.json Drivers only for the progress / data-loss ones (faint-run, multi-hit, Kurt, Radio Tower, Rock Smash shift, herb shop, save slot). No new unit tests. New comments are pokegold file.asm:line only. A verifier agent will get this same list once the four finish and check that the diffs actually fix the reports. Verifier checked the batch against pokegold. Almost everything landed. I closed the two leftovers that were still real bugs: #1185 : the active mon no longer reprints GrewToLevel (engine/battle/core.asm:7044). Bench mons still print it, then the stats box, then the learn-move line. #1180 : the party list recalcs stats on open, same as Summary. Gold boot now applies options.touchControls / haptics from the Gold options block, not the shared Red pad. # Verdict 1168 multi-hit FIXED 1180 DVs / stats FIXED 1185 learn-move order FIXED (was partial) 1152 run after faint FIXED 1184 Kurt FIXED 1164 / 1188 Radio Tower FIXED 1173 rocks slide FIXED 1172 Rock Smash name FIXED 1167 Ilex hidden items SKIP-OK (already in the Gold cache) 1165 trade + ledge FIXED 1166 nickname color FIXED 1162 TM ABLE / NOT ABLE FIXED 1169 herb shop white-out FIXED 1151 Pokegear FIXED 1150 / 1190 rebind freeze FIXED 1178 vibration FIXED 1177 touch layout FIXED 1107 save slot FIXED 1145 mod tab filter FIXED 1192 RGXX Gold manifest FIXED Nothing is committed. Drivers, from the repo root: POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/multihit_bug1168_test.lua love . Fury Attack should hit 2-5 times. Always twice is still broken. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/use_next_mon_bug1152_test.lua love . After the lead faints: "Use next POKéMON?" YES opens the party. NO/B tries to run. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/kurt_well_bug1184_test.lua love . Kurt at the well entrance (16, 14), not on the inner path. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/radiotower_softlock_bug1164_test.lua love . Gentleman in the 5F office (3, 6). Stairs at (12, 0) clear. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/rocksmash_shift_bug1173_test.lua love . Route 40 rocks stay put. A slide one cell left is the old bug. POKEPORT_GAME=gold POKEPORT_TOUCH=0 POKEPORT_DRIVER=tests/drivers/herbshop_bug1169_test.lua love . Herb shop intro over the Underground map, not a white screen. POKEPORT_GAME=gold POKEPORT_IDENTITY=gold-bug1107 POKEPORT_DRIVER=tests/drivers/gold_save_slot_bug1107_test.lua love . Look for PASS and a saves/gold/slot*.lua path. CONTINUE should see it. Worth a hand check with no driver: nickname color, a TM for ABLE/NOT ABLE, Pokegear phone B-to-close, OPTION > CONTROLS, a ledge hop, a trade movie, and on a phone OPTION > TOUCH LAYOUT / VIBRATION. give me CLOSES #93939 , in a comma separated list each saying CLOSES before each issue number that is fixed CLOSES #1107 , CLOSES #1145 , CLOSES #1150 , CLOSES #1151 , CLOSES #1152 , CLOSES #1162 , CLOSES #1164 , CLOSES #1165 , CLOSES #1166 , CLOSES #1168 , CLOSES #1169 , CLOSES #1172 , CLOSES #1173 , CLOSES #1177 , CLOSES #1178 , CLOSES #1180 , CLOSES #1184 , CLOSES #1185 , CLOSES #1188 , CLOSES #1190 , CLOSES #1192
2026-08-12 16:51:27 -04:00
ae6cac89e1
G2 support
2026-08-11 11:53:30 -04:00
86b90fd4b8
Merge pull request #821 from johnjohto/fix-held-direction-799
...
Rebuild held input after lifecycle resets
2026-08-04 16:37:59 -04:00
0fa8206321
CLOSES #785 , CLOSES #807 , CLOSES #811 , CLOSES #814
2026-08-04 15:13:06 -04:00
78ac154998
Rebuild held input after lifecycle resets
...
A focus flip, visibility flip, joystick add/remove, or resume reset all
held input, and a still-held direction never re-fires keypressed, so any
spurious reset (macOS Bluetooth re-enumeration fires joystickadded with
no hotplug) parked the player until every direction was re-pressed.
Reconcile from device ground truth after each reset; only what is
physically down comes back, so swallowed releases still clear.
2026-08-04 14:08:15 -04:00
cbf622f4aa
Merge branch 'dev' into feat/switch-nx
...
Bring feat/switch-nx up to date with origin/dev (72 commits). Resolve
Input/RomImporter conflicts by keeping GamepadMap (NX face remap + dual-path
gate) while adopting upstream joyBindings rebinds (#632 ) and Enable-all mods
(#647 ). Gate shoulder GAME SPEED hotkeys when Select is held so Select+L
display chords still work.
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-02 21:36:56 -03:00
35b3fa6d9c
CLOSES #455 , CLOSES #487 , CLOSES #501 , CLOSES #540 , CLOSES #585 , CLOSES #591 , CLOSES #593 , CLOSES #595 , CLOSES #597 , CLOSES #599 , CLOSES #600 , CLOSES #606 , CLOSES #607 , CLOSES #610 , CLOSES #613 , CLOSES #616 , CLOSES #620 , CLOSES #626 , CLOSES #632 , CLOSES #633 , CLOSES #647
2026-08-02 08:19:28 -04:00
5bc76ce6fe
Merge branch 'dev' into feat/switch-nx
...
Bring latest upstream fixes (Metal/iOS, encounter slide, second-screen seam) into the Switch NX feature branch.
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-01 12:12:07 -03:00
9326b07583
CLOSES #415 , CLOSES #484 , CLOSES #488 , CLOSES #492 , CLOSES #497 , CLOSES #541 , CLOSES #559 , CLOSES #562 , CLOSES #563 , CLOSES #564 , CLOSES #565 , CLOSES #566 , CLOSES #567 , CLOSES #568 , CLOSES #569 , CLOSES #570 , CLOSES #571 , CLOSES #572
2026-08-01 08:10:20 -04:00
2699c9a2f9
fix(input): Nintendo A/B face map on NX
...
SDL labels south as a and east as b; on Switch remap so physical A
confirms and physical B cancels in launcher and NamingScreen.
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-01 04:24:57 -03:00
efd81d8e34
fix(input): ignore raw face presses when Joy-Con is gamepad
...
love-nx emits gamepad+raw on one press; NamingScreen saw a+b and always
erased. Skip raw when isGamepad(); align NX Y→a/X→b; prefer A if both.
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-01 04:15:47 -03:00
83cf1fdb00
refactor(input): share gamepad map between launcher and gameplay
...
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-01 03:53:13 -03:00
8a649e8d95
Handle generic joystick input
...
Unmapped handheld controllers emit joystick events, leaving the launcher
cursor and in-game input inactive.
2026-07-30 10:38:24 -04:00
f9f38d161f
CLOSES #223 , CLOSES #233 , CLOSES #236 , CLOSES #240 , CLOSES #241 , CLOSES #249 , CLOSES #252 , CLOSES #255 , CLOSES #257 , CLOSES #258 , CLOSES #263 , CLOSES #265 , CLOSES #274 , CLOSES #275 , CLOSES #276 , CLOSES #279 , CLOSES #280 , CLOSES #282 , CLOSES #283 , CLOSES #287 , CLOSES #291 , CLOSES #292 , CLOSES #293 , CLOSES #301 , CLOSES #304 , CLOSES #315 , CLOSES #316 , CLOSES #317 , CLOSES #321 , CLOSES #322 , CLOSES #330
2026-07-28 10:29:05 -04:00
a8936e79d6
Add on-screen touch controls and assets
2026-07-25 23:16:15 -04:00
819150f50f
Bugs and stuff ( #146 )
...
* main menu scrollable when over 8 items
* buggies
* more buggies
* Lorelei, Bruno, and Agatha now push their AfterBattle text right after a win
* more and more bugs
2026-07-24 09:26:43 -04:00
839cf19088
bzinga
2026-07-22 12:28:51 -04:00
4311955c43
input sticky bug
2026-07-22 10:38:37 -04:00
a5d2e77e7d
initial commit
2026-07-17 20:30:02 -04:00
bryanthaboi
johnjohto
Andrew Quenehen