Fix Gen 1/2 battle, menu, PC and audio parity gaps; wire luacheck into CI

CLOSES #1484, CLOSES #1486, CLOSES #1513, CLOSES #1517, CLOSES #1556, CLOSES #1564, CLOSES #1567
This commit is contained in:
bryanthaboi
2026-08-21 19:22:34 -04:00
parent 087a275189
commit c0f4315cd8
45 changed files with 2487 additions and 168 deletions
+3
View File
@@ -699,6 +699,9 @@ REQUIRED_SYMBOLS = {
# marker without this symbol.
"MonMenuIcons", "Icons", "IconPointers", "HeldItemIcons",
"PokedexDataPointerTable",
# engine/pokemon/bills_pc.asm:2170-2173 (the four vTiles2 $5c tiles
# PCMonInfo prints at :1086/:1091) and engine/gfx/cgb_layouts.asm:287.
"PCMailGFX", "BillsPCOrangePalette",
# New-game / Pokecenter respawn table (data/maps/spawn_points.asm)
"SpawnPoints",
"NewPokedexOrder", "AlphabeticalPokedexOrder", "Landmarks",
+72 -56
View File
@@ -12912,6 +12912,10 @@
105,
16837
],
"BillsPCOrangePalette": [
2,
21965
],
"BlastoiseBackpic": [
25,
30882
@@ -12936,6 +12940,10 @@
107,
21761
],
"BoltEmote": [
5,
17737
],
"BugCatchingContestantEventFlagTable": [
4,
32186
@@ -12968,6 +12976,30 @@
26,
26667
],
"CardFlipLZ01": [
56,
21795
],
"CardFlipLZ02": [
56,
22197
],
"CardFlipLZ03": [
56,
21736
],
"CardFlipOffButtonGFX": [
56,
21763
],
"CardFlipOnButtonGFX": [
56,
21779
],
"CardFlipTilemap": [
56,
22809
],
"CardStatusGFX": [
9,
22287
@@ -13612,6 +13644,10 @@
106,
19800
],
"FishEmote": [
5,
17865
],
"FishGroups": [
36,
27127
@@ -13956,6 +13992,10 @@
4,
26664
],
"HeartEmote": [
5,
17673
],
"HeldItemIcons": [
35,
26843
@@ -15420,6 +15460,10 @@
5,
18398
],
"PCMailGFX": [
56,
31768
],
"PackGFX": [
4,
21553
@@ -16096,22 +16140,6 @@
5,
17417
],
"HeartEmote": [
5,
17673
],
"BoltEmote": [
5,
17737
],
"SleepEmote": [
5,
17801
],
"FishEmote": [
5,
17865
],
"Shrink1Pic": [
62,
30142
@@ -16156,6 +16184,26 @@
106,
22935
],
"SleepEmote": [
5,
17801
],
"Slots1LZ": [
36,
31138
],
"Slots2LZ": [
36,
31522
],
"Slots3LZ": [
36,
32130
],
"SlotsTilemap": [
36,
30898
],
"SlowbroBackpic": [
26,
32198
@@ -16356,6 +16404,14 @@
105,
22509
],
"StatsScreenPagePals": [
2,
21715
],
"StatsScreenPageTilesGFX": [
62,
19106
],
"StatsScreen_PlaceFrontpic": [
20,
20675
@@ -17667,46 +17723,6 @@
"wBaseUnusedFrontpic": [
1,
53554
],
"Slots1LZ": [
36,
31138
],
"Slots2LZ": [
36,
31522
],
"Slots3LZ": [
36,
32130
],
"SlotsTilemap": [
36,
30898
],
"CardFlipLZ01": [
56,
21795
],
"CardFlipLZ02": [
56,
22197
],
"CardFlipLZ03": [
56,
21736
],
"CardFlipOnButtonGFX": [
56,
21779
],
"CardFlipOffButtonGFX": [
56,
21763
],
"CardFlipTilemap": [
56,
22809
]
},
"tilesets": {
+56 -40
View File
@@ -12912,6 +12912,10 @@
105,
16840
],
"BillsPCOrangePalette": [
2,
21965
],
"BlastoiseBackpic": [
25,
31647
@@ -12972,6 +12976,30 @@
26,
27406
],
"CardFlipLZ01": [
56,
21795
],
"CardFlipLZ02": [
56,
22197
],
"CardFlipLZ03": [
56,
21736
],
"CardFlipOffButtonGFX": [
56,
21763
],
"CardFlipOnButtonGFX": [
56,
21779
],
"CardFlipTilemap": [
56,
22809
],
"CardStatusGFX": [
9,
22287
@@ -15432,6 +15460,10 @@
5,
18398
],
"PCMailGFX": [
56,
31768
],
"PackGFX": [
4,
21553
@@ -16156,6 +16188,22 @@
5,
17801
],
"Slots1LZ": [
36,
31138
],
"Slots2LZ": [
36,
31522
],
"Slots3LZ": [
36,
32130
],
"SlotsTilemap": [
36,
30898
],
"SlowbroBackpic": [
26,
31900
@@ -16356,6 +16404,14 @@
105,
22501
],
"StatsScreenPagePals": [
2,
21715
],
"StatsScreenPageTilesGFX": [
62,
19106
],
"StatsScreen_PlaceFrontpic": [
20,
20675
@@ -17667,46 +17723,6 @@
"wBaseUnusedFrontpic": [
1,
53554
],
"Slots1LZ": [
36,
31138
],
"Slots2LZ": [
36,
31522
],
"Slots3LZ": [
36,
32130
],
"SlotsTilemap": [
36,
30898
],
"CardFlipLZ01": [
56,
21795
],
"CardFlipLZ02": [
56,
22197
],
"CardFlipLZ03": [
56,
21736
],
"CardFlipOnButtonGFX": [
56,
21779
],
"CardFlipOffButtonGFX": [
56,
21763
],
"CardFlipTilemap": [
56,
22809
]
},
"tilesets": {