pokemon/gen1recomp
1
0
Fork 0
mirror of https://github.com/bryanthaboi/gen1recomp.git synced 2026-08-12 08:21:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #959 from MaxTomahawk/feat/reproducible-mod-packages

Browse Source 
fix: make modkit packages reproducible with SOURCE_DATE_EPOCH
This commit is contained in:
bryanthaboi
2026-08-07 12:43:50 -04:00
committed by GitHub
parent 91a85a065b 02fd21bcdb
commit 5b6dfed359
2 changed files with 65 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/modkit_tests.lua
+46
View File
@@ -636,6 +636,52 @@ local packed = io.open(cleanPkg, "rb")
check(packed ~= nil, "pack writes the package")
if packed then packed:close() end
-- Reproducible-build callers pin the informational pack timestamp through the
-- standard SOURCE_DATE_EPOCH contract. Two clean invocations over the same
-- input must then produce identical archive bytes and metadata.
local epoch = "1234567890"
local envPrefix = isWindows
and ('set "SOURCE_DATE_EPOCH=%s" && '):format(epoch)
or ("SOURCE_DATE_EPOCH=%s "):format(epoch)
local deterministicA = root .. "/declared-a.modpkg"
local deterministicB = root .. "/declared-b.modpkg"
out, code = run(envPrefix ..
("%s tools/modkit.py pack %q -o %q --base fixture")
:format(python, declared, deterministicA))
check(code == 0, "SOURCE_DATE_EPOCH package A succeeds: " .. out)
out, code = run(envPrefix ..
("%s tools/modkit.py pack %q -o %q --base fixture")
:format(python, declared, deterministicB))
check(code == 0, "SOURCE_DATE_EPOCH package B succeeds: " .. out)
local archiveA = assert(io.open(deterministicA, "rb"))
local bytesA = archiveA:read("*a")
archiveA:close()
local archiveB = assert(io.open(deterministicB, "rb"))
local bytesB = archiveB:read("*a")
archiveB:close()
check(bytesA == bytesB, "SOURCE_DATE_EPOCH makes package bytes reproducible")
local inspectPack = root .. "/inspect_pack.py"
write(inspectPack, [[
import json, sys, zipfile
with zipfile.ZipFile(sys.argv[1]) as archive:
meta = json.loads(archive.read(".modkit/pack.json"))
assert meta["packed_at"] == "2009-02-13T23:31:30Z", meta["packed_at"]
]])
out, code = run(("%s %q %q"):format(python, inspectPack, deterministicA))
check(code == 0, "pack metadata honors SOURCE_DATE_EPOCH: " .. out)
local invalidEpochPrefix = isWindows
and 'set "SOURCE_DATE_EPOCH=not-a-time" && '
or "SOURCE_DATE_EPOCH=not-a-time "
local invalidEpochPkg = root .. "/declared-invalid-epoch.modpkg"
out, code = run(invalidEpochPrefix ..
("%s tools/modkit.py pack %q -o %q --base fixture")
:format(python, declared, invalidEpochPkg))
check(code == 2, "invalid SOURCE_DATE_EPOCH is a usage failure: " .. out)
check(out:find("SOURCE_DATE_EPOCH", 1, true) ~= nil,
"invalid source epoch names the failed contract")
check(io.open(invalidEpochPkg, "rb") == nil,
"invalid source epoch writes no package")
-- MK305 diffs shipped tables against the imported dataset; fake one under
-- a scratch repo root so the check exercises the same on ROM-less machines
local fake = root .. "/fakerepo"