pokemon/gen1recomp
1
0
Fork 0
mirror of https://github.com/bryanthaboi/gen1recomp.git synced 2026-08-19 12:15:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(import): drop redundant mobileFileBridge or and unused ready

Browse Source 
scanInbox never consulted ready, and mobileFileBridge already mirrors
android on Android/iOS, so the dual guard was a no-op.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Andrew Quenehen
2026-08-03 10:02:17 -03:00
parent 17843c2f7a
commit 50fd0e9c7d
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/engine/rom_importer_nx_mods_inbox_test.lua
+3 -3
View File
@@ -112,7 +112,7 @@ eq(zips[1], "imports/mods/valid.zip", "scanModsInbox path is under imports/mods/
ri = freshImporter()
love.filesystem.write("imports/modpack.zip", "ZIPROM")
love.filesystem.write("imports/mods/also.zip", "ZIPMOD")
local roms = ri:scanInbox(ri.ready)
local roms = ri:scanInbox()
for _, path in ipairs(roms) do
check(not path:lower():match("%.zip$"),
"ROM scanInbox ignores zip: " .. tostring(path))
@@ -123,7 +123,7 @@ eq(#roms, 0, "ROM scanInbox finds no zip-only inbox entries")
ri = freshImporter()
love.filesystem.write("imports/cart.gb", string.rep("G", 16))
love.filesystem.write("imports/sidecar.zip", "NOTAROM")
roms = ri:scanInbox(ri.ready)
roms = ri:scanInbox()
local sawGb, sawZip = false, false
for _, path in ipairs(roms) do
if path:lower():match("%.zip$") then sawZip = true end
@@ -221,7 +221,7 @@ check(not (ri.modNotice.text or ""):find("failed", 1, true),
ri = freshImporter()
love.filesystem.write("imports/._cart.gb", string.rep("X", 16))
love.filesystem.write("imports/cart.gb", string.rep("G", 16))
roms = ri:scanInbox(ri.ready)
roms = ri:scanInbox()
local sawHidden, sawReal = false, false
for _, path in ipairs(roms) do
if path:find("._cart", 1, true) then sawHidden = true end