CLOSES #998, CLOSES #1472, CLOSES #1526, CLOSES #1529, CLOSES #1530, CLOSES #1532, CLOSES #1534, CLOSES #1547, CLOSES #1549, CLOSES #1550, CLOSES #1551

tests/engine/pc_accessed_text_bug1529.lua

@@ -0,0 +1,100 @@
+-- engine/menus/pc.asm prints the access text between SFX_ENTER_PC and the
+-- farcall: BillsPC (:73-85) picks AccessedBillsPCText / AccessedSomeonesPCText
+-- off EVENT_MET_BILL, .playersPC (:50-59) prints AccessedMyPCText.  The port
+-- opened BoxMenu / PlayerPC straight from the sound (#1529).
+package.path = "./?.lua;./?/init.lua;" .. package.path
+
+local T = require("tests.modkit")
+local Data = T.fixtures.load()
+
+Data.text._TurnedOnPC1Text = "{PLAYER} turned on\nthe PC."
+Data.text._AccessedBillsPCText = "Accessed BILL's\nPC.\fAccessed POKéMON\nStorage System."
+Data.text._AccessedSomeonesPCText =
+  "Accessed someone's\nPC.\fAccessed POKéMON\nStorage System."
+Data.text._AccessedMyPCText = "Accessed my PC.\fAccessed Item\nStorage System."
+
+local SaveData = require("src.core.SaveData")
+local OW = require("src.world.OverworldController")
+
+local function setUpvalue(fn, name, val)
+  local i = 1
+  while true do
+    local n = debug.getupvalue(fn, i)
+    if not n then return false end
+    if n == name then debug.setupvalue(fn, i, val); return true end
+    i = i + 1
+  end
+end
+
+local pushed, screens = {}, {}
+local stackStub = { push = function(_, item) pushed[#pushed + 1] = item end }
+local textBoxStub = {
+  new = function(_, text, onDone, opts)
+    return { kind = "text", text = text, onDone = onDone, opts = opts }
+  end,
+}
+local menuStub = {
+  new = function(_, items, opts) return { kind = "menu", items = items, opts = opts or {} } end,
+}
+package.loaded["src.core.Sound"] = { play = function() end, playCry = function() end }
+package.loaded["src.ui.Menu"] = menuStub
+
+local fakeGame = { data = Data, save = SaveData.newGame(), stack = stackStub }
+T.check(setUpvalue(OW.openPC, "Game", fakeGame), "Game upvalue on openPC")
+T.check(setUpvalue(OW.openPC, "TextBox", textBoxStub), "TextBox upvalue on openPC")
+T.check(setUpvalue(OW.openPC, "Screens",
+  { push = function(_, id) screens[#screens + 1] = id end }), "Screens upvalue on openPC")
+
+local fakeSelf = setmetatable({}, { __index = OW })
+
+local function openMenu(metBill)
+  pushed, screens = {}, {}
+  fakeGame.save = SaveData.newGame()
+  if metBill then fakeGame.save.flags.EVENT_MET_BILL = true end
+  fakeSelf:openPC(function() end)
+  local pcOn = pushed[#pushed]
+  T.eq(pcOn.kind, "text", "the session opens with TurnedOnPC1Text")
+  pcOn.onDone()
+  local menu = pushed[#pushed]
+  T.eq(menu.kind, "menu", "then the PC menu")
+  return menu
+end
+
+-- === SOMEONE'S PC: the access text before BoxMenu
+do
+  local menu = openMenu(false)
+  menu.items[1].onSelect()
+  local box = pushed[#pushed]
+  T.eq(box.kind, "text", "the box row opens a text box")
+  T.check(tostring(box.text):find("Accessed someone's", 1, true) ~= nil,
+    "before meeting BILL it is AccessedSomeonesPCText")
+  T.eq(#screens, 0, "and the box screen has NOT opened yet")
+  box.onDone()
+  T.eq(screens[1], "BoxMenu", "BoxMenu follows the text, as the farcall does")
+end
+
+-- === BILL'S PC once EVENT_MET_BILL is set
+do
+  local menu = openMenu(true)
+  menu.items[1].onSelect()
+  local box = pushed[#pushed]
+  T.check(tostring(box.text):find("Accessed BILL's", 1, true) ~= nil,
+    "after meeting BILL it is AccessedBillsPCText")
+  box.onDone()
+  T.eq(screens[1], "BoxMenu", "and still opens BoxMenu")
+end
+
+-- === the player's item storage
+do
+  local menu = openMenu(false)
+  menu.items[2].onSelect()
+  local box = pushed[#pushed]
+  T.eq(box.kind, "text", "the item row opens a text box")
+  T.check(tostring(box.text):find("Accessed my PC.", 1, true) ~= nil,
+    "and it is AccessedMyPCText")
+  T.eq(#screens, 0, "PlayerPC has not opened yet")
+  box.onDone()
+  T.eq(screens[1], "PlayerPC", "PlayerPC follows the text")
+end
+
+T.finish("PC access text (#1529)")