From 44bfb1b93f7271d5107f23e5e322d4124b870826 Mon Sep 17 00:00:00 2001 From: Andrew Quenehen Date: Mon, 3 Aug 2026 09:58:53 -0300 Subject: [PATCH] test(nx): move ROM-free NX suites into the engine tier platform_nx_* and rom_importer_nx_* run with the love stub and must execute in CI's ROM-free lane via tests/run_engine.lua, not only T3. Co-authored-by: Cursor --- docs/switch-development.md | 2 +- tests/{ => engine}/platform_nx_network_gate_test.lua | 0 tests/{ => engine}/platform_nx_shell_gate_test.lua | 0 tests/{ => engine}/platform_nx_test.lua | 2 +- tests/{ => engine}/rom_importer_nx_flags_test.lua | 0 tests/{ => engine}/rom_importer_nx_inbox_test.lua | 0 tests/{ => engine}/rom_importer_nx_mods_inbox_test.lua | 0 tests/{ => engine}/rom_importer_nx_saves_inbox_test.lua | 0 tests/run_tests.lua | 9 ++------- 9 files changed, 4 insertions(+), 9 deletions(-) rename tests/{ => engine}/platform_nx_network_gate_test.lua (100%) rename tests/{ => engine}/platform_nx_shell_gate_test.lua (100%) rename tests/{ => engine}/platform_nx_test.lua (97%) rename tests/{ => engine}/rom_importer_nx_flags_test.lua (100%) rename tests/{ => engine}/rom_importer_nx_inbox_test.lua (100%) rename tests/{ => engine}/rom_importer_nx_mods_inbox_test.lua (100%) rename tests/{ => engine}/rom_importer_nx_saves_inbox_test.lua (100%) diff --git a/docs/switch-development.md b/docs/switch-development.md index 10525801..7bada5df 100644 --- a/docs/switch-development.md +++ b/docs/switch-development.md @@ -519,7 +519,7 @@ Each slice should declare: **no ROM/save bytes committed**, **love-nx pin with m - `src/core/Platform.lua`, `conf.lua` NX branch - `src/import/RomImporter.lua` (NX flags, inbox, scan, shell/updater gates) -- Tests: `tests/platform_nx_*`, `tests/rom_importer_nx_*` +- Tests: `tests/engine/platform_nx_*`, `tests/engine/rom_importer_nx_*` (ROM-free T2) - Docs: inbox/MTP import sections only ### Slice 2 — Input + lifecycle (`input/lifecycle`) diff --git a/tests/platform_nx_network_gate_test.lua b/tests/engine/platform_nx_network_gate_test.lua similarity index 100% rename from tests/platform_nx_network_gate_test.lua rename to tests/engine/platform_nx_network_gate_test.lua diff --git a/tests/platform_nx_shell_gate_test.lua b/tests/engine/platform_nx_shell_gate_test.lua similarity index 100% rename from tests/platform_nx_shell_gate_test.lua rename to tests/engine/platform_nx_shell_gate_test.lua diff --git a/tests/platform_nx_test.lua b/tests/engine/platform_nx_test.lua similarity index 97% rename from tests/platform_nx_test.lua rename to tests/engine/platform_nx_test.lua index 91fba03c..af7c88aa 100644 --- a/tests/platform_nx_test.lua +++ b/tests/engine/platform_nx_test.lua @@ -1,5 +1,5 @@ -- NX / Android / desktop capability detection (SWNX-01). --- Self-contained: luajit tests/platform_nx_test.lua +-- Self-contained: luajit tests/engine/platform_nx_test.lua package.path = "./?.lua;./?/init.lua;" .. package.path diff --git a/tests/rom_importer_nx_flags_test.lua b/tests/engine/rom_importer_nx_flags_test.lua similarity index 100% rename from tests/rom_importer_nx_flags_test.lua rename to tests/engine/rom_importer_nx_flags_test.lua diff --git a/tests/rom_importer_nx_inbox_test.lua b/tests/engine/rom_importer_nx_inbox_test.lua similarity index 100% rename from tests/rom_importer_nx_inbox_test.lua rename to tests/engine/rom_importer_nx_inbox_test.lua diff --git a/tests/rom_importer_nx_mods_inbox_test.lua b/tests/engine/rom_importer_nx_mods_inbox_test.lua similarity index 100% rename from tests/rom_importer_nx_mods_inbox_test.lua rename to tests/engine/rom_importer_nx_mods_inbox_test.lua diff --git a/tests/rom_importer_nx_saves_inbox_test.lua b/tests/engine/rom_importer_nx_saves_inbox_test.lua similarity index 100% rename from tests/rom_importer_nx_saves_inbox_test.lua rename to tests/engine/rom_importer_nx_saves_inbox_test.lua diff --git a/tests/run_tests.lua b/tests/run_tests.lua index 215d637d..6119e18c 100644 --- a/tests/run_tests.lua +++ b/tests/run_tests.lua @@ -3376,13 +3376,8 @@ runSuites({ "tests/rom_importer_android_mod_pick_test.lua" }) runSuites({ "tests/rom_importer_no_picker_test.lua" }) runSuites({ "tests/rom_importer_double_pick_test.lua" }) -- ---------------------------------------------- Switch platform capabilities -runSuites({ "tests/platform_nx_test.lua" }) -runSuites({ "tests/platform_nx_shell_gate_test.lua" }) -runSuites({ "tests/platform_nx_network_gate_test.lua" }) -runSuites({ "tests/rom_importer_nx_flags_test.lua" }) -runSuites({ "tests/rom_importer_nx_inbox_test.lua" }) -runSuites({ "tests/rom_importer_nx_mods_inbox_test.lua" }) -runSuites({ "tests/rom_importer_nx_saves_inbox_test.lua" }) +-- platform_nx_* / rom_importer_nx_* live in tests/engine/ (ROM-free T2) so +-- CI's headless lane runs them without data/generated/. runSuites({ "tests/launcher_mods_install_zip_test.lua" }) -- ---------------------------------------------- parity workstream tests -- Each tests/parity_*.lua is a self-contained file (own bootstrap + check,