CLOSES #1211, CLOSES #1228, CLOSES #1229, CLOSES #1232, CLOSES #1251, CLOSES #1265, CLOSES #1267, CLOSES #1276, CLOSES #1279, CLOSES #1282, CLOSES #1293, CLOSES #1296, CLOSES #1303, CLOSES #1329, CLOSES #1338, CLOSES #1341, CLOSES #1343, CLOSES #1344, CLOSES #1368, CLOSES #1385, CLOSES #1388, CLOSES #1389, CLOSES #1391

2026-08-18 03:35:56 +02:00 · 2026-08-16 08:55:40 -04:00
parent 65128e13a4
commit 1151c188a7
50 changed files with 2835 additions and 276 deletions
@@ -0,0 +1,83 @@
+-- #1251: the Game Corner's `CheckCoinsAndCoinCase` transcription must ask
+-- the bag about the real COIN_CASE item id, not SILVER_WING.
+-- constants/item_constants.asm:62 (COIN_CASE = $36); SILVER_WING is $47.
+package.path = "./?.lua;./?/init.lua;" .. package.path
+
+local T = require("tests.harness")
+
+local Vm = require("src.script.gen2.Vm")
+local Specials = require("src.script.gen2.Specials")
+local Events = require("src.world.gen2.Events")
+
+local COIN_CASE = 0x36
+local SILVER_WING = 0x47
+
+-- 1) the id the handler actually queries the bag with
+local seenId
+local vm = Vm.new({ generation = 2 }, {}, Events.new(), {
+  specials = {
+    coins = function() return 100 end,
+    hasItem = function(id) seenId = id return true end,
+    gameCornerGame = function(_, done) done() end,
+  },
+})
+vm.showTextFn = function() end
+vm.co = coroutine.create(function() Specials.HANDLERS.SlotMachine(vm) end)
+coroutine.resume(vm.co)
+T.eq(seenId, COIN_CASE,
+  "SlotMachine's CheckItem call carries the real COIN_CASE id ($36)")
+T.check(seenId ~= SILVER_WING,
+  "and specifically not SILVER_WING ($47), the pre-fix value")
+
+-- 2) a bag holding ONLY the real coin case (not the silver wing) must be
+-- enough to open both machines: this is what would still fail if the id
+-- above were merely logged and not actually used to gate the machine.
+local bag = { [COIN_CASE] = true }
+local slotsOpened, flipOpened
+local vm2 = Vm.new({ generation = 2 }, {}, Events.new(), {
+  specials = {
+    coins = function() return 50 end,
+    hasItem = function(id) return bag[id] == true end,
+    gameCornerGame = function(kind, done) slotsOpened = kind done() end,
+  },
+})
+vm2.showTextFn = function() end
+vm2.co = coroutine.create(function() Specials.HANDLERS.SlotMachine(vm2) end)
+coroutine.resume(vm2.co)
+T.eq(slotsOpened, "slots",
+  "a bag with the real COIN CASE and coins opens the slot machine")
+
+local vm3 = Vm.new({ generation = 2 }, {}, Events.new(), {
+  specials = {
+    coins = function() return 50 end,
+    hasItem = function(id) return bag[id] == true end,
+    gameCornerGame = function(kind, done) flipOpened = kind done() end,
+  },
+})
+vm3.showTextFn = function() end
+vm3.co = coroutine.create(function() Specials.HANDLERS.CardFlip(vm3) end)
+coroutine.resume(vm3.co)
+T.eq(flipOpened, "cardflip",
+  "and the same bag opens card flip too")
+
+-- 3) the mirror case: SILVER_WING in the bag, no coin case, must still
+-- refuse with _NoCoinCaseText (this is the exact symptom in #1251, and it
+-- is the yield the coroutine parks on, not a call, so opening never runs
+-- behind it).
+local wrongBag = { [SILVER_WING] = true }
+local opened = false
+local vm4 = Vm.new({ generation = 2 }, {}, Events.new(), {
+  specials = {
+    coins = function() return 50 end,
+    hasItem = function(id) return wrongBag[id] == true end,
+    gameCornerGame = function() opened = true end,
+  },
+})
+vm4.showTextFn = function() end
+vm4.co = coroutine.create(function() Specials.HANDLERS.SlotMachine(vm4) end)
+local _, refusal = coroutine.resume(vm4.co)
+T.eq(refusal and refusal.text, "You don't have a\nCOIN CASE.",
+  "holding only SILVER_WING gets the real _NoCoinCaseText refusal")
+T.check(not opened, "and the machine never opens behind it")
+
+T.finish("gen2_coin_case_bug1251")