CLOSES #1211, CLOSES #1228, CLOSES #1229, CLOSES #1232, CLOSES #1251, CLOSES #1265, CLOSES #1267, CLOSES #1276, CLOSES #1279, CLOSES #1282, CLOSES #1293, CLOSES #1296, CLOSES #1303, CLOSES #1329, CLOSES #1338, CLOSES #1341, CLOSES #1343, CLOSES #1344, CLOSES #1368, CLOSES #1385, CLOSES #1388, CLOSES #1389, CLOSES #1391

2026-08-19 12:15:31 +02:00 · 2026-08-16 08:55:40 -04:00
parent 65128e13a4
commit 1151c188a7
50 changed files with 2835 additions and 276 deletions
@@ -0,0 +1,49 @@
+-- engine/battle/experience.asm:69
+
+package.path = "./?.lua;./?/init.lua;" .. package.path
+
+love = require("tests.love_stub")
+
+local T = require("tests.harness")
+local BattleState = require("src.battle.BattleState")
+
+local function newSave()
+  return { player = { id = 12345, name = "RED" } }
+end
+
+do
+  local save = newSave()
+  local homegrown = {}
+  BattleState.stampOT(save, homegrown)
+  T.eq(homegrown.otId, 12345, "a home-grown mon is still stamped with the player id")
+  T.eq(homegrown.ot, "RED", "and the player's own name")
+end
+
+-- The bug: a mon that arrived traded (traded = true) but whose OT id was
+-- never recorded (a legacy peer, a link mon with no otId in its packet) used
+-- to get save.player.id written into otId on the very first load, which then
+-- reads identically to a mon the player caught -- awardExp's OT-id compare
+-- (BattleState.lua ~4009) permanently loses the 1.5x boost.
+do
+  local save = newSave()
+  local tradedNoId = { traded = true }
+  BattleState.stampOT(save, tradedNoId)
+  T.eq(tradedNoId.otId, nil,
+    "a traded mon with no OT id is left unstamped, not silently adopted")
+  T.eq(tradedNoId.ot, "RED",
+    "the OT NAME fill still happens (cosmetic, not the boost gate)")
+  -- a second stampOT pass (a second save/load cycle) must not adopt it either
+  BattleState.stampOT(save, tradedNoId)
+  T.eq(tradedNoId.otId, nil, "repeated reloads do not eventually stamp it")
+end
+
+-- A mon with its own foreign OT id (the ordinary traded-in case) is untouched
+-- either way; this is the arm the regression never broke.
+do
+  local save = newSave()
+  local tradedWithId = { traded = true, otId = 777 }
+  BattleState.stampOT(save, tradedWithId)
+  T.eq(tradedWithId.otId, 777, "a recorded foreign OT id is never overwritten")
+end
+
+T.finish("exp traded ot survives reload bug 1265")