LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-12 08:30:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Show a popup error if love.window loads but love.graphics does not.

Browse Source 
Also include backend-specific errors in graphics initalization error messages.
Improves visibility of errors related to vulkan/metal/opengl initialization.
Related to #2335.
This commit is contained in:
Sasha Szpakowski
2026-07-12 11:01:02 -03:00
parent 540e681454
commit e47acd766d
6 changed files with 48 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/Graphics.cpp
+23 -7
View File
@@ -36,6 +36,7 @@
// C++
#include <algorithm>
#include <tuple>
#include <stdlib.h>
namespace love
@@ -106,12 +107,12 @@ bool isDebugEnabled()
love::Type Graphics::type("graphics", &Module::type);
namespace opengl { extern love::graphics::Graphics *createInstance(); }
namespace opengl { extern std::tuple<love::graphics::Graphics *, std::string> createInstance(); }
#ifdef LOVE_GRAPHICS_METAL
namespace metal { extern love::graphics::Graphics *createInstance(); }
namespace metal { extern std::tuple<love::graphics::Graphics *, std::string> createInstance(); }
#endif
#ifdef LOVE_GRAPHICS_VULKAN
namespace vulkan { extern love::graphics::Graphics *createInstance(); }
namespace vulkan { extern std::tuple<love::graphics::Graphics *, std::string> createInstance(); }
#endif
static const Renderer rendererOrder[] = {
@@ -164,6 +165,7 @@ bool isLowPowerPreferred()
Graphics *Graphics::createInstance()
{
Graphics *instance = Module::getInstance<Graphics>(M_GRAPHICS);
std::string errors;
if (instance != nullptr)
instance->retain();
@@ -171,25 +173,39 @@ Graphics *Graphics::createInstance()
{
for (auto r : rendererOrder)
{
if (std::find(_renderers.begin(), _renderers.end(), r) == _renderers.end())
continue;
std::string err;
#ifdef LOVE_GRAPHICS_VULKAN
if (r == RENDERER_VULKAN)
instance = vulkan::createInstance();
std::tie(instance, err) = vulkan::createInstance();
#endif
if (r == RENDERER_OPENGL)
instance = opengl::createInstance();
std::tie(instance, err) = opengl::createInstance();
#ifdef LOVE_GRAPHICS_METAL
if (r == RENDERER_METAL)
instance = metal::createInstance();
std::tie(instance, err) = metal::createInstance();
#endif
if (!err.empty())
{
errors += err;
if (isDebugEnabled())
::printf("%s", err.c_str());
}
if (instance != nullptr)
break;
}
}
if (instance == nullptr)
{
throw love::Exception("Cannot create graphics: no supported renderer on this system.\n%s", errors.c_str());
}
return instance;
}