LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-28 18:26:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

Respond to PR feedback.

Browse Source
This commit is contained in:
Erin Maus
2026-07-24 08:06:52 -04:00
parent efa18664a0
commit d8430c39df
5 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/Graphics.cpp
-1
View File
@@ -2990,7 +2990,6 @@ STRINGMAP_CLASS_BEGIN(Graphics, Graphics::Feature, Graphics::FEATURE_MAX_ENUM, f
{ "indirectdraw", Graphics::FEATURE_INDIRECT_DRAW }, { "indirectdraw", Graphics::FEATURE_INDIRECT_DRAW },
{ "vertexwrite", Graphics::FEATURE_VERTEX_WRITE }, { "vertexwrite", Graphics::FEATURE_VERTEX_WRITE },
{ "pixelwrite", Graphics::FEATURE_PIXEL_WRITE }, { "pixelwrite", Graphics::FEATURE_PIXEL_WRITE },
{ "imageatomics", Graphics::FEATURE_IMAGE_ATOMICS },
} }
STRINGMAP_CLASS_END(Graphics, Graphics::Feature, Graphics::FEATURE_MAX_ENUM, feature) STRINGMAP_CLASS_END(Graphics, Graphics::Feature, Graphics::FEATURE_MAX_ENUM, feature)
src/modules/graphics/Graphics.h
-1
View File
@@ -165,7 +165,6 @@ public:
FEATURE_INDIRECT_DRAW, FEATURE_INDIRECT_DRAW,
FEATURE_VERTEX_WRITE, FEATURE_VERTEX_WRITE,
FEATURE_PIXEL_WRITE, FEATURE_PIXEL_WRITE,
FEATURE_IMAGE_ATOMICS,
FEATURE_MAX_ENUM FEATURE_MAX_ENUM
}; };
src/modules/graphics/metal/Graphics.mm
+1 -4
View File
@@ -2264,10 +2264,7 @@ void Graphics::initCapabilities()
capabilities.features[FEATURE_PIXEL_WRITE] = false; capabilities.features[FEATURE_PIXEL_WRITE] = false;
} }
// Not supported until Metal 3 static_assert(FEATURE_MAX_ENUM == 15, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
capabilities.features[FEATURE_IMAGE_ATOMICS] = false;
static_assert(FEATURE_MAX_ENUM == 16, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
// https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf // https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf
capabilities.limits[LIMIT_POINT_SIZE] = 511; capabilities.limits[LIMIT_POINT_SIZE] = 511;
src/modules/graphics/opengl/Graphics.cpp
+1 -2
View File
@@ -1634,8 +1634,7 @@ void Graphics::initCapabilities()
capabilities.features[FEATURE_INDIRECT_DRAW] = capabilities.features[FEATURE_GLSL4]; capabilities.features[FEATURE_INDIRECT_DRAW] = capabilities.features[FEATURE_GLSL4];
capabilities.features[FEATURE_VERTEX_WRITE] = capabilities.features[FEATURE_GLSL4]; capabilities.features[FEATURE_VERTEX_WRITE] = capabilities.features[FEATURE_GLSL4];
capabilities.features[FEATURE_PIXEL_WRITE] = capabilities.features[FEATURE_GLSL4]; capabilities.features[FEATURE_PIXEL_WRITE] = capabilities.features[FEATURE_GLSL4];
capabilities.features[FEATURE_IMAGE_ATOMICS] = capabilities.features[FEATURE_GLSL4]; static_assert(FEATURE_MAX_ENUM == 15, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
static_assert(FEATURE_MAX_ENUM == 16, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
capabilities.limits[LIMIT_POINT_SIZE] = gl.getMaxPointSize(); capabilities.limits[LIMIT_POINT_SIZE] = gl.getMaxPointSize();
capabilities.limits[LIMIT_TEXTURE_SIZE] = gl.getMax2DTextureSize(); capabilities.limits[LIMIT_TEXTURE_SIZE] = gl.getMax2DTextureSize();
src/modules/graphics/vulkan/Graphics.cpp
+1 -2
View File
@@ -838,8 +838,7 @@ void Graphics::initCapabilities()
capabilities.features[FEATURE_INDIRECT_DRAW] = true; capabilities.features[FEATURE_INDIRECT_DRAW] = true;
capabilities.features[FEATURE_VERTEX_WRITE] = features.vertexPipelineStoresAndAtomics; capabilities.features[FEATURE_VERTEX_WRITE] = features.vertexPipelineStoresAndAtomics;
capabilities.features[FEATURE_PIXEL_WRITE] = features.fragmentStoresAndAtomics; capabilities.features[FEATURE_PIXEL_WRITE] = features.fragmentStoresAndAtomics;
capabilities.features[FEATURE_IMAGE_ATOMICS] = true; static_assert(FEATURE_MAX_ENUM == 15, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
static_assert(FEATURE_MAX_ENUM == 16, "Graphics::initCapabilities must be updated when adding a new graphics feature!");
VkPhysicalDeviceProperties properties; VkPhysicalDeviceProperties properties;
vkGetPhysicalDeviceProperties(physicalDevice, &properties); vkGetPhysicalDeviceProperties(physicalDevice, &properties);