LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-16 16:20:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add 'staging' buffer data usage enum.

Browse Source
This commit is contained in:
Alex Szpakowski
2021-12-28 12:49:33 -04:00
parent 52101b2563
commit bfcf025ef7
6 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/opengl/Buffer.cpp
+8 -4
View File
@@ -157,6 +157,11 @@ bool Buffer::load(const void *initialdata)
return (glGetError() == GL_NO_ERROR);
}
bool Buffer::supportsOrphan() const
{
return dataUsage == BUFFERDATAUSAGE_STREAM || dataUsage == BUFFERDATAUSAGE_DYNAMIC;
}
void *Buffer::map(MapType /*map*/, size_t offset, size_t size)
{
if (size == 0)
@@ -202,7 +207,7 @@ void Buffer::unmap(size_t usedoffset, size_t usedsize)
mapped = false;
// Orphan optimization - see fill().
if (dataUsage != BUFFERDATAUSAGE_STATIC && mappedRange.first == 0 && mappedRange.getSize() == getSize())
if (supportsOrphan() && mappedRange.first == 0 && mappedRange.getSize() == getSize())
{
usedoffset = 0;
usedsize = getSize();
@@ -234,15 +239,14 @@ void Buffer::fill(size_t offset, size_t size, const void *data)
gl.bindBuffer(mapUsage, buffer);
if (dataUsage != BUFFERDATAUSAGE_STATIC && size == buffersize)
if (supportsOrphan() && size == buffersize)
{
// "orphan" current buffer to avoid implicit synchronisation on the GPU:
// http://www.seas.upenn.edu/~pcozzi/OpenGLInsights/OpenGLInsights-AsynchronousBufferTransfers.pdf
gl.bindBuffer(mapUsage, buffer);
glBufferData(target, (GLsizeiptr) buffersize, nullptr, gldatausage);
#if LOVE_WINDOWS
// TODO: Verify that this codepath is a useful optimization.
// TODO: Verify that this intel codepath is a useful optimization.
if (gl.getVendor() == OpenGL::VENDOR_INTEL)
glBufferData(target, (GLsizeiptr) buffersize, data, gldatausage);
else