Aesthete: Bug #829: Adding missing exception guards to audio source wrapper.

--HG--
branch : minor
This commit is contained in:
Aesthete
2014-04-23 11:15:14 +10:00
parent a2473f860d
commit ba21f79966
+408 -408
View File
@@ -1,408 +1,408 @@
/** /**
* Copyright (c) 2006-2014 LOVE Development Team * Copyright (c) 2006-2014 LOVE Development Team
* *
* This software is provided 'as-is', without any express or implied * This software is provided 'as-is', without any express or implied
* warranty. In no event will the authors be held liable for any damages * warranty. In no event will the authors be held liable for any damages
* arising from the use of this software. * arising from the use of this software.
* *
* Permission is granted to anyone to use this software for any purpose, * Permission is granted to anyone to use this software for any purpose,
* including commercial applications, and to alter it and redistribute it * including commercial applications, and to alter it and redistribute it
* freely, subject to the following restrictions: * freely, subject to the following restrictions:
* *
* 1. The origin of this software must not be misrepresented; you must not * 1. The origin of this software must not be misrepresented; you must not
* claim that you wrote the original software. If you use this software * claim that you wrote the original software. If you use this software
* in a product, an acknowledgment in the product documentation would be * in a product, an acknowledgment in the product documentation would be
* appreciated but is not required. * appreciated but is not required.
* 2. Altered source versions must be plainly marked as such, and must not be * 2. Altered source versions must be plainly marked as such, and must not be
* misrepresented as being the original software. * misrepresented as being the original software.
* 3. This notice may not be removed or altered from any source distribution. * 3. This notice may not be removed or altered from any source distribution.
**/ **/
#include <limits> #include <limits>
#include "wrap_Source.h" #include "wrap_Source.h"
namespace love namespace love
{ {
namespace audio namespace audio
{ {
Source *luax_checksource(lua_State *L, int idx) Source *luax_checksource(lua_State *L, int idx)
{ {
return luax_checktype<Source>(L, idx, "Source", AUDIO_SOURCE_T); return luax_checktype<Source>(L, idx, "Source", AUDIO_SOURCE_T);
} }
int w_Source_clone(lua_State *L) int w_Source_clone(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
Source *clone = nullptr; Source *clone = nullptr;
EXCEPT_GUARD(clone = t->clone();) EXCEPT_GUARD(clone = t->clone();)
luax_pushtype(L, "Source", AUDIO_SOURCE_T, clone); luax_pushtype(L, "Source", AUDIO_SOURCE_T, clone);
return 1; return 1;
} }
int w_Source_play(lua_State *L) int w_Source_play(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, t->play()); luax_pushboolean(L, t->play());
return 1; return 1;
} }
int w_Source_stop(lua_State *L) int w_Source_stop(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->stop(); t->stop();
return 0; return 0;
} }
int w_Source_pause(lua_State *L) int w_Source_pause(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->pause(); t->pause();
return 0; return 0;
} }
int w_Source_resume(lua_State *L) int w_Source_resume(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->resume(); t->resume();
return 0; return 0;
} }
int w_Source_rewind(lua_State *L) int w_Source_rewind(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->rewind(); t->rewind();
return 0; return 0;
} }
int w_Source_setPitch(lua_State *L) int w_Source_setPitch(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float p = (float)luaL_checknumber(L, 2); float p = (float)luaL_checknumber(L, 2);
if (p > std::numeric_limits<lua_Number>::max() || if (p > std::numeric_limits<lua_Number>::max() ||
p < std::numeric_limits<lua_Number>::min() || p < std::numeric_limits<lua_Number>::min() ||
p != p) p != p)
return luaL_error(L, "Pitch has to be finite and not NaN."); return luaL_error(L, "Pitch has to be finite and not NaN.");
t->setPitch(p); t->setPitch(p);
return 0; return 0;
} }
int w_Source_getPitch(lua_State *L) int w_Source_getPitch(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushnumber(L, t->getPitch()); lua_pushnumber(L, t->getPitch());
return 1; return 1;
} }
int w_Source_setVolume(lua_State *L) int w_Source_setVolume(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float p = (float)luaL_checknumber(L, 2); float p = (float)luaL_checknumber(L, 2);
t->setVolume(p); t->setVolume(p);
return 0; return 0;
} }
int w_Source_getVolume(lua_State *L) int w_Source_getVolume(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushnumber(L, t->getVolume()); lua_pushnumber(L, t->getVolume());
return 1; return 1;
} }
int w_Source_seek(lua_State *L) int w_Source_seek(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float offset = (float)luaL_checknumber(L, 2); float offset = (float)luaL_checknumber(L, 2);
if (offset < 0) if (offset < 0)
return luaL_argerror(L, 2, "can't seek to a negative position"); return luaL_argerror(L, 2, "can't seek to a negative position");
Source::Unit u = Source::UNIT_SECONDS; Source::Unit u = Source::UNIT_SECONDS;
const char *unit = lua_isnoneornil(L, 3) ? 0 : lua_tostring(L, 3); const char *unit = lua_isnoneornil(L, 3) ? 0 : lua_tostring(L, 3);
if (unit && !t->getConstant(unit, u)) if (unit && !t->getConstant(unit, u))
return luaL_error(L, "Invalid Source time unit: %s", unit); return luaL_error(L, "Invalid Source time unit: %s", unit);
t->seek(offset, u); t->seek(offset, u);
return 0; return 0;
} }
int w_Source_tell(lua_State *L) int w_Source_tell(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
Source::Unit u = Source::UNIT_SECONDS; Source::Unit u = Source::UNIT_SECONDS;
const char *unit = lua_isnoneornil(L, 2) ? 0 : lua_tostring(L, 2); const char *unit = lua_isnoneornil(L, 2) ? 0 : lua_tostring(L, 2);
if (unit && !t->getConstant(unit, u)) if (unit && !t->getConstant(unit, u))
return luaL_error(L, "Invalid Source time unit: %s", unit); return luaL_error(L, "Invalid Source time unit: %s", unit);
lua_pushnumber(L, t->tell(u)); lua_pushnumber(L, t->tell(u));
return 1; return 1;
} }
int w_Source_setPosition(lua_State *L) int w_Source_setPosition(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
v[0] = (float)luaL_checknumber(L, 2); v[0] = (float)luaL_checknumber(L, 2);
v[1] = (float)luaL_checknumber(L, 3); v[1] = (float)luaL_checknumber(L, 3);
v[2] = (float)luaL_optnumber(L, 4, 0); v[2] = (float)luaL_optnumber(L, 4, 0);
t->setPosition(v); EXCEPT_GUARD(t->setPosition(v);)
return 0; return 0;
} }
int w_Source_getPosition(lua_State *L) int w_Source_getPosition(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
t->getPosition(v); EXCEPT_GUARD(t->getPosition(v);)
lua_pushnumber(L, v[0]); lua_pushnumber(L, v[0]);
lua_pushnumber(L, v[1]); lua_pushnumber(L, v[1]);
lua_pushnumber(L, v[2]); lua_pushnumber(L, v[2]);
return 3; return 3;
} }
int w_Source_setVelocity(lua_State *L) int w_Source_setVelocity(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
v[0] = (float)luaL_checknumber(L, 2); v[0] = (float)luaL_checknumber(L, 2);
v[1] = (float)luaL_checknumber(L, 3); v[1] = (float)luaL_checknumber(L, 3);
v[2] = (float)luaL_optnumber(L, 4, 0); v[2] = (float)luaL_optnumber(L, 4, 0);
t->setVelocity(v); EXCEPT_GUARD(t->setVelocity(v);)
return 0; return 0;
} }
int w_Source_getVelocity(lua_State *L) int w_Source_getVelocity(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
t->getVelocity(v); EXCEPT_GUARD(t->getVelocity(v);)
lua_pushnumber(L, v[0]); lua_pushnumber(L, v[0]);
lua_pushnumber(L, v[1]); lua_pushnumber(L, v[1]);
lua_pushnumber(L, v[2]); lua_pushnumber(L, v[2]);
return 3; return 3;
} }
int w_Source_setDirection(lua_State *L) int w_Source_setDirection(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
v[0] = (float)luaL_checknumber(L, 2); v[0] = (float)luaL_checknumber(L, 2);
v[1] = (float)luaL_checknumber(L, 3); v[1] = (float)luaL_checknumber(L, 3);
v[2] = (float)luaL_optnumber(L, 4, 0); v[2] = (float)luaL_optnumber(L, 4, 0);
t->setDirection(v); EXCEPT_GUARD(t->setDirection(v);)
return 0; return 0;
} }
int w_Source_getDirection(lua_State *L) int w_Source_getDirection(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float v[3]; float v[3];
t->getDirection(v); EXCEPT_GUARD(t->getDirection(v);)
lua_pushnumber(L, v[0]); lua_pushnumber(L, v[0]);
lua_pushnumber(L, v[1]); lua_pushnumber(L, v[1]);
lua_pushnumber(L, v[2]); lua_pushnumber(L, v[2]);
return 3; return 3;
} }
int w_Source_setCone(lua_State *L) int w_Source_setCone(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float innerAngle = (float) luaL_checknumber(L, 2); float innerAngle = (float) luaL_checknumber(L, 2);
float outerAngle = (float) luaL_checknumber(L, 3); float outerAngle = (float) luaL_checknumber(L, 3);
float outerVolume = (float) luaL_optnumber(L, 4, 0.0); float outerVolume = (float) luaL_optnumber(L, 4, 0.0);
t->setCone(innerAngle, outerAngle, outerVolume); EXCEPT_GUARD(t->setCone(innerAngle, outerAngle, outerVolume);)
return 0; return 0;
} }
int w_Source_getCone(lua_State *L) int w_Source_getCone(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float innerAngle, outerAngle, outerVolume; float innerAngle, outerAngle, outerVolume;
t->getCone(innerAngle, outerAngle, outerVolume); EXCEPT_GUARD(t->getCone(innerAngle, outerAngle, outerVolume);)
lua_pushnumber(L, innerAngle); lua_pushnumber(L, innerAngle);
lua_pushnumber(L, outerAngle); lua_pushnumber(L, outerAngle);
lua_pushnumber(L, outerVolume); lua_pushnumber(L, outerVolume);
return 3; return 3;
} }
int w_Source_setRelative(lua_State *L) int w_Source_setRelative(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->setRelative(luax_toboolean(L, 2)); EXCEPT_GUARD(t->setRelative(luax_toboolean(L, 2));)
return 0; return 0;
} }
int w_Source_isRelative(lua_State *L) int w_Source_isRelative(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, t->isRelative()); EXCEPT_GUARD(luax_pushboolean(L, t->isRelative());)
return 1; return 1;
} }
int w_Source_setLooping(lua_State *L) int w_Source_setLooping(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
t->setLooping(luax_toboolean(L, 2)); t->setLooping(luax_toboolean(L, 2));
return 0; return 0;
} }
int w_Source_isLooping(lua_State *L) int w_Source_isLooping(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, t->isLooping()); luax_pushboolean(L, t->isLooping());
return 1; return 1;
} }
int w_Source_isStopped(lua_State *L) int w_Source_isStopped(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, t->isStopped()); luax_pushboolean(L, t->isStopped());
return 1; return 1;
} }
int w_Source_isPaused(lua_State *L) int w_Source_isPaused(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, t->isPaused()); luax_pushboolean(L, t->isPaused());
return 1; return 1;
} }
int w_Source_isPlaying(lua_State *L) int w_Source_isPlaying(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
luax_pushboolean(L, !t->isStopped() && !t->isPaused()); luax_pushboolean(L, !t->isStopped() && !t->isPaused());
return 1; return 1;
} }
int w_Source_setVolumeLimits(lua_State *L) int w_Source_setVolumeLimits(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float vmin = (float)luaL_checknumber(L, 2); float vmin = (float)luaL_checknumber(L, 2);
float vmax = (float)luaL_checknumber(L, 3); float vmax = (float)luaL_checknumber(L, 3);
if (vmin < .0f || vmin > 1.f || vmax < .0f || vmax > 1.f) if (vmin < .0f || vmin > 1.f || vmax < .0f || vmax > 1.f)
return luaL_error(L, "Invalid volume limits: [%f:%f]. Must be in [0:1]", vmin, vmax); return luaL_error(L, "Invalid volume limits: [%f:%f]. Must be in [0:1]", vmin, vmax);
t->setMinVolume(vmin); t->setMinVolume(vmin);
t->setMaxVolume(vmax); t->setMaxVolume(vmax);
return 0; return 0;
} }
int w_Source_getVolumeLimits(lua_State *L) int w_Source_getVolumeLimits(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushnumber(L, t->getMinVolume()); lua_pushnumber(L, t->getMinVolume());
lua_pushnumber(L, t->getMaxVolume()); lua_pushnumber(L, t->getMaxVolume());
return 2; return 2;
} }
int w_Source_setAttenuationDistances(lua_State *L) int w_Source_setAttenuationDistances(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float dref = (float)luaL_checknumber(L, 2); float dref = (float)luaL_checknumber(L, 2);
float dmax = (float)luaL_checknumber(L, 3); float dmax = (float)luaL_checknumber(L, 3);
if (dref < .0f || dmax < .0f) if (dref < .0f || dmax < .0f)
return luaL_error(L, "Invalid distances: %f, %f. Must be > 0", dref, dmax); return luaL_error(L, "Invalid distances: %f, %f. Must be > 0", dref, dmax);
t->setReferenceDistance(dref); EXCEPT_GUARD(t->setReferenceDistance(dref);)
t->setMaxDistance(dmax); EXCEPT_GUARD(t->setMaxDistance(dmax);)
return 0; return 0;
} }
int w_Source_getAttenuationDistances(lua_State *L) int w_Source_getAttenuationDistances(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushnumber(L, t->getReferenceDistance()); EXCEPT_GUARD(lua_pushnumber(L, t->getReferenceDistance());)
lua_pushnumber(L, t->getMaxDistance()); EXCEPT_GUARD(lua_pushnumber(L, t->getMaxDistance());)
return 2; return 2;
} }
int w_Source_setRolloff(lua_State *L) int w_Source_setRolloff(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
float rolloff = (float)luaL_checknumber(L, 2); float rolloff = (float)luaL_checknumber(L, 2);
if (rolloff < .0f) if (rolloff < .0f)
return luaL_error(L, "Invalid rolloff: %f. Must be > 0.", rolloff); return luaL_error(L, "Invalid rolloff: %f. Must be > 0.", rolloff);
t->setRolloffFactor(rolloff); EXCEPT_GUARD(t->setRolloffFactor(rolloff);)
return 0; return 0;
} }
int w_Source_getRolloff(lua_State *L) int w_Source_getRolloff(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushnumber(L, t->getRolloffFactor()); EXCEPT_GUARD(lua_pushnumber(L, t->getRolloffFactor());)
return 1; return 1;
} }
int w_Source_getChannels(lua_State *L) int w_Source_getChannels(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
lua_pushinteger(L, t->getChannels()); lua_pushinteger(L, t->getChannels());
return 1; return 1;
} }
int w_Source_getType(lua_State *L) int w_Source_getType(lua_State *L)
{ {
Source *t = luax_checksource(L, 1); Source *t = luax_checksource(L, 1);
Source::Type type = t->getType(); Source::Type type = t->getType();
const char *str = nullptr; const char *str = nullptr;
if (!Source::getConstant(type, str)) if (!Source::getConstant(type, str))
return luaL_error(L, "Unknown Source type."); return luaL_error(L, "Unknown Source type.");
lua_pushstring(L, str); lua_pushstring(L, str);
return 1; return 1;
} }
static const luaL_Reg functions[] = static const luaL_Reg functions[] =
{ {
{ "clone", w_Source_clone }, { "clone", w_Source_clone },
{ "play", w_Source_play }, { "play", w_Source_play },
{ "stop", w_Source_stop }, { "stop", w_Source_stop },
{ "pause", w_Source_pause }, { "pause", w_Source_pause },
{ "resume", w_Source_resume }, { "resume", w_Source_resume },
{ "rewind", w_Source_rewind }, { "rewind", w_Source_rewind },
{ "setPitch", w_Source_setPitch }, { "setPitch", w_Source_setPitch },
{ "getPitch", w_Source_getPitch }, { "getPitch", w_Source_getPitch },
{ "setVolume", w_Source_setVolume }, { "setVolume", w_Source_setVolume },
{ "getVolume", w_Source_getVolume }, { "getVolume", w_Source_getVolume },
{ "seek", w_Source_seek }, { "seek", w_Source_seek },
{ "tell", w_Source_tell }, { "tell", w_Source_tell },
{ "setPosition", w_Source_setPosition }, { "setPosition", w_Source_setPosition },
{ "getPosition", w_Source_getPosition }, { "getPosition", w_Source_getPosition },
{ "setVelocity", w_Source_setVelocity }, { "setVelocity", w_Source_setVelocity },
{ "getVelocity", w_Source_getVelocity }, { "getVelocity", w_Source_getVelocity },
{ "setDirection", w_Source_setDirection }, { "setDirection", w_Source_setDirection },
{ "getDirection", w_Source_getDirection }, { "getDirection", w_Source_getDirection },
{ "setCone", w_Source_setCone }, { "setCone", w_Source_setCone },
{ "getCone", w_Source_getCone }, { "getCone", w_Source_getCone },
{ "setRelative", w_Source_setRelative }, { "setRelative", w_Source_setRelative },
{ "isRelative", w_Source_isRelative }, { "isRelative", w_Source_isRelative },
{ "setLooping", w_Source_setLooping }, { "setLooping", w_Source_setLooping },
{ "isLooping", w_Source_isLooping }, { "isLooping", w_Source_isLooping },
{ "isStopped", w_Source_isStopped }, { "isStopped", w_Source_isStopped },
{ "isPaused", w_Source_isPaused }, { "isPaused", w_Source_isPaused },
{ "isPlaying", w_Source_isPlaying }, { "isPlaying", w_Source_isPlaying },
{ "setVolumeLimits", w_Source_setVolumeLimits }, { "setVolumeLimits", w_Source_setVolumeLimits },
{ "getVolumeLimits", w_Source_getVolumeLimits }, { "getVolumeLimits", w_Source_getVolumeLimits },
{ "setAttenuationDistances", w_Source_setAttenuationDistances }, { "setAttenuationDistances", w_Source_setAttenuationDistances },
{ "getAttenuationDistances", w_Source_getAttenuationDistances }, { "getAttenuationDistances", w_Source_getAttenuationDistances },
{ "setRolloff", w_Source_setRolloff}, { "setRolloff", w_Source_setRolloff},
{ "getRolloff", w_Source_getRolloff}, { "getRolloff", w_Source_getRolloff},
{ "getChannels", w_Source_getChannels }, { "getChannels", w_Source_getChannels },
{ "getType", w_Source_getType }, { "getType", w_Source_getType },
{ 0, 0 } { 0, 0 }
}; };
extern "C" int luaopen_source(lua_State *L) extern "C" int luaopen_source(lua_State *L)
{ {
return luax_register_type(L, "Source", functions); return luax_register_type(L, "Source", functions);
} }
} // audio } // audio
} // love } // love