LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-19 20:19:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Disallow mat3 formats in shader storage buffers.

Browse Source 
GLSL's std430 layout rules make it really unintuitive for users to deal with.
This commit is contained in:
Alex Szpakowski
2021-11-06 18:30:08 -03:00
parent 5c98cbdabd
commit a3ff9999d1
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/Buffer.cpp
+13 -5
View File
@@ -154,11 +154,19 @@ Buffer::Buffer(Graphics *gfx, const Settings &settings, const std::vector<DataDe
// with R components each". // with R components each".
// "If the member is a three-component vector with components // "If the member is a three-component vector with components
// consuming N basic machine units, the base alignment is 4N." // consuming N basic machine units, the base alignment is 4N."
int components = info.isMatrix ? info.matrixRows : info.components; int c = info.isMatrix ? info.matrixRows : info.components;
if (components == 3) alignment = c == 3 ? 4 * info.componentSize : c * info.componentSize;
alignment = 4 * info.componentSize;
else // std430 will effectively turn a floatmat3x3 into a floatmat4x3
alignment = components * info.componentSize; // because of its vec3 padding rules. For now we'd rather not
// support those formats at all, because it's not easy for users to
// deal with.
if (alignment != c * info.componentSize && (decl.arrayLength > 0 || info.isMatrix))
{
const char *fstr = "unknown";
getConstant(decl.format, fstr);
throw love::Exception("Data format %s%s is not currently supported in shader storage buffers.", fstr, decl.arrayLength > 0 ? " array" : "");
}
// "If the member is a structure, the base alignment of the structure // "If the member is a structure, the base alignment of the structure
// is N, where N is the largest base alignment value of any of its // is N, where N is the largest base alignment value of any of its