LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-16 16:20:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Android: Use mode a+rwx for directories and a+rw for files in external storage path.

Browse Source 
Issue love2d/love-android#269.
This commit is contained in:
Miku AuahDark
2024-04-27 12:38:30 +08:00
parent 0089749ad0
commit 629fc1c581
5 changed files with 38 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/common/android.cpp
+20 -6
View File
@@ -175,10 +175,24 @@ bool directoryExists(const char *path)
bool mkdir(const char *path)
{
int err = ::mkdir(path, 0770);
int err = ::mkdir(path, S_IRWXU | S_IRWXG | S_IRWXO | S_ISGID);
if (err == -1)
{
SDL_Log("Error: Could not create directory %s", path);
const char *error = strerror(errno);
SDL_Log("Error: Could not create directory '%s': %s", path, error);
return false;
}
return true;
}
bool chmod(const char *path, int mode)
{
int err = ::chmod(path, mode);
if (err == -1)
{
const char *error = strerror(errno);
SDL_Log("Error: Could not change mode '%s': %s", path, error);
return false;
}
@@ -216,11 +230,11 @@ bool createStorageDirectories()
return true;
}
void fixupPermissionSingleFile(const std::string &savedir, const std::string &path)
void fixupPermissionSingleFile(const std::string &savedir, const std::string &path, int mode)
{
std::string fixedSavedir = savedir.back() == '/' ? savedir : (savedir + "/");
std::string target = fixedSavedir + path;
::chmod(target.c_str(), 0660);
::chmod(target.c_str(), mode);
}
void fixupExternalStoragePermission(const std::string &savedir, const std::string &path)
@@ -242,7 +256,7 @@ void fixupExternalStoragePermission(const std::string &savedir, const std::strin
}
std::string fixedSavedir = savedir.back() == '/' ? savedir : (savedir + "/");
::chmod(savedir.c_str(), 0770);
chmod(savedir.c_str(), S_IRWXU | S_IRWXG | S_IRWXO | S_ISGID);
for (const std::string &dir: pathsToFix)
{
@@ -250,7 +264,7 @@ void fixupExternalStoragePermission(const std::string &savedir, const std::strin
if (!dir.empty() && strcmp(realPath, savedir.c_str()) == 0)
{
std::string target = fixedSavedir + dir;
::chmod(target.c_str(), 0770);
chmod(target.c_str(), S_IRWXU | S_IRWXG | S_IRWXO | S_ISGID);
}
}
}
src/common/android.h
+1 -1
View File
@@ -65,7 +65,7 @@ bool mkdir(const char *path);
bool createStorageDirectories();
void fixupPermissionSingleFile(const std::string &savedir, const std::string &path);
void fixupPermissionSingleFile(const std::string &savedir, const std::string &path, int mode = 0666);
void fixupExternalStoragePermission(const std::string &savedir, const std::string &path);