Addressed some criticism

getRecordingDevices internal function is now returns constant reference,
also re-enumerates devices every time it is called; this is a slow operation
getID removed for not being useful

--HG--
branch : minor-mic-input
This commit is contained in:
Raidho
2016-11-03 06:31:31 +03:00
parent a99c757652
commit 57d02dec2b
12 changed files with 39 additions and 64 deletions
+2 -2
View File
@@ -144,9 +144,9 @@ float Audio::getDopplerScale() const
return 1.0f;
}
std::vector<love::audio::RecordingDevice*> *Audio::getRecordingDevices()
const std::vector<love::audio::RecordingDevice*> &Audio::getRecordingDevices()
{
return &capture;
return capture;
}
Audio::DistanceModel Audio::getDistanceModel() const
+1 -1
View File
@@ -71,7 +71,7 @@ public:
void setDopplerScale(float scale);
float getDopplerScale() const;
std::vector<love::audio::RecordingDevice*> *getRecordingDevices();
const std::vector<love::audio::RecordingDevice*> &getRecordingDevices();
DistanceModel getDistanceModel() const;
void setDistanceModel(DistanceModel distanceModel);
@@ -82,11 +82,6 @@ const char *RecordingDevice::getName() const
return name;
}
int RecordingDevice::getID() const
{
return 0;
}
bool RecordingDevice::isRecording() const
{
return false;
-1
View File
@@ -41,7 +41,6 @@ public:
virtual void stopRecording();
virtual love::sound::SoundData *getData();
virtual const char *getName() const;
virtual int getID() const;
virtual int getSampleCount() const;
virtual int getSampleRate() const;
virtual int getBitDepth() const;