From 2598a51316a480c477f7a55cb9c3b94c34416585 Mon Sep 17 00:00:00 2001
From: Sasha Szpakowski <slime73@gmail.com>
Date: Sat, 26 Nov 2022 20:54:46 -0400
Subject: [PATCH] Unify love.system.getOS and love._os implementations.

---
 src/modules/love/love.cpp          | 19 +++++++------------
 src/modules/system/System.cpp      |  2 +-
 src/modules/system/System.h        |  2 +-
 src/modules/system/wrap_System.cpp |  2 +-
 4 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/src/modules/love/love.cpp b/src/modules/love/love.cpp
index ab511a05e..4c1494aa4 100644
--- a/src/modules/love/love.cpp
+++ b/src/modules/love/love.cpp
@@ -86,6 +86,11 @@ extern "C"
 #	include "audio/Audio.h"
 #endif
 
+// For love::system::System::getOS.
+#ifdef LOVE_ENABLE_SYSTEM
+#	include "system/System.h"
+#endif
+
 // Scripts.
 #include "scripts/nogame.lua.h"
 
@@ -599,18 +604,8 @@ int luaopen_love(lua_State *L)
 	lua_pushcfunction(L, w_love_isVersionCompatible);
 	lua_setfield(L, -2, "isVersionCompatible");
 
-#ifdef LOVE_WINDOWS_UWP
-	lua_pushstring(L, "UWP");
-#elif LOVE_WINDOWS
-	lua_pushstring(L, "Windows");
-#elif defined(LOVE_MACOS)
-	lua_pushstring(L, "OS X");
-#elif defined(LOVE_IOS)
-	lua_pushstring(L, "iOS");
-#elif defined(LOVE_ANDROID)
-	lua_pushstring(L, "Android");
-#elif defined(LOVE_LINUX)
-	lua_pushstring(L, "Linux");
+#ifdef LOVE_ENABLE_SYSTEM
+	lua_pushstring(L, love::system::System::getOS());
 #else
 	lua_pushstring(L, "Unknown");
 #endif
diff --git a/src/modules/system/System.cpp b/src/modules/system/System.cpp
index 800bf5866..fc3fa935b 100644
--- a/src/modules/system/System.cpp
+++ b/src/modules/system/System.cpp
@@ -62,7 +62,7 @@ System::System()
 {
 }
 
-std::string System::getOS() const
+const char *System::getOS()
 {
 #if defined(LOVE_MACOS)
 	return "OS X";
diff --git a/src/modules/system/System.h b/src/modules/system/System.h
index 8a40f59e9..f81862fe8 100644
--- a/src/modules/system/System.h
+++ b/src/modules/system/System.h
@@ -57,7 +57,7 @@ public:
 	/**
 	 * Gets the current operating system.
 	 **/
-	std::string getOS() const;
+	static const char *getOS();
 
 	/**
 	 * Gets the number of reported CPU cores on the current system.
diff --git a/src/modules/system/wrap_System.cpp b/src/modules/system/wrap_System.cpp
index d7d3209bd..0c0d7c6ad 100644
--- a/src/modules/system/wrap_System.cpp
+++ b/src/modules/system/wrap_System.cpp
@@ -31,7 +31,7 @@ namespace system
 
 int w_getOS(lua_State *L)
 {
-	luax_pushstring(L, instance()->getOS());
+	luax_pushstring(L, System::getOS());
 	return 1;
 }