LOVE/love
1
0
Fork 0
mirror of https://github.com/love2d/love.git synced 2026-08-17 11:00:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't discard the backbuffer depth/stencil in setCanvas.

Browse Source 
#1893.
This commit is contained in:
Sasha Szpakowski
2023-01-11 08:58:12 -04:00
parent 8572d4f935
commit 249d90067e
4 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/graphics/opengl/Graphics.cpp
+10 -7
View File
@@ -758,7 +758,7 @@ void Graphics::setRenderTargetsInternal(const RenderTargets &rts, int pixelw, in
OpenGL::TempDebugGroup debuggroup("setRenderTargets");
endPass();
endPass(false);
bool iswindow = rts.getFirstTarget().texture == nullptr;
Winding vertexwinding = state.winding;
@@ -794,16 +794,18 @@ void Graphics::setRenderTargetsInternal(const RenderTargets &rts, int pixelw, in
}
}
void Graphics::endPass()
void Graphics::endPass(bool presenting)
{
auto &rts = states.back().renderTargets;
love::graphics::Texture *depthstencil = rts.depthStencil.texture.get();
// Discard the depth/stencil buffer if we're using an internal cached one.
if (depthstencil == nullptr && (rts.temporaryRTFlags & (TEMPORARY_RT_DEPTH | TEMPORARY_RT_STENCIL)) != 0)
// Discard the depth/stencil buffer if we're using an internal cached one,
// or if we're presenting the backbuffer to the display.
if ((depthstencil == nullptr && (rts.temporaryRTFlags & (TEMPORARY_RT_DEPTH | TEMPORARY_RT_STENCIL)) != 0)
|| (presenting && !rts.getFirstTarget().texture.get()))
{
discard({}, true);
else if (!rts.getFirstTarget().texture.get())
discard({}, true); // Backbuffer
}
// Resolve MSAA buffers. MSAA is only supported for 2D render targets so we
// don't have to worry about resolving to slices.
@@ -1224,7 +1226,8 @@ void Graphics::present(void *screenshotCallbackData)
deprecations.draw(this);
flushBatchedDraws();
endPass();
endPass(true);
int w = getPixelWidth();
int h = getPixelHeight();
src/modules/graphics/opengl/Graphics.h
+1 -1
View File
@@ -149,7 +149,7 @@ private:
void initCapabilities() override;
void getAPIStats(int &shaderswitches) const override;
void endPass();
void endPass(bool presenting);
GLuint bindCachedFBO(const RenderTargets &targets);
void discard(OpenGL::FramebufferTarget target, const std::vector<bool> &colorbuffers, bool depthstencil);