From 5df17ba07552556d8280edc5d5b4b8e619acb8ad Mon Sep 17 00:00:00 2001
From: Miku AuahDark <auahdark687291@gmail.com>
Date: Sat, 10 Aug 2019 15:59:26 +0800
Subject: [PATCH] Modify AndroidManifest.xml again(?)

Moved WRITE_EXTERNAL_STORAGE maxSdkVersion to 28. Although t.externalstorage=true
needs WRITE_EXTERNAL_STORAGE for Android Jelly Bean and earlier, it's needed
for the game downloader to store files in Downloads folder. However the permission
to do it is unnecessary since Android Q (API 29).
See https://developer.android.com/reference/android/app/DownloadManager.Request#setDestinationInExternalPublicDir(java.lang.String,%2520java.lang.String)

Use per-activity theme instead of per-application theme. We need different
theme for the GameActivity and the DownloadActivity.
---
 app/src/main/AndroidManifest.xml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 9a11ae21..aa4a56fd 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -4,7 +4,7 @@
   <uses-permission android:name="android.permission.INTERNET"/>
   <uses-permission android:name="android.permission.VIBRATE"/>
   <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
-  <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="18" />
+  <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
 
   <!-- OpenGL ES 2.0 -->
   <uses-feature android:glEsVersion="0x00020000" />
@@ -13,7 +13,7 @@
       android:allowBackup="true"
       android:icon="@drawable/love"
       android:label="LÖVE for Android"
-      android:theme="@android:style/Theme.NoTitleBar.Fullscreen" >
+      android:usesCleartextTraffic="true" >
       <service android:name="org.love2d.android.DownloadService" />
       <activity
         android:name="org.love2d.android.GameActivity"
@@ -21,7 +21,8 @@
         android:label="LÖVE for Android"
         android:launchMode="singleTask"
         android:screenOrientation="landscape"
-        android:resizeableActivity="false" >
+        android:resizeableActivity="false"
+        android:theme="@android:style/Theme.NoTitleBar.Fullscreen" >
         <intent-filter>
           <action android:name="android.intent.action.MAIN" />
           <category android:name="android.intent.category.LAUNCHER" />
@@ -55,7 +56,8 @@
       </activity>
       <activity
         android:name="org.love2d.android.DownloadActivity"
-        android:noHistory="true" >
+        android:noHistory="true"
+        android:theme="@android:style/Theme.NoTitleBar" >
         <intent-filter>
           <action android:name="android.intent.action.VIEW" />
           <category android:name="android.intent.category.DEFAULT" />